)]}'
{"barbicanclient/v1/client.py":[{"author":{"_account_id":9914,"name":"Ade Lee","email":"alee@redhat.com","username":"alee"},"change_message_id":"b7d29aec9f8d72d4f16b31b3fb331f2e941dc56c","unresolved":true,"context_lines":[{"line_number":32,"context_line":"_STABLE \u003d \"STABLE\""},{"line_number":33,"context_line":""},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"def get_microversion_as_string(microversion):"},{"line_number":36,"context_line":"    normalized \u003d discover.normalize_version_number(microversion)"},{"line_number":37,"context_line":"    if normalized in _SUPPORTED_MICROVERSIONS:"},{"line_number":38,"context_line":"        return discover.version_to_string(normalized)"}],"source_content_type":"text/x-python","patch_set":2,"id":"a9faabca_b290ea4e","line":35,"range":{"start_line":35,"start_character":0,"end_line":35,"end_character":30},"updated":"2022-11-30 13:35:12.000000000","message":"This is not well named in that you\u0027re doing two things here - \n1. normalizing the microversion\n2. checking to see if the version is in _SUPPORTED_MICROVERSIONS\n   ie. checking to see if the version requested is in the versions supported by the client.\n   \nProbably better to either leave in the existing method ..","commit_id":"181b76f91abff9efaeced2c0de0b31d0c1b9b3d5"},{"author":{"_account_id":34120,"name":"Andre Aranha","display_name":"afariasa","email":"afariasa@redhat.com","username":"afariasa"},"change_message_id":"283f6262bc332b456f6866f2a41c56a813cefebe","unresolved":true,"context_lines":[{"line_number":32,"context_line":"_STABLE \u003d \"STABLE\""},{"line_number":33,"context_line":""},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"def get_microversion_as_string(microversion):"},{"line_number":36,"context_line":"    normalized \u003d discover.normalize_version_number(microversion)"},{"line_number":37,"context_line":"    if normalized in _SUPPORTED_MICROVERSIONS:"},{"line_number":38,"context_line":"        return discover.version_to_string(normalized)"}],"source_content_type":"text/x-python","patch_set":2,"id":"f95fc82f_c8f496c7","line":35,"range":{"start_line":35,"start_character":0,"end_line":35,"end_character":30},"in_reply_to":"a9faabca_b290ea4e","updated":"2022-12-02 16:20:08.000000000","message":"Done, agreed, it can have a better name.\nThe second stuff, I disagree, leaving this code on the main method only makes it more difficult to read.","commit_id":"181b76f91abff9efaeced2c0de0b31d0c1b9b3d5"},{"author":{"_account_id":9914,"name":"Ade Lee","email":"alee@redhat.com","username":"alee"},"change_message_id":"b7d29aec9f8d72d4f16b31b3fb331f2e941dc56c","unresolved":true,"context_lines":[{"line_number":48,"context_line":"        interface\u003dinterface, region_name\u003dregion_name, version\u003dversion)"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"def get_server_min_max_version(session, versioned_endpoint, service_type,"},{"line_number":52,"context_line":"                               microversion):"},{"line_number":53,"context_line":"    headers \u003d {"},{"line_number":54,"context_line":"        \u0027Accept\u0027: \u0027application/json\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"a658a47a_b02623d0","line":51,"updated":"2022-11-30 13:35:12.000000000","message":"Please add back some of the comments in here about the versions for STABLE etc.\nWe wont remember this stuff six months from now.","commit_id":"181b76f91abff9efaeced2c0de0b31d0c1b9b3d5"},{"author":{"_account_id":34120,"name":"Andre Aranha","display_name":"afariasa","email":"afariasa@redhat.com","username":"afariasa"},"change_message_id":"283f6262bc332b456f6866f2a41c56a813cefebe","unresolved":false,"context_lines":[{"line_number":48,"context_line":"        interface\u003dinterface, region_name\u003dregion_name, version\u003dversion)"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"def get_server_min_max_version(session, versioned_endpoint, service_type,"},{"line_number":52,"context_line":"                               microversion):"},{"line_number":53,"context_line":"    headers \u003d {"},{"line_number":54,"context_line":"        \u0027Accept\u0027: \u0027application/json\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"0be6b8ff_8b19fb76","line":51,"in_reply_to":"a658a47a_b02623d0","updated":"2022-12-02 16:20:08.000000000","message":"Done","commit_id":"181b76f91abff9efaeced2c0de0b31d0c1b9b3d5"},{"author":{"_account_id":9914,"name":"Ade Lee","email":"alee@redhat.com","username":"alee"},"change_message_id":"b7d29aec9f8d72d4f16b31b3fb331f2e941dc56c","unresolved":true,"context_lines":[{"line_number":100,"context_line":"        self.cas \u003d cas.CAManager(self.client)"},{"line_number":101,"context_line":"        self.acls \u003d acls.ACLManager(self.client)"},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"    def _is_supported_microversion(self, session, endpoint, version,"},{"line_number":104,"context_line":"                                   service_type, service_name, interface,"},{"line_number":105,"context_line":"                                   region_name, microversion):"},{"line_number":106,"context_line":"        normalized_microversion \u003d get_microversion_as_string(microversion)"}],"source_content_type":"text/x-python","patch_set":2,"id":"ed2d6b3a_2ea475ba","line":103,"range":{"start_line":103,"start_character":0,"end_line":103,"end_character":34},"updated":"2022-11-30 13:35:12.000000000","message":"Please add comments here:\n\n# Confirm microversion is supported by client\n\n# Confirm microversion is supported by server","commit_id":"181b76f91abff9efaeced2c0de0b31d0c1b9b3d5"},{"author":{"_account_id":34120,"name":"Andre Aranha","display_name":"afariasa","email":"afariasa@redhat.com","username":"afariasa"},"change_message_id":"283f6262bc332b456f6866f2a41c56a813cefebe","unresolved":false,"context_lines":[{"line_number":100,"context_line":"        self.cas \u003d cas.CAManager(self.client)"},{"line_number":101,"context_line":"        self.acls \u003d acls.ACLManager(self.client)"},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"    def _is_supported_microversion(self, session, endpoint, version,"},{"line_number":104,"context_line":"                                   service_type, service_name, interface,"},{"line_number":105,"context_line":"                                   region_name, microversion):"},{"line_number":106,"context_line":"        normalized_microversion \u003d get_microversion_as_string(microversion)"}],"source_content_type":"text/x-python","patch_set":2,"id":"a25ffd11_5ed75ea4","line":103,"range":{"start_line":103,"start_character":0,"end_line":103,"end_character":34},"in_reply_to":"ed2d6b3a_2ea475ba","updated":"2022-12-02 16:20:08.000000000","message":"Done","commit_id":"181b76f91abff9efaeced2c0de0b31d0c1b9b3d5"}]}