)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":7973,"name":"Douglas Mendizábal","email":"dmendiza@redhat.com","username":"dougmendizabal"},"change_message_id":"5c2be972c42fda7f4590c5a92d3309505c3dc935","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"559e3d04_8af8b00b","updated":"2025-07-15 21:06:03.000000000","message":"Direct instantiation of the barbicanclient.v1.client.Client class is not supported and therefore not currently tested in this codebase.\n\nThe factory function barbicanclient.client.Client must be used to create client instances as documented in https://docs.openstack.org/python-barbicanclient/latest/cli/usage.html\n\nI suspect this patch is relevant again because of Heat\u0027s use of direct instantiation, which should be removed when https://review.opendev.org/c/openstack/heat/+/955045 merges.\n\nI think the correct change here is to prevent direct instantiation of the Client class, as intended when the factory function was introduced.\n\nIf direct instantiation is something we really want then we would need to add a suite of tests to ensure everything works and prevent regressions to issues like the one this patch is trying to address.  We would also probably not want to have a factory function that is optional, so we would have to figure out a path forward for that.","commit_id":"f9b9861b2fd5bf49d7e1bc60c71330621c6e5b1d"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"43b802f85879772442eaea4d519a3a9bc041fb0d","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":5,"id":"ede3d77e_e2025cdb","in_reply_to":"559e3d04_8af8b00b","updated":"2025-07-16 01:18:07.000000000","message":"As long as the module has a public name (without _ prefix), we SHOULD assume it might be used directly. I agree we ideally should have testing coverage, I don\u0027t think that SHOULD block fixing this problem itself.","commit_id":"f9b9861b2fd5bf49d7e1bc60c71330621c6e5b1d"},{"author":{"_account_id":8833,"name":"Rabi Mishra","email":"ramishra@redhat.com","username":"rabi"},"change_message_id":"b7c7b861b57b41c26b07752234e33de14c351048","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":5,"id":"35c223ed_29a36731","in_reply_to":"ede3d77e_e2025cdb","updated":"2025-07-16 03:32:50.000000000","message":"Right, it\u0027s bad to introduce backward incompatible changes that restricts the use of something that was not restricted earlier. You really don\u0027t know who is using it.","commit_id":"f9b9861b2fd5bf49d7e1bc60c71330621c6e5b1d"}],"barbicanclient/v1/client.py":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"a6d2f0b69be527cf789aab590b677ae9fbdedaf5","unresolved":true,"context_lines":[{"line_number":27,"context_line":""},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":30,"context_line":"DEFAULT_API_VERSION \u003d \u0027v1\u0027"},{"line_number":31,"context_line":"_SUPPORTED_MICROVERSIONS \u003d [(1, 0),"},{"line_number":32,"context_line":"                            (1, 1)]"},{"line_number":33,"context_line":"# For microversion 1.0, API status is \"stable\""}],"source_content_type":"text/x-python","patch_set":4,"id":"bbe53bdd_e89d9a69","line":30,"range":{"start_line":30,"start_character":0,"end_line":30,"end_character":19},"updated":"2025-07-15 15:11:45.000000000","message":"I noticed this is not actually used. Let me correct it.","commit_id":"f332e3476e2e8950b111b0361d8f38d60a792128"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"1547af74b904674e9bcc22b8e970fb2d5d1d9b8a","unresolved":false,"context_lines":[{"line_number":27,"context_line":""},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":30,"context_line":"DEFAULT_API_VERSION \u003d \u0027v1\u0027"},{"line_number":31,"context_line":"_SUPPORTED_MICROVERSIONS \u003d [(1, 0),"},{"line_number":32,"context_line":"                            (1, 1)]"},{"line_number":33,"context_line":"# For microversion 1.0, API status is \"stable\""}],"source_content_type":"text/x-python","patch_set":4,"id":"02e0577d_61f05dc6","line":30,"range":{"start_line":30,"start_character":0,"end_line":30,"end_character":19},"in_reply_to":"bbe53bdd_e89d9a69","updated":"2025-10-08 12:59:27.000000000","message":"Done","commit_id":"f332e3476e2e8950b111b0361d8f38d60a792128"}]}