)]}'
{"blazarclient/v1/leases.py":[{"author":{"_account_id":23840,"name":"Hiroaki Kobayashi","email":"kobayashi.hiroaki@lab.ntt.co.jp","username":"hiro-kobayashi"},"change_message_id":"1424e66613eaf7cf629a00518b67281d7cce661c","unresolved":false,"context_lines":[{"line_number":54,"context_line":"                                 prolong_for is not None)"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"        if lease_start_date_change:"},{"line_number":57,"context_line":"            if lease is None:"},{"line_number":58,"context_line":"                lease \u003d self.get(lease_id)"},{"line_number":59,"context_line":"            self._add_lease_date(values, lease, \u0027start_date\u0027,"},{"line_number":60,"context_line":"                                 lease_start_date_change,"}],"source_content_type":"text/x-python","patch_set":2,"id":"df140735_224e90c0","side":"PARENT","line":57,"range":{"start_line":57,"start_character":1,"end_line":57,"end_character":29},"updated":"2017-06-06 03:30:36.000000000","message":"Why has this if-statement been removed?","commit_id":"96b890412dcbe46d998e3b8b80bd910780bd9a83"},{"author":{"_account_id":8878,"name":"Masahito Muroi","email":"masahito.muroi@g.softbank.co.jp","username":"masa"},"change_message_id":"b05befef42059d021fa695c2b6ea7ca010ade973","unresolved":false,"context_lines":[{"line_number":54,"context_line":"                                 prolong_for is not None)"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"        if lease_start_date_change:"},{"line_number":57,"context_line":"            if lease is None:"},{"line_number":58,"context_line":"                lease \u003d self.get(lease_id)"},{"line_number":59,"context_line":"            self._add_lease_date(values, lease, \u0027start_date\u0027,"},{"line_number":60,"context_line":"                                 lease_start_date_change,"}],"source_content_type":"text/x-python","patch_set":2,"id":"df140735_6ce576dc","side":"PARENT","line":57,"range":{"start_line":57,"start_character":1,"end_line":57,"end_character":29},"in_reply_to":"df140735_224e90c0","updated":"2017-06-07 01:41:16.000000000","message":"lease variable is None or a result of self.get(lease_id) here. So it gets lease anyhow.\n\nFor performance perspective, it\u0027s good to check it. I\u0027ll back the if-statement.","commit_id":"96b890412dcbe46d998e3b8b80bd910780bd9a83"},{"author":{"_account_id":23840,"name":"Hiroaki Kobayashi","email":"kobayashi.hiroaki@lab.ntt.co.jp","username":"hiro-kobayashi"},"change_message_id":"78447ae215d2e86af227d8b914e57044d48b87e4","unresolved":false,"context_lines":[{"line_number":54,"context_line":"                                 prolong_for is not None)"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"        if lease_start_date_change:"},{"line_number":57,"context_line":"            if lease is None:"},{"line_number":58,"context_line":"                lease \u003d self.get(lease_id)"},{"line_number":59,"context_line":"            self._add_lease_date(values, lease, \u0027start_date\u0027,"},{"line_number":60,"context_line":"                                 lease_start_date_change,"}],"source_content_type":"text/x-python","patch_set":2,"id":"df140735_874f8591","side":"PARENT","line":57,"range":{"start_line":57,"start_character":1,"end_line":57,"end_character":29},"in_reply_to":"df140735_6ce576dc","updated":"2017-06-07 02:41:17.000000000","message":"Yes, I think it\u0027s better getting back the if-statement for performance perspective. thanks!","commit_id":"96b890412dcbe46d998e3b8b80bd910780bd9a83"}]}