)]}'
{"blazarclient/v1/shell_commands/leases.py":[{"author":{"_account_id":13192,"name":"Souville","display_name":"Bertrand Souville","email":"souville@docomolab-euro.com","username":"bertys"},"change_message_id":"9ffd4ba2ec0b4de24eb9c441390c72f3a00f7c73","unresolved":false,"context_lines":[{"line_number":266,"context_line":"            \u0027--reservation\u0027,"},{"line_number":267,"context_line":"            metavar\u003d\"\u003ckey\u003dvalue\u003e\","},{"line_number":268,"context_line":"            action\u003d\u0027append\u0027,"},{"line_number":269,"context_line":"            help\u003d\u0027Reservation values to update\u0027,"},{"line_number":270,"context_line":"            default\u003dNone)"},{"line_number":271,"context_line":""},{"line_number":272,"context_line":"        #prolong-for and reduce_by are mutually exclusive"}],"source_content_type":"text/x-python","patch_set":5,"id":"7f287b81_8e1d5bbf","line":269,"range":{"start_line":269,"start_character":18,"end_line":269,"end_character":46},"updated":"2017-08-22 08:04:22.000000000","message":"What about refining the help message  (as a short term solution), e.g. stating that the following key-value pair \u003cid\u003d\u003creservation-id\u003e\u003e is required?","commit_id":"2028a04f5eeafa60a5346467dc4704880493d1dd"},{"author":{"_account_id":23840,"name":"Hiroaki Kobayashi","email":"kobayashi.hiroaki@lab.ntt.co.jp","username":"hiro-kobayashi"},"change_message_id":"ffe7424a9bc10ae811f1c29c21a09012c4b169cd","unresolved":false,"context_lines":[{"line_number":266,"context_line":"            \u0027--reservation\u0027,"},{"line_number":267,"context_line":"            metavar\u003d\"\u003ckey\u003dvalue\u003e\","},{"line_number":268,"context_line":"            action\u003d\u0027append\u0027,"},{"line_number":269,"context_line":"            help\u003d\u0027Reservation values to update\u0027,"},{"line_number":270,"context_line":"            default\u003dNone)"},{"line_number":271,"context_line":""},{"line_number":272,"context_line":"        #prolong-for and reduce_by are mutually exclusive"}],"source_content_type":"text/x-python","patch_set":5,"id":"7f287b81_0e716be1","line":269,"range":{"start_line":269,"start_character":18,"end_line":269,"end_character":46},"in_reply_to":"7f287b81_8e1d5bbf","updated":"2017-08-22 08:25:02.000000000","message":"Done","commit_id":"2028a04f5eeafa60a5346467dc4704880493d1dd"},{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"250c7925d1b9944b60fb6a4a293d43caf1811269","unresolved":false,"context_lines":[{"line_number":290,"context_line":"            \u0027--reservation\u0027,"},{"line_number":291,"context_line":"            metavar\u003d\"\u003ckey\u003dvalue\u003e\","},{"line_number":292,"context_line":"            action\u003d\u0027append\u0027,"},{"line_number":293,"context_line":"            help\u003d\u0027Reservation values to update (the following key-value pair \u0027"},{"line_number":294,"context_line":"                 \u0027\u003cid\u003d\u003creservation-id\u003e\u003e is required)\u0027,"},{"line_number":295,"context_line":"            default\u003dNone)"},{"line_number":296,"context_line":""},{"line_number":297,"context_line":"        #prolong-for and reduce_by are mutually exclusive"}],"source_content_type":"text/x-python","patch_set":6,"id":"7f287b81_1104ee7a","line":294,"range":{"start_line":293,"start_character":48,"end_line":294,"end_character":51},"updated":"2017-08-22 08:49:28.000000000","message":"I would simply use:\n\nthe key-value pair id\u003d\u003creservation_id\u003e is required","commit_id":"e5fcf702b67e94515e717ffb6aff1b6ec1c408bf"},{"author":{"_account_id":23840,"name":"Hiroaki Kobayashi","email":"kobayashi.hiroaki@lab.ntt.co.jp","username":"hiro-kobayashi"},"change_message_id":"a4df797c585b7299f5aa7a88ee88d544dd947088","unresolved":false,"context_lines":[{"line_number":290,"context_line":"            \u0027--reservation\u0027,"},{"line_number":291,"context_line":"            metavar\u003d\"\u003ckey\u003dvalue\u003e\","},{"line_number":292,"context_line":"            action\u003d\u0027append\u0027,"},{"line_number":293,"context_line":"            help\u003d\u0027Reservation values to update (the following key-value pair \u0027"},{"line_number":294,"context_line":"                 \u0027\u003cid\u003d\u003creservation-id\u003e\u003e is required)\u0027,"},{"line_number":295,"context_line":"            default\u003dNone)"},{"line_number":296,"context_line":""},{"line_number":297,"context_line":"        #prolong-for and reduce_by are mutually exclusive"}],"source_content_type":"text/x-python","patch_set":6,"id":"7f287b81_5199561d","line":294,"range":{"start_line":293,"start_character":48,"end_line":294,"end_character":51},"in_reply_to":"7f287b81_1104ee7a","updated":"2017-08-22 10:16:47.000000000","message":"Done","commit_id":"e5fcf702b67e94515e717ffb6aff1b6ec1c408bf"},{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"250c7925d1b9944b60fb6a4a293d43caf1811269","unresolved":false,"context_lines":[{"line_number":380,"context_line":"                            parse_params(match.group(1))"},{"line_number":381,"context_line":""},{"line_number":382,"context_line":"                parse_params(res_str)"},{"line_number":383,"context_line":"                if res_info:"},{"line_number":384,"context_line":"                    reservations.append(res_info)"},{"line_number":385,"context_line":"            if not reservations:"},{"line_number":386,"context_line":"                raise exception.IncorrectLease(err_msg)"},{"line_number":387,"context_line":"            params[\u0027reservations\u0027] \u003d reservations"}],"source_content_type":"text/x-python","patch_set":6,"id":"7f287b81_31348a4a","line":384,"range":{"start_line":383,"start_character":0,"end_line":384,"end_character":49},"updated":"2017-08-22 08:49:28.000000000","message":"Could we check here that id is part of the params and return an error if not, without sending the invalid request to the API?","commit_id":"e5fcf702b67e94515e717ffb6aff1b6ec1c408bf"},{"author":{"_account_id":23840,"name":"Hiroaki Kobayashi","email":"kobayashi.hiroaki@lab.ntt.co.jp","username":"hiro-kobayashi"},"change_message_id":"a4df797c585b7299f5aa7a88ee88d544dd947088","unresolved":false,"context_lines":[{"line_number":380,"context_line":"                            parse_params(match.group(1))"},{"line_number":381,"context_line":""},{"line_number":382,"context_line":"                parse_params(res_str)"},{"line_number":383,"context_line":"                if res_info:"},{"line_number":384,"context_line":"                    reservations.append(res_info)"},{"line_number":385,"context_line":"            if not reservations:"},{"line_number":386,"context_line":"                raise exception.IncorrectLease(err_msg)"},{"line_number":387,"context_line":"            params[\u0027reservations\u0027] \u003d reservations"}],"source_content_type":"text/x-python","patch_set":6,"id":"7f287b81_37b7da89","line":384,"range":{"start_line":383,"start_character":0,"end_line":384,"end_character":49},"in_reply_to":"7f287b81_31348a4a","updated":"2017-08-22 10:16:47.000000000","message":"Done","commit_id":"e5fcf702b67e94515e717ffb6aff1b6ec1c408bf"},{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"bf41c7625ece38119488af0224d4b25c2c505527","unresolved":false,"context_lines":[{"line_number":290,"context_line":"            \u0027--reservation\u0027,"},{"line_number":291,"context_line":"            metavar\u003d\"\u003ckey\u003dvalue\u003e\","},{"line_number":292,"context_line":"            action\u003d\u0027append\u0027,"},{"line_number":293,"context_line":"            help\u003d\u0027Reservation values to update (the key-value pair \u0027"},{"line_number":294,"context_line":"                 \u0027id\u003d\u003creservation-id\u003e is required)\u0027,"},{"line_number":295,"context_line":"            default\u003dNone)"},{"line_number":296,"context_line":""},{"line_number":297,"context_line":"        #prolong-for and reduce_by are mutually exclusive"}],"source_content_type":"text/x-python","patch_set":7,"id":"7f287b81_220d5637","line":294,"range":{"start_line":293,"start_character":0,"end_line":294,"end_character":52},"updated":"2017-08-22 10:29:50.000000000","message":"The resulting message doesn\u0027t look great because of line wrap:\n\n    Reservation values to update (the key-value pair id\n    \u003d\u003creservation-id\u003e is required)\n\nI propose the following:\n\n    help\u003d\u0027Reservation values to update. The reservation must be \u0027\n         \u0027selected with the id\u003d\u003creservation-id\u003e key-value pair.\u0027,","commit_id":"f317f22fd19a56c98e083bc251366dd147974b71"},{"author":{"_account_id":23840,"name":"Hiroaki Kobayashi","email":"kobayashi.hiroaki@lab.ntt.co.jp","username":"hiro-kobayashi"},"change_message_id":"df08824c4e627a1a392a2616af0bbde516b576fa","unresolved":false,"context_lines":[{"line_number":290,"context_line":"            \u0027--reservation\u0027,"},{"line_number":291,"context_line":"            metavar\u003d\"\u003ckey\u003dvalue\u003e\","},{"line_number":292,"context_line":"            action\u003d\u0027append\u0027,"},{"line_number":293,"context_line":"            help\u003d\u0027Reservation values to update (the key-value pair \u0027"},{"line_number":294,"context_line":"                 \u0027id\u003d\u003creservation-id\u003e is required)\u0027,"},{"line_number":295,"context_line":"            default\u003dNone)"},{"line_number":296,"context_line":""},{"line_number":297,"context_line":"        #prolong-for and reduce_by are mutually exclusive"}],"source_content_type":"text/x-python","patch_set":7,"id":"7f287b81_d919d688","line":294,"range":{"start_line":293,"start_character":0,"end_line":294,"end_character":52},"in_reply_to":"7f287b81_220d5637","updated":"2017-08-23 01:31:13.000000000","message":"Done","commit_id":"f317f22fd19a56c98e083bc251366dd147974b71"}]}