)]}'
{"blazarclient/base.py":[{"author":{"_account_id":23840,"name":"Hiroaki Kobayashi","email":"kobayashi.hiroaki@lab.ntt.co.jp","username":"hiro-kobayashi"},"change_message_id":"18cb78cf0f42aa7ceef9578e245392a3a6053d9f","unresolved":false,"context_lines":[{"line_number":20,"context_line":"from blazarclient.i18n import _"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"class BaseClientManager(adapter.LegacyJsonAdapter):"},{"line_number":24,"context_line":"    \"\"\"Base manager to  interact with a particular type of API."},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"    There are environments, nodes and jobs types of API requests."}],"source_content_type":"text/x-python","patch_set":1,"id":"7f287b81_d8c357ec","line":23,"range":{"start_line":23,"start_character":32,"end_line":23,"end_character":49},"updated":"2017-08-30 08:28:56.000000000","message":"Why do you use not the Adapter but the LegacyJsonAdapter?","commit_id":"31cdc782df8e95592248752875dbdd3faa5fafb2"},{"author":{"_account_id":22687,"name":"Hiroki Ito","email":"ito.hiroki@lab.ntt.co.jp","username":"hrito"},"change_message_id":"2c0d0bb76ea69e560ef5efe32a1223ed033ebe5b","unresolved":false,"context_lines":[{"line_number":20,"context_line":"from blazarclient.i18n import _"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"class BaseClientManager(adapter.LegacyJsonAdapter):"},{"line_number":24,"context_line":"    \"\"\"Base manager to  interact with a particular type of API."},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"    There are environments, nodes and jobs types of API requests."}],"source_content_type":"text/x-python","patch_set":2,"id":"7f287b81_c897e944","line":23,"range":{"start_line":23,"start_character":24,"end_line":23,"end_character":49},"updated":"2017-08-31 04:25:21.000000000","message":"Because LegacyJsonAdapter adds procedures of checking and returning json bodies, I use LegacyJsonAdapter instead of Adapter class.","commit_id":"f44b5b38e33e7a9de4cca03979a7fa395905aa7c"},{"author":{"_account_id":8878,"name":"Masahito Muroi","email":"masahito.muroi@g.softbank.co.jp","username":"masa"},"change_message_id":"387c4b695b4a65e1f6ebdb08a50f58631b8f98da","unresolved":false,"context_lines":[{"line_number":20,"context_line":"from blazarclient.i18n import _"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"class BaseClientManager(adapter.LegacyJsonAdapter):"},{"line_number":24,"context_line":"    \"\"\"Base manager to  interact with a particular type of API."},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"    There are environments, nodes and jobs types of API requests."}],"source_content_type":"text/x-python","patch_set":2,"id":"7f287b81_4a05e679","line":23,"range":{"start_line":23,"start_character":0,"end_line":23,"end_character":51},"updated":"2017-09-04 07:48:09.000000000","message":"Is this class really need?  _get, _create, _update and _delete methods only add HTTP response to a request method and pick up response body using response_key.\n\nThe Adapter class from keystoneauth1 has above four methods. IMO, it\u0027s better for blazarclient.v1.leases.LeaseClientManager and blazarclient.v1.hosts.HostClientManager to inherit the keystoneauth1.adapter.Adapter class directly. It can remove this file.","commit_id":"f44b5b38e33e7a9de4cca03979a7fa395905aa7c"},{"author":{"_account_id":22687,"name":"Hiroki Ito","email":"ito.hiroki@lab.ntt.co.jp","username":"hrito"},"change_message_id":"92f7044aa4767f7a8393353c216eeb09c47c324a","unresolved":false,"context_lines":[{"line_number":20,"context_line":"from blazarclient.i18n import _"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"class BaseClientManager(adapter.LegacyJsonAdapter):"},{"line_number":24,"context_line":"    \"\"\"Base manager to  interact with a particular type of API."},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"    There are environments, nodes and jobs types of API requests."}],"source_content_type":"text/x-python","patch_set":2,"id":"7f287b81_9315ede7","line":23,"range":{"start_line":23,"start_character":0,"end_line":23,"end_character":51},"in_reply_to":"7f287b81_4a05e679","updated":"2017-09-07 09:57:42.000000000","message":"Taking your advice, I removed this Class and changed blazarclient.v1.leases.LeaseClientManager and blazarclient.v1.hosts.HostClientManager to inherit keystoneauth1.adapter.LegacyJsonAdapter class.","commit_id":"f44b5b38e33e7a9de4cca03979a7fa395905aa7c"},{"author":{"_account_id":22687,"name":"Hiroki Ito","email":"ito.hiroki@lab.ntt.co.jp","username":"hrito"},"change_message_id":"92f7044aa4767f7a8393353c216eeb09c47c324a","unresolved":false,"context_lines":[{"line_number":88,"context_line":"        resp, body \u003d self.request(url, \u0027PUT\u0027, body\u003dbody, **kwargs)"},{"line_number":89,"context_line":"        return body[response_key]"},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"    def request(self, url, method, **kwargs):"},{"line_number":92,"context_line":"        \"\"\"Base request method."},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"        Adds specific headers and URL prefix to the request."}],"source_content_type":"text/x-python","patch_set":2,"id":"7f287b81_b3c22933","line":91,"range":{"start_line":91,"start_character":1,"end_line":91,"end_character":45},"updated":"2017-09-07 09:57:42.000000000","message":"Because I noticed that checks done by this method are already implemented in keystoneauth1.adapter and keystoneauth1.session, I don\u0027t move this method to blazarclient.v1.leases.LeaseClientManager and blazarclient.v1.hosts.HostClientManager.","commit_id":"f44b5b38e33e7a9de4cca03979a7fa395905aa7c"}],"blazarclient/shell.py":[{"author":{"_account_id":23840,"name":"Hiroaki Kobayashi","email":"kobayashi.hiroaki@lab.ntt.co.jp","username":"hiro-kobayashi"},"change_message_id":"18cb78cf0f42aa7ceef9578e245392a3a6053d9f","unresolved":false,"context_lines":[{"line_number":26,"context_line":"from cliff import app"},{"line_number":27,"context_line":"from cliff import commandmanager"},{"line_number":28,"context_line":"from keystoneauth1 import identity"},{"line_number":29,"context_line":"from keystoneauth1 import session as ksession"},{"line_number":30,"context_line":"from oslo_utils import encodeutils"},{"line_number":31,"context_line":"import six"},{"line_number":32,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"7f287b81_187affb8","line":29,"range":{"start_line":29,"start_character":26,"end_line":29,"end_character":45},"updated":"2017-08-30 08:28:56.000000000","message":"I don\u0027t have a strong preference but jus the name \u0027session\u0027 can be used like the keystoneauth guide because there is no other module named session in this code.","commit_id":"31cdc782df8e95592248752875dbdd3faa5fafb2"},{"author":{"_account_id":22687,"name":"Hiroki Ito","email":"ito.hiroki@lab.ntt.co.jp","username":"hrito"},"change_message_id":"2c0d0bb76ea69e560ef5efe32a1223ed033ebe5b","unresolved":false,"context_lines":[{"line_number":26,"context_line":"from cliff import app"},{"line_number":27,"context_line":"from cliff import commandmanager"},{"line_number":28,"context_line":"from keystoneauth1 import identity"},{"line_number":29,"context_line":"from keystoneauth1 import session"},{"line_number":30,"context_line":"from oslo_utils import encodeutils"},{"line_number":31,"context_line":"import six"},{"line_number":32,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"7f287b81_68823502","line":29,"range":{"start_line":29,"start_character":26,"end_line":29,"end_character":33},"updated":"2017-08-31 04:25:21.000000000","message":"I\u0027ve changed \"ksession\" to \"session\"","commit_id":"f44b5b38e33e7a9de4cca03979a7fa395905aa7c"},{"author":{"_account_id":8878,"name":"Masahito Muroi","email":"masahito.muroi@g.softbank.co.jp","username":"masa"},"change_message_id":"387c4b695b4a65e1f6ebdb08a50f58631b8f98da","unresolved":false,"context_lines":[{"line_number":415,"context_line":"                password\u003dself.options.os_password"},{"line_number":416,"context_line":"            )"},{"line_number":417,"context_line":""},{"line_number":418,"context_line":"        if not auth:"},{"line_number":419,"context_line":"            raise exception.NotAuthorized(\"User %s is not authorized.\" %"},{"line_number":420,"context_line":"                                          self.options.os_username)"},{"line_number":421,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"7f287b81_15138468","line":418,"range":{"start_line":418,"start_character":0,"end_line":418,"end_character":19},"updated":"2017-09-04 07:48:09.000000000","message":"When does the if-statement become True?  It looks like the previous if-else statement ensures auth variable have some variable.","commit_id":"f44b5b38e33e7a9de4cca03979a7fa395905aa7c"},{"author":{"_account_id":22687,"name":"Hiroki Ito","email":"ito.hiroki@lab.ntt.co.jp","username":"hrito"},"change_message_id":"92f7044aa4767f7a8393353c216eeb09c47c324a","unresolved":false,"context_lines":[{"line_number":415,"context_line":"                password\u003dself.options.os_password"},{"line_number":416,"context_line":"            )"},{"line_number":417,"context_line":""},{"line_number":418,"context_line":"        if not auth:"},{"line_number":419,"context_line":"            raise exception.NotAuthorized(\"User %s is not authorized.\" %"},{"line_number":420,"context_line":"                                          self.options.os_username)"},{"line_number":421,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"7f287b81_530c25a4","line":418,"range":{"start_line":418,"start_character":0,"end_line":418,"end_character":19},"in_reply_to":"7f287b81_15138468","updated":"2017-09-07 09:57:42.000000000","message":"You are right. I removed this if-statement.","commit_id":"f44b5b38e33e7a9de4cca03979a7fa395905aa7c"},{"author":{"_account_id":8878,"name":"Masahito Muroi","email":"masahito.muroi@g.softbank.co.jp","username":"masa"},"change_message_id":"387c4b695b4a65e1f6ebdb08a50f58631b8f98da","unresolved":false,"context_lines":[{"line_number":427,"context_line":"        self.client \u003d blazar_client.Client("},{"line_number":428,"context_line":"            self.options.os_reservation_api_version,"},{"line_number":429,"context_line":"            session\u003dsess,"},{"line_number":430,"context_line":"            service_type\u003d\u0027reservation\u0027,"},{"line_number":431,"context_line":"            interface\u003d\u0027public\u0027"},{"line_number":432,"context_line":"        )"},{"line_number":433,"context_line":"        return"}],"source_content_type":"text/x-python","patch_set":2,"id":"7f287b81_4736ffb6","line":430,"range":{"start_line":430,"start_character":0,"end_line":430,"end_character":38},"updated":"2017-09-04 07:48:09.000000000","message":"It\u0027s good to make the variable configurable.  The \u0027reservation\u0027 is just default setting in devstack plugin in Blazar repo.","commit_id":"f44b5b38e33e7a9de4cca03979a7fa395905aa7c"},{"author":{"_account_id":22687,"name":"Hiroki Ito","email":"ito.hiroki@lab.ntt.co.jp","username":"hrito"},"change_message_id":"92f7044aa4767f7a8393353c216eeb09c47c324a","unresolved":false,"context_lines":[{"line_number":427,"context_line":"        self.client \u003d blazar_client.Client("},{"line_number":428,"context_line":"            self.options.os_reservation_api_version,"},{"line_number":429,"context_line":"            session\u003dsess,"},{"line_number":430,"context_line":"            service_type\u003d\u0027reservation\u0027,"},{"line_number":431,"context_line":"            interface\u003d\u0027public\u0027"},{"line_number":432,"context_line":"        )"},{"line_number":433,"context_line":"        return"}],"source_content_type":"text/x-python","patch_set":2,"id":"7f287b81_5331c559","line":430,"range":{"start_line":430,"start_character":0,"end_line":430,"end_character":38},"in_reply_to":"7f287b81_4736ffb6","updated":"2017-09-07 09:57:42.000000000","message":"I\u0027ve added --service-type option and set its default value to reservation.","commit_id":"f44b5b38e33e7a9de4cca03979a7fa395905aa7c"},{"author":{"_account_id":8878,"name":"Masahito Muroi","email":"masahito.muroi@g.softbank.co.jp","username":"masa"},"change_message_id":"387c4b695b4a65e1f6ebdb08a50f58631b8f98da","unresolved":false,"context_lines":[{"line_number":428,"context_line":"            self.options.os_reservation_api_version,"},{"line_number":429,"context_line":"            session\u003dsess,"},{"line_number":430,"context_line":"            service_type\u003d\u0027reservation\u0027,"},{"line_number":431,"context_line":"            interface\u003d\u0027public\u0027"},{"line_number":432,"context_line":"        )"},{"line_number":433,"context_line":"        return"},{"line_number":434,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"7f287b81_4775df97","line":431,"range":{"start_line":431,"start_character":0,"end_line":431,"end_character":30},"updated":"2017-09-04 07:48:09.000000000","message":"It should be self.options.endpoint_type.","commit_id":"f44b5b38e33e7a9de4cca03979a7fa395905aa7c"},{"author":{"_account_id":22687,"name":"Hiroki Ito","email":"ito.hiroki@lab.ntt.co.jp","username":"hrito"},"change_message_id":"92f7044aa4767f7a8393353c216eeb09c47c324a","unresolved":false,"context_lines":[{"line_number":428,"context_line":"            self.options.os_reservation_api_version,"},{"line_number":429,"context_line":"            session\u003dsess,"},{"line_number":430,"context_line":"            service_type\u003d\u0027reservation\u0027,"},{"line_number":431,"context_line":"            interface\u003d\u0027public\u0027"},{"line_number":432,"context_line":"        )"},{"line_number":433,"context_line":"        return"},{"line_number":434,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"7f287b81_f33f9122","line":431,"range":{"start_line":431,"start_character":0,"end_line":431,"end_character":30},"in_reply_to":"7f287b81_4775df97","updated":"2017-09-07 09:57:42.000000000","message":"Done","commit_id":"f44b5b38e33e7a9de4cca03979a7fa395905aa7c"},{"author":{"_account_id":22687,"name":"Hiroki Ito","email":"ito.hiroki@lab.ntt.co.jp","username":"hrito"},"change_message_id":"00aed549c3392659f063e879d5a1f1db998834de","unresolved":false,"context_lines":[{"line_number":380,"context_line":"        \"\"\"Make sure the user has provided all of the authentication"},{"line_number":381,"context_line":"        info we need."},{"line_number":382,"context_line":"        \"\"\""},{"line_number":383,"context_line":"        if not self.options.os_token:"},{"line_number":384,"context_line":"            if not self.options.os_username:"},{"line_number":385,"context_line":"                raise exception.CommandError("},{"line_number":386,"context_line":"                    \"You must provide a username via\""},{"line_number":387,"context_line":"                    \" either --os-username or env[OS_USERNAME]\")"},{"line_number":388,"context_line":""},{"line_number":389,"context_line":"            if not self.options.os_password:"},{"line_number":390,"context_line":"                raise exception.CommandError("},{"line_number":391,"context_line":"                    \"You must provide a password via\""},{"line_number":392,"context_line":"                    \" either --os-password or env[OS_PASSWORD]\")"},{"line_number":393,"context_line":""},{"line_number":394,"context_line":"            if (not self.options.os_tenant_name and"},{"line_number":395,"context_line":"                    not self.options.os_tenant_id):"},{"line_number":396,"context_line":"                raise exception.CommandError("},{"line_number":397,"context_line":"                    \"You must provide a tenant_name or tenant_id via\""},{"line_number":398,"context_line":"                    \"  --os-tenant-name, env[OS_TENANT_NAME]\""},{"line_number":399,"context_line":"                    \"  --os-tenant-id, or via env[OS_TENANT_ID]\")"},{"line_number":400,"context_line":""},{"line_number":401,"context_line":"        if not self.options.os_auth_url:"},{"line_number":402,"context_line":"            raise exception.CommandError("},{"line_number":403,"context_line":"                \"You must provide an auth url via\""},{"line_number":404,"context_line":"                \" either --os-auth-url or via env[OS_AUTH_URL]\")"},{"line_number":405,"context_line":""},{"line_number":406,"context_line":"        if self.options.os_token:"},{"line_number":407,"context_line":"            auth \u003d identity.Token("}],"source_content_type":"text/x-python","patch_set":7,"id":"7f515b1d_b845a517","line":404,"range":{"start_line":383,"start_character":0,"end_line":404,"end_character":64},"updated":"2017-10-06 08:15:12.000000000","message":"Because I found keystoneauth1 does these kind of checks, I removed these lines.","commit_id":"4957e9446772826bd9c85ad2c9d9ca8155c60a7f"},{"author":{"_account_id":8878,"name":"Masahito Muroi","email":"masahito.muroi@g.softbank.co.jp","username":"masa"},"change_message_id":"fb72f5824f6a1517299df48589ea08d0f239cd01","unresolved":false,"context_lines":[{"line_number":408,"context_line":"                auth_url\u003dself.options.os_auth_url,"},{"line_number":409,"context_line":"                token\u003dself.options.os_token,"},{"line_number":410,"context_line":"                tenant_id\u003dself.options.os_tenant_id,"},{"line_number":411,"context_line":"                tenant_name\u003dself.options.os_tenant_name"},{"line_number":412,"context_line":"            )"},{"line_number":413,"context_line":"        else:"},{"line_number":414,"context_line":"            auth \u003d identity.Password("}],"source_content_type":"text/x-python","patch_set":7,"id":"7f515b1d_f20c5f3a","line":411,"updated":"2017-10-06 03:05:34.000000000","message":"It also needs domain info?","commit_id":"4957e9446772826bd9c85ad2c9d9ca8155c60a7f"},{"author":{"_account_id":22687,"name":"Hiroki Ito","email":"ito.hiroki@lab.ntt.co.jp","username":"hrito"},"change_message_id":"00aed549c3392659f063e879d5a1f1db998834de","unresolved":false,"context_lines":[{"line_number":408,"context_line":"                auth_url\u003dself.options.os_auth_url,"},{"line_number":409,"context_line":"                token\u003dself.options.os_token,"},{"line_number":410,"context_line":"                tenant_id\u003dself.options.os_tenant_id,"},{"line_number":411,"context_line":"                tenant_name\u003dself.options.os_tenant_name"},{"line_number":412,"context_line":"            )"},{"line_number":413,"context_line":"        else:"},{"line_number":414,"context_line":"            auth \u003d identity.Password("}],"source_content_type":"text/x-python","patch_set":7,"id":"7f515b1d_554c3a9d","line":411,"in_reply_to":"7f515b1d_f20c5f3a","updated":"2017-10-06 08:15:12.000000000","message":"I added project_id/name and user_domain_id/name for Token authentication because Token auth needs them for keystone v3 endpoint.","commit_id":"4957e9446772826bd9c85ad2c9d9ca8155c60a7f"},{"author":{"_account_id":8878,"name":"Masahito Muroi","email":"masahito.muroi@g.softbank.co.jp","username":"masa"},"change_message_id":"fb72f5824f6a1517299df48589ea08d0f239cd01","unresolved":false,"context_lines":[{"line_number":416,"context_line":"                username\u003dself.options.os_username,"},{"line_number":417,"context_line":"                tenant_id\u003dself.options.os_tenant_id,"},{"line_number":418,"context_line":"                tenant_name\u003dself.options.os_tenant_name,"},{"line_number":419,"context_line":"                password\u003dself.options.os_password"},{"line_number":420,"context_line":"            )"},{"line_number":421,"context_line":""},{"line_number":422,"context_line":"        sess \u003d session.Session("}],"source_content_type":"text/x-python","patch_set":7,"id":"7f515b1d_5208d326","line":419,"updated":"2017-10-06 03:05:34.000000000","message":"I think it needs to pass domain information to identity.","commit_id":"4957e9446772826bd9c85ad2c9d9ca8155c60a7f"},{"author":{"_account_id":22687,"name":"Hiroki Ito","email":"ito.hiroki@lab.ntt.co.jp","username":"hrito"},"change_message_id":"00aed549c3392659f063e879d5a1f1db998834de","unresolved":false,"context_lines":[{"line_number":416,"context_line":"                username\u003dself.options.os_username,"},{"line_number":417,"context_line":"                tenant_id\u003dself.options.os_tenant_id,"},{"line_number":418,"context_line":"                tenant_name\u003dself.options.os_tenant_name,"},{"line_number":419,"context_line":"                password\u003dself.options.os_password"},{"line_number":420,"context_line":"            )"},{"line_number":421,"context_line":""},{"line_number":422,"context_line":"        sess \u003d session.Session("}],"source_content_type":"text/x-python","patch_set":7,"id":"7f515b1d_f5168655","line":419,"in_reply_to":"7f515b1d_5208d326","updated":"2017-10-06 08:15:12.000000000","message":"Password auth needs project_id/name, project_domain_id/name and user_domain_id/name for keystone v3 endpoint, so I added them.","commit_id":"4957e9446772826bd9c85ad2c9d9ca8155c60a7f"}],"blazarclient/v1/client.py":[{"author":{"_account_id":8878,"name":"Masahito Muroi","email":"masahito.muroi@g.softbank.co.jp","username":"masa"},"change_message_id":"18b79650454128ef313ef82dbb25e5c9da439ebc","unresolved":false,"context_lines":[{"line_number":31,"context_line":"        ..."},{"line_number":32,"context_line":"    \"\"\""},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"    def __init__(self, session, version\u003d\u00271\u0027, *args, **kwargs):"},{"line_number":35,"context_line":"        self.session \u003d session"},{"line_number":36,"context_line":"        self.version \u003d version"},{"line_number":37,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"7f515b1d_08aa75d1","line":34,"range":{"start_line":34,"start_character":31,"end_line":34,"end_character":43},"updated":"2017-10-04 05:51:42.000000000","message":"Is there a specific reason that version is defined as argument? This client class is only for v1. The version should not be changeable.","commit_id":"3c571d19e566956c24ffbcdf56dac1420f4b4126"},{"author":{"_account_id":22687,"name":"Hiroki Ito","email":"ito.hiroki@lab.ntt.co.jp","username":"hrito"},"change_message_id":"4cc84ed0678a089535c269052c31e7be36800715","unresolved":false,"context_lines":[{"line_number":31,"context_line":"        ..."},{"line_number":32,"context_line":"    \"\"\""},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"    def __init__(self, session, version\u003d\u00271\u0027, *args, **kwargs):"},{"line_number":35,"context_line":"        self.session \u003d session"},{"line_number":36,"context_line":"        self.version \u003d version"},{"line_number":37,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"7f515b1d_6e0d71e7","line":34,"range":{"start_line":34,"start_character":31,"end_line":34,"end_character":43},"in_reply_to":"7f515b1d_08aa75d1","updated":"2017-10-04 07:46:27.000000000","message":"There is no specific reason and so I removed the version argument from __init__() and changed it to a static value.","commit_id":"3c571d19e566956c24ffbcdf56dac1420f4b4126"}],"blazarclient/v1/hosts.py":[{"author":{"_account_id":8878,"name":"Masahito Muroi","email":"masahito.muroi@g.softbank.co.jp","username":"masa"},"change_message_id":"18b79650454128ef313ef82dbb25e5c9da439ebc","unresolved":false,"context_lines":[{"line_number":27,"context_line":"        \"\"\"Creates host from values passed.\"\"\""},{"line_number":28,"context_line":"        values \u003d {\u0027name\u0027: name}"},{"line_number":29,"context_line":"        values.update(**kwargs)"},{"line_number":30,"context_line":"        resp, body \u003d super(ComputeHostClientManager,"},{"line_number":31,"context_line":"                           self).post(\u0027/os-hosts\u0027, body\u003dvalues)"},{"line_number":32,"context_line":"        return body[\u0027host\u0027]"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"    def get(self, host_id):"}],"source_content_type":"text/x-python","patch_set":5,"id":"7f515b1d_68f1e901","line":31,"range":{"start_line":30,"start_character":0,"end_line":31,"end_character":63},"updated":"2017-10-04 05:51:42.000000000","message":"The ComputeHostClientManager class doesn\u0027t override post method of LegacyJsonAdapter class. It\u0027s not need to use super method.","commit_id":"3c571d19e566956c24ffbcdf56dac1420f4b4126"},{"author":{"_account_id":22687,"name":"Hiroki Ito","email":"ito.hiroki@lab.ntt.co.jp","username":"hrito"},"change_message_id":"4cc84ed0678a089535c269052c31e7be36800715","unresolved":false,"context_lines":[{"line_number":27,"context_line":"        \"\"\"Creates host from values passed.\"\"\""},{"line_number":28,"context_line":"        values \u003d {\u0027name\u0027: name}"},{"line_number":29,"context_line":"        values.update(**kwargs)"},{"line_number":30,"context_line":"        resp, body \u003d super(ComputeHostClientManager,"},{"line_number":31,"context_line":"                           self).post(\u0027/os-hosts\u0027, body\u003dvalues)"},{"line_number":32,"context_line":"        return body[\u0027host\u0027]"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"    def get(self, host_id):"}],"source_content_type":"text/x-python","patch_set":5,"id":"7f515b1d_ee0041ae","line":31,"range":{"start_line":30,"start_character":0,"end_line":31,"end_character":63},"in_reply_to":"7f515b1d_68f1e901","updated":"2017-10-04 07:46:27.000000000","message":"Done","commit_id":"3c571d19e566956c24ffbcdf56dac1420f4b4126"},{"author":{"_account_id":8878,"name":"Masahito Muroi","email":"masahito.muroi@g.softbank.co.jp","username":"masa"},"change_message_id":"18b79650454128ef313ef82dbb25e5c9da439ebc","unresolved":false,"context_lines":[{"line_number":41,"context_line":"        \"\"\"Update attributes of the host.\"\"\""},{"line_number":42,"context_line":"        if not values:"},{"line_number":43,"context_line":"            return _(\u0027No values to update passed.\u0027)"},{"line_number":44,"context_line":"        resp, body \u003d super(ComputeHostClientManager,"},{"line_number":45,"context_line":"                           self).put(\u0027/os-hosts/%s\u0027 % host_id, body\u003dvalues)"},{"line_number":46,"context_line":"        return body[\u0027host\u0027]"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"    def delete(self, host_id):"}],"source_content_type":"text/x-python","patch_set":5,"id":"7f515b1d_683fa987","line":45,"range":{"start_line":44,"start_character":0,"end_line":45,"end_character":75},"updated":"2017-10-04 05:51:42.000000000","message":"same as above","commit_id":"3c571d19e566956c24ffbcdf56dac1420f4b4126"},{"author":{"_account_id":22687,"name":"Hiroki Ito","email":"ito.hiroki@lab.ntt.co.jp","username":"hrito"},"change_message_id":"4cc84ed0678a089535c269052c31e7be36800715","unresolved":false,"context_lines":[{"line_number":41,"context_line":"        \"\"\"Update attributes of the host.\"\"\""},{"line_number":42,"context_line":"        if not values:"},{"line_number":43,"context_line":"            return _(\u0027No values to update passed.\u0027)"},{"line_number":44,"context_line":"        resp, body \u003d super(ComputeHostClientManager,"},{"line_number":45,"context_line":"                           self).put(\u0027/os-hosts/%s\u0027 % host_id, body\u003dvalues)"},{"line_number":46,"context_line":"        return body[\u0027host\u0027]"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"    def delete(self, host_id):"}],"source_content_type":"text/x-python","patch_set":5,"id":"7f515b1d_cefd85b2","line":45,"range":{"start_line":44,"start_character":0,"end_line":45,"end_character":75},"in_reply_to":"7f515b1d_683fa987","updated":"2017-10-04 07:46:27.000000000","message":"Done","commit_id":"3c571d19e566956c24ffbcdf56dac1420f4b4126"}],"blazarclient/v1/leases.py":[{"author":{"_account_id":8878,"name":"Masahito Muroi","email":"masahito.muroi@g.softbank.co.jp","username":"masa"},"change_message_id":"18b79650454128ef313ef82dbb25e5c9da439ebc","unresolved":false,"context_lines":[{"line_number":31,"context_line":"                  \u0027reservations\u0027: reservations, \u0027events\u0027: events,"},{"line_number":32,"context_line":"                  \u0027before_end_date\u0027: before_end}"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"        resp, body \u003d super(LeaseClientManager,"},{"line_number":35,"context_line":"                           self).post(\u0027/leases\u0027, body\u003dvalues)"},{"line_number":36,"context_line":"        return body[\u0027lease\u0027]"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"    def get(self, lease_id):"}],"source_content_type":"text/x-python","patch_set":5,"id":"7f515b1d_a85ec1e6","line":35,"range":{"start_line":34,"start_character":0,"end_line":35,"end_character":61},"updated":"2017-10-04 05:51:42.000000000","message":"same comment I wrote in hosts.py","commit_id":"3c571d19e566956c24ffbcdf56dac1420f4b4126"},{"author":{"_account_id":22687,"name":"Hiroki Ito","email":"ito.hiroki@lab.ntt.co.jp","username":"hrito"},"change_message_id":"4cc84ed0678a089535c269052c31e7be36800715","unresolved":false,"context_lines":[{"line_number":31,"context_line":"                  \u0027reservations\u0027: reservations, \u0027events\u0027: events,"},{"line_number":32,"context_line":"                  \u0027before_end_date\u0027: before_end}"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"        resp, body \u003d super(LeaseClientManager,"},{"line_number":35,"context_line":"                           self).post(\u0027/leases\u0027, body\u003dvalues)"},{"line_number":36,"context_line":"        return body[\u0027lease\u0027]"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"    def get(self, lease_id):"}],"source_content_type":"text/x-python","patch_set":5,"id":"7f515b1d_0e1ddd0e","line":35,"range":{"start_line":34,"start_character":0,"end_line":35,"end_character":61},"in_reply_to":"7f515b1d_a85ec1e6","updated":"2017-10-04 07:46:27.000000000","message":"Done","commit_id":"3c571d19e566956c24ffbcdf56dac1420f4b4126"},{"author":{"_account_id":8878,"name":"Masahito Muroi","email":"masahito.muroi@g.softbank.co.jp","username":"masa"},"change_message_id":"18b79650454128ef313ef82dbb25e5c9da439ebc","unresolved":false,"context_lines":[{"line_number":84,"context_line":""},{"line_number":85,"context_line":"        if not values:"},{"line_number":86,"context_line":"            return _(\u0027No values to update passed.\u0027)"},{"line_number":87,"context_line":"        resp, body \u003d super(LeaseClientManager,"},{"line_number":88,"context_line":"                           self).put(\u0027/leases/%s\u0027 % lease_id, body\u003dvalues)"},{"line_number":89,"context_line":"        return body[\u0027lease\u0027]"},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"    def delete(self, lease_id):"}],"source_content_type":"text/x-python","patch_set":5,"id":"7f515b1d_2872d17d","line":88,"range":{"start_line":87,"start_character":0,"end_line":88,"end_character":74},"updated":"2017-10-04 05:51:42.000000000","message":"same as above","commit_id":"3c571d19e566956c24ffbcdf56dac1420f4b4126"},{"author":{"_account_id":22687,"name":"Hiroki Ito","email":"ito.hiroki@lab.ntt.co.jp","username":"hrito"},"change_message_id":"4cc84ed0678a089535c269052c31e7be36800715","unresolved":false,"context_lines":[{"line_number":84,"context_line":""},{"line_number":85,"context_line":"        if not values:"},{"line_number":86,"context_line":"            return _(\u0027No values to update passed.\u0027)"},{"line_number":87,"context_line":"        resp, body \u003d super(LeaseClientManager,"},{"line_number":88,"context_line":"                           self).put(\u0027/leases/%s\u0027 % lease_id, body\u003dvalues)"},{"line_number":89,"context_line":"        return body[\u0027lease\u0027]"},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"    def delete(self, lease_id):"}],"source_content_type":"text/x-python","patch_set":5,"id":"7f515b1d_ee196122","line":88,"range":{"start_line":87,"start_character":0,"end_line":88,"end_character":74},"in_reply_to":"7f515b1d_2872d17d","updated":"2017-10-04 07:46:27.000000000","message":"Done","commit_id":"3c571d19e566956c24ffbcdf56dac1420f4b4126"}]}