)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":23840,"name":"Hiroaki Kobayashi","email":"kobayashi.hiroaki@lab.ntt.co.jp","username":"hiro-kobayashi"},"change_message_id":"47e5caae0bf4d74bdbcef1c1ed24495d26df61cd","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Hiroki Ito \u003cito.hiroki@lab.ntt.co.jp\u003e"},{"line_number":5,"context_line":"CommitDate: 2017-11-06 11:45:43 +0900"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Ensure backward compatibility for init client"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"After merged the patch #498340, blazarclient can\u0027t be used with"},{"line_number":10,"context_line":"auth_url and auth_token since this patch only allows sessions for"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3f4b6375_c3ed9425","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":6},"updated":"2017-11-07 00:32:03.000000000","message":"I think recover or restore is better.","commit_id":"531bf68c319860eb67efe33257b7bbbf1effc88e"},{"author":{"_account_id":22687,"name":"Hiroki Ito","email":"ito.hiroki@lab.ntt.co.jp","username":"hrito"},"change_message_id":"4ed8b613359409da34219e3c7449dfd00644d56a","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Hiroki Ito \u003cito.hiroki@lab.ntt.co.jp\u003e"},{"line_number":5,"context_line":"CommitDate: 2017-11-06 11:45:43 +0900"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Ensure backward compatibility for init client"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"After merged the patch #498340, blazarclient can\u0027t be used with"},{"line_number":10,"context_line":"auth_url and auth_token since this patch only allows sessions for"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3f4b6375_899fbd00","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":6},"in_reply_to":"3f4b6375_c3ed9425","updated":"2017-11-07 02:12:00.000000000","message":"Done","commit_id":"531bf68c319860eb67efe33257b7bbbf1effc88e"},{"author":{"_account_id":8878,"name":"Masahito Muroi","email":"masahito.muroi@g.softbank.co.jp","username":"masa"},"change_message_id":"ff99d369bf589e3e5deebb48272547e33738db67","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Ensure backward compatibility for init client"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"After merged the patch #498340, blazarclient can\u0027t be used with"},{"line_number":10,"context_line":"auth_url and auth_token since this patch only allows sessions for"},{"line_number":11,"context_line":"the initiation of client. For backward compatibility, blazarclient"},{"line_number":12,"context_line":"should be initiated with auth_url and auth_token as before."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3f4b6375_e0076681","line":9,"range":{"start_line":9,"start_character":23,"end_line":9,"end_character":30},"updated":"2017-11-06 23:48:04.000000000","message":"you should refer the patch by Change-ID, not using a gerrit patch number.","commit_id":"531bf68c319860eb67efe33257b7bbbf1effc88e"},{"author":{"_account_id":22687,"name":"Hiroki Ito","email":"ito.hiroki@lab.ntt.co.jp","username":"hrito"},"change_message_id":"4ed8b613359409da34219e3c7449dfd00644d56a","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Ensure backward compatibility for init client"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"After merged the patch #498340, blazarclient can\u0027t be used with"},{"line_number":10,"context_line":"auth_url and auth_token since this patch only allows sessions for"},{"line_number":11,"context_line":"the initiation of client. For backward compatibility, blazarclient"},{"line_number":12,"context_line":"should be initiated with auth_url and auth_token as before."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3f4b6375_498545ac","line":9,"range":{"start_line":9,"start_character":23,"end_line":9,"end_character":30},"in_reply_to":"3f4b6375_e0076681","updated":"2017-11-07 02:12:00.000000000","message":"Done","commit_id":"531bf68c319860eb67efe33257b7bbbf1effc88e"},{"author":{"_account_id":23840,"name":"Hiroaki Kobayashi","email":"kobayashi.hiroaki@lab.ntt.co.jp","username":"hiro-kobayashi"},"change_message_id":"47e5caae0bf4d74bdbcef1c1ed24495d26df61cd","unresolved":false,"context_lines":[{"line_number":11,"context_line":"the initiation of client. For backward compatibility, blazarclient"},{"line_number":12,"context_line":"should be initiated with auth_url and auth_token as before."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"In this patch enables using blazarclient with auth_url and"},{"line_number":15,"context_line":"auth_token or session by reviving BaseClientManager class and"},{"line_number":16,"context_line":"adding a logic to use both old and new auth methods depending"},{"line_number":17,"context_line":"on given params."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3f4b6375_431e440c","line":14,"range":{"start_line":14,"start_character":0,"end_line":14,"end_character":3},"updated":"2017-11-07 00:32:03.000000000","message":"not needed","commit_id":"531bf68c319860eb67efe33257b7bbbf1effc88e"},{"author":{"_account_id":22687,"name":"Hiroki Ito","email":"ito.hiroki@lab.ntt.co.jp","username":"hrito"},"change_message_id":"4ed8b613359409da34219e3c7449dfd00644d56a","unresolved":false,"context_lines":[{"line_number":11,"context_line":"the initiation of client. For backward compatibility, blazarclient"},{"line_number":12,"context_line":"should be initiated with auth_url and auth_token as before."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"In this patch enables using blazarclient with auth_url and"},{"line_number":15,"context_line":"auth_token or session by reviving BaseClientManager class and"},{"line_number":16,"context_line":"adding a logic to use both old and new auth methods depending"},{"line_number":17,"context_line":"on given params."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3f4b6375_69b36199","line":14,"range":{"start_line":14,"start_character":0,"end_line":14,"end_character":3},"in_reply_to":"3f4b6375_431e440c","updated":"2017-11-07 02:12:00.000000000","message":"Done","commit_id":"531bf68c319860eb67efe33257b7bbbf1effc88e"},{"author":{"_account_id":8878,"name":"Masahito Muroi","email":"masahito.muroi@g.softbank.co.jp","username":"masa"},"change_message_id":"ff99d369bf589e3e5deebb48272547e33738db67","unresolved":false,"context_lines":[{"line_number":12,"context_line":"should be initiated with auth_url and auth_token as before."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"In this patch enables using blazarclient with auth_url and"},{"line_number":15,"context_line":"auth_token or session by reviving BaseClientManager class and"},{"line_number":16,"context_line":"adding a logic to use both old and new auth methods depending"},{"line_number":17,"context_line":"on given params."},{"line_number":18,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3f4b6375_60fb7678","line":15,"range":{"start_line":15,"start_character":22,"end_line":15,"end_character":51},"updated":"2017-11-06 23:48:04.000000000","message":"As I commented in code, I think the class doesn\u0027t need to be revived.","commit_id":"531bf68c319860eb67efe33257b7bbbf1effc88e"},{"author":{"_account_id":23840,"name":"Hiroaki Kobayashi","email":"kobayashi.hiroaki@lab.ntt.co.jp","username":"hiro-kobayashi"},"change_message_id":"47e5caae0bf4d74bdbcef1c1ed24495d26df61cd","unresolved":false,"context_lines":[{"line_number":11,"context_line":"the initiation of client. For backward compatibility, blazarclient"},{"line_number":12,"context_line":"should be initiated with auth_url and auth_token as before."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"In this patch enables using blazarclient with auth_url and"},{"line_number":15,"context_line":"auth_token or session by reviving BaseClientManager class and"},{"line_number":16,"context_line":"adding a logic to use both old and new auth methods depending"},{"line_number":17,"context_line":"on given params."},{"line_number":18,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3f4b6375_63d14023","line":15,"range":{"start_line":14,"start_character":46,"end_line":15,"end_character":10},"updated":"2017-11-07 00:32:03.000000000","message":"a set of auth_url and auth_token?","commit_id":"531bf68c319860eb67efe33257b7bbbf1effc88e"},{"author":{"_account_id":22687,"name":"Hiroki Ito","email":"ito.hiroki@lab.ntt.co.jp","username":"hrito"},"change_message_id":"4ed8b613359409da34219e3c7449dfd00644d56a","unresolved":false,"context_lines":[{"line_number":12,"context_line":"should be initiated with auth_url and auth_token as before."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"In this patch enables using blazarclient with auth_url and"},{"line_number":15,"context_line":"auth_token or session by reviving BaseClientManager class and"},{"line_number":16,"context_line":"adding a logic to use both old and new auth methods depending"},{"line_number":17,"context_line":"on given params."},{"line_number":18,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3f4b6375_09a4ed49","line":15,"range":{"start_line":15,"start_character":22,"end_line":15,"end_character":51},"in_reply_to":"3f4b6375_60fb7678","updated":"2017-11-07 02:12:00.000000000","message":"I replied why I revived this class in client.py and base.py.","commit_id":"531bf68c319860eb67efe33257b7bbbf1effc88e"},{"author":{"_account_id":22687,"name":"Hiroki Ito","email":"ito.hiroki@lab.ntt.co.jp","username":"hrito"},"change_message_id":"4ed8b613359409da34219e3c7449dfd00644d56a","unresolved":false,"context_lines":[{"line_number":11,"context_line":"the initiation of client. For backward compatibility, blazarclient"},{"line_number":12,"context_line":"should be initiated with auth_url and auth_token as before."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"In this patch enables using blazarclient with auth_url and"},{"line_number":15,"context_line":"auth_token or session by reviving BaseClientManager class and"},{"line_number":16,"context_line":"adding a logic to use both old and new auth methods depending"},{"line_number":17,"context_line":"on given params."},{"line_number":18,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3f4b6375_a96a79e9","line":15,"range":{"start_line":14,"start_character":46,"end_line":15,"end_character":10},"in_reply_to":"3f4b6375_63d14023","updated":"2017-11-07 02:12:00.000000000","message":"Done","commit_id":"531bf68c319860eb67efe33257b7bbbf1effc88e"},{"author":{"_account_id":23840,"name":"Hiroaki Kobayashi","email":"kobayashi.hiroaki@lab.ntt.co.jp","username":"hiro-kobayashi"},"change_message_id":"47e5caae0bf4d74bdbcef1c1ed24495d26df61cd","unresolved":false,"context_lines":[{"line_number":13,"context_line":""},{"line_number":14,"context_line":"In this patch enables using blazarclient with auth_url and"},{"line_number":15,"context_line":"auth_token or session by reviving BaseClientManager class and"},{"line_number":16,"context_line":"adding a logic to use both old and new auth methods depending"},{"line_number":17,"context_line":"on given params."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Change-Id: I25a665145b0503cc04e49bc85c39e2f6dca36925"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3f4b6375_23758832","line":16,"range":{"start_line":16,"start_character":0,"end_line":16,"end_character":6},"updated":"2017-11-07 00:32:03.000000000","message":"adds","commit_id":"531bf68c319860eb67efe33257b7bbbf1effc88e"},{"author":{"_account_id":22687,"name":"Hiroki Ito","email":"ito.hiroki@lab.ntt.co.jp","username":"hrito"},"change_message_id":"4ed8b613359409da34219e3c7449dfd00644d56a","unresolved":false,"context_lines":[{"line_number":13,"context_line":""},{"line_number":14,"context_line":"In this patch enables using blazarclient with auth_url and"},{"line_number":15,"context_line":"auth_token or session by reviving BaseClientManager class and"},{"line_number":16,"context_line":"adding a logic to use both old and new auth methods depending"},{"line_number":17,"context_line":"on given params."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Change-Id: I25a665145b0503cc04e49bc85c39e2f6dca36925"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3f4b6375_896d7d04","line":16,"range":{"start_line":16,"start_character":0,"end_line":16,"end_character":6},"in_reply_to":"3f4b6375_23758832","updated":"2017-11-07 02:12:00.000000000","message":"Done","commit_id":"531bf68c319860eb67efe33257b7bbbf1effc88e"},{"author":{"_account_id":23840,"name":"Hiroaki Kobayashi","email":"kobayashi.hiroaki@lab.ntt.co.jp","username":"hiro-kobayashi"},"change_message_id":"47e5caae0bf4d74bdbcef1c1ed24495d26df61cd","unresolved":false,"context_lines":[{"line_number":13,"context_line":""},{"line_number":14,"context_line":"In this patch enables using blazarclient with auth_url and"},{"line_number":15,"context_line":"auth_token or session by reviving BaseClientManager class and"},{"line_number":16,"context_line":"adding a logic to use both old and new auth methods depending"},{"line_number":17,"context_line":"on given params."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Change-Id: I25a665145b0503cc04e49bc85c39e2f6dca36925"},{"line_number":20,"context_line":"Closes-Bug: #1724757"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3f4b6375_43c88453","line":17,"range":{"start_line":16,"start_character":18,"end_line":17,"end_character":16},"updated":"2017-11-07 00:32:03.000000000","message":"chose an auth method based on given params?","commit_id":"531bf68c319860eb67efe33257b7bbbf1effc88e"},{"author":{"_account_id":22687,"name":"Hiroki Ito","email":"ito.hiroki@lab.ntt.co.jp","username":"hrito"},"change_message_id":"4ed8b613359409da34219e3c7449dfd00644d56a","unresolved":false,"context_lines":[{"line_number":13,"context_line":""},{"line_number":14,"context_line":"In this patch enables using blazarclient with auth_url and"},{"line_number":15,"context_line":"auth_token or session by reviving BaseClientManager class and"},{"line_number":16,"context_line":"adding a logic to use both old and new auth methods depending"},{"line_number":17,"context_line":"on given params."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Change-Id: I25a665145b0503cc04e49bc85c39e2f6dca36925"},{"line_number":20,"context_line":"Closes-Bug: #1724757"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3f4b6375_697801c3","line":17,"range":{"start_line":16,"start_character":18,"end_line":17,"end_character":16},"in_reply_to":"3f4b6375_43c88453","updated":"2017-11-07 02:12:00.000000000","message":"Done","commit_id":"531bf68c319860eb67efe33257b7bbbf1effc88e"}],"blazarclient/base.py":[{"author":{"_account_id":8878,"name":"Masahito Muroi","email":"masahito.muroi@g.softbank.co.jp","username":"masa"},"change_message_id":"ff99d369bf589e3e5deebb48272547e33738db67","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright (c) 2013 Mirantis Inc."},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"# Licensed under the Apache License, Version 2.0 (the \"License\");"},{"line_number":4,"context_line":"# you may not use this file except in compliance with the License."}],"source_content_type":"text/x-python","patch_set":1,"id":"3f4b6375_407aba23","line":1,"updated":"2017-11-06 23:48:04.000000000","message":"Why this file and classes in this file are revived?  As I commented the previous patch, we shouldn\u0027t maintain library\u0027s code in blazarclient repo. The two classes are same as keystoneauth1.adapter class.","commit_id":"531bf68c319860eb67efe33257b7bbbf1effc88e"},{"author":{"_account_id":22687,"name":"Hiroki Ito","email":"ito.hiroki@lab.ntt.co.jp","username":"hrito"},"change_message_id":"4ed8b613359409da34219e3c7449dfd00644d56a","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright (c) 2013 Mirantis Inc."},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"# Licensed under the Apache License, Version 2.0 (the \"License\");"},{"line_number":4,"context_line":"# you may not use this file except in compliance with the License."}],"source_content_type":"text/x-python","patch_set":1,"id":"3f4b6375_c966d551","line":1,"in_reply_to":"3f4b6375_407aba23","updated":"2017-11-07 02:12:00.000000000","message":"As I replied to the comment in v1/client.py, we need this file and classes to authenticate with only target_url and auth_token which is not supported in keystoneauth1. The two classes\u0027 logic are not completely same as keytoneauth1.adapter for this reason.","commit_id":"531bf68c319860eb67efe33257b7bbbf1effc88e"},{"author":{"_account_id":8878,"name":"Masahito Muroi","email":"masahito.muroi@g.softbank.co.jp","username":"masa"},"change_message_id":"c3dd8c6731af46c221cab204aba8e1458a5ee75a","unresolved":false,"context_lines":[{"line_number":114,"context_line":"class BaseClientManager(object):"},{"line_number":115,"context_line":"    \"\"\"Base class for managing resources of Blazar.\"\"\""},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"    def __init__(self, blazar_url\u003dNone, auth_token\u003dNone, session\u003dNone,"},{"line_number":118,"context_line":"                 version\u003dNone, user_agent\u003d\u0027python-blazarclient\u0027, **kwargs):"},{"line_number":119,"context_line":"        self.blazar_url \u003d blazar_url"},{"line_number":120,"context_line":"        self.auth_token \u003d auth_token"},{"line_number":121,"context_line":"        self.session \u003d session"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f4b6375_633243a9","line":118,"range":{"start_line":117,"start_character":1,"end_line":118,"end_character":75},"updated":"2017-11-08 13:31:11.000000000","message":"Few questions and comments for the arguments.\n\n* Why do all the arguments have initial value?  IMO, the all initial value is not needed because v1.client.Client() instantiates this class. And just define *arg, **kwargs.\n* Why user_agent is configurable?","commit_id":"557bd3052c4414e0aef55dbb2f9022fcbed9d28c"},{"author":{"_account_id":22687,"name":"Hiroki Ito","email":"ito.hiroki@lab.ntt.co.jp","username":"hrito"},"change_message_id":"4e0d3e482c626ff76334a84a24f0afc820da0fef","unresolved":false,"context_lines":[{"line_number":114,"context_line":"class BaseClientManager(object):"},{"line_number":115,"context_line":"    \"\"\"Base class for managing resources of Blazar.\"\"\""},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"    def __init__(self, blazar_url\u003dNone, auth_token\u003dNone, session\u003dNone,"},{"line_number":118,"context_line":"                 version\u003dNone, user_agent\u003d\u0027python-blazarclient\u0027, **kwargs):"},{"line_number":119,"context_line":"        self.blazar_url \u003d blazar_url"},{"line_number":120,"context_line":"        self.auth_token \u003d auth_token"},{"line_number":121,"context_line":"        self.session \u003d session"}],"source_content_type":"text/x-python","patch_set":2,"id":"1f485f77_c9bb430c","line":118,"range":{"start_line":117,"start_character":1,"end_line":118,"end_character":75},"in_reply_to":"3f4b6375_633243a9","updated":"2017-11-10 09:06:28.000000000","message":"\u003e Why do all the arguments have initial value?  IMO, the all initial value is not needed because v1.client.Client() instantiates this class. And just define *arg, **kwargs.\n\nAs you said, we don\u0027t need default values in both v1.client.Client() and base.BaseClientManager(). I think it\u0027s better to define defaults in base.BaseClientManager() because the actual user of these values is this class and so I modified v1.client.Client() to just pass **kwargs to ClientManagers. \n\n\u003e Why user_agent is configurable?\n\nThis value is not necessarily to be configurable, so I changed it to class attribute.","commit_id":"557bd3052c4414e0aef55dbb2f9022fcbed9d28c"},{"author":{"_account_id":8878,"name":"Masahito Muroi","email":"masahito.muroi@g.softbank.co.jp","username":"masa"},"change_message_id":"c3dd8c6731af46c221cab204aba8e1458a5ee75a","unresolved":false,"context_lines":[{"line_number":129,"context_line":"                version\u003dself.version,"},{"line_number":130,"context_line":"                **kwargs"},{"line_number":131,"context_line":"            )"},{"line_number":132,"context_line":"        elif self.blazar_url and self.auth_token:"},{"line_number":133,"context_line":"            self.request_manager \u003d RequestManager(blazar_url\u003dself.blazar_url,"},{"line_number":134,"context_line":"                                                  auth_token\u003dself.auth_token,"},{"line_number":135,"context_line":"                                                  user_agent\u003dself.user_agent)"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f4b6375_c3ed77f0","line":132,"updated":"2017-11-08 13:31:11.000000000","message":"We\u0027ll remove this class later. It\u0027s better to output warning a log message which mentions this auth method is deprecated here.","commit_id":"557bd3052c4414e0aef55dbb2f9022fcbed9d28c"},{"author":{"_account_id":22687,"name":"Hiroki Ito","email":"ito.hiroki@lab.ntt.co.jp","username":"hrito"},"change_message_id":"4e0d3e482c626ff76334a84a24f0afc820da0fef","unresolved":false,"context_lines":[{"line_number":129,"context_line":"                version\u003dself.version,"},{"line_number":130,"context_line":"                **kwargs"},{"line_number":131,"context_line":"            )"},{"line_number":132,"context_line":"        elif self.blazar_url and self.auth_token:"},{"line_number":133,"context_line":"            self.request_manager \u003d RequestManager(blazar_url\u003dself.blazar_url,"},{"line_number":134,"context_line":"                                                  auth_token\u003dself.auth_token,"},{"line_number":135,"context_line":"                                                  user_agent\u003dself.user_agent)"}],"source_content_type":"text/x-python","patch_set":2,"id":"1f485f77_e9539fe1","line":132,"in_reply_to":"3f4b6375_c3ed77f0","updated":"2017-11-10 09:06:28.000000000","message":"I added a warning message.","commit_id":"557bd3052c4414e0aef55dbb2f9022fcbed9d28c"}],"blazarclient/exception.py":[{"author":{"_account_id":8878,"name":"Masahito Muroi","email":"masahito.muroi@g.softbank.co.jp","username":"masa"},"change_message_id":"c3dd8c6731af46c221cab204aba8e1458a5ee75a","unresolved":false,"context_lines":[{"line_number":86,"context_line":""},{"line_number":87,"context_line":"class InsufficientAuthInfomation(BlazarClientException):"},{"line_number":88,"context_line":"    \"\"\"Occurs if the auth info passed to blazar client is insufficient.\"\"\""},{"line_number":89,"context_line":"    message \u003d _(\"The authenticate infomation is insufficient \""},{"line_number":90,"context_line":"                \"for initiating blazar client.\")"},{"line_number":91,"context_line":"    code \u003d 400"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f4b6375_0396ef4c","line":90,"range":{"start_line":89,"start_character":16,"end_line":90,"end_character":47},"updated":"2017-11-08 13:31:11.000000000","message":"This message should advise users to use session object.","commit_id":"557bd3052c4414e0aef55dbb2f9022fcbed9d28c"},{"author":{"_account_id":22687,"name":"Hiroki Ito","email":"ito.hiroki@lab.ntt.co.jp","username":"hrito"},"change_message_id":"4e0d3e482c626ff76334a84a24f0afc820da0fef","unresolved":false,"context_lines":[{"line_number":86,"context_line":""},{"line_number":87,"context_line":"class InsufficientAuthInfomation(BlazarClientException):"},{"line_number":88,"context_line":"    \"\"\"Occurs if the auth info passed to blazar client is insufficient.\"\"\""},{"line_number":89,"context_line":"    message \u003d _(\"The authenticate infomation is insufficient \""},{"line_number":90,"context_line":"                \"for initiating blazar client.\")"},{"line_number":91,"context_line":"    code \u003d 400"}],"source_content_type":"text/x-python","patch_set":2,"id":"1f485f77_6959effc","line":90,"range":{"start_line":89,"start_character":16,"end_line":90,"end_character":47},"in_reply_to":"3f4b6375_0396ef4c","updated":"2017-11-10 09:06:28.000000000","message":"Done","commit_id":"557bd3052c4414e0aef55dbb2f9022fcbed9d28c"}],"blazarclient/v1/client.py":[{"author":{"_account_id":8878,"name":"Masahito Muroi","email":"masahito.muroi@g.softbank.co.jp","username":"masa"},"change_message_id":"ff99d369bf589e3e5deebb48272547e33738db67","unresolved":false,"context_lines":[{"line_number":37,"context_line":"        self.auth_token \u003d auth_token"},{"line_number":38,"context_line":"        self.session \u003d session"},{"line_number":39,"context_line":"        self._version \u003d \u00271\u0027"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"        self.lease \u003d leases.LeaseClientManager(blazar_url\u003dself.blazar_url,"},{"line_number":42,"context_line":"                                               auth_token\u003dself.auth_token,"},{"line_number":43,"context_line":"                                               session\u003dself.session,"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f4b6375_e0de460f","line":40,"updated":"2017-11-06 23:48:04.000000000","message":"It\u0027s better to create a session here using keystoneauth1.identity.v3.token.Token class when blazar_url and auth_token are passed. In that case, we don\u0027t need blazarclient/base.py and the LeaseClientManager and the ComputeHostClientManger can be a subclass of keystoneauth.adapter.LegacyJsonAdapter class.","commit_id":"531bf68c319860eb67efe33257b7bbbf1effc88e"},{"author":{"_account_id":22687,"name":"Hiroki Ito","email":"ito.hiroki@lab.ntt.co.jp","username":"hrito"},"change_message_id":"4ed8b613359409da34219e3c7449dfd00644d56a","unresolved":false,"context_lines":[{"line_number":37,"context_line":"        self.auth_token \u003d auth_token"},{"line_number":38,"context_line":"        self.session \u003d session"},{"line_number":39,"context_line":"        self._version \u003d \u00271\u0027"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"        self.lease \u003d leases.LeaseClientManager(blazar_url\u003dself.blazar_url,"},{"line_number":42,"context_line":"                                               auth_token\u003dself.auth_token,"},{"line_number":43,"context_line":"                                               session\u003dself.session,"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f4b6375_09418da6","line":40,"in_reply_to":"3f4b6375_e0de460f","updated":"2017-11-07 02:12:00.000000000","message":"At first, I have tried the logic you mentioned but realized that keystoneauth1.session can\u0027t be authenticated by keystoneauth1.identity.v3.token.Token with only target_url and auth_token. At least auth_url, project_id and project_domain_id are needed. However, for backward compatibility, blazarclient should be initiated with only blazar_url and auth_token. That\u0027s why I revived blazarclient.base.BaseClientManager class with minor modifications.","commit_id":"531bf68c319860eb67efe33257b7bbbf1effc88e"},{"author":{"_account_id":8878,"name":"Masahito Muroi","email":"masahito.muroi@g.softbank.co.jp","username":"masa"},"change_message_id":"dc1b569a453f2492cb45531813bd5b11272b8c23","unresolved":false,"context_lines":[{"line_number":40,"context_line":"        self.auth_token \u003d auth_token"},{"line_number":41,"context_line":"        self.session \u003d session"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"        if self.blazar_url and self.auth_token:"},{"line_number":44,"context_line":"            logging.warning(\u0027Using blazar_url and auth_token is deprecated \u0027"},{"line_number":45,"context_line":"                            \u0027for the authentication of blazarclient. Please \u0027"},{"line_number":46,"context_line":"                            \u0027use keystone sessions.\u0027)"}],"source_content_type":"text/x-python","patch_set":4,"id":"1f485f77_0d15829c","line":43,"range":{"start_line":43,"start_character":0,"end_line":43,"end_character":47},"updated":"2017-11-15 08:17:09.000000000","message":"It\u0027s better to use \u0027if not session\u0027 here or keep the message in blazarclient.base.py:L130.","commit_id":"60941086b2fddc539718024be11ee5c9a0b3b991"},{"author":{"_account_id":22687,"name":"Hiroki Ito","email":"ito.hiroki@lab.ntt.co.jp","username":"hrito"},"change_message_id":"84b7228e15af3174a510b60f9d14a6b6f5904fbe","unresolved":false,"context_lines":[{"line_number":40,"context_line":"        self.auth_token \u003d auth_token"},{"line_number":41,"context_line":"        self.session \u003d session"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"        if self.blazar_url and self.auth_token:"},{"line_number":44,"context_line":"            logging.warning(\u0027Using blazar_url and auth_token is deprecated \u0027"},{"line_number":45,"context_line":"                            \u0027for the authentication of blazarclient. Please \u0027"},{"line_number":46,"context_line":"                            \u0027use keystone sessions.\u0027)"}],"source_content_type":"text/x-python","patch_set":4,"id":"1f485f77_2b2346bf","line":43,"range":{"start_line":43,"start_character":0,"end_line":43,"end_character":47},"in_reply_to":"1f485f77_0d15829c","updated":"2017-11-17 04:35:43.000000000","message":"Done","commit_id":"60941086b2fddc539718024be11ee5c9a0b3b991"}]}