)]}'
{"blazarclient/base.py":[{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"9e8d488c014120eea6ddda6a44028318e619ef5d","unresolved":false,"context_lines":[{"line_number":88,"context_line":""},{"line_number":89,"context_line":"        if \u0027body\u0027 in kwargs:"},{"line_number":90,"context_line":"            kwargs[\u0027headers\u0027][\u0027Content-Type\u0027] \u003d \u0027application/json\u0027"},{"line_number":91,"context_line":"            kwargs[\u0027data\u0027] \u003d jsonutils.dump_as_bytes(kwargs[\u0027body\u0027])"},{"line_number":92,"context_line":"            del kwargs[\u0027body\u0027]"},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"        resp \u003d requests.request(method, self.blazar_url + url, **kwargs)"}],"source_content_type":"text/x-python","patch_set":3,"id":"5f93b717_04149c9f","line":91,"updated":"2018-01-25 12:55:48.000000000","message":"Is dump_as_bytes still needed here as well? Unit tests and manual testing are passing for me using `jsonutils.dumps` on Python 3.6.","commit_id":"39e1b71b81b3cde1e7936552f837f42211ae7747"},{"author":{"_account_id":23840,"name":"Hiroaki Kobayashi","email":"kobayashi.hiroaki@lab.ntt.co.jp","username":"hiro-kobayashi"},"change_message_id":"442f8a60a8ffb978370684149e4ddea383099a4b","unresolved":false,"context_lines":[{"line_number":88,"context_line":""},{"line_number":89,"context_line":"        if \u0027body\u0027 in kwargs:"},{"line_number":90,"context_line":"            kwargs[\u0027headers\u0027][\u0027Content-Type\u0027] \u003d \u0027application/json\u0027"},{"line_number":91,"context_line":"            kwargs[\u0027data\u0027] \u003d jsonutils.dump_as_bytes(kwargs[\u0027body\u0027])"},{"line_number":92,"context_line":"            del kwargs[\u0027body\u0027]"},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"        resp \u003d requests.request(method, self.blazar_url + url, **kwargs)"}],"source_content_type":"text/x-python","patch_set":3,"id":"5f93b717_639a2415","line":91,"in_reply_to":"5f93b717_04149c9f","updated":"2018-01-26 02:02:19.000000000","message":"The format_output_data() which we discussed before was for data which is printed on the terminal. So, using dumps() to output str was okay. However, the dump here is for data which is sent as a request body. To my understand, OpenStack recommends to use bytes when serializing JSON format data [1].\nFrom blazar-api side, it accepts both of bytes and str, so it works with dumps(). However, I think it\u0027s better to follow OpenStack standards.\n\n[1] https://wiki.openstack.org/wiki/Python3#Serialization:_base64.2C_JSON.2C_etc.","commit_id":"39e1b71b81b3cde1e7936552f837f42211ae7747"},{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"849c36c2c5943112fd65d99a372a3b7fa0b1b96e","unresolved":false,"context_lines":[{"line_number":88,"context_line":""},{"line_number":89,"context_line":"        if \u0027body\u0027 in kwargs:"},{"line_number":90,"context_line":"            kwargs[\u0027headers\u0027][\u0027Content-Type\u0027] \u003d \u0027application/json\u0027"},{"line_number":91,"context_line":"            kwargs[\u0027data\u0027] \u003d jsonutils.dump_as_bytes(kwargs[\u0027body\u0027])"},{"line_number":92,"context_line":"            del kwargs[\u0027body\u0027]"},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"        resp \u003d requests.request(method, self.blazar_url + url, **kwargs)"}],"source_content_type":"text/x-python","patch_set":3,"id":"5f93b717_db3dc6dd","line":91,"in_reply_to":"5f93b717_639a2415","updated":"2018-01-30 14:04:51.000000000","message":"Thanks for the explanation!","commit_id":"39e1b71b81b3cde1e7936552f837f42211ae7747"}]}
