)]}'
{"blazarclient/tests/v1/shell_commands/test_floatingips.py":[{"author":{"_account_id":25625,"name":"Tetsuro Nakamura","email":"tetsuro.nakamura.bc@hco.ntt.co.jp","username":"tetsuro0907"},"change_message_id":"f67be0d097de3dcd5d7c6e142a5de577188181bc","unresolved":false,"context_lines":[{"line_number":105,"context_line":"        delete_floatingip.run(args)"},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"        floatingip_manager.delete.assert_called_once_with("},{"line_number":108,"context_line":"            \u002784c4d37e-1f8b-45ce-897b-16ad7f49b0e9\u0027)"}],"source_content_type":"text/x-python","patch_set":5,"id":"bfb3d3c7_c1c4aff7","line":108,"updated":"2019-05-29 07:03:59.000000000","message":"Is there a reason why we lack exercising ListFloatingIPsTest class?","commit_id":"49a6dbfba950f002bb42123f3c87a28b72bb84bd"},{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"a665e19a981fa2f5e7ce5bd543966a50f3cbe963","unresolved":false,"context_lines":[{"line_number":105,"context_line":"        delete_floatingip.run(args)"},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"        floatingip_manager.delete.assert_called_once_with("},{"line_number":108,"context_line":"            \u002784c4d37e-1f8b-45ce-897b-16ad7f49b0e9\u0027)"}],"source_content_type":"text/x-python","patch_set":5,"id":"bfb3d3c7_39f60665","line":108,"in_reply_to":"bfb3d3c7_c1c4aff7","updated":"2019-05-30 10:31:36.000000000","message":"Thanks Tetsuro, good catch. I used test_hosts.py as a template, but it doesn\u0027t have a test case for list. I added one for floating IPs in a newer patch.","commit_id":"49a6dbfba950f002bb42123f3c87a28b72bb84bd"}],"blazarclient/v1/shell_commands/leases.py":[{"author":{"_account_id":8878,"name":"Masahito Muroi","email":"masahito.muroi@linecorp.com","username":"masa"},"change_message_id":"f72f91627c19840dadaa4184813539c9a3fea938","unresolved":false,"context_lines":[{"line_number":288,"context_line":""},{"line_number":289,"context_line":"            res_info \u003d parse_params(res_str, defaults)"},{"line_number":290,"context_line":""},{"line_number":291,"context_line":"            if \u0027virtual:floatingip\u0027 in res_str:"},{"line_number":292,"context_line":"                if not res_info.get(\u0027network_id\u0027):"},{"line_number":293,"context_line":"                    err_msg \u003d (\"Missing reservation argument \u0027network_id\u0027 for \""},{"line_number":294,"context_line":"                               \"virtual:floatingip reservation\")"},{"line_number":295,"context_line":"                    raise exception.IncorrectLease(err_msg)"}],"source_content_type":"text/x-python","patch_set":4,"id":"5fc1f717_e9d76322","line":292,"range":{"start_line":291,"start_character":0,"end_line":292,"end_character":50},"updated":"2019-04-09 09:30:20.000000000","message":"I don\u0027t think this validation is needed because the Blazar server returns 400 error when network_id is missing.","commit_id":"c4ff1d642cb6c5b0ba9425af0bcdd02233b6c5dc"},{"author":{"_account_id":15197,"name":"Pierre Riteau","email":"pierre@stackhpc.com","username":"priteau","status":"StackHPC"},"change_message_id":"4f16000754b1468493c7aab2b5698ca07e8af834","unresolved":false,"context_lines":[{"line_number":288,"context_line":""},{"line_number":289,"context_line":"            res_info \u003d parse_params(res_str, defaults)"},{"line_number":290,"context_line":""},{"line_number":291,"context_line":"            if \u0027virtual:floatingip\u0027 in res_str:"},{"line_number":292,"context_line":"                if not res_info.get(\u0027network_id\u0027):"},{"line_number":293,"context_line":"                    err_msg \u003d (\"Missing reservation argument \u0027network_id\u0027 for \""},{"line_number":294,"context_line":"                               \"virtual:floatingip reservation\")"},{"line_number":295,"context_line":"                    raise exception.IncorrectLease(err_msg)"}],"source_content_type":"text/x-python","patch_set":4,"id":"dfbec78f_8de57c3a","line":292,"range":{"start_line":291,"start_character":0,"end_line":292,"end_character":50},"in_reply_to":"5fc1f717_e9d76322","updated":"2019-05-15 14:31:16.000000000","message":"I\u0027ve removed the validation and also removed the default empty string passed as network_id, which was preventing the validation code in Blazar from returning the right message.","commit_id":"c4ff1d642cb6c5b0ba9425af0bcdd02233b6c5dc"}]}