)]}'
{"climateclient/tests/__init__.py":[{"author":{"_account_id":9331,"name":"Pablo Andres Fuente","email":"pablo.andres.fuente@gmail.com","username":"pafuent"},"change_message_id":"d3b7f55dfa1582251a1e6e796dae031448f46ed1","unresolved":false,"context_lines":[{"line_number":29,"context_line":"    \"\"\"Test case base class for all unit tests."},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"    Due to the slowness of DB access, this class is not supporting DB tests."},{"line_number":32,"context_line":"    If needed, please herit from DBTestCase instead."},{"line_number":33,"context_line":"    \"\"\""},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"    def setUp(self):"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAUX%2F%2F2XU%3D","line":32,"updated":"2014-02-10 12:42:17.000000000","message":"Could you please add the DBTestCase class? If isn\u0027t makes sense at this point I think would be better to remove this line.","commit_id":"d417d2549adbdf042fe4711eb460b69c9eb82271"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"e844f4c56cc4fd0e59ee8a6a3f2db5010ca185d3","unresolved":false,"context_lines":[{"line_number":29,"context_line":"    \"\"\"Test case base class for all unit tests."},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"    Due to the slowness of DB access, this class is not supporting DB tests."},{"line_number":32,"context_line":"    If needed, please herit from DBTestCase instead."},{"line_number":33,"context_line":"    \"\"\""},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"    def setUp(self):"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAUX%2F%2F2CQ%3D","line":32,"in_reply_to":"AAAAUX%2F%2F2TI%3D","updated":"2014-02-10 13:24:50.000000000","message":"There is no need for having a DBTestCase (the code was copied from Climate), as it\u0027s only a framework for CLI.\n\nOnly amending the docstring is enough for me.","commit_id":"d417d2549adbdf042fe4711eb460b69c9eb82271"},{"author":{"_account_id":3012,"name":"Dina Belova","email":"dbelova@mirantis.com","username":"dbelova"},"change_message_id":"b8163f92e08e299ccdb3fbe0d448ff61340dea0c","unresolved":false,"context_lines":[{"line_number":29,"context_line":"    \"\"\"Test case base class for all unit tests."},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"    Due to the slowness of DB access, this class is not supporting DB tests."},{"line_number":32,"context_line":"    If needed, please herit from DBTestCase instead."},{"line_number":33,"context_line":"    \"\"\""},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"    def setUp(self):"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAUX%2F%2F2TI%3D","line":32,"in_reply_to":"AAAAUX%2F%2F2XU%3D","updated":"2014-02-10 12:51:28.000000000","message":"I suppose that was somehow copied from other project - so the doc is also copied, Nick, please, fix it.","commit_id":"d417d2549adbdf042fe4711eb460b69c9eb82271"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"c83bc09a098a4ba6d0ccdeb5ea32a3a78cafbacd","unresolved":false,"context_lines":[{"line_number":28,"context_line":"class TestCase(test.BaseTestCase):"},{"line_number":29,"context_line":"    \"\"\"Test case base class for all unit tests."},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"    Due to the slowness of DB access, this class is not supporting DB tests."},{"line_number":32,"context_line":"    \"\"\""},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"    def setUp(self):"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAUX%2F%2FbJw%3D","line":31,"updated":"2014-02-13 10:01:22.000000000","message":"just a quick nit : I think this line is useless, as the python client doesn\u0027t have DB connection","commit_id":"1579ae7f43258f6964c35b4d2ddefa3c3427da4d"},{"author":{"_account_id":3012,"name":"Dina Belova","email":"dbelova@mirantis.com","username":"dbelova"},"change_message_id":"f4cb742bf3f5d1a77836cfe3cbb148f4a8a2d9f7","unresolved":false,"context_lines":[{"line_number":28,"context_line":"class TestCase(test.BaseTestCase):"},{"line_number":29,"context_line":"    \"\"\"Test case base class for all unit tests."},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"    Due to the slowness of DB access, this class is not supporting DB tests."},{"line_number":32,"context_line":"    \"\"\""},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"    def setUp(self):"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAUX%2F%2FbHE%3D","line":31,"in_reply_to":"AAAAUX%2F%2FbJw%3D","updated":"2014-02-13 10:08:34.000000000","message":"oh, yep - it would be nice to fix it. Completely missed it.","commit_id":"1579ae7f43258f6964c35b4d2ddefa3c3427da4d"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"1d2564b18670a3d538cc0aa6e211917b5bacf55a","unresolved":false,"context_lines":[{"line_number":21,"context_line":"from climateclient.openstack.common.fixture import mockpatch"},{"line_number":22,"context_line":"from climateclient.openstack.common import test"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"CONF \u003d cfg.CONF"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"class TestCase(test.BaseTestCase):"}],"source_content_type":"text/x-python","patch_set":8,"id":"AAAAUX%2F%2Bl6M%3D","line":24,"updated":"2014-02-20 10:10:50.000000000","message":"useless, please remove it for now.","commit_id":"da473646339ec9863348b438ef5f168937b7c1db"}],"test-requirements.txt":[{"author":{"_account_id":7535,"name":"Nikolay Starodubtsev","email":"starodubcevna@gmail.com","username":"Kezar"},"change_message_id":"2db7527cb8d6cfe6ecc40636da60f80873e9c106","unresolved":false,"context_lines":[{"line_number":8,"context_line":"mox\u003e\u003d0.5.3"},{"line_number":9,"context_line":"fixtures\u003e\u003d0.3.14"},{"line_number":10,"context_line":"testrepository\u003e\u003d0.0.17"},{"line_number":11,"context_line":"testtools\u003e\u003d0.9.34"},{"line_number":12,"context_line":"coverage\u003e\u003d3.6"}],"source_content_type":"text/plain","patch_set":8,"id":"AAAAU3%2F%2F6fQ%3D","line":11,"updated":"2014-02-24 04:39:27.000000000","message":"testtools\u003e\u003d0.9.32,\u003c0.9.35","commit_id":"da473646339ec9863348b438ef5f168937b7c1db"}],"tox.ini":[{"author":{"_account_id":9331,"name":"Pablo Andres Fuente","email":"pablo.andres.fuente@gmail.com","username":"pafuent"},"change_message_id":"d3b7f55dfa1582251a1e6e796dae031448f46ed1","unresolved":false,"context_lines":[{"line_number":27,"context_line":"[testenv:cover]"},{"line_number":28,"context_line":"setenv \u003d VIRTUAL_ENV\u003d{envdir}"},{"line_number":29,"context_line":"commands \u003d"},{"line_number":30,"context_line":"  python -m climateclient.openstack.common.lockutils python setup.py testr --coverage --testr-args\u003d\u0027^(?!.*test.*coverage).*$\u0027"}],"source_content_type":"text/x-properties","patch_set":3,"id":"AAAAUX%2F%2F2YA%3D","line":30,"updated":"2014-02-10 12:42:17.000000000","message":"Why are you filtering the tests using this regex? I think is better to use ${posargs}, because all the test will be run by default and gives to the developer the chance to run only a subset of all tests.","commit_id":"d417d2549adbdf042fe4711eb460b69c9eb82271"},{"author":{"_account_id":3012,"name":"Dina Belova","email":"dbelova@mirantis.com","username":"dbelova"},"change_message_id":"b8163f92e08e299ccdb3fbe0d448ff61340dea0c","unresolved":false,"context_lines":[{"line_number":27,"context_line":"[testenv:cover]"},{"line_number":28,"context_line":"setenv \u003d VIRTUAL_ENV\u003d{envdir}"},{"line_number":29,"context_line":"commands \u003d"},{"line_number":30,"context_line":"  python -m climateclient.openstack.common.lockutils python setup.py testr --coverage --testr-args\u003d\u0027^(?!.*test.*coverage).*$\u0027"}],"source_content_type":"text/x-properties","patch_set":3,"id":"AAAAUX%2F%2F2SY%3D","line":30,"in_reply_to":"AAAAUX%2F%2F2YA%3D","updated":"2014-02-10 12:51:28.000000000","message":"+1, it should look like https://github.com/openstack/savanna/blob/master/tox.ini#L24 - only we use lockutils, that\u0027s right","commit_id":"d417d2549adbdf042fe4711eb460b69c9eb82271"}]}
