)]}'
{"climateclient/utils.py":[{"author":{"_account_id":9331,"name":"Pablo Andres Fuente","email":"pablo.andres.fuente@gmail.com","username":"pafuent"},"change_message_id":"9e2bc48ed180a6d500d2ca0a329cf78ed08c8472","unresolved":false,"context_lines":[{"line_number":142,"context_line":"                                               status_code\u003d404)"},{"line_number":143,"context_line":""},{"line_number":144,"context_line":""},{"line_number":145,"context_line":"def from_elapsed_time_to_seconds(elapsed_time, sign\u003d0):"},{"line_number":146,"context_line":"    \"\"\"Return the positive or negative amount of seconds based on the"},{"line_number":147,"context_line":"    elapsed_time parameter with a sign depending on the sign parameter."},{"line_number":148,"context_line":"    :param: elapsed_time: a string that matches ELAPSED_TIME_REGEX"}],"source_content_type":"text/x-python","patch_set":2,"id":"9ad9bd40_5f1dccbc","line":145,"updated":"2014-04-30 20:57:52.000000000","message":"Please use a boolean value for sign, or do this sing thing outside this method (I prefer this outside)","commit_id":"7ea16145e4d52ca591e5ad9cfe9ce66309de7098"},{"author":{"_account_id":9225,"name":"Cristian A Sanchez","email":"cabsanchez@gmail.com","username":"casanch1"},"change_message_id":"0a5e536ad8a98efee370c24c16dd0d08e87ad34e","unresolved":false,"context_lines":[{"line_number":142,"context_line":"                                               status_code\u003d404)"},{"line_number":143,"context_line":""},{"line_number":144,"context_line":""},{"line_number":145,"context_line":"def from_elapsed_time_to_seconds(elapsed_time, sign\u003d0):"},{"line_number":146,"context_line":"    \"\"\"Return the positive or negative amount of seconds based on the"},{"line_number":147,"context_line":"    elapsed_time parameter with a sign depending on the sign parameter."},{"line_number":148,"context_line":"    :param: elapsed_time: a string that matches ELAPSED_TIME_REGEX"}],"source_content_type":"text/x-python","patch_set":2,"id":"7adec928_1d46cc21","line":145,"in_reply_to":"9ad9bd40_35a9d17b","updated":"2014-05-22 20:52:39.000000000","message":"I will leave the argument but make it boolean. If I make the sign operation outside this method I will have to put if/else everywhere.","commit_id":"7ea16145e4d52ca591e5ad9cfe9ce66309de7098"},{"author":{"_account_id":7535,"name":"Nikolay Starodubtsev","email":"starodubcevna@gmail.com","username":"Kezar"},"change_message_id":"104a34126f52ff1125b2199b95751736e2a5c8dd","unresolved":false,"context_lines":[{"line_number":142,"context_line":"                                               status_code\u003d404)"},{"line_number":143,"context_line":""},{"line_number":144,"context_line":""},{"line_number":145,"context_line":"def from_elapsed_time_to_seconds(elapsed_time, sign\u003d0):"},{"line_number":146,"context_line":"    \"\"\"Return the positive or negative amount of seconds based on the"},{"line_number":147,"context_line":"    elapsed_time parameter with a sign depending on the sign parameter."},{"line_number":148,"context_line":"    :param: elapsed_time: a string that matches ELAPSED_TIME_REGEX"}],"source_content_type":"text/x-python","patch_set":2,"id":"9ad9bd40_35a9d17b","line":145,"in_reply_to":"9ad9bd40_5f1dccbc","updated":"2014-05-02 21:59:17.000000000","message":"+1  to Pablo. Otherwise why do you use separated func for this? Or do you use it in other places?","commit_id":"7ea16145e4d52ca591e5ad9cfe9ce66309de7098"},{"author":{"_account_id":7494,"name":"Guangya Liu","email":"gyliu513@gmail.com","username":"JayLau"},"change_message_id":"c0c5e2a71096eb6d8fe7c25a4038695d42c9327d","unresolved":false,"context_lines":[{"line_number":169,"context_line":"    # the above code returns a \"float\""},{"line_number":170,"context_line":"    if sign \u003e\u003d 0:"},{"line_number":171,"context_line":"        return int(seconds)"},{"line_number":172,"context_line":"    else:"},{"line_number":173,"context_line":"        return int(seconds) * -1"},{"line_number":174,"context_line":""},{"line_number":175,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"9ad9bd40_8cbdddb9","line":172,"updated":"2014-05-07 07:54:31.000000000","message":"Agree the sign to be a Boolean value.\n\nAlso imho the else is not needed for a simple if statement.\n\nif xxx:\n    yyy\nzzz","commit_id":"7ea16145e4d52ca591e5ad9cfe9ce66309de7098"},{"author":{"_account_id":9225,"name":"Cristian A Sanchez","email":"cabsanchez@gmail.com","username":"casanch1"},"change_message_id":"0a5e536ad8a98efee370c24c16dd0d08e87ad34e","unresolved":false,"context_lines":[{"line_number":169,"context_line":"    # the above code returns a \"float\""},{"line_number":170,"context_line":"    if sign \u003e\u003d 0:"},{"line_number":171,"context_line":"        return int(seconds)"},{"line_number":172,"context_line":"    else:"},{"line_number":173,"context_line":"        return int(seconds) * -1"},{"line_number":174,"context_line":""},{"line_number":175,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"7adec928_5d5054d4","line":172,"in_reply_to":"9ad9bd40_26c22d34","updated":"2014-05-22 20:52:39.000000000","message":"done","commit_id":"7ea16145e4d52ca591e5ad9cfe9ce66309de7098"},{"author":{"_account_id":7494,"name":"Guangya Liu","email":"gyliu513@gmail.com","username":"JayLau"},"change_message_id":"1022934d08dbe1e952b610b137f78442e80b7a09","unresolved":false,"context_lines":[{"line_number":169,"context_line":"    # the above code returns a \"float\""},{"line_number":170,"context_line":"    if sign \u003e\u003d 0:"},{"line_number":171,"context_line":"        return int(seconds)"},{"line_number":172,"context_line":"    else:"},{"line_number":173,"context_line":"        return int(seconds) * -1"},{"line_number":174,"context_line":""},{"line_number":175,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"9ad9bd40_26c22d34","line":172,"in_reply_to":"9ad9bd40_26ef8dea","updated":"2014-05-07 11:54:32.000000000","message":"@Sylvain, what I mean for above is for a Boolean value. Agree for other values but not Boolean, it is better use explicit comparison. ;-)","commit_id":"7ea16145e4d52ca591e5ad9cfe9ce66309de7098"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"443f664dd396fb3dd8994abff8d011002fe44832","unresolved":false,"context_lines":[{"line_number":169,"context_line":"    # the above code returns a \"float\""},{"line_number":170,"context_line":"    if sign \u003e\u003d 0:"},{"line_number":171,"context_line":"        return int(seconds)"},{"line_number":172,"context_line":"    else:"},{"line_number":173,"context_line":"        return int(seconds) * -1"},{"line_number":174,"context_line":""},{"line_number":175,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"9ad9bd40_26ef8dea","line":172,"in_reply_to":"9ad9bd40_8cbdddb9","updated":"2014-05-07 11:46:29.000000000","message":"Well, I personnally prefer using explicit comparisons like : \n  if xxx is not None:\n    yyy\n  zzz","commit_id":"7ea16145e4d52ca591e5ad9cfe9ce66309de7098"}],"climateclient/v1/leases.py":[{"author":{"_account_id":10200,"name":"Christian Martinez","email":"chmartinez35@gmail.com","username":"cmart"},"change_message_id":"ffcacda84a01dcf046dd50f22a2321f5e55fc809","unresolved":false,"context_lines":[{"line_number":70,"context_line":"                \u0027%Y-%m-%dT%H:%M:%S.%f\u0027)"},{"line_number":71,"context_line":"            values[\u0027start_date\u0027] \u003d datetime.datetime.strftime("},{"line_number":72,"context_line":"                lease_start_date + delta_sec,"},{"line_number":73,"context_line":"                \u0027%Y-%m-%d %H:%M\u0027)"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"        if not values:"},{"line_number":76,"context_line":"            return _(\u0027No values to update passed.\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"bad4c104_f2725be4","line":73,"updated":"2014-04-29 20:03:11.000000000","message":"I would suggest to convert these data_format strings into constants. I know that they should match the ones used on climate module, so maybe we could import them.\nRegarding the \u0027%Y-%m-%dT%H:%M:%S.%f\u0027, the timeutils does have a couple of constants that could help","commit_id":"8e61014bb8a50e8f351a43aa0d0bb52c645f4424"},{"author":{"_account_id":9225,"name":"Cristian A Sanchez","email":"cabsanchez@gmail.com","username":"casanch1"},"change_message_id":"10b66fd21361729db0ea2517825940d70bcd9544","unresolved":false,"context_lines":[{"line_number":70,"context_line":"                \u0027%Y-%m-%dT%H:%M:%S.%f\u0027)"},{"line_number":71,"context_line":"            values[\u0027start_date\u0027] \u003d datetime.datetime.strftime("},{"line_number":72,"context_line":"                lease_start_date + delta_sec,"},{"line_number":73,"context_line":"                \u0027%Y-%m-%d %H:%M\u0027)"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"        if not values:"},{"line_number":76,"context_line":"            return _(\u0027No values to update passed.\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"bad4c104_8d12d4b2","line":73,"in_reply_to":"bad4c104_f2725be4","updated":"2014-04-29 20:24:16.000000000","message":"You\u0027re right. I will create a couple of functions for those conversions so they\u0027re used everywhere.","commit_id":"8e61014bb8a50e8f351a43aa0d0bb52c645f4424"},{"author":{"_account_id":9331,"name":"Pablo Andres Fuente","email":"pablo.andres.fuente@gmail.com","username":"pafuent"},"change_message_id":"9e2bc48ed180a6d500d2ca0a329cf78ed08c8472","unresolved":false,"context_lines":[{"line_number":46,"context_line":"        lease_start_date_change \u003d defer_by"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"        if lease_end_date_change:"},{"line_number":49,"context_line":"            delta_sec \u003d utils.from_elapsed_time_to_delta("},{"line_number":50,"context_line":"                lease_end_date_change,"},{"line_number":51,"context_line":"                sign\u003d1 if prolong_for else -1)"},{"line_number":52,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"9ad9bd40_9f94b438","line":49,"updated":"2014-04-30 20:57:52.000000000","message":"Maybe this code could be extracted in a method. The two date_change if are similar.","commit_id":"7ea16145e4d52ca591e5ad9cfe9ce66309de7098"},{"author":{"_account_id":9225,"name":"Cristian A Sanchez","email":"cabsanchez@gmail.com","username":"casanch1"},"change_message_id":"0a5e536ad8a98efee370c24c16dd0d08e87ad34e","unresolved":false,"context_lines":[{"line_number":46,"context_line":"        lease_start_date_change \u003d defer_by"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"        if lease_end_date_change:"},{"line_number":49,"context_line":"            delta_sec \u003d utils.from_elapsed_time_to_delta("},{"line_number":50,"context_line":"                lease_end_date_change,"},{"line_number":51,"context_line":"                sign\u003d1 if prolong_for else -1)"},{"line_number":52,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"7adec928_bdb078de","line":49,"in_reply_to":"9ad9bd40_9f94b438","updated":"2014-05-22 20:52:39.000000000","message":"I agree. I just didn\u0027t want to change the existing code very much. But will do","commit_id":"7ea16145e4d52ca591e5ad9cfe9ce66309de7098"}],"climateclient/v1/shell_commands/leases.py":[{"author":{"_account_id":9331,"name":"Pablo Andres Fuente","email":"pablo.andres.fuente@gmail.com","username":"pafuent"},"change_message_id":"9e2bc48ed180a6d500d2ca0a329cf78ed08c8472","unresolved":false,"context_lines":[{"line_number":251,"context_line":"        group \u003d parser.add_mutually_exclusive_group()"},{"line_number":252,"context_line":"        group.add_argument("},{"line_number":253,"context_line":"            \u0027--defer-by\u0027,"},{"line_number":254,"context_line":"            help\u003d\u0027Time to defer the lease start\u0027,"},{"line_number":255,"context_line":"            default\u003dNone"},{"line_number":256,"context_line":"        )"},{"line_number":257,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"9ad9bd40_7fd37038","line":254,"updated":"2014-04-30 20:57:52.000000000","message":"Please update the help to include all the available options for this parameter (s/m/h/d)","commit_id":"7ea16145e4d52ca591e5ad9cfe9ce66309de7098"},{"author":{"_account_id":9225,"name":"Cristian A Sanchez","email":"cabsanchez@gmail.com","username":"casanch1"},"change_message_id":"0a5e536ad8a98efee370c24c16dd0d08e87ad34e","unresolved":false,"context_lines":[{"line_number":251,"context_line":"        group \u003d parser.add_mutually_exclusive_group()"},{"line_number":252,"context_line":"        group.add_argument("},{"line_number":253,"context_line":"            \u0027--defer-by\u0027,"},{"line_number":254,"context_line":"            help\u003d\u0027Time to defer the lease start\u0027,"},{"line_number":255,"context_line":"            default\u003dNone"},{"line_number":256,"context_line":"        )"},{"line_number":257,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"7adec928_d80f552d","line":254,"in_reply_to":"9ad9bd40_7fd37038","updated":"2014-05-22 20:52:39.000000000","message":"the previous arguments have also the same options. Do you suggest adding that to all of them?","commit_id":"7ea16145e4d52ca591e5ad9cfe9ce66309de7098"}]}