)]}'
{"id":"openstack%2Fpython-brick-cinderclient-ext~429527","triplet_id":"openstack%2Fpython-brick-cinderclient-ext~master~Ib80b7967889987dc2c78f85d6b006d84ef96fe15","project":"openstack/python-brick-cinderclient-ext","branch":"master","topic":"cleancode","hashtags":[],"change_id":"Ib80b7967889987dc2c78f85d6b006d84ef96fe15","subject":"Clean imports in code","status":"MERGED","created":"2017-02-06 06:44:23.000000000","updated":"2017-02-06 15:02:39.000000000","submitted":"2017-02-06 15:02:39.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"26b34891fdcb136a8b8ea16c759733197e762ed4","_number":429527,"virtual_id_number":429527,"owner":{"_account_id":15905,"name":"Cao Xuan Hoang","email":"xuanhoangqb@gmail.com","username":"hoangcx"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":0,"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},{"value":2,"date":"2017-02-06 15:02:39.000000000","post_submit":true,"_account_id":3,"name":"Jenkins","username":"jenkins"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"all":[{"value":2,"date":"2017-02-06 14:44:27.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"all":[{"value":1,"date":"2017-02-06 14:44:27.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"}],"values":{"-1":"Branch Freeze"," 0":"No Priority","+1":"Important Change","+2":"Gate Blocker Fix / Urgent Change"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2017-02-06 14:44:27.000000000","updated_by":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"reviewer":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"state":"REVIEWER"},{"updated":"2017-02-06 15:02:39.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"24d53877f8273cbed8da9f8ba3250f2f7e49fc27","author":{"_account_id":15905,"name":"Cao Xuan Hoang","email":"xuanhoangqb@gmail.com","username":"hoangcx"},"date":"2017-02-06 06:44:23.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"2212dbc72d624b316ebdea538a06df7eb4f8fefc","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-02-06 07:02:16.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-brick-cinderclient-ext-docs-ubuntu-xenial http://docs-draft.openstack.org/27/429527/1/check/gate-python-brick-cinderclient-ext-docs-ubuntu-xenial/9b64454//doc/build/html/ : SUCCESS in 2m 22s\n- gate-python-brick-cinderclient-ext-pep8-ubuntu-xenial http://logs.openstack.org/27/429527/1/check/gate-python-brick-cinderclient-ext-pep8-ubuntu-xenial/cd2140d/ : SUCCESS in 2m 27s\n- gate-python-brick-cinderclient-ext-python27-ubuntu-xenial http://logs.openstack.org/27/429527/1/check/gate-python-brick-cinderclient-ext-python27-ubuntu-xenial/d64f680/ : SUCCESS in 2m 21s\n- gate-python-brick-cinderclient-ext-python35 http://logs.openstack.org/27/429527/1/check/gate-python-brick-cinderclient-ext-python35/737ffb7/ : SUCCESS in 1m 49s\n- gate-python-brick-cinderclient-ext-pypy http://logs.openstack.org/27/429527/1/check/gate-python-brick-cinderclient-ext-pypy/c3f9ee2/ : SUCCESS in 2m 12s (non-voting)\n- gate-brick-cinderclient-ext-dsvm-functional-ubuntu-xenial http://logs.openstack.org/27/429527/1/check/gate-brick-cinderclient-ext-dsvm-functional-ubuntu-xenial/18400d2/ : SUCCESS in 16m 59s","accounts_in_message":[],"_revision_number":1},{"id":"29cf0e68e51c9665667c3b0ddd6ee9ad87358bfd","author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"date":"2017-02-06 14:44:27.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":1},{"id":"33bae5b14b0639b813a321a17954ea870fdb6d1c","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-02-06 14:44:37.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":1},{"id":"4294515890af73aaa72f6821ff51a59455a93e7e","date":"2017-02-06 15:02:39.000000000","message":"Change has been successfully merged into the git repository by Jenkins","accounts_in_message":[],"_revision_number":1},{"id":"4f9b1bd9b0d107d5e99ebb3fac5185239fffba74","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-02-06 15:02:39.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- gate-python-brick-cinderclient-ext-docs-ubuntu-xenial http://docs-draft.openstack.org/27/429527/1/gate/gate-python-brick-cinderclient-ext-docs-ubuntu-xenial/2f8f515//doc/build/html/ : SUCCESS in 2m 23s\n- gate-python-brick-cinderclient-ext-pep8-ubuntu-xenial http://logs.openstack.org/27/429527/1/gate/gate-python-brick-cinderclient-ext-pep8-ubuntu-xenial/9f5fc84/ : SUCCESS in 2m 07s\n- gate-python-brick-cinderclient-ext-python27-ubuntu-xenial http://logs.openstack.org/27/429527/1/gate/gate-python-brick-cinderclient-ext-python27-ubuntu-xenial/d29be57/ : SUCCESS in 1m 55s\n- gate-python-brick-cinderclient-ext-python35 http://logs.openstack.org/27/429527/1/gate/gate-python-brick-cinderclient-ext-python35/7c36474/ : SUCCESS in 2m 00s\n- gate-brick-cinderclient-ext-dsvm-functional-ubuntu-xenial http://logs.openstack.org/27/429527/1/gate/gate-brick-cinderclient-ext-dsvm-functional-ubuntu-xenial/9ec1036/ : SUCCESS in 17m 37s","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"3b843f8ed8a2d8c9da95e2e6ac28e81bfa165783","revisions":{"3b843f8ed8a2d8c9da95e2e6ac28e81bfa165783":{"kind":"REWORK","_number":1,"created":"2017-02-06 06:44:23.000000000","uploader":{"_account_id":15905,"name":"Cao Xuan Hoang","email":"xuanhoangqb@gmail.com","username":"hoangcx"},"ref":"refs/changes/27/429527/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-brick-cinderclient-ext","ref":"refs/changes/27/429527/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-brick-cinderclient-ext refs/changes/27/429527/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-brick-cinderclient-ext refs/changes/27/429527/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-brick-cinderclient-ext refs/changes/27/429527/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-brick-cinderclient-ext refs/changes/27/429527/1"}}},"commit":{"parents":[{"commit":"39c714c06ed537177f15e14b3c4a1ad73d957518","subject":"Remove unnecessary \u0027service_type\u0027 decorator","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-brick-cinderclient-ext/commit/39c714c06ed537177f15e14b3c4a1ad73d957518"}]}],"author":{"name":"Cao Xuan Hoang","email":"hoangcx@vn.fujitsu.com","date":"2017-02-06 06:42:44.000000000","tz":420},"committer":{"name":"Cao Xuan Hoang","email":"hoangcx@vn.fujitsu.com","date":"2017-02-06 06:42:44.000000000","tz":420},"subject":"Clean imports in code","message":"Clean imports in code\n\nThis patch set modifies lines which are importing objects\ninstead of modules. As per openstack import guide lines, user should\nimport modules in a file not objects.\n\nhttp://docs.openstack.org/developer/hacking/#imports\n\nChange-Id: Ib80b7967889987dc2c78f85d6b006d84ef96fe15\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-brick-cinderclient-ext/commit/3b843f8ed8a2d8c9da95e2e6ac28e81bfa165783"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-brick-cinderclient-ext/commit/3b843f8ed8a2d8c9da95e2e6ac28e81bfa165783"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}
