)]}'
{"id":"openstack%2Fpython-brick-cinderclient-ext~479371","triplet_id":"openstack%2Fpython-brick-cinderclient-ext~master~If5d5fdcf140a557aa2b273e65c0fcdb64aa56f17","project":"openstack/python-brick-cinderclient-ext","branch":"master","topic":"new-attach","hashtags":[],"change_id":"If5d5fdcf140a557aa2b273e65c0fcdb64aa56f17","subject":"Don\u0027t override brick\u0027s execute function","status":"MERGED","created":"2017-06-30 16:56:44.000000000","updated":"2017-07-01 22:08:38.000000000","submitted":"2017-07-01 22:08:38.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":1,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"3ab53780f4edbf2ec83a6b56615598f7c92c7db5","_number":479371,"virtual_id_number":479371,"owner":{"_account_id":12924,"name":"Patrick East","email":"east.patrick@gmail.com","username":"patrick.east"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":0,"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},{"value":0,"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},{"value":2,"date":"2017-07-01 22:08:38.000000000","post_submit":true,"_account_id":3,"name":"Jenkins","username":"jenkins"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"all":[{"value":2,"date":"2017-07-01 21:54:32.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},{"value":2,"date":"2017-06-30 19:39:15.000000000","_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"all":[{"value":1,"date":"2017-07-01 21:54:32.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},{"value":0,"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},{"value":0,"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"}],"values":{"-1":"Branch Freeze"," 0":"No Priority","+1":"Important Change","+2":"Gate Blocker Fix / Urgent Change"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2017-06-30 19:39:15.000000000","updated_by":{"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},"reviewer":{"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},"state":"REVIEWER"},{"updated":"2017-07-01 21:54:32.000000000","updated_by":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"reviewer":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"state":"REVIEWER"},{"updated":"2017-07-01 22:08:38.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"8b47fe5ebd7bf8bd97112eb68fe5fd7479907e00","author":{"_account_id":12924,"name":"Patrick East","email":"east.patrick@gmail.com","username":"patrick.east"},"date":"2017-06-30 16:56:44.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"2e12fa61dca624bf1eac856ca82cf6fe4da172ea","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-06-30 17:18:39.000000000","message":"Patch Set 1: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see http://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n- gate-python-brick-cinderclient-ext-docs-ubuntu-xenial http://docs-draft.openstack.org/71/479371/1/check/gate-python-brick-cinderclient-ext-docs-ubuntu-xenial/832e7cd//doc/build/html/ : SUCCESS in 1m 49s\n- gate-python-brick-cinderclient-ext-pep8-ubuntu-xenial http://logs.openstack.org/71/479371/1/check/gate-python-brick-cinderclient-ext-pep8-ubuntu-xenial/36b715e/ : SUCCESS in 1m 03s\n- gate-python-brick-cinderclient-ext-python27-ubuntu-xenial http://logs.openstack.org/71/479371/1/check/gate-python-brick-cinderclient-ext-python27-ubuntu-xenial/455ae6e/ : FAILURE in 1m 49s\n- gate-python-brick-cinderclient-ext-python35 http://logs.openstack.org/71/479371/1/check/gate-python-brick-cinderclient-ext-python35/fe9dcbd/ : FAILURE in 1m 29s\n- gate-brick-cinderclient-ext-dsvm-functional-ubuntu-xenial http://logs.openstack.org/71/479371/1/check/gate-brick-cinderclient-ext-dsvm-functional-ubuntu-xenial/d94eebc/ : SUCCESS in 20m 43s","accounts_in_message":[],"_revision_number":1},{"id":"e49391531641134d7ebb872837d28127f56b240d","author":{"_account_id":12924,"name":"Patrick East","email":"east.patrick@gmail.com","username":"patrick.east"},"date":"2017-06-30 17:49:25.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"68fcafc42b57db61743e5ae2984c80f1535dc1f9","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-06-30 18:20:50.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-brick-cinderclient-ext-docs-ubuntu-xenial http://docs-draft.openstack.org/71/479371/2/check/gate-python-brick-cinderclient-ext-docs-ubuntu-xenial/f0e639a//doc/build/html/ : SUCCESS in 2m 31s\n- gate-python-brick-cinderclient-ext-pep8-ubuntu-xenial http://logs.openstack.org/71/479371/2/check/gate-python-brick-cinderclient-ext-pep8-ubuntu-xenial/076d18a/ : SUCCESS in 2m 18s\n- gate-python-brick-cinderclient-ext-python27-ubuntu-xenial http://logs.openstack.org/71/479371/2/check/gate-python-brick-cinderclient-ext-python27-ubuntu-xenial/063e585/ : SUCCESS in 2m 11s\n- gate-python-brick-cinderclient-ext-python35 http://logs.openstack.org/71/479371/2/check/gate-python-brick-cinderclient-ext-python35/3193754/ : SUCCESS in 1m 26s\n- gate-brick-cinderclient-ext-dsvm-functional-ubuntu-xenial http://logs.openstack.org/71/479371/2/check/gate-brick-cinderclient-ext-dsvm-functional-ubuntu-xenial/80c9527/ : SUCCESS in 30m 42s","accounts_in_message":[],"_revision_number":2},{"id":"0cba7f163bb5fc2105c35a527f24efea76d1c50c","author":{"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},"date":"2017-06-30 19:39:15.000000000","message":"Patch Set 2: Code-Review+2\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"48c72be85952bec93c58536c1c6b43d14b40b472","author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"date":"2017-07-01 21:54:32.000000000","message":"Patch Set 2: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":2},{"id":"a1e757b7250e8c7062f7ded6db81a6b0ca385957","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-07-01 21:54:42.000000000","message":"Patch Set 2: -Verified\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":2},{"id":"5222d99f8694e7f29b9a64003f88b3a024ff2de0","date":"2017-07-01 22:08:38.000000000","message":"Change has been successfully merged into the git repository by Jenkins","accounts_in_message":[],"_revision_number":2},{"id":"c0689a62b652311a39174b61fa5d2ec25a365962","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-07-01 22:08:38.000000000","message":"Patch Set 2: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- gate-python-brick-cinderclient-ext-docs-ubuntu-xenial http://docs-draft.openstack.org/71/479371/2/gate/gate-python-brick-cinderclient-ext-docs-ubuntu-xenial/407a4e5//doc/build/html/ : SUCCESS in 40s\n- gate-python-brick-cinderclient-ext-pep8-ubuntu-xenial http://logs.openstack.org/71/479371/2/gate/gate-python-brick-cinderclient-ext-pep8-ubuntu-xenial/50d2e8a/ : SUCCESS in 52s\n- gate-python-brick-cinderclient-ext-python27-ubuntu-xenial http://logs.openstack.org/71/479371/2/gate/gate-python-brick-cinderclient-ext-python27-ubuntu-xenial/b4fd349/ : SUCCESS in 41s\n- gate-python-brick-cinderclient-ext-python35 http://logs.openstack.org/71/479371/2/gate/gate-python-brick-cinderclient-ext-python35/e52ef0c/ : SUCCESS in 42s\n- gate-brick-cinderclient-ext-dsvm-functional-ubuntu-xenial http://logs.openstack.org/71/479371/2/gate/gate-brick-cinderclient-ext-dsvm-functional-ubuntu-xenial/2e1fda5/ : SUCCESS in 13m 47s","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"8ad341db04b789554108a7c70412d18a518f63cd","revisions":{"2bcb9eb860b467068091ab162e0934f3e29a3108":{"kind":"REWORK","_number":1,"created":"2017-06-30 16:56:44.000000000","uploader":{"_account_id":12924,"name":"Patrick East","email":"east.patrick@gmail.com","username":"patrick.east"},"ref":"refs/changes/71/479371/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-brick-cinderclient-ext","ref":"refs/changes/71/479371/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-brick-cinderclient-ext refs/changes/71/479371/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-brick-cinderclient-ext refs/changes/71/479371/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-brick-cinderclient-ext refs/changes/71/479371/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-brick-cinderclient-ext refs/changes/71/479371/1"}}},"commit":{"parents":[{"commit":"a1c0aef194383b13eb646833b88a6910757d8477","subject":"Updated from global requirements","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-brick-cinderclient-ext/commit/a1c0aef194383b13eb646833b88a6910757d8477"}]}],"author":{"name":"Patrick East","email":"patrick.east@purestorage.com","date":"2017-06-30 16:53:24.000000000","tz":-420},"committer":{"name":"Patrick East","email":"patrick.east@purestorage.com","date":"2017-06-30 16:56:12.000000000","tz":-420},"subject":"Don\u0027t override brick\u0027s execute function","message":"Don\u0027t override brick\u0027s execute function\n\nThere was a custom_execute added into os-brick that\ntakes additional parameters, and now if we just pass\nin putils.execute it blows up in places we call\nexecute with the new parameters.\n\nShort term fix is to just pass in None by default\nwhich gives us the custom_execute, under the hood\nit just uses putils.execute anyway.\n\nChange-Id: If5d5fdcf140a557aa2b273e65c0fcdb64aa56f17\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-brick-cinderclient-ext/commit/2bcb9eb860b467068091ab162e0934f3e29a3108"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-brick-cinderclient-ext/commit/2bcb9eb860b467068091ab162e0934f3e29a3108"}]},"branch":"refs/heads/master"},"8ad341db04b789554108a7c70412d18a518f63cd":{"kind":"REWORK","_number":2,"created":"2017-06-30 17:49:25.000000000","uploader":{"_account_id":12924,"name":"Patrick East","email":"east.patrick@gmail.com","username":"patrick.east"},"ref":"refs/changes/71/479371/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-brick-cinderclient-ext","ref":"refs/changes/71/479371/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-brick-cinderclient-ext refs/changes/71/479371/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-brick-cinderclient-ext refs/changes/71/479371/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-brick-cinderclient-ext refs/changes/71/479371/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-brick-cinderclient-ext refs/changes/71/479371/2"}}},"commit":{"parents":[{"commit":"a1c0aef194383b13eb646833b88a6910757d8477","subject":"Updated from global requirements","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-brick-cinderclient-ext/commit/a1c0aef194383b13eb646833b88a6910757d8477"}]}],"author":{"name":"Patrick East","email":"patrick.east@purestorage.com","date":"2017-06-30 16:53:24.000000000","tz":-420},"committer":{"name":"Patrick East","email":"patrick.east@purestorage.com","date":"2017-06-30 17:49:05.000000000","tz":-420},"subject":"Don\u0027t override brick\u0027s execute function","message":"Don\u0027t override brick\u0027s execute function\n\nThere was a custom_execute added into os-brick that\ntakes additional parameters, and now if we just pass\nin putils.execute it blows up in places we call\nexecute with the new parameters.\n\nShort term fix is to just pass in None by default\nwhich gives us the custom_execute, under the hood\nit just uses putils.execute anyway.\n\nChange-Id: If5d5fdcf140a557aa2b273e65c0fcdb64aa56f17\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-brick-cinderclient-ext/commit/8ad341db04b789554108a7c70412d18a518f63cd"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-brick-cinderclient-ext/commit/8ad341db04b789554108a7c70412d18a518f63cd"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}