)]}'
{"id":"openstack%2Fpython-brick-cinderclient-ext~479373","triplet_id":"openstack%2Fpython-brick-cinderclient-ext~master~If41dd2cc8324c372742d52d001bc98961936f1f0","project":"openstack/python-brick-cinderclient-ext","branch":"master","topic":"new-attach","hashtags":[],"change_id":"If41dd2cc8324c372742d52d001bc98961936f1f0","subject":"Actually do the detach with the new attach/detach flow","status":"MERGED","created":"2017-06-30 16:56:44.000000000","updated":"2017-07-06 18:37:26.000000000","submitted":"2017-07-06 18:37:26.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":1,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"85f48566b23e4828e499e99e5371079ebf487f45","_number":479373,"virtual_id_number":479373,"owner":{"_account_id":12924,"name":"Patrick East","email":"east.patrick@gmail.com","username":"patrick.east"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":0,"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},{"value":0,"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},{"value":2,"date":"2017-07-06 18:37:26.000000000","post_submit":true,"_account_id":3,"name":"Jenkins","username":"jenkins"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"all":[{"value":2,"date":"2017-07-06 18:21:21.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},{"value":2,"date":"2017-06-30 19:33:39.000000000","_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"all":[{"value":1,"date":"2017-07-06 18:21:21.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},{"value":0,"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},{"value":0,"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"}],"values":{"-1":"Branch Freeze"," 0":"No Priority","+1":"Important Change","+2":"Gate Blocker Fix / Urgent Change"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2017-06-30 19:33:39.000000000","updated_by":{"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},"reviewer":{"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},"state":"REVIEWER"},{"updated":"2017-07-06 18:21:21.000000000","updated_by":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"reviewer":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"state":"REVIEWER"},{"updated":"2017-07-06 18:37:26.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"216b8193f908d5f979d421472d2780b9b67f9264","author":{"_account_id":12924,"name":"Patrick East","email":"east.patrick@gmail.com","username":"patrick.east"},"date":"2017-06-30 16:56:44.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"4e65e4787bdc1c769180c6b9328629308526523d","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-06-30 17:19:02.000000000","message":"Patch Set 1: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see http://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n- gate-python-brick-cinderclient-ext-docs-ubuntu-xenial http://docs-draft.openstack.org/73/479373/1/check/gate-python-brick-cinderclient-ext-docs-ubuntu-xenial/6005b87//doc/build/html/ : SUCCESS in 1m 21s\n- gate-python-brick-cinderclient-ext-pep8-ubuntu-xenial http://logs.openstack.org/73/479373/1/check/gate-python-brick-cinderclient-ext-pep8-ubuntu-xenial/200895e/ : SUCCESS in 1m 50s\n- gate-python-brick-cinderclient-ext-python27-ubuntu-xenial http://logs.openstack.org/73/479373/1/check/gate-python-brick-cinderclient-ext-python27-ubuntu-xenial/2e85a80/ : FAILURE in 1m 18s\n- gate-python-brick-cinderclient-ext-python35 http://logs.openstack.org/73/479373/1/check/gate-python-brick-cinderclient-ext-python35/491ad03/ : FAILURE in 1m 21s\n- gate-brick-cinderclient-ext-dsvm-functional-ubuntu-xenial http://logs.openstack.org/73/479373/1/check/gate-brick-cinderclient-ext-dsvm-functional-ubuntu-xenial/f87d9f2/ : SUCCESS in 21m 04s","accounts_in_message":[],"_revision_number":1},{"id":"a88ba9cb958cbe2bc33e046bff4f909e00199f75","author":{"_account_id":12924,"name":"Patrick East","email":"east.patrick@gmail.com","username":"patrick.east"},"date":"2017-06-30 17:49:25.000000000","message":"Uploaded patch set 2: Patch Set 1 was rebased.","accounts_in_message":[],"_revision_number":2},{"id":"a32e72f705237a61a22892446fc55525ed7deb96","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-06-30 18:06:18.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-brick-cinderclient-ext-docs-ubuntu-xenial http://docs-draft.openstack.org/73/479373/2/check/gate-python-brick-cinderclient-ext-docs-ubuntu-xenial/a48daa7//doc/build/html/ : SUCCESS in 1m 47s\n- gate-python-brick-cinderclient-ext-pep8-ubuntu-xenial http://logs.openstack.org/73/479373/2/check/gate-python-brick-cinderclient-ext-pep8-ubuntu-xenial/445aa74/ : SUCCESS in 1m 44s\n- gate-python-brick-cinderclient-ext-python27-ubuntu-xenial http://logs.openstack.org/73/479373/2/check/gate-python-brick-cinderclient-ext-python27-ubuntu-xenial/e2cb8f9/ : SUCCESS in 49s\n- gate-python-brick-cinderclient-ext-python35 http://logs.openstack.org/73/479373/2/check/gate-python-brick-cinderclient-ext-python35/11ebcae/ : SUCCESS in 1m 40s\n- gate-brick-cinderclient-ext-dsvm-functional-ubuntu-xenial http://logs.openstack.org/73/479373/2/check/gate-brick-cinderclient-ext-dsvm-functional-ubuntu-xenial/56a2095/ : SUCCESS in 15m 47s","accounts_in_message":[],"_revision_number":2},{"id":"b99f1e87114485fe4d99723c0c1bfe68dab23b16","author":{"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},"date":"2017-06-30 19:33:39.000000000","message":"Patch Set 2: Code-Review+2","accounts_in_message":[],"_revision_number":2},{"id":"602e72d3a92f0b18059836cc378676e1b25f4c84","author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"date":"2017-07-01 21:55:59.000000000","message":"Patch Set 2:\n\nDo we need to be doing some microversion checking here?","accounts_in_message":[],"_revision_number":2},{"id":"4323fc4037e48588bd273692ef4ed7c2843ac2d2","author":{"_account_id":12924,"name":"Patrick East","email":"east.patrick@gmail.com","username":"patrick.east"},"date":"2017-07-06 17:59:40.000000000","message":"Patch Set 2:\n\n@Sean, looks like that logic is already done when the client initializes. This method being changed is only called once it has decided to use the new api\u0027s","accounts_in_message":[],"_revision_number":2},{"id":"c01f9864ea5b05e28d4d87632462bbb1e11b61e4","author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"date":"2017-07-06 18:21:21.000000000","message":"Patch Set 2: Code-Review+2 Workflow+1\n\n(1 comment)","accounts_in_message":[],"_revision_number":2},{"id":"4185c28d2df9bdf09125a8956b66a16685502d66","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-07-06 18:21:38.000000000","message":"Patch Set 2: -Verified\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":2},{"id":"8e710e2fd11a70517098815ea5f15c6d66530d7c","date":"2017-07-06 18:37:26.000000000","message":"Change has been successfully merged into the git repository by Jenkins","accounts_in_message":[],"_revision_number":2},{"id":"f224e830de1c3fee6811a764cd851e7e222e52db","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2017-07-06 18:37:26.000000000","message":"Patch Set 2: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- gate-python-brick-cinderclient-ext-docs-ubuntu-xenial http://docs-draft.openstack.org/73/479373/2/gate/gate-python-brick-cinderclient-ext-docs-ubuntu-xenial/3e3decf//doc/build/html/ : SUCCESS in 1m 23s\n- gate-python-brick-cinderclient-ext-pep8-ubuntu-xenial http://logs.openstack.org/73/479373/2/gate/gate-python-brick-cinderclient-ext-pep8-ubuntu-xenial/4b79270/ : SUCCESS in 1m 32s\n- gate-python-brick-cinderclient-ext-python27-ubuntu-xenial http://logs.openstack.org/73/479373/2/gate/gate-python-brick-cinderclient-ext-python27-ubuntu-xenial/27c8056/ : SUCCESS in 1m 01s\n- gate-python-brick-cinderclient-ext-python35 http://logs.openstack.org/73/479373/2/gate/gate-python-brick-cinderclient-ext-python35/e4ec1e3/ : SUCCESS in 58s\n- gate-brick-cinderclient-ext-dsvm-functional-ubuntu-xenial http://logs.openstack.org/73/479373/2/gate/gate-brick-cinderclient-ext-dsvm-functional-ubuntu-xenial/d071910/ : SUCCESS in 15m 04s","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"41f1a65a421748c455bb8e49ceaf0d5abaa262b4","revisions":{"522dd2d4e812a5441a9fd728f06c1cbebc1a476b":{"kind":"REWORK","_number":1,"created":"2017-06-30 16:56:44.000000000","uploader":{"_account_id":12924,"name":"Patrick East","email":"east.patrick@gmail.com","username":"patrick.east"},"ref":"refs/changes/73/479373/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-brick-cinderclient-ext","ref":"refs/changes/73/479373/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-brick-cinderclient-ext refs/changes/73/479373/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-brick-cinderclient-ext refs/changes/73/479373/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-brick-cinderclient-ext refs/changes/73/479373/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-brick-cinderclient-ext refs/changes/73/479373/1"}}},"commit":{"parents":[{"commit":"f7cb24f4948e23ccf4a1ffcf83d26582315f65e4","subject":"Fix to allow multipathing with attach/detach","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-brick-cinderclient-ext/commit/f7cb24f4948e23ccf4a1ffcf83d26582315f65e4"}]}],"author":{"name":"Patrick East","email":"patrick.east@purestorage.com","date":"2017-06-30 16:55:23.000000000","tz":-420},"committer":{"name":"Patrick East","email":"patrick.east@purestorage.com","date":"2017-06-30 16:56:31.000000000","tz":-420},"subject":"Actually do the detach with the new attach/detach flow","message":"Actually do the detach with the new attach/detach flow\n\nThis adds in the missing step to pull the connector\nout of cinder from the attachment.id which we shove\nback into os-brick to detach the volume.\n\nChange-Id: If41dd2cc8324c372742d52d001bc98961936f1f0\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-brick-cinderclient-ext/commit/522dd2d4e812a5441a9fd728f06c1cbebc1a476b"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-brick-cinderclient-ext/commit/522dd2d4e812a5441a9fd728f06c1cbebc1a476b"}]},"branch":"refs/heads/master"},"41f1a65a421748c455bb8e49ceaf0d5abaa262b4":{"kind":"TRIVIAL_REBASE","_number":2,"created":"2017-06-30 17:49:25.000000000","uploader":{"_account_id":12924,"name":"Patrick East","email":"east.patrick@gmail.com","username":"patrick.east"},"ref":"refs/changes/73/479373/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-brick-cinderclient-ext","ref":"refs/changes/73/479373/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-brick-cinderclient-ext refs/changes/73/479373/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-brick-cinderclient-ext refs/changes/73/479373/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-brick-cinderclient-ext refs/changes/73/479373/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-brick-cinderclient-ext refs/changes/73/479373/2"}}},"commit":{"parents":[{"commit":"bb3593ed1259cd3678f4e1bf06decc92e2c0c9a3","subject":"Fix to allow multipathing with attach/detach","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-brick-cinderclient-ext/commit/bb3593ed1259cd3678f4e1bf06decc92e2c0c9a3"}]}],"author":{"name":"Patrick East","email":"patrick.east@purestorage.com","date":"2017-06-30 16:55:23.000000000","tz":-420},"committer":{"name":"Patrick East","email":"patrick.east@purestorage.com","date":"2017-06-30 17:49:11.000000000","tz":-420},"subject":"Actually do the detach with the new attach/detach flow","message":"Actually do the detach with the new attach/detach flow\n\nThis adds in the missing step to pull the connector\nout of cinder from the attachment.id which we shove\nback into os-brick to detach the volume.\n\nChange-Id: If41dd2cc8324c372742d52d001bc98961936f1f0\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-brick-cinderclient-ext/commit/41f1a65a421748c455bb8e49ceaf0d5abaa262b4"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-brick-cinderclient-ext/commit/41f1a65a421748c455bb8e49ceaf0d5abaa262b4"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}
