)]}'
{"id":"openstack%2Fpython-brick-cinderclient-ext~565683","triplet_id":"openstack%2Fpython-brick-cinderclient-ext~master~Ia3830b156400f6bf6d345e00215eb4667fe24474","project":"openstack/python-brick-cinderclient-ext","branch":"master","hashtags":[],"change_id":"Ia3830b156400f6bf6d345e00215eb4667fe24474","subject":"Set the `device` value in the attachment dict","status":"MERGED","created":"2018-05-02 09:26:21.000000000","updated":"2018-06-26 14:33:12.000000000","submitted":"2018-06-26 14:33:11.000000000","submitter":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"total_comment_count":1,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"565683-1530023592143-5c9d8c9f","meta_rev_id":"2603327c0eaaf058ccdb7378cfebe2ec18b28702","_number":565683,"virtual_id_number":565683,"owner":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},{"value":0,"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},{"value":2,"date":"2018-06-26 14:33:11.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},"all":[{"value":2,"date":"2018-06-26 12:56:16.000000000","_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},{"value":2,"date":"2018-06-18 14:52:17.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},"all":[{"value":1,"date":"2018-06-26 12:56:16.000000000","_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},{"value":0,"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},{"value":0,"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},{"value":0,"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Branch Freeze"," 0":"No Priority","+1":"Important Change","+2":"Gate Blocker Fix / Urgent Change"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},{"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2018-06-18 14:52:17.000000000","updated_by":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"reviewer":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"state":"REVIEWER"},{"updated":"2018-06-26 12:56:16.000000000","updated_by":{"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},"reviewer":{"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},"state":"REVIEWER"},{"updated":"2018-06-26 14:33:11.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"d17b7e4f892baf491af25aa4f15bf9e6ae03cfbf","author":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"date":"2018-05-02 09:26:21.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"206619f34ab7afc4af1227c30a230ad4b185c1dd","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2018-05-02 09:43:24.000000000","message":"Patch Set 1: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see\nhttp://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n\n- openstack-tox-pep8 http://logs.openstack.org/83/565683/1/check/openstack-tox-pep8/0488a7b/ : FAILURE in 3m 30s\n- openstack-tox-py27 http://logs.openstack.org/83/565683/1/check/openstack-tox-py27/a6b572e/ : SUCCESS in 2m 46s\n- openstack-tox-py35 http://logs.openstack.org/83/565683/1/check/openstack-tox-py35/af4b0d4/ : SUCCESS in 3m 13s\n- build-openstack-sphinx-docs http://logs.openstack.org/83/565683/1/check/build-openstack-sphinx-docs/e886454/html/ : SUCCESS in 3m 18s\n- brick-cinderclient-dsvm-functional http://logs.openstack.org/83/565683/1/check/brick-cinderclient-dsvm-functional/77b50ce/ : SUCCESS in 14m 21s\n- openstack-tox-lower-constraints http://logs.openstack.org/83/565683/1/check/openstack-tox-lower-constraints/af9a52d/ : SUCCESS in 2m 50s","accounts_in_message":[],"_revision_number":1},{"id":"474f1b02d2a51c934fb3713586e2e1204d8979fb","author":{"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},"date":"2018-05-02 13:39:55.000000000","message":"Patch Set 1:\n\n(1 comment)\n\nsome notes/thoughts inline; I think this fixes the problem and is a logical behavior.  Other than the pep8 you\u0027d get my vote.","accounts_in_message":[],"_revision_number":1},{"id":"21557c058a37e84124e607f3df9a364f41a1ff7b","author":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"date":"2018-05-03 04:49:41.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"85bcee9875583a545d97e53f47e7a56545b92949","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2018-05-03 05:05:18.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-pep8 http://logs.openstack.org/83/565683/2/check/openstack-tox-pep8/04e34d9/ : SUCCESS in 2m 14s\n- openstack-tox-py27 http://logs.openstack.org/83/565683/2/check/openstack-tox-py27/b454e78/ : SUCCESS in 2m 07s\n- openstack-tox-py35 http://logs.openstack.org/83/565683/2/check/openstack-tox-py35/1690b17/ : SUCCESS in 2m 15s\n- build-openstack-sphinx-docs http://logs.openstack.org/83/565683/2/check/build-openstack-sphinx-docs/eda896c/html/ : SUCCESS in 2m 34s\n- brick-cinderclient-dsvm-functional http://logs.openstack.org/83/565683/2/check/brick-cinderclient-dsvm-functional/713df03/ : SUCCESS in 14m 28s\n- openstack-tox-lower-constraints http://logs.openstack.org/83/565683/2/check/openstack-tox-lower-constraints/4917803/ : SUCCESS in 2m 12s","accounts_in_message":[],"_revision_number":2},{"id":"b3acb1fe1362338ced6f94284ade6a12d06cad5a","author":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"date":"2018-06-18 14:52:17.000000000","message":"Patch Set 2: Code-Review+2","accounts_in_message":[],"_revision_number":2},{"id":"8c7f75427167430b32267a0732dd5e21ef80d2b5","author":{"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},"date":"2018-06-26 12:56:16.000000000","message":"Patch Set 2: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":2},{"id":"4dbeb5c1b5f40ab3baffff7c15640207badb80b7","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2018-06-26 12:56:28.000000000","message":"Patch Set 2: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":2},{"id":"1b3d79742e0df754e7d2f290def872272b4f19e4","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2018-06-26 13:22:01.000000000","message":"Patch Set 2: Verified-2\n\nBuild failed (gate pipeline).  For information on how to proceed, see\nhttp://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n\n- openstack-tox-pep8 http://logs.openstack.org/83/565683/2/gate/openstack-tox-pep8/7a9e3eb/ : SUCCESS in 5m 22s\n- openstack-tox-py27 http://logs.openstack.org/83/565683/2/gate/openstack-tox-py27/48a830e/ : SUCCESS in 3m 59s\n- openstack-tox-py35 http://logs.openstack.org/83/565683/2/gate/openstack-tox-py35/f2beb0d/ : SUCCESS in 4m 41s\n- build-openstack-sphinx-docs http://logs.openstack.org/83/565683/2/gate/build-openstack-sphinx-docs/d9f21af/html/ : SUCCESS in 4m 24s\n- brick-cinderclient-dsvm-functional http://logs.openstack.org/83/565683/2/gate/brick-cinderclient-dsvm-functional/644f57e/ : POST_FAILURE in 23m 06s\n- openstack-tox-lower-constraints http://logs.openstack.org/83/565683/2/gate/openstack-tox-lower-constraints/11f40b3/ : SUCCESS in 4m 18s","accounts_in_message":[],"_revision_number":2},{"id":"d1a36b3b16ad04a74fb86bc73409e5543884cdc9","author":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"date":"2018-06-26 13:23:16.000000000","message":"Patch Set 2:\n\nrecheck","accounts_in_message":[],"_revision_number":2},{"id":"569f8bb666b83f0498899a7037aee12e339a5add","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2018-06-26 14:07:03.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- openstack-tox-pep8 http://logs.openstack.org/83/565683/2/check/openstack-tox-pep8/577ca8c/ : SUCCESS in 4m 37s\n- openstack-tox-py27 http://logs.openstack.org/83/565683/2/check/openstack-tox-py27/e7c42d8/ : SUCCESS in 3m 57s\n- openstack-tox-py35 http://logs.openstack.org/83/565683/2/check/openstack-tox-py35/ba8a52d/ : SUCCESS in 4m 51s\n- build-openstack-sphinx-docs http://logs.openstack.org/83/565683/2/check/build-openstack-sphinx-docs/2dff4bf/html/ : SUCCESS in 3m 31s\n- brick-cinderclient-dsvm-functional http://logs.openstack.org/83/565683/2/check/brick-cinderclient-dsvm-functional/30e5c78/ : SUCCESS in 19m 21s\n- openstack-tox-lower-constraints http://logs.openstack.org/83/565683/2/check/openstack-tox-lower-constraints/109978e/ : SUCCESS in 4m 58s","accounts_in_message":[],"_revision_number":2},{"id":"814873c0ac5631999923819522213c5c61021d55","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2018-06-26 14:07:15.000000000","message":"Patch Set 2: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":2},{"id":"ed2bcd345495ef6cfc2dafe9a971d88ec7194e79","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2018-06-26 14:33:11.000000000","message":"Patch Set 2: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- openstack-tox-pep8 http://logs.openstack.org/83/565683/2/gate/openstack-tox-pep8/2375fc9/ : SUCCESS in 4m 32s\n- openstack-tox-py27 http://logs.openstack.org/83/565683/2/gate/openstack-tox-py27/d582c89/ : SUCCESS in 4m 37s\n- openstack-tox-py35 http://logs.openstack.org/83/565683/2/gate/openstack-tox-py35/801b0db/ : SUCCESS in 4m 34s\n- build-openstack-sphinx-docs http://logs.openstack.org/83/565683/2/gate/build-openstack-sphinx-docs/61b03a2/html/ : SUCCESS in 4m 02s\n- brick-cinderclient-dsvm-functional http://logs.openstack.org/83/565683/2/gate/brick-cinderclient-dsvm-functional/9f1a8ae/ : SUCCESS in 19m 37s\n- openstack-tox-lower-constraints http://logs.openstack.org/83/565683/2/gate/openstack-tox-lower-constraints/a959935/ : SUCCESS in 5m 06s","accounts_in_message":[],"_revision_number":2},{"id":"2603327c0eaaf058ccdb7378cfebe2ec18b28702","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2018-06-26 14:33:12.000000000","message":"Change has been successfully merged by Zuul","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"297374e41b2f717765f36070eb3e0fb56c977111","revisions":{"2146a5e9f59a40fd178b65dc62b02fd4d5b6c800":{"kind":"REWORK","_number":1,"created":"2018-05-02 09:26:21.000000000","uploader":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"ref":"refs/changes/83/565683/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-brick-cinderclient-ext","ref":"refs/changes/83/565683/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-brick-cinderclient-ext refs/changes/83/565683/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-brick-cinderclient-ext refs/changes/83/565683/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-brick-cinderclient-ext refs/changes/83/565683/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-brick-cinderclient-ext refs/changes/83/565683/1"}}},"commit":{"parents":[{"commit":"b23f62201f8a194b4a6c4c8cbbda8272b8e6529a","subject":"Merge \"Update links in README\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-brick-cinderclient-ext/commit/b23f62201f8a194b4a6c4c8cbbda8272b8e6529a"}]}],"author":{"name":"Flavio Percoco","email":"flaper87@gmail.com","date":"2018-05-02 09:23:03.000000000","tz":120},"committer":{"name":"Flavio Percoco","email":"flaper87@gmail.com","date":"2018-05-02 09:26:17.000000000","tz":120},"subject":"Set the `device` value in the attachment dict","message":"Set the `device` value in the attachment dict\n\nWe\u0027re currently not setting the device path in the attachment metadata\nwhen using the legacy_attach workflow. Since we have this info, we might\nas well set it.\n\nUnsure whether this is correctly done for the new attach workflow,\nthough.\n\nChange-Id: Ia3830b156400f6bf6d345e00215eb4667fe24474\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-brick-cinderclient-ext/commit/2146a5e9f59a40fd178b65dc62b02fd4d5b6c800"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-brick-cinderclient-ext/commit/2146a5e9f59a40fd178b65dc62b02fd4d5b6c800"}]},"branch":"refs/heads/master"},"297374e41b2f717765f36070eb3e0fb56c977111":{"kind":"REWORK","_number":2,"created":"2018-05-03 04:49:41.000000000","uploader":{"_account_id":6159,"name":"Flavio Percoco Premoli","display_name":"flaper87","email":"flavio.percoco@flyrlabs.com","username":"flaper87"},"ref":"refs/changes/83/565683/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-brick-cinderclient-ext","ref":"refs/changes/83/565683/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-brick-cinderclient-ext refs/changes/83/565683/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-brick-cinderclient-ext refs/changes/83/565683/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-brick-cinderclient-ext refs/changes/83/565683/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-brick-cinderclient-ext refs/changes/83/565683/2"}}},"commit":{"parents":[{"commit":"b23f62201f8a194b4a6c4c8cbbda8272b8e6529a","subject":"Merge \"Update links in README\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-brick-cinderclient-ext/commit/b23f62201f8a194b4a6c4c8cbbda8272b8e6529a"}]}],"author":{"name":"Flavio Percoco","email":"flaper87@gmail.com","date":"2018-05-02 09:23:03.000000000","tz":120},"committer":{"name":"Flavio Percoco","email":"flaper87@gmail.com","date":"2018-05-03 04:49:30.000000000","tz":120},"subject":"Set the `device` value in the attachment dict","message":"Set the `device` value in the attachment dict\n\nWe\u0027re currently not setting the device path in the attachment metadata\nwhen using the legacy_attach workflow. Since we have this info, we might\nas well set it.\n\nUnsure whether this is correctly done for the new attach workflow,\nthough.\n\nChange-Id: Ia3830b156400f6bf6d345e00215eb4667fe24474\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-brick-cinderclient-ext/commit/297374e41b2f717765f36070eb3e0fb56c977111"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-brick-cinderclient-ext/commit/297374e41b2f717765f36070eb3e0fb56c977111"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}