)]}'
{"id":"openstack%2Fpython-brick-cinderclient-ext~734502","triplet_id":"openstack%2Fpython-brick-cinderclient-ext~master~Icce173050f5b94a33fbf1d4381ec0d72b56f25ab","project":"openstack/python-brick-cinderclient-ext","branch":"master","topic":"drop_mock","hashtags":[],"change_id":"Icce173050f5b94a33fbf1d4381ec0d72b56f25ab","subject":"drop mock from lower-constraints","status":"ABANDONED","created":"2020-06-09 09:53:11.000000000","updated":"2020-06-22 14:14:29.000000000","total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"a5d22c40537027f43e147f3b5d7d24ef9f8feef8","_number":734502,"virtual_id_number":734502,"owner":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"actions":{},"labels":{"Verified":{"recommended":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"all":[{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},{"date":"2020-06-22 14:13:59.000000000","_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},{"tag":"autogenerated:zuul:check","value":1,"date":"2020-06-18 13:05:28.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":1,"default_value":0,"optional":true},"Code-Review":{"disliked":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"all":[{"value":-1,"date":"2020-06-18 12:45:22.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},{"value":0,"permitted_voting_range":{"min":-2,"max":2},"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},{"value":0,"permitted_voting_range":{"min":-2,"max":2},"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":-1,"default_value":0,"optional":true},"Workflow":{"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},{"value":0,"permitted_voting_range":{"min":-1,"max":0},"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":2},"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},{"value":0,"permitted_voting_range":{"min":-1,"max":2},"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},{"value":0,"permitted_voting_range":{"min":-1,"max":2},"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]}],"values":{"-1":"Branch Freeze"," 0":"No Priority","+1":"Important Change","+2":"Gate Blocker Fix / Urgent Change"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2020-06-09 12:30:15.000000000","updated_by":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"reviewer":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"state":"REVIEWER"},{"updated":"2020-06-17 21:26:15.000000000","updated_by":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"reviewer":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"state":"REVIEWER"},{"updated":"2020-06-18 12:45:22.000000000","updated_by":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"reviewer":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"state":"REVIEWER"},{"updated":"2020-06-18 13:05:28.000000000","updated_by":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"reviewer":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"state":"REVIEWER"}],"messages":[{"id":"1d787b9416df1718c941571fcf5dc671bba409b6","author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"date":"2020-06-09 09:53:11.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"accd7e15a0e318f2a14477a1f708a0d923cd696e","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-06-09 10:29:16.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- requirements-check https://zuul.opendev.org/t/openstack/build/31f53ea1496247b6903c6997f599f92d : SUCCESS in 2m 54s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/a1d14bb047dc430a8e8920b30ec25e98 : SUCCESS in 4m 16s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/d3d66167024540ba92772927606b06a4 : SUCCESS in 5m 53s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/8f742829b953452db5e11fbb50f8abb3 : SUCCESS in 7m 49s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/82645be098f843f58cda9b1df748d4f5 : SUCCESS in 4m 20s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/52e6be40f55545ec804122b165bff7fe : SUCCESS in 6m 01s\n- brick-cinderclient-dsvm-functional-py36 https://zuul.opendev.org/t/openstack/build/e02d4988d91144a8b35bab46bab23572 : SUCCESS in 28m 09s\n- brick-cinderclient-dsvm-functional-py37 https://zuul.opendev.org/t/openstack/build/a8f72d129ad6434583e60fbe751f52de : SUCCESS in 27m 00s","accounts_in_message":[],"_revision_number":1},{"id":"21b64404538c4b02de6a2a5882bdd65dca299b07","author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"date":"2020-06-09 12:30:15.000000000","message":"Patch Set 1: Code-Review+2\n\n@Hervé: This question isn\u0027t directly related to this patch.  Will removing mock from requirements also remove mock from upper-constraints as well?  Even though we\u0027re not using it here, something is pulling it in:\n\n[master] wha\u0027ppen? .tox/py36/bin/pip freeze | grep mock\nmock\u003d\u003d3.0.5\n[master] wha\u0027ppen? .tox/py37/bin/pip freeze | grep mock\nmock\u003d\u003d3.0.5\n[master] wha\u0027ppen? .tox/py38/bin/pip freeze | grep mock\nmock\u003d\u003d3.0.5\n\nI imagine that we don\u0027t want the version to be unconstrained?","accounts_in_message":[],"_revision_number":1},{"id":"f79d7dd0dae24e531e031c0f84cf8bf2d7ea424a","author":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"date":"2020-06-17 21:26:15.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":1},{"id":"dbb10d67c0a00c7604b79ddf96356b73702d26d4","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-06-17 21:26:28.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":1},{"id":"22d359c6a8aeaa56bc86f948cdac91af0b931d99","tag":"autogenerated:zuul:gate","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-06-17 21:55:03.000000000","message":"Patch Set 1: Verified-2\n\nBuild failed (gate pipeline).  For information on how to proceed, see\nhttps://docs.opendev.org/opendev/infra-manual/latest/developers.html#automated-testing\n\n\n- requirements-check https://zuul.opendev.org/t/openstack/build/4ebfb673eda847e88d2d404c1d58ed2a : FAILURE in 4m 03s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/606122b7f3544a51b272d9ea28374260 : SUCCESS in 6m 40s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/bde9cd4ad52b4cdc831edc0420416157 : SUCCESS in 8m 14s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/2d09a8e5f5a042b08a311da06900975a : SUCCESS in 7m 52s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/9e3a1cf2b86f4fc5a465b49d8129306d : SUCCESS in 9m 32s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/f2870cf9a382421d981d44647cca2abc : SUCCESS in 8m 25s\n- brick-cinderclient-dsvm-functional-py36 https://zuul.opendev.org/t/openstack/build/4dfd6e6b53d648b8abcbaf83300e59e9 : SUCCESS in 22m 34s\n- brick-cinderclient-dsvm-functional-py37 https://zuul.opendev.org/t/openstack/build/f9dc707f81104abe9e12f14ea76255b0 : SUCCESS in 24m 44s","accounts_in_message":[],"_revision_number":1},{"id":"4cddb0d29d85088ade1372784886d12f69a69b27","author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"date":"2020-06-18 12:41:27.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"e2bddf15b50dd686d981cb25f08052184b969d01","author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"date":"2020-06-18 12:44:04.000000000","message":"Patch Set 2:\n\nLast PS is a rebase on the top of 301002ab7e5fbe48496e2057b3b68c9a9145e78f (https://review.opendev.org/#/c/734471/)","accounts_in_message":[],"_revision_number":2},{"id":"16a6ebca24511fdc804d4bca6402e871e3e7eba4","author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"date":"2020-06-18 12:45:22.000000000","message":"Patch Set 2: Code-Review-1\n\nI\u0027ve mentioned this elsewhere before, but these patches are not needed and are not correct.\n\nLower-constraints is the generated set of all constraints from a pip freeze output when installing dependencies. So it\u0027s the project\u0027s dependencies, and all the dependencies that those pull in.\n\nmock is still used by other packages. We should not be removing it individually from lower-constraints. If it ends up no longer being used, it will be dropped by a future refresh of the constraints.","accounts_in_message":[],"_revision_number":2},{"id":"5e8958a5691da384e79cc63ff35079afd1f01ddf","tag":"autogenerated:zuul:check","author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"date":"2020-06-18 13:05:28.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- requirements-check https://zuul.opendev.org/t/openstack/build/164c5ae141b54af7b9293d9704867ded : SUCCESS in 3m 42s\n- openstack-tox-lower-constraints https://zuul.opendev.org/t/openstack/build/b3993ab743554938bb09689eb6ba36d5 : SUCCESS in 4m 31s\n- openstack-tox-pep8 https://zuul.opendev.org/t/openstack/build/ddfeea9640b34be19371ad0a952760f9 : SUCCESS in 4m 05s\n- openstack-tox-py36 https://zuul.opendev.org/t/openstack/build/ed28fdbe934f42d5aca0bbea617be5ca : SUCCESS in 4m 40s\n- openstack-tox-py38 https://zuul.opendev.org/t/openstack/build/810cf371a10d4173a45f4712e74f1d53 : SUCCESS in 5m 50s\n- openstack-tox-docs https://zuul.opendev.org/t/openstack/build/c000ea26907742f48ba5fc2fdca55772 : SUCCESS in 4m 11s\n- brick-cinderclient-dsvm-functional-py36 https://zuul.opendev.org/t/openstack/build/8996fe5aae8b45b8b0d9f0cab8f27b92 : SUCCESS in 20m 17s\n- brick-cinderclient-dsvm-functional-py37 https://zuul.opendev.org/t/openstack/build/fbecf238412344a3a5716568194c6cf0 : SUCCESS in 20m 46s","accounts_in_message":[],"_revision_number":2},{"id":"3962a4b7524e661ab3d377a5092a4a484afe68d5","author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"date":"2020-06-22 14:13:59.000000000","message":"Patch Set 2:\n\n\u003e I\u0027ve mentioned this elsewhere before, but these patches are not\n \u003e needed and are not correct.\n \u003e \n \u003e Lower-constraints is the generated set of all constraints from a\n \u003e pip freeze output when installing dependencies. So it\u0027s the\n \u003e project\u0027s dependencies, and all the dependencies that those pull\n \u003e in.\n \u003e \n \u003e mock is still used by other packages. We should not be removing it\n \u003e individually from lower-constraints. If it ends up no longer being\n \u003e used, it will be dropped by a future refresh of the constraints.\n\nAh right, thanks for the heads-up","accounts_in_message":[],"_revision_number":2},{"id":"ca85612bc61a8f5e6bd89f7f0c4eacf80a6a8571","author":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"date":"2020-06-22 14:14:29.000000000","message":"Abandoned","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"39457d2e0f1bef725b347093606cd2a95fe3766f","revisions":{"8d2b52c33fca7bef61ac2aa9c1934ec262e63e1c":{"kind":"REWORK","_number":1,"created":"2020-06-09 09:53:11.000000000","uploader":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"ref":"refs/changes/02/734502/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-brick-cinderclient-ext","ref":"refs/changes/02/734502/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-brick-cinderclient-ext refs/changes/02/734502/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-brick-cinderclient-ext refs/changes/02/734502/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-brick-cinderclient-ext refs/changes/02/734502/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-brick-cinderclient-ext refs/changes/02/734502/1"}}},"commit":{"parents":[{"commit":"8be9717296baa99689917110d5f1403d25ff0afc","subject":"Switch to newer openstackdocstheme and reno versions","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-brick-cinderclient-ext/commit/8be9717296baa99689917110d5f1403d25ff0afc"}]}],"author":{"name":"Hervé Beraud","email":"hberaud@redhat.com","date":"2020-06-09 09:53:06.000000000","tz":120},"committer":{"name":"Hervé Beraud","email":"hberaud@redhat.com","date":"2020-06-09 09:53:06.000000000","tz":120},"subject":"drop mock from lower-constraints","message":"drop mock from lower-constraints\n\nThe mock third party library was needed for mock support in py2\nruntimes. Since we now only support py36 and later, we don\u0027t need it\nin lower-constraints.\n\nThese changes will help us to drop `mock` from openstack/requirements\n\nChange-Id: Icce173050f5b94a33fbf1d4381ec0d72b56f25ab\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-brick-cinderclient-ext/commit/8d2b52c33fca7bef61ac2aa9c1934ec262e63e1c"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-brick-cinderclient-ext/commit/8d2b52c33fca7bef61ac2aa9c1934ec262e63e1c"}]},"branch":"refs/heads/master"},"39457d2e0f1bef725b347093606cd2a95fe3766f":{"kind":"REWORK","_number":2,"created":"2020-06-18 12:41:27.000000000","uploader":{"_account_id":28522,"name":"Hervé Beraud","email":"herveberaud.pro@gmail.com","username":"hberaud"},"ref":"refs/changes/02/734502/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-brick-cinderclient-ext","ref":"refs/changes/02/734502/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-brick-cinderclient-ext refs/changes/02/734502/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-brick-cinderclient-ext refs/changes/02/734502/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-brick-cinderclient-ext refs/changes/02/734502/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-brick-cinderclient-ext refs/changes/02/734502/2"}}},"commit":{"parents":[{"commit":"3ae9a5dc1015419265fec8db45cf77cf35413513","subject":"Merge \"Stop to use the __future__ module.\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-brick-cinderclient-ext/commit/3ae9a5dc1015419265fec8db45cf77cf35413513"}]}],"author":{"name":"Hervé Beraud","email":"hberaud@redhat.com","date":"2020-06-09 09:53:06.000000000","tz":120},"committer":{"name":"Hervé Beraud","email":"hberaud@redhat.com","date":"2020-06-18 12:41:14.000000000","tz":120},"subject":"drop mock from lower-constraints","message":"drop mock from lower-constraints\n\nThe mock third party library was needed for mock support in py2\nruntimes. Since we now only support py36 and later, we don\u0027t need it\nin lower-constraints.\n\nThese changes will help us to drop `mock` from openstack/requirements\n\nChange-Id: Icce173050f5b94a33fbf1d4381ec0d72b56f25ab\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-brick-cinderclient-ext/commit/39457d2e0f1bef725b347093606cd2a95fe3766f"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-brick-cinderclient-ext/commit/39457d2e0f1bef725b347093606cd2a95fe3766f"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}