)]}'
{"id":"openstack%2Fpython-ceilometerclient~110343","triplet_id":"openstack%2Fpython-ceilometerclient~master~I5d9579b1077dfda8faad4658d62048704a30277b","project":"openstack/python-ceilometerclient","branch":"master","topic":"1348387.2","hashtags":[],"change_id":"I5d9579b1077dfda8faad4658d62048704a30277b","subject":"Verify alarm found before modifying","status":"ABANDONED","created":"2014-07-29 15:50:16.000000000","updated":"2014-07-29 16:04:32.000000000","total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"f3e4797188965844aac97a50b47e2c01815dff1e","_number":110343,"virtual_id_number":110343,"owner":{"_account_id":7409,"name":"Eric Pendergrass","email":"epende@gmail.com","username":"epende"},"actions":{},"labels":{"Verified":{"all":[{"_account_id":7409,"name":"Eric Pendergrass","email":"epende@gmail.com","username":"epende"},{"date":"2014-07-29 16:04:18.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":7409,"name":"Eric Pendergrass","email":"epende@gmail.com","username":"epende"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":3,"name":"Jenkins","username":"jenkins"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"all":[{"value":0,"date":"2014-07-29 16:04:23.000000000","permitted_voting_range":{"min":-1,"max":0},"_account_id":7409,"name":"Eric Pendergrass","email":"epende@gmail.com","username":"epende"},{"_account_id":3,"name":"Jenkins","username":"jenkins"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":7409,"name":"Eric Pendergrass","email":"epende@gmail.com","username":"epende"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2014-07-29 16:04:18.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"b343805fd905c3905381c44e104548733929b06a","author":{"_account_id":7409,"name":"Eric Pendergrass","email":"epende@gmail.com","username":"epende"},"date":"2014-07-29 15:50:16.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"2b49ab8cb7d59a021d2476950fb7eb6067331a56","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-07-29 15:50:17.000000000","message":"Patch Set 1:\n\nStarting check jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":1},{"id":"87de0fd4c3da6756c334ed51dc943aa270ee2de3","author":{"_account_id":7409,"name":"Eric Pendergrass","email":"epende@gmail.com","username":"epende"},"date":"2014-07-29 15:52:08.000000000","message":"Patch Set 1: Workflow-1","accounts_in_message":[],"_revision_number":1},{"id":"2b256eb35873ab3ea67178a83575e6720a215f7a","author":{"_account_id":7409,"name":"Eric Pendergrass","email":"epende@gmail.com","username":"epende"},"date":"2014-07-29 15:57:49.000000000","message":"Abandoned\n\nUnfixable commit msg","accounts_in_message":[],"_revision_number":1},{"id":"2532aabbceed7e76e0b281d094bea326d24b0260","author":{"_account_id":7409,"name":"Eric Pendergrass","email":"epende@gmail.com","username":"epende"},"date":"2014-07-29 16:04:16.000000000","message":"Restored\n\nrestoring to remove -1","accounts_in_message":[],"_revision_number":1},{"id":"723bf77bed486d0af536c36528f94595ac1ffbe0","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-07-29 16:04:18.000000000","message":"Patch Set 1:\n\nStarting check jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":1},{"id":"944ac75fa481706eaf6e83182ad6c9415fe1c599","author":{"_account_id":7409,"name":"Eric Pendergrass","email":"epende@gmail.com","username":"epende"},"date":"2014-07-29 16:04:23.000000000","message":"Patch Set 1: -Workflow","accounts_in_message":[],"_revision_number":1},{"id":"55845d7d698047bd2aeea8554c42adeea0a6fc38","author":{"_account_id":7409,"name":"Eric Pendergrass","email":"epende@gmail.com","username":"epende"},"date":"2014-07-29 16:04:32.000000000","message":"Abandoned\n\nremoved -1","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"1243ece5385d524bd57ebe79e74a16abfa55fa3e","revisions":{"1243ece5385d524bd57ebe79e74a16abfa55fa3e":{"kind":"REWORK","_number":1,"created":"2014-07-29 15:50:16.000000000","uploader":{"_account_id":7409,"name":"Eric Pendergrass","email":"epende@gmail.com","username":"epende"},"ref":"refs/changes/43/110343/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-ceilometerclient","ref":"refs/changes/43/110343/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-ceilometerclient refs/changes/43/110343/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-ceilometerclient refs/changes/43/110343/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-ceilometerclient refs/changes/43/110343/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-ceilometerclient refs/changes/43/110343/1"}}},"commit":{"parents":[{"commit":"092eb6643161747186ba4d0947a847af45e3d546","subject":"Update developer docs template","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-ceilometerclient/commit/092eb6643161747186ba4d0947a847af45e3d546"}]}],"author":{"name":"Eric Pendergrass","email":"eap@hp.com","date":"2014-07-29 15:46:56.000000000","tz":-420},"committer":{"name":"Eric Pendergrass","email":"eap@hp.com","date":"2014-07-29 15:48:31.000000000","tz":-420},"subject":"Verify alarm found before modifying","message":"Verify alarm found before modifying\n\n    Current behavior is to retrieve alarm\n    by id and conduct operations on the\n    object.  If the tenant doesn\u0027t own\n    the alarm or isn\u0027t admin, the user\n    will receive the message:\n    \u0027NoneType\u0027 object has no attribute \u0027to_dict\u0027\n\n    Above message doesn\u0027t provide any useful\n    diagnostic information and indicates\n    a programming error since an unexpected\n    None-type is encountered and not handled.\n\n    This change verifies the alarm is found\n    before using the object.  If alarm not\n    found it prints the same message for\n    a not found Alarm as other PUT operations\n    like alarm-state-set:  Alarm not found:\n    \u003calarm_id\u003e.\n\n    This message is more useful for diagnosis\n    and gets rid of the uncaught None-type\n    error.\n\nChange-Id: I5d9579b1077dfda8faad4658d62048704a30277b\nCloses-Bug: #1348387\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-ceilometerclient/commit/1243ece5385d524bd57ebe79e74a16abfa55fa3e"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-ceilometerclient/commit/1243ece5385d524bd57ebe79e74a16abfa55fa3e"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}