)]}'
{"ceilometerclient/tests/v2/test_alarms.py":[{"author":{"_account_id":10987,"name":"Igor Degtiarov","username":"tovstun","inactive":true},"change_message_id":"d89ee74a92e538c8c2b66056c03cac05b7e3b8a5","unresolved":false,"context_lines":[{"line_number":383,"context_line":"    def test_update_missing(self):"},{"line_number":384,"context_line":"        alarm \u003d None"},{"line_number":385,"context_line":"        try:"},{"line_number":386,"context_line":"            alarm \u003d self.mgr.update(alarm_id\u003d\u0027missing-alarm-id\u0027, **UPDATE_ALARM)"},{"line_number":387,"context_line":"        except exc.CommandError:"},{"line_number":388,"context_line":"            pass"},{"line_number":389,"context_line":"        self.assertEqual(alarm, None)"}],"source_content_type":"text/x-python","patch_set":4,"id":"1abeadc6_098c39d9","line":386,"updated":"2014-08-22 21:03:22.000000000","message":"this line is longer then 80 characters","commit_id":"3ce1581ad7704569499691b4d776da64868c442c"},{"author":{"_account_id":10987,"name":"Igor Degtiarov","username":"tovstun","inactive":true},"change_message_id":"d3b6a8f456dcab74a9ddbe29d7f0e002e88f09ca","unresolved":false,"context_lines":[{"line_number":23,"context_line":""},{"line_number":24,"context_line":"from ceilometerclient.openstack.common.apiclient import client"},{"line_number":25,"context_line":"from ceilometerclient.openstack.common.apiclient import fake_client"},{"line_number":26,"context_line":"from ceilometerclient import exc"},{"line_number":27,"context_line":"from ceilometerclient.v2 import alarms"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"AN_ALARM \u003d {u\u0027alarm_actions\u0027: [u\u0027http://site:8000/alarm\u0027],"}],"source_content_type":"text/x-python","patch_set":7,"id":"1abeadc6_7d251909","line":26,"updated":"2014-08-26 06:22:10.000000000","message":"Please improve order of import.","commit_id":"82a5163ee0962b18dff7782c53d93167f690231d"}],"ceilometerclient/v2/alarms.py":[{"author":{"_account_id":10987,"name":"Igor Degtiarov","username":"tovstun","inactive":true},"change_message_id":"d89ee74a92e538c8c2b66056c03cac05b7e3b8a5","unresolved":false,"context_lines":[{"line_number":82,"context_line":"    def get(self, alarm_id):"},{"line_number":83,"context_line":"        try:"},{"line_number":84,"context_line":"            return self._list(self._path(alarm_id), expect_single\u003dTrue)[0]"},{"line_number":85,"context_line":"        except (IndexError, KeyError) as e:"},{"line_number":86,"context_line":"            return None"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"        except exc.HTTPNotFound:"}],"source_content_type":"text/x-python","patch_set":4,"id":"1abeadc6_69a4cd4a","line":85,"updated":"2014-08-22 21:03:22.000000000","message":"why you specify error as e, if it is not used?","commit_id":"3ce1581ad7704569499691b4d776da64868c442c"},{"author":{"_account_id":4491,"name":"Lianhao Lu","email":"llh_misc@outlook.com","username":"lianhao-lu"},"change_message_id":"c7a8ba05560ca55a81ed49649f18346ea8be3282","unresolved":false,"context_lines":[{"line_number":84,"context_line":"            return self._list(self._path(alarm_id), expect_single\u003dTrue)[0]"},{"line_number":85,"context_line":"        except IndexError:"},{"line_number":86,"context_line":"            return None"},{"line_number":87,"context_line":"        except KeyError:"},{"line_number":88,"context_line":"            return None"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"        except exc.HTTPNotFound:"}],"source_content_type":"text/x-python","patch_set":14,"id":"1abeadc6_494043a5","line":87,"updated":"2014-08-28 06:09:14.000000000","message":"how could KeyError be thrown out here? If there is no alarm returned in self._list(), the return value for that should be [] which would trigger IndexError instead of KeyError","commit_id":"ef4ba4366c28066983bd8e144a6cfab81c645781"},{"author":{"_account_id":4491,"name":"Lianhao Lu","email":"llh_misc@outlook.com","username":"lianhao-lu"},"change_message_id":"55e89a8c9f143e5aed1fac4fd3143518a91868be","unresolved":false,"context_lines":[{"line_number":81,"context_line":""},{"line_number":82,"context_line":"    def get(self, alarm_id):"},{"line_number":83,"context_line":"        try:"},{"line_number":84,"context_line":"            if not self._path(alarm_id):"},{"line_number":85,"context_line":"                raise KeyError"},{"line_number":86,"context_line":"            return self._list(self._path(alarm_id), expect_single\u003dTrue)[0]"},{"line_number":87,"context_line":"        except IndexError:"}],"source_content_type":"text/x-python","patch_set":15,"id":"1abeadc6_7bfbf37a","line":84,"updated":"2014-08-28 13:59:20.000000000","message":"sorry, but I don\u0027t think this statement would ever be true.","commit_id":"4e36688de2dd9835086c52a3a21153aaebdfc5f8"}]}