)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":3012,"name":"Dina Belova","email":"dbelova@mirantis.com","username":"dbelova"},"change_message_id":"0fa2f9c53a1a148811e1944fccb79d23222f7f2d","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"keystone discovery fallback support"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"blah"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Change-Id: Ib253c736e37f8dbc50881f9fc691bfdb4ab87d71"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"fa98f980_f3c86a77","line":9,"updated":"2014-09-09 10:36:00.000000000","message":"hehe, will be the message more informative? :)","commit_id":"ec1f74106a0d6663019c1c5cde94a5ca594bb041"}],"ceilometerclient/client.py":[{"author":{"_account_id":3012,"name":"Dina Belova","email":"dbelova@mirantis.com","username":"dbelova"},"change_message_id":"0fa2f9c53a1a148811e1944fccb79d23222f7f2d","unresolved":false,"context_lines":[{"line_number":87,"context_line":"    project_domain_name \u003d kwargs.pop(\u0027project_domain_name\u0027, None)"},{"line_number":88,"context_line":"    project_domain_id \u003d kwargs.pop(\u0027project_domain_id\u0027, None)"},{"line_number":89,"context_line":"    auth \u003d None"},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"    use_domain \u003d (user_domain_id or user_domain_name or"},{"line_number":92,"context_line":"                  project_domain_id or project_domain_name)"},{"line_number":93,"context_line":"    use_v3 \u003d v3_auth_url and (use_domain or (not v2_auth_url))"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa98f980_73b9daca","line":90,"updated":"2014-09-09 10:36:00.000000000","message":"will we somehow check that nothing else is passed to the kwargs? or we\u0027re just ignoring all extra data coming here? If so, it looks like persistent args like user_id, project_dpmain_id, etc. might be ok here.","commit_id":"ec1f74106a0d6663019c1c5cde94a5ca594bb041"},{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"c493d76864d98d3d2f35cc80709d0861284316a9","unresolved":false,"context_lines":[{"line_number":87,"context_line":"    project_domain_name \u003d kwargs.pop(\u0027project_domain_name\u0027, None)"},{"line_number":88,"context_line":"    project_domain_id \u003d kwargs.pop(\u0027project_domain_id\u0027, None)"},{"line_number":89,"context_line":"    auth \u003d None"},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"    use_domain \u003d (user_domain_id or user_domain_name or"},{"line_number":92,"context_line":"                  project_domain_id or project_domain_name)"},{"line_number":93,"context_line":"    use_v3 \u003d v3_auth_url and (use_domain or (not v2_auth_url))"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa98f980_26a9a7df","line":90,"in_reply_to":"fa98f980_73b9daca","updated":"2014-09-10 20:01:47.000000000","message":"not quite sure what you mean... the below is just a refactor to remove the duplicate paths that exist.","commit_id":"ec1f74106a0d6663019c1c5cde94a5ca594bb041"},{"author":{"_account_id":6676,"name":"zqfan","email":"aji.zqfan@gmail.com","username":"aji-zqfan"},"change_message_id":"41cdd961f8aea77a13df695d5055599f5d5fc0e6","unresolved":false,"context_lines":[{"line_number":32,"context_line":"        ks_discover \u003d discover.Discover(session\u003dsession, auth_url\u003dauth_url)"},{"line_number":33,"context_line":"        v2_auth_url \u003d ks_discover.url_for(\u00272.0\u0027)"},{"line_number":34,"context_line":"        v3_auth_url \u003d ks_discover.url_for(\u00273.0\u0027)"},{"line_number":35,"context_line":"    except ks_exc.DiscoveryFailure:"},{"line_number":36,"context_line":"        raise"},{"line_number":37,"context_line":"    except exceptions.ClientException:"},{"line_number":38,"context_line":"        # Identity service may not support discovery. In that case,"}],"source_content_type":"text/x-python","patch_set":3,"id":"da9df570_454fea92","line":35,"updated":"2014-09-20 03:26:39.000000000","message":"I think keystoneclient.exceptions.DiscoveryFailure is not a subclass of ceilometerclient.openstack.common.apiclient.exceptions.ClientException, so this except block may not be necessary\n\n    \u003e\u003e\u003e from keystoneclient.exceptions import DiscoveryFailure\n    \u003e\u003e\u003e from ceilometerclient.openstack.common.apiclient.exceptions import ClientException\n    \u003e\u003e\u003e issubclass(DiscoveryFailure, ClientException)\n    False\n    \u003e\u003e\u003e from keystoneclient.openstack.common.apiclient.exceptions import ClientException\n    \u003e\u003e\u003e issubclass(DiscoveryFailure, ClientException)\n    True","commit_id":"bc71ba32c9e69c2a57f612d752fe1128fccc7d40"},{"author":{"_account_id":6676,"name":"zqfan","email":"aji.zqfan@gmail.com","username":"aji-zqfan"},"change_message_id":"41cdd961f8aea77a13df695d5055599f5d5fc0e6","unresolved":false,"context_lines":[{"line_number":91,"context_line":"    use_domain \u003d (user_domain_id or user_domain_name or"},{"line_number":92,"context_line":"                  project_domain_id or project_domain_name)"},{"line_number":93,"context_line":"    use_v3 \u003d v3_auth_url and (use_domain or (not v2_auth_url))"},{"line_number":94,"context_line":"    use_v2 \u003d v2_auth_url and not use_domain"},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"    if use_v3:"},{"line_number":97,"context_line":"        # the auth_url as v3 specified"}],"source_content_type":"text/x-python","patch_set":3,"id":"da9df570_e52e1ea5","line":94,"updated":"2014-09-20 03:26:39.000000000","message":"L94 can be put in front of L93, so it can be more clear as\n\n    use_v2 \u003d v2_auth_url and not use_domain\n    use_v3 \u003d v3_auth_url and not use_v2","commit_id":"bc71ba32c9e69c2a57f612d752fe1128fccc7d40"}]}