)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":4491,"name":"Lianhao Lu","email":"llh_misc@outlook.com","username":"lianhao-lu"},"change_message_id":"407850cae07f9cb6b3f387b3c2395afd2c7741b8","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Catch missing 404 exceptions in client"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Whenever an entity wasn\u0027t found, the ceilometerclient would issue a"},{"line_number":10,"context_line":"NotFound exception. Which is fine, except that it\u0027s not the exceptions"},{"line_number":11,"context_line":"that was being excepted in the client at all. This exception was defined"},{"line_number":12,"context_line":"in the apiclient in the openstack/common directory. So, instead this"},{"line_number":13,"context_line":"exception is now being caught in the manager, and now the appropriate"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"1aca2d91_a6689df6","line":10,"updated":"2015-05-07 08:20:18.000000000","message":"s/exceptions/exception/","commit_id":"a0c6306bc5ad1e101779e5633418e87492d111bf"},{"author":{"_account_id":4491,"name":"Lianhao Lu","email":"llh_misc@outlook.com","username":"lianhao-lu"},"change_message_id":"407850cae07f9cb6b3f387b3c2395afd2c7741b8","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Whenever an entity wasn\u0027t found, the ceilometerclient would issue a"},{"line_number":10,"context_line":"NotFound exception. Which is fine, except that it\u0027s not the exceptions"},{"line_number":11,"context_line":"that was being excepted in the client at all. This exception was defined"},{"line_number":12,"context_line":"in the apiclient in the openstack/common directory. So, instead this"},{"line_number":13,"context_line":"exception is now being caught in the manager, and now the appropriate"},{"line_number":14,"context_line":"exception is being raised."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"1aca2d91_667285e7","line":11,"updated":"2015-05-07 08:20:18.000000000","message":"s/excepted/expected/","commit_id":"a0c6306bc5ad1e101779e5633418e87492d111bf"},{"author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"change_message_id":"56dde3f73a10afff2f2bbfffea4b98933e3bb119","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Catch missing 404 exceptions in client"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Whenever an entity wasn\u0027t found, the ceilometerclient would issue a"},{"line_number":10,"context_line":"NotFound exception. Which is fine, except that it\u0027s not the exceptions"},{"line_number":11,"context_line":"that was being excepted in the client at all. This exception was defined"},{"line_number":12,"context_line":"in the apiclient in the openstack/common directory. So, instead this"},{"line_number":13,"context_line":"exception is now being caught in the manager, and now the appropriate"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"9af37de9_5bef99b0","line":10,"updated":"2015-05-11 11:46:45.000000000","message":"exception","commit_id":"349f23358688e50ff0fd1ed6b00cf3e0d3b10b7b"},{"author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"change_message_id":"56dde3f73a10afff2f2bbfffea4b98933e3bb119","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Whenever an entity wasn\u0027t found, the ceilometerclient would issue a"},{"line_number":10,"context_line":"NotFound exception. Which is fine, except that it\u0027s not the exceptions"},{"line_number":11,"context_line":"that was being excepted in the client at all. This exception was defined"},{"line_number":12,"context_line":"in the apiclient in the openstack/common directory. So, instead this"},{"line_number":13,"context_line":"exception is now being caught in the manager, and now the appropriate"},{"line_number":14,"context_line":"exception is being raised."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"9af37de9_1b30f155","line":11,"updated":"2015-05-11 11:46:45.000000000","message":"expected","commit_id":"349f23358688e50ff0fd1ed6b00cf3e0d3b10b7b"},{"author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"change_message_id":"8d7ff0c08cfe4ab5ab252ef6e4d324860c1023ee","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Catch missing 404 exceptions in client"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Whenever an entity wasn\u0027t found, the ceilometerclient would issue a"},{"line_number":10,"context_line":"NotFound exception. Which is fine, except that it\u0027s not the exceptions"},{"line_number":11,"context_line":"that was being excepted in the client at all. This exception was defined"},{"line_number":12,"context_line":"in the apiclient in the openstack/common directory. So, instead this"},{"line_number":13,"context_line":"exception is now being caught in the manager, and now the appropriate"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"7a016987_ddb821e8","line":10,"updated":"2015-05-14 12:11:30.000000000","message":"s/exceptions/exception/","commit_id":"dcbe3e7804b5a1fa6a3ca230427177867cbbbe9a"},{"author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"change_message_id":"8d7ff0c08cfe4ab5ab252ef6e4d324860c1023ee","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Whenever an entity wasn\u0027t found, the ceilometerclient would issue a"},{"line_number":10,"context_line":"NotFound exception. Which is fine, except that it\u0027s not the exceptions"},{"line_number":11,"context_line":"that was being excepted in the client at all. This exception was defined"},{"line_number":12,"context_line":"in the apiclient in the openstack/common directory. So, instead this"},{"line_number":13,"context_line":"exception is now being caught in the manager, and now the appropriate"},{"line_number":14,"context_line":"exception is being raised."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"7a016987_7dc80d75","line":11,"updated":"2015-05-14 12:11:30.000000000","message":"s/excepted/expected/","commit_id":"dcbe3e7804b5a1fa6a3ca230427177867cbbbe9a"}],"ceilometerclient/common/base.py":[{"author":{"_account_id":4491,"name":"Lianhao Lu","email":"llh_misc@outlook.com","username":"lianhao-lu"},"change_message_id":"407850cae07f9cb6b3f387b3c2395afd2c7741b8","unresolved":false,"context_lines":[{"line_number":66,"context_line":""},{"line_number":67,"context_line":"    def _list(self, url, response_key\u003dNone, obj_class\u003dNone, body\u003dNone,"},{"line_number":68,"context_line":"              expect_single\u003dFalse):"},{"line_number":69,"context_line":"        resp \u003d None"},{"line_number":70,"context_line":"        try:"},{"line_number":71,"context_line":"            resp \u003d self.api.get(url)"},{"line_number":72,"context_line":"            if not resp.content:"}],"source_content_type":"text/x-python","patch_set":2,"id":"1aca2d91_86e8017e","line":69,"updated":"2015-05-07 08:20:18.000000000","message":"nitpicking, why need this line?","commit_id":"a0c6306bc5ad1e101779e5633418e87492d111bf"},{"author":{"_account_id":4491,"name":"Lianhao Lu","email":"llh_misc@outlook.com","username":"lianhao-lu"},"change_message_id":"39709c9c1ecc23a30b2c053b93d46dd3ec5eaccf","unresolved":false,"context_lines":[{"line_number":66,"context_line":""},{"line_number":67,"context_line":"    def _list(self, url, response_key\u003dNone, obj_class\u003dNone, body\u003dNone,"},{"line_number":68,"context_line":"              expect_single\u003dFalse):"},{"line_number":69,"context_line":"        resp \u003d None"},{"line_number":70,"context_line":"        try:"},{"line_number":71,"context_line":"            resp \u003d self.api.get(url)"},{"line_number":72,"context_line":"            if not resp.content:"}],"source_content_type":"text/x-python","patch_set":2,"id":"1aca2d91_bbb1cf91","line":69,"in_reply_to":"1aca2d91_377dd51c","updated":"2015-05-07 10:09:52.000000000","message":"Unlike C, python doesn\u0027t need that.","commit_id":"a0c6306bc5ad1e101779e5633418e87492d111bf"},{"author":{"_account_id":10873,"name":"Juan Antonio Osorio Robles","email":"jaosorior@redhat.com","username":"ejuaoso"},"change_message_id":"6171335a5727b0fe7c03ed5bc04c41f69e7833a7","unresolved":false,"context_lines":[{"line_number":66,"context_line":""},{"line_number":67,"context_line":"    def _list(self, url, response_key\u003dNone, obj_class\u003dNone, body\u003dNone,"},{"line_number":68,"context_line":"              expect_single\u003dFalse):"},{"line_number":69,"context_line":"        resp \u003d None"},{"line_number":70,"context_line":"        try:"},{"line_number":71,"context_line":"            resp \u003d self.api.get(url)"},{"line_number":72,"context_line":"            if not resp.content:"}],"source_content_type":"text/x-python","patch_set":2,"id":"1aca2d91_377dd51c","line":69,"in_reply_to":"1aca2d91_86e8017e","updated":"2015-05-07 09:30:58.000000000","message":"I will test without the line, but I think the definition of the variable needs to be there.","commit_id":"a0c6306bc5ad1e101779e5633418e87492d111bf"},{"author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"change_message_id":"56dde3f73a10afff2f2bbfffea4b98933e3bb119","unresolved":false,"context_lines":[{"line_number":71,"context_line":"            resp \u003d self.api.get(url)"},{"line_number":72,"context_line":"            if not resp.content:"},{"line_number":73,"context_line":"                raise exc.HTTPNotFound"},{"line_number":74,"context_line":"        except exceptions.NotFound:"},{"line_number":75,"context_line":"            raise exc.HTTPNotFound"},{"line_number":76,"context_line":"        body \u003d resp.json()"},{"line_number":77,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"9af37de9_9b6aa119","line":74,"updated":"2015-05-11 11:46:45.000000000","message":"I think it is best for the try/except block to only wrap the part of the code that is going to raise that exception. Presumably that means only the api.get in this case?","commit_id":"349f23358688e50ff0fd1ed6b00cf3e0d3b10b7b"},{"author":{"_account_id":10873,"name":"Juan Antonio Osorio Robles","email":"jaosorior@redhat.com","username":"ejuaoso"},"change_message_id":"c1f0a96a9f915b1421e008c5297b67ad382c77cf","unresolved":false,"context_lines":[{"line_number":71,"context_line":"            resp \u003d self.api.get(url)"},{"line_number":72,"context_line":"            if not resp.content:"},{"line_number":73,"context_line":"                raise exc.HTTPNotFound"},{"line_number":74,"context_line":"        except exceptions.NotFound:"},{"line_number":75,"context_line":"            raise exc.HTTPNotFound"},{"line_number":76,"context_line":"        body \u003d resp.json()"},{"line_number":77,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"9af37de9_1b9a3115","line":74,"in_reply_to":"9af37de9_9b6aa119","updated":"2015-05-11 11:48:58.000000000","message":"that\u0027s a good point.","commit_id":"349f23358688e50ff0fd1ed6b00cf3e0d3b10b7b"}]}