)]}'
{"ceilometerclient/v2/samples.py":[{"author":{"_account_id":10987,"name":"Igor Degtiarov","username":"tovstun","inactive":true},"change_message_id":"d6dc7dd2b9391f2da2f505f82f80e1f941e39ea1","unresolved":false,"context_lines":[{"line_number":52,"context_line":"        direct \u003d kwargs.pop(\u0027direct\u0027, False)"},{"line_number":53,"context_line":"        new \u003d dict((key, value) for (key, value) in kwargs.items()"},{"line_number":54,"context_line":"                   if key in CREATION_ATTRIBUTES)"},{"line_number":55,"context_line":"        url \u003d self._path(counter_name\u003dkwargs[\u0027counter_name\u0027])"},{"line_number":56,"context_line":"        if direct:"},{"line_number":57,"context_line":"            url \u003d \u0027%s?direct\u003d%s\u0027 % (url, str(direct))"},{"line_number":58,"context_line":"        body \u003d self.api.post(url, json\u003d[new]).json()"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa32b979_2a801149","line":55,"updated":"2015-06-26 07:23:54.000000000","message":"it could be written in one string: \nurl \u003d self._path(counter_name\u003dkwargs[\u0027counter_name\u0027]) + (\u0027?direct\u003d%s\u0027 % (str(direct)) if direct else \u0027\u0027)","commit_id":"1427683a1fdca896f77349ec2756c115fea31101"},{"author":{"_account_id":8290,"name":"liusheng","email":"liusheng2048@gmail.com","username":"LiuSheng"},"change_message_id":"28b7a0b8ea1559acd1fed3fc0b5d26548049445b","unresolved":false,"context_lines":[{"line_number":52,"context_line":"        direct \u003d kwargs.pop(\u0027direct\u0027, False)"},{"line_number":53,"context_line":"        new \u003d dict((key, value) for (key, value) in kwargs.items()"},{"line_number":54,"context_line":"                   if key in CREATION_ATTRIBUTES)"},{"line_number":55,"context_line":"        url \u003d self._path(counter_name\u003dkwargs[\u0027counter_name\u0027])"},{"line_number":56,"context_line":"        if direct:"},{"line_number":57,"context_line":"            url \u003d \u0027%s?direct\u003d%s\u0027 % (url, str(direct))"},{"line_number":58,"context_line":"        body \u003d self.api.post(url, json\u003d[new]).json()"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa32b979_2aec9191","line":55,"in_reply_to":"fa32b979_2a801149","updated":"2015-06-26 07:44:08.000000000","message":"I personally think it is not a good habit to put complex logical in 1 line (maybe this is more pthonic :-) ), and here we cannot use \"?direct\u003d%s\u0027 % (str(direct)) if direct else \u0027\u0027\" because if direct is not set, the url will be: \"xxx?direct\u003d\", this is invalid.\n\nTo avoid modifying a lot of unit tests, it is better to keep the url as before if direct is not set or set as False.","commit_id":"1427683a1fdca896f77349ec2756c115fea31101"},{"author":{"_account_id":10987,"name":"Igor Degtiarov","username":"tovstun","inactive":true},"change_message_id":"c51f18947fb60e2f3c5d6f5534a8eb056cbd7bfd","unresolved":false,"context_lines":[{"line_number":52,"context_line":"        direct \u003d kwargs.pop(\u0027direct\u0027, False)"},{"line_number":53,"context_line":"        new \u003d dict((key, value) for (key, value) in kwargs.items()"},{"line_number":54,"context_line":"                   if key in CREATION_ATTRIBUTES)"},{"line_number":55,"context_line":"        url \u003d self._path(counter_name\u003dkwargs[\u0027counter_name\u0027])"},{"line_number":56,"context_line":"        if direct:"},{"line_number":57,"context_line":"            url \u003d \u0027%s?direct\u003d%s\u0027 % (url, str(direct))"},{"line_number":58,"context_line":"        body \u003d self.api.post(url, json\u003d[new]).json()"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa32b979_d7aeed2e","line":55,"in_reply_to":"fa32b979_2aec9191","updated":"2015-06-26 08:46:04.000000000","message":"you are not right here if not direct url will be \"xxx\" without phrase in parentheses.","commit_id":"1427683a1fdca896f77349ec2756c115fea31101"},{"author":{"_account_id":8290,"name":"liusheng","email":"liusheng2048@gmail.com","username":"LiuSheng"},"change_message_id":"eb0cfabb8fe2d39e1a80f3ff3b8d46cfd7fe4c0c","unresolved":false,"context_lines":[{"line_number":52,"context_line":"        direct \u003d kwargs.pop(\u0027direct\u0027, False)"},{"line_number":53,"context_line":"        new \u003d dict((key, value) for (key, value) in kwargs.items()"},{"line_number":54,"context_line":"                   if key in CREATION_ATTRIBUTES)"},{"line_number":55,"context_line":"        url \u003d self._path(counter_name\u003dkwargs[\u0027counter_name\u0027])"},{"line_number":56,"context_line":"        if direct:"},{"line_number":57,"context_line":"            url \u003d \u0027%s?direct\u003d%s\u0027 % (url, str(direct))"},{"line_number":58,"context_line":"        body \u003d self.api.post(url, json\u003d[new]).json()"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa32b979_502f43a7","line":55,"in_reply_to":"fa32b979_d7aeed2e","updated":"2015-06-26 09:46:53.000000000","message":"sorry for misunderstanding, done.","commit_id":"1427683a1fdca896f77349ec2756c115fea31101"},{"author":{"_account_id":10987,"name":"Igor Degtiarov","username":"tovstun","inactive":true},"change_message_id":"d6dc7dd2b9391f2da2f505f82f80e1f941e39ea1","unresolved":false,"context_lines":[{"line_number":73,"context_line":"        sample_return_list \u003d []"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"        for (counter_name, sample_body) in sample_dict.items():"},{"line_number":76,"context_line":"            url \u003d self._path(counter_name\u003dcounter_name)"},{"line_number":77,"context_line":"            if direct:"},{"line_number":78,"context_line":"                url \u003d \u0027%s?direct\u003d%s\u0027 % (url, str(direct))"},{"line_number":79,"context_line":"            body \u003d self.api.post(url, json\u003dsample_body).json()"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa32b979_8ab4bd35","line":76,"updated":"2015-06-26 07:23:54.000000000","message":"ditto","commit_id":"1427683a1fdca896f77349ec2756c115fea31101"},{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"f9e4a9c4e9a333f5a3827475a212a2ece38866bf","unresolved":false,"context_lines":[{"line_number":53,"context_line":"        new \u003d dict((key, value) for (key, value) in kwargs.items()"},{"line_number":54,"context_line":"                   if key in CREATION_ATTRIBUTES)"},{"line_number":55,"context_line":"        url \u003d self._path(counter_name\u003dkwargs[\u0027counter_name\u0027])+("},{"line_number":56,"context_line":"            \u0027?direct\u003d%s\u0027 % (str(direct)) if direct else \u0027\u0027)"},{"line_number":57,"context_line":"        body \u003d self.api.post(url, json\u003d[new]).json()"},{"line_number":58,"context_line":"        if body:"},{"line_number":59,"context_line":"            return [OldSample(self, b) for b in body]"}],"source_content_type":"text/x-python","patch_set":5,"id":"fa32b979_967047de","line":56,"updated":"2015-06-26 20:49:29.000000000","message":"slightly confused, why do we need to add direct param if its false? isn\u0027t that default already?","commit_id":"d16d853da6f6e43a26e2a80a613d9ca0208b727d"},{"author":{"_account_id":8290,"name":"liusheng","email":"liusheng2048@gmail.com","username":"LiuSheng"},"change_message_id":"a018f24e490a8d4f6114fc87ec660aa3a4644f72","unresolved":false,"context_lines":[{"line_number":53,"context_line":"        new \u003d dict((key, value) for (key, value) in kwargs.items()"},{"line_number":54,"context_line":"                   if key in CREATION_ATTRIBUTES)"},{"line_number":55,"context_line":"        url \u003d self._path(counter_name\u003dkwargs[\u0027counter_name\u0027])+("},{"line_number":56,"context_line":"            \u0027?direct\u003d%s\u0027 % (str(direct)) if direct else \u0027\u0027)"},{"line_number":57,"context_line":"        body \u003d self.api.post(url, json\u003d[new]).json()"},{"line_number":58,"context_line":"        if body:"},{"line_number":59,"context_line":"            return [OldSample(self, b) for b in body]"}],"source_content_type":"text/x-python","patch_set":5,"id":"9a41bdd9_3c56d15c","line":56,"in_reply_to":"fa32b979_967047de","updated":"2015-07-14 00:56:39.000000000","message":"Hi gordon, you are right. if if direct param is false, this statement will don\u0027t add direct param. the *(\u0027?direct\u003d%s\u0027 % (str(direct)) if direct else \u0027\u0027)* will be \u0027?direct\u003dTrue\u0027 if direct is True value and be \u0027\u0027 if direct is False value.","commit_id":"d16d853da6f6e43a26e2a80a613d9ca0208b727d"}],"ceilometerclient/v2/shell.py":[{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"5f60d7970b7d4475361ec226ccb568744df856b5","unresolved":false,"context_lines":[{"line_number":268,"context_line":"@utils.arg(\u0027samples_list\u0027, metavar\u003d\u0027\u003cSAMPLES_LIST\u003e\u0027, action\u003dNotEmptyAction,"},{"line_number":269,"context_line":"           help\u003d\u0027Json array with samples to create.\u0027)"},{"line_number":270,"context_line":"@utils.arg(\u0027--direct\u0027, metavar\u003d\u0027\u003cDIRECT\u003e\u0027,"},{"line_number":271,"context_line":"           help\u003d\u0027Post samples to storage directly.\u0027)"},{"line_number":272,"context_line":"def do_sample_create_list(cc, args\u003d{}):"},{"line_number":273,"context_line":"    \"\"\"Create a sample list.\"\"\""},{"line_number":274,"context_line":"    sample_list_array \u003d json.loads(args.samples_list)"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa32b979_08ca0b1b","line":271,"updated":"2015-06-25 19:26:17.000000000","message":"i think you can set default here.","commit_id":"35c1f84c475bbbee87d21592d249cd9bc56d8b06"},{"author":{"_account_id":8290,"name":"liusheng","email":"liusheng2048@gmail.com","username":"LiuSheng"},"change_message_id":"b2ccfb9e037216c1ffe35b28f259024d2eccdadf","unresolved":false,"context_lines":[{"line_number":268,"context_line":"@utils.arg(\u0027samples_list\u0027, metavar\u003d\u0027\u003cSAMPLES_LIST\u003e\u0027, action\u003dNotEmptyAction,"},{"line_number":269,"context_line":"           help\u003d\u0027Json array with samples to create.\u0027)"},{"line_number":270,"context_line":"@utils.arg(\u0027--direct\u0027, metavar\u003d\u0027\u003cDIRECT\u003e\u0027,"},{"line_number":271,"context_line":"           help\u003d\u0027Post samples to storage directly.\u0027)"},{"line_number":272,"context_line":"def do_sample_create_list(cc, args\u003d{}):"},{"line_number":273,"context_line":"    \"\"\"Create a sample list.\"\"\""},{"line_number":274,"context_line":"    sample_list_array \u003d json.loads(args.samples_list)"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa32b979_7f9a5d70","line":271,"in_reply_to":"fa32b979_08ca0b1b","updated":"2015-06-26 06:59:41.000000000","message":"thanks, done.","commit_id":"35c1f84c475bbbee87d21592d249cd9bc56d8b06"}]}