)]}'
{"ceilometerclient/v2/resources.py":[{"author":{"_account_id":6676,"name":"zqfan","email":"aji.zqfan@gmail.com","username":"aji-zqfan"},"change_message_id":"8c897608e49c23f0f0b5c61ff973dff06b64793a","unresolved":false,"context_lines":[{"line_number":32,"context_line":""},{"line_number":33,"context_line":"    def list(self, q\u003dNone):"},{"line_number":34,"context_line":"        path \u003d \u0027/v2/resources\u0027"},{"line_number":35,"context_line":"        params \u003d [\u0027meter_links\u003d0\u0027]"},{"line_number":36,"context_line":"        return self._list(options.build_url(path, q, params))"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"    def get(self, resource_id):"}],"source_content_type":"text/x-python","patch_set":1,"id":"da20952f_8a2fd3a6","line":35,"updated":"2015-09-09 01:55:16.000000000","message":"Maybe we should not hard-code it to disable it, make it disable by default can be better.\n\nBecause ceilometerclient not only prints on screen, such case the meter links is useless, but can also used by python code, then developer may want to get some kind of resources with their links, so web page can shows what meters these resources have and their links, if there is a switch of meter_link can be enable then can save plenty requests, and end user can quickly click some link and get the samples of this resource (with default limit)\n\nOK, this case is actually not seen by me, just heard some discuss on this before, so still +2","commit_id":"7774b2373155881351e228cfeb10110eedd3788b"},{"author":{"_account_id":8290,"name":"liusheng","email":"liusheng2048@gmail.com","username":"LiuSheng"},"change_message_id":"77901f9fbe549989cff262eb94a0aeb88f835371","unresolved":false,"context_lines":[{"line_number":31,"context_line":"    resource_class \u003d Resource"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"    def list(self, q\u003dNone, links\u003dNone):"},{"line_number":34,"context_line":"        path \u003d \u0027/v2/resources\u0027"},{"line_number":35,"context_line":"        params \u003d [\u0027meter_links\u003d%d\u0027 % (1 if links else 0)]"},{"line_number":36,"context_line":"        return self._list(options.build_url(path, q, params))"},{"line_number":37,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"da20952f_b750ffd5","line":34,"updated":"2015-09-09 04:19:59.000000000","message":"the meter_links parameter looks like a boolean value, just curious why it is defined as a int value in ceilometer-api, how about using a strutils.bool_from_string() here ?","commit_id":"4f1b09f7687d59c313af59358b3a309fe1b90d7d"},{"author":{"_account_id":6676,"name":"zqfan","email":"aji.zqfan@gmail.com","username":"aji-zqfan"},"change_message_id":"a98a47f5164cfab3719792f624a392c8177dbff8","unresolved":false,"context_lines":[{"line_number":31,"context_line":"    resource_class \u003d Resource"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"    def list(self, q\u003dNone, links\u003dNone):"},{"line_number":34,"context_line":"        path \u003d \u0027/v2/resources\u0027"},{"line_number":35,"context_line":"        params \u003d [\u0027meter_links\u003d%d\u0027 % (1 if links else 0)]"},{"line_number":36,"context_line":"        return self._list(options.build_url(path, q, params))"},{"line_number":37,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"da20952f_4d7f9066","line":34,"in_reply_to":"da20952f_b750ffd5","updated":"2015-09-09 06:15:52.000000000","message":"This parameter will be passed via developer, I think maybe bool_from_string goes too far. Input from shell will always be strings, then we should consider cast IMHO","commit_id":"4f1b09f7687d59c313af59358b3a309fe1b90d7d"}]}