)]}'
{"ceilometerclient/common/http.py":[{"author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"change_message_id":"ab81faf7650f047615301d34eabcb1b4354f2464","unresolved":false,"context_lines":[{"line_number":136,"context_line":"        try:"},{"line_number":137,"context_line":"            conn_params \u003d self.connection_params[1][2]"},{"line_number":138,"context_line":"            if conn_params:"},{"line_number":139,"context_line":"                conn_url \u003d os.path.normpath(\u0027%s/%s\u0027 % (conn_params, url))"},{"line_number":140,"context_line":"            else:"},{"line_number":141,"context_line":"                conn_url \u003d url"},{"line_number":142,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAN3%2F%2F80w%3D","line":139,"updated":"2013-03-05 15:05:29.000000000","message":"You don\u0027t want to use os.path.normpath(), since it assumes the platform-specific filesystem path separator, which is \\ for Windows but URLs always use /.\n\nI think you want something like:\n\n  \u0027%s/%s\u0027 % (conn_params.rstrip(\u0027/\u0027), url.lstrip(\u0027/\u0027))","commit_id":"794234ac04325c323ee3f17db11cfb2c21efc736"}],"tests/test_http.py":[{"author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"change_message_id":"bd7cbb6caa95b6bf18023c21a521c3cc36c36214","unresolved":false,"context_lines":[{"line_number":27,"context_line":"        self.api \u003d utils.FakeAPI(fixtures)"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"    def test_url_generation_with_connection_params(self):"},{"line_number":30,"context_line":"        result \u003d self.api.url_generation(\u0027GET\u0027, \u0027/v1/meters\u0027, \u0027test_connection_params\u0027)"},{"line_number":31,"context_line":"        self.assertEqual(result, \u0027test_connection_params/v1/meters\u0027)"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"    def test_url_generation_without_connection_params(self):"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAN3%2F%2F4TU%3D","line":30,"updated":"2013-03-07 20:25:07.000000000","message":"As far as I can tell, this is going to invoke the new method you added on the FakeAPI, rather than doing anything with the client.\n\nI think the FakeAPI is meant to be used when stubbing out the network calls that would be made by the client, but in this case we don\u0027t care about the network data at all. We just care that the URL is built properly. So I think you want to stub out the request() method of the object returned by get_connection() and then verify that it is called with the right values.\n\nIt would be easier to test this if you moved the logic for building those parameters into its own method, since you could call that method without triggering any network access at all, so you wouldn\u0027t need any mocks.","commit_id":"8e1a8c64072fa7740349d4915e7f9f4a05b6dca4"},{"author":{"_account_id":4715,"name":"Angus Salkeld","email":"asalkeld@redhat.com","username":"asalkeld"},"change_message_id":"3ab37700cd9557cb78743bd8c2e8f459e59cc4b5","unresolved":false,"context_lines":[{"line_number":15,"context_line":""},{"line_number":16,"context_line":"import unittest"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"import mock"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"from tests import utils"},{"line_number":21,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAN3%2F%2F4Ag%3D","line":18,"updated":"2013-03-07 23:02:07.000000000","message":"you don\u0027t use mock anymore\n also you could remove it from test-requires","commit_id":"a28c199f5f99fab139b810924a571e636fd2d098"}],"tools/test-requires":[{"author":{"_account_id":4491,"name":"Lianhao Lu","email":"llh_misc@outlook.com","username":"lianhao-lu"},"change_message_id":"76b6cb25f6c00c412e774a42c8a2c0eaaf584847","unresolved":false,"context_lines":[{"line_number":1,"context_line":"distribute\u003e\u003d0.6.24"},{"line_number":2,"context_line":"mock"},{"line_number":3,"context_line":"mox"},{"line_number":4,"context_line":"nose"},{"line_number":5,"context_line":"nose-exclude"}],"source_content_type":"application/octet-stream","patch_set":6,"id":"AAAAN3%2F%2F3aw%3D","line":2,"updated":"2013-03-08 09:10:10.000000000","message":"I think you forgot to remove this.","commit_id":"5250ca3057f24be97db0ef81db85284dbf40a51a"}]}