)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6676,"name":"zqfan","email":"aji.zqfan@gmail.com","username":"aji-zqfan"},"change_message_id":"5ec4ccba04c6f58bb665eb0ab47b6ac189bcdc19","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Ignores endpoint_type if interface is provided"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When a keystone session object is used, if endpoint_type and interface"},{"line_number":10,"context_line":"is provided, we must use interface and drops endpoint_type."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I379e18f684aa5092f8adbeaebe98030053115767"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"ba8a016a_5d72d57d","line":10,"updated":"2015-11-23 13:04:56.000000000","message":"s/is/are/\n\ns/drops/drop/","commit_id":"6736ac66b1bf61a37f48e1a8451fd61622b01bd1"}],"ceilometerclient/client.py":[{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"622d3206fb1a699425fa642214bd722ce45e790e","unresolved":false,"context_lines":[{"line_number":457,"context_line":"        return SessionClient("},{"line_number":458,"context_line":"            session\u003dkwargs.pop(\u0027session\u0027),"},{"line_number":459,"context_line":"            service_type\u003dkwargs.pop(\u0027service_type\u0027, \u0027metering\u0027),"},{"line_number":460,"context_line":"            interface\u003dkwargs.pop(\u0027interface\u0027, kwargs.pop(\u0027endpoint_type\u0027,"},{"line_number":461,"context_line":"                                                         \u0027publicURL\u0027)),"},{"line_number":462,"context_line":"            region_name\u003dkwargs.pop(\u0027region_name\u0027, None),"},{"line_number":463,"context_line":"            user_agent\u003dkwargs.pop(\u0027user_agent\u0027, \u0027python-ceilometerclient\u0027),"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba8a016a_30fccb3d","line":460,"updated":"2015-11-23 15:57:00.000000000","message":"does this actually drop endpoint_type? doesn\u0027t this just default to use endpoint_type if interface does not exist?","commit_id":"6736ac66b1bf61a37f48e1a8451fd61622b01bd1"},{"author":{"_account_id":6676,"name":"zqfan","email":"aji.zqfan@gmail.com","username":"aji-zqfan"},"change_message_id":"fee7c393d5e9078ecaad5764fe5ae5ba81f2d9c6","unresolved":false,"context_lines":[{"line_number":457,"context_line":"        return SessionClient("},{"line_number":458,"context_line":"            session\u003dkwargs.pop(\u0027session\u0027),"},{"line_number":459,"context_line":"            service_type\u003dkwargs.pop(\u0027service_type\u0027, \u0027metering\u0027),"},{"line_number":460,"context_line":"            interface\u003dkwargs.pop(\u0027interface\u0027, kwargs.pop(\u0027endpoint_type\u0027,"},{"line_number":461,"context_line":"                                                         \u0027publicURL\u0027)),"},{"line_number":462,"context_line":"            region_name\u003dkwargs.pop(\u0027region_name\u0027, None),"},{"line_number":463,"context_line":"            user_agent\u003dkwargs.pop(\u0027user_agent\u0027, \u0027python-ceilometerclient\u0027),"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a8ffd7b_841d8abf","line":460,"in_reply_to":"9a8ffd7b_acac3aee","updated":"2015-11-24 15:36:36.000000000","message":"I thought it does,\n\n    Python 2.7.6 (default, Jun 22 2015, 17:58:13) \n    [GCC 4.8.2] on linux2\n    \u003e\u003e\u003e d \u003d {1:2,3:4}\n    \u003e\u003e\u003e d.pop(1, d.pop(3,6))\n    2\n    \u003e\u003e\u003e d\n    {}","commit_id":"6736ac66b1bf61a37f48e1a8451fd61622b01bd1"},{"author":{"_account_id":6676,"name":"zqfan","email":"aji.zqfan@gmail.com","username":"aji-zqfan"},"change_message_id":"86c2573af9b7e9ab071175e51c1e3eeda40ec6f3","unresolved":false,"context_lines":[{"line_number":457,"context_line":"        return SessionClient("},{"line_number":458,"context_line":"            session\u003dkwargs.pop(\u0027session\u0027),"},{"line_number":459,"context_line":"            service_type\u003dkwargs.pop(\u0027service_type\u0027, \u0027metering\u0027),"},{"line_number":460,"context_line":"            interface\u003dkwargs.pop(\u0027interface\u0027, kwargs.pop(\u0027endpoint_type\u0027,"},{"line_number":461,"context_line":"                                                         \u0027publicURL\u0027)),"},{"line_number":462,"context_line":"            region_name\u003dkwargs.pop(\u0027region_name\u0027, None),"},{"line_number":463,"context_line":"            user_agent\u003dkwargs.pop(\u0027user_agent\u0027, \u0027python-ceilometerclient\u0027),"}],"source_content_type":"text/x-python","patch_set":2,"id":"ba8a016a_c4a4a2ba","line":460,"in_reply_to":"ba8a016a_30fccb3d","updated":"2015-11-23 16:33:35.000000000","message":"for some old code, may pass endpoint_type instead of interface, so the old code provide the compatibility for such case. the problem is that the left code will leave endpoint_type to kwargs which I think may not be harmful but still good to drop it.\n\nIIUC","commit_id":"6736ac66b1bf61a37f48e1a8451fd61622b01bd1"},{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"46004541a02f98de6abaf52ae6caa2700e7fbc4f","unresolved":false,"context_lines":[{"line_number":457,"context_line":"        return SessionClient("},{"line_number":458,"context_line":"            session\u003dkwargs.pop(\u0027session\u0027),"},{"line_number":459,"context_line":"            service_type\u003dkwargs.pop(\u0027service_type\u0027, \u0027metering\u0027),"},{"line_number":460,"context_line":"            interface\u003dkwargs.pop(\u0027interface\u0027, kwargs.pop(\u0027endpoint_type\u0027,"},{"line_number":461,"context_line":"                                                         \u0027publicURL\u0027)),"},{"line_number":462,"context_line":"            region_name\u003dkwargs.pop(\u0027region_name\u0027, None),"},{"line_number":463,"context_line":"            user_agent\u003dkwargs.pop(\u0027user_agent\u0027, \u0027python-ceilometerclient\u0027),"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a8ffd7b_acac3aee","line":460,"in_reply_to":"ba8a016a_c4a4a2ba","updated":"2015-11-24 14:12:00.000000000","message":"right. but right now it doesn\u0027t drop endpoint_type if interface exists.","commit_id":"6736ac66b1bf61a37f48e1a8451fd61622b01bd1"}]}