)]}'
{"id":"openstack%2Fpython-ceilometerclient~249690","triplet_id":"openstack%2Fpython-ceilometerclient~master~Ib15cdd73b62b7f0b86d0bd6f19d344fd24a665f6","project":"openstack/python-ceilometerclient","branch":"master","topic":"bug/1519729","hashtags":[],"change_id":"Ib15cdd73b62b7f0b86d0bd6f19d344fd24a665f6","subject":"Token will be lost when constructing a ceilometer client","status":"MERGED","created":"2015-11-25 10:16:10.000000000","updated":"2015-11-30 14:25:31.000000000","submitted":"2015-11-30 14:25:30.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":2,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"936a78afd1aa61812dd07b55ae3c791e7be0cc3f","_number":249690,"virtual_id_number":249690,"owner":{"_account_id":13001,"name":"lixiangjun","email":"xiangjun.li@easystack.cn","username":"lixiangjun"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":2,"date":"2015-11-30 14:25:30.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":6676,"name":"zqfan","email":"aji.zqfan@gmail.com","username":"aji-zqfan"},{"value":0,"date":"2015-11-27 03:26:08.000000000","_account_id":13001,"name":"lixiangjun","email":"xiangjun.li@easystack.cn","username":"lixiangjun"},{"value":0,"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":6676,"name":"zqfan","email":"aji.zqfan@gmail.com","username":"aji-zqfan"},"all":[{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":2,"date":"2015-11-30 13:11:10.000000000","_account_id":6676,"name":"zqfan","email":"aji.zqfan@gmail.com","username":"aji-zqfan"},{"value":0,"_account_id":13001,"name":"lixiangjun","email":"xiangjun.li@easystack.cn","username":"lixiangjun"},{"value":2,"date":"2015-11-30 13:04:05.000000000","_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":6676,"name":"zqfan","email":"aji.zqfan@gmail.com","username":"aji-zqfan"},"all":[{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":1,"date":"2015-11-30 13:11:10.000000000","_account_id":6676,"name":"zqfan","email":"aji.zqfan@gmail.com","username":"aji-zqfan"},{"value":0,"_account_id":13001,"name":"lixiangjun","email":"xiangjun.li@easystack.cn","username":"lixiangjun"},{"value":0,"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},{"_account_id":6676,"name":"zqfan","email":"aji.zqfan@gmail.com","username":"aji-zqfan"},{"_account_id":13001,"name":"lixiangjun","email":"xiangjun.li@easystack.cn","username":"lixiangjun"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2015-11-30 13:04:05.000000000","updated_by":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"reviewer":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"state":"REVIEWER"},{"updated":"2015-11-30 13:11:10.000000000","updated_by":{"_account_id":6676,"name":"zqfan","email":"aji.zqfan@gmail.com","username":"aji-zqfan"},"reviewer":{"_account_id":6676,"name":"zqfan","email":"aji.zqfan@gmail.com","username":"aji-zqfan"},"state":"REVIEWER"},{"updated":"2015-11-30 14:25:30.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"c41d128c5b0cc365059ab80d1ba7e7dde03f9fcc","author":{"_account_id":13001,"name":"lixiangjun","email":"xiangjun.li@easystack.cn","username":"lixiangjun"},"date":"2015-11-25 10:16:10.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"148d2b00fc786aafa5e013f32d65294e867429ba","author":{"_account_id":6676,"name":"zqfan","email":"aji.zqfan@gmail.com","username":"aji-zqfan"},"date":"2015-11-25 11:18:18.000000000","message":"Patch Set 1: Code-Review+2\n\nlooks like deprecating it is not enough","accounts_in_message":[],"_revision_number":1},{"id":"58fb89a0c6a29bfc7b123134c542ac431364e38b","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-11-25 11:33:02.000000000","message":"Patch Set 1: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see http://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n- gate-python-ceilometerclient-pep8 http://logs.openstack.org/90/249690/1/check/gate-python-ceilometerclient-pep8/7d1c2ca/ : SUCCESS in 58s\n- gate-python-ceilometerclient-docs http://docs-draft.openstack.org/90/249690/1/check/gate-python-ceilometerclient-docs/2edda14//doc/build/html/ : SUCCESS in 2m 17s\n- gate-python-ceilometerclient-python27 http://logs.openstack.org/90/249690/1/check/gate-python-ceilometerclient-python27/941b919/ : SUCCESS in 1m 20s\n- gate-python-ceilometerclient-python34 http://logs.openstack.org/90/249690/1/check/gate-python-ceilometerclient-python34/4cf90f4/ : SUCCESS in 1m 23s\n- gate-python-ceilometerclient-pypy http://logs.openstack.org/90/249690/1/check/gate-python-ceilometerclient-pypy/93a71f5/ : SUCCESS in 2m 08s (non-voting)\n- gate-tempest-dsvm-neutron-src-python-ceilometerclient-plugin http://logs.openstack.org/90/249690/1/check/gate-tempest-dsvm-neutron-src-python-ceilometerclient-plugin/0ea3243/ : SUCCESS in 1h 13m 59s\n- gate-ceilometerclient-dsvm-functional http://logs.openstack.org/90/249690/1/check/gate-ceilometerclient-dsvm-functional/0fb1392/ : FAILURE in 27m 41s","accounts_in_message":[],"_revision_number":1},{"id":"24236daa3cdc2298c2f180bb2fb384af10d1e715","author":{"_account_id":13001,"name":"lixiangjun","email":"xiangjun.li@easystack.cn","username":"lixiangjun"},"date":"2015-11-25 14:27:44.000000000","message":"Patch Set 1:\n\nrecheck","accounts_in_message":[],"_revision_number":1},{"id":"034222bb8ecfe45274051724d196e6e2600995ca","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-11-25 15:53:41.000000000","message":"Patch Set 1:\n\nBuild failed (check pipeline).  For information on how to proceed, see http://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n- gate-python-ceilometerclient-pep8 http://logs.openstack.org/90/249690/1/check/gate-python-ceilometerclient-pep8/7706930/ : SUCCESS in 1m 12s\n- gate-python-ceilometerclient-docs http://docs-draft.openstack.org/90/249690/1/check/gate-python-ceilometerclient-docs/597b968//doc/build/html/ : SUCCESS in 1m 32s\n- gate-python-ceilometerclient-python27 http://logs.openstack.org/90/249690/1/check/gate-python-ceilometerclient-python27/4b789ab/ : SUCCESS in 1m 10s\n- gate-python-ceilometerclient-python34 http://logs.openstack.org/90/249690/1/check/gate-python-ceilometerclient-python34/c0c7829/ : SUCCESS in 1m 33s\n- gate-python-ceilometerclient-pypy http://logs.openstack.org/90/249690/1/check/gate-python-ceilometerclient-pypy/119d912/ : SUCCESS in 1m 51s (non-voting)\n- gate-tempest-dsvm-neutron-src-python-ceilometerclient-plugin http://logs.openstack.org/90/249690/1/check/gate-tempest-dsvm-neutron-src-python-ceilometerclient-plugin/4644ce3/ : SUCCESS in 1h 22m 35s\n- gate-ceilometerclient-dsvm-functional http://logs.openstack.org/90/249690/1/check/gate-ceilometerclient-dsvm-functional/faa421c/ : FAILURE in 33m 49s","accounts_in_message":[],"_revision_number":1},{"id":"4a08bf62b7ddef0e6d9cbe9f7f34c80f03fee74d","author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"date":"2015-11-26 21:16:51.000000000","message":"Patch Set 1: Code-Review-1\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"0e62cf73c9e4454c966a8ee13444b913e237918e","author":{"_account_id":6676,"name":"zqfan","email":"aji.zqfan@gmail.com","username":"aji-zqfan"},"date":"2015-11-27 02:19:18.000000000","message":"Patch Set 1: Code-Review-1\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"22e36a59ce835149a42e29ab4b261c0abbb414e6","author":{"_account_id":13001,"name":"lixiangjun","email":"xiangjun.li@easystack.cn","username":"lixiangjun"},"date":"2015-11-27 03:22:44.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"835dd33474cd7004fbe79ae17e21cd570bf015be","author":{"_account_id":13001,"name":"lixiangjun","email":"xiangjun.li@easystack.cn","username":"lixiangjun"},"date":"2015-11-27 03:26:08.000000000","message":"Patch Set 2:\n\nseems that at least horizon use the way of passing parameter ‘token’ to construct ceilometer client, so check for ‘token’ is added.\nhttps://github.com/openstack/horizon/blob/master/openstack_dashboard/api/ceilometer.py#L281","accounts_in_message":[],"_revision_number":2},{"id":"80ae733484dd23e736c6d863ccb79c96198a05fb","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-11-27 04:28:38.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-ceilometerclient-pep8 http://logs.openstack.org/90/249690/2/check/gate-python-ceilometerclient-pep8/7f191ad/ : SUCCESS in 53s\n- gate-python-ceilometerclient-docs http://docs-draft.openstack.org/90/249690/2/check/gate-python-ceilometerclient-docs/18de81b//doc/build/html/ : SUCCESS in 1m 14s\n- gate-python-ceilometerclient-python27 http://logs.openstack.org/90/249690/2/check/gate-python-ceilometerclient-python27/f69c978/ : SUCCESS in 1m 07s\n- gate-python-ceilometerclient-python34 http://logs.openstack.org/90/249690/2/check/gate-python-ceilometerclient-python34/b814a01/ : SUCCESS in 1m 33s\n- gate-python-ceilometerclient-pypy http://logs.openstack.org/90/249690/2/check/gate-python-ceilometerclient-pypy/fd83a74/ : SUCCESS in 1m 49s (non-voting)\n- gate-tempest-dsvm-neutron-src-python-ceilometerclient-plugin http://logs.openstack.org/90/249690/2/check/gate-tempest-dsvm-neutron-src-python-ceilometerclient-plugin/4bd6f71/ : SUCCESS in 1h 05m 46s\n- gate-ceilometerclient-dsvm-functional http://logs.openstack.org/90/249690/2/check/gate-ceilometerclient-dsvm-functional/a3925ed/ : SUCCESS in 23m 19s","accounts_in_message":[],"_revision_number":2},{"id":"74e987d25a3f19ee428bc4112ad90701a328ed8a","author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"date":"2015-11-30 13:04:05.000000000","message":"Patch Set 2: Code-Review+2","accounts_in_message":[],"_revision_number":2},{"id":"51a1492b1b86d08cb463f08173f560851456929f","author":{"_account_id":6676,"name":"zqfan","email":"aji.zqfan@gmail.com","username":"aji-zqfan"},"date":"2015-11-30 13:11:10.000000000","message":"Patch Set 2: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":2},{"id":"99dbbc7930a34d65904b2ee6ee4c53604ce2da5f","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-11-30 13:11:20.000000000","message":"Patch Set 2: -Verified\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":2},{"id":"2071b2278f0f5b133ddf3d827973891020d93556","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-11-30 14:25:30.000000000","message":"Patch Set 2: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- gate-python-ceilometerclient-docs http://docs-draft.openstack.org/90/249690/2/gate/gate-python-ceilometerclient-docs/fa7d3a5//doc/build/html/ : SUCCESS in 1m 16s\n- gate-python-ceilometerclient-pep8 http://logs.openstack.org/90/249690/2/gate/gate-python-ceilometerclient-pep8/fbf84e1/ : SUCCESS in 1m 01s\n- gate-python-ceilometerclient-python27 http://logs.openstack.org/90/249690/2/gate/gate-python-ceilometerclient-python27/fb9afce/ : SUCCESS in 1m 06s\n- gate-python-ceilometerclient-python34 http://logs.openstack.org/90/249690/2/gate/gate-python-ceilometerclient-python34/f2ae614/ : SUCCESS in 1m 25s\n- gate-tempest-dsvm-neutron-src-python-ceilometerclient-plugin http://logs.openstack.org/90/249690/2/gate/gate-tempest-dsvm-neutron-src-python-ceilometerclient-plugin/5e9956a/ : SUCCESS in 1h 12m 38s\n- gate-ceilometerclient-dsvm-functional http://logs.openstack.org/90/249690/2/gate/gate-ceilometerclient-dsvm-functional/9da5373/ : SUCCESS in 23m 05s","accounts_in_message":[],"_revision_number":2},{"id":"da38b130b9d67ef9274642688954ca7033650f34","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-11-30 14:25:31.000000000","message":"Change has been successfully merged into the git repository.","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"b398841ebf1bb8acd0fea7c88dae613dad788d08","revisions":{"1ad3b2e31df670833d180ac5f108ccee01b59b8d":{"kind":"REWORK","_number":1,"created":"2015-11-25 10:16:10.000000000","uploader":{"_account_id":13001,"name":"lixiangjun","email":"xiangjun.li@easystack.cn","username":"lixiangjun"},"ref":"refs/changes/90/249690/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-ceilometerclient","ref":"refs/changes/90/249690/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-ceilometerclient refs/changes/90/249690/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-ceilometerclient refs/changes/90/249690/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-ceilometerclient refs/changes/90/249690/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-ceilometerclient refs/changes/90/249690/1"}}},"commit":{"parents":[{"commit":"7a3da84d0c03ee84ae9e19844ac9c8177e7e78c3","subject":"Merge \"Remove double API requests\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-ceilometerclient/commit/7a3da84d0c03ee84ae9e19844ac9c8177e7e78c3"}]}],"author":{"name":"xiangjun li","email":"lixiangjun@cn.fujitsu.com","date":"2015-11-25 10:08:51.000000000","tz":480},"committer":{"name":"xiangjun li","email":"lixiangjun@cn.fujitsu.com","date":"2015-11-25 10:16:06.000000000","tz":480},"subject":"Token will be lost when constructing a ceilometer client","message":"Token will be lost when constructing a ceilometer client\n\nIf parameters os_token and os_endpoint were passed to\nceilometerclient.client.get_client to construct a ceilometer client, the\ntoken will be wrongly replaced with None in method\nceilometerclient.client._adjust_kwargs, which will cause the\nauthentication error when use the instance of ceilometer client later.\nThis patch fixed this problem.\n\nChange-Id: Ib15cdd73b62b7f0b86d0bd6f19d344fd24a665f6\nCloses-Bug: #1519729\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-ceilometerclient/commit/1ad3b2e31df670833d180ac5f108ccee01b59b8d"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-ceilometerclient/commit/1ad3b2e31df670833d180ac5f108ccee01b59b8d"}]},"branch":"refs/heads/master"},"b398841ebf1bb8acd0fea7c88dae613dad788d08":{"kind":"REWORK","_number":2,"created":"2015-11-27 03:22:44.000000000","uploader":{"_account_id":13001,"name":"lixiangjun","email":"xiangjun.li@easystack.cn","username":"lixiangjun"},"ref":"refs/changes/90/249690/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-ceilometerclient","ref":"refs/changes/90/249690/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-ceilometerclient refs/changes/90/249690/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-ceilometerclient refs/changes/90/249690/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-ceilometerclient refs/changes/90/249690/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-ceilometerclient refs/changes/90/249690/2"}}},"commit":{"parents":[{"commit":"7a3da84d0c03ee84ae9e19844ac9c8177e7e78c3","subject":"Merge \"Remove double API requests\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-ceilometerclient/commit/7a3da84d0c03ee84ae9e19844ac9c8177e7e78c3"}]}],"author":{"name":"xiangjun li","email":"lixiangjun@cn.fujitsu.com","date":"2015-11-25 10:08:51.000000000","tz":480},"committer":{"name":"xiangjun li","email":"lixiangjun@cn.fujitsu.com","date":"2015-11-27 03:22:12.000000000","tz":480},"subject":"Token will be lost when constructing a ceilometer client","message":"Token will be lost when constructing a ceilometer client\n\nIf parameters os_token and os_endpoint were passed to\nceilometerclient.client.get_client to construct a ceilometer client, the\ntoken will be wrongly replaced with None in method\nceilometerclient.client._adjust_kwargs, which will cause the\nauthentication error when use the instance of ceilometer client later.\nThis patch fixed this problem.\n\nChange-Id: Ib15cdd73b62b7f0b86d0bd6f19d344fd24a665f6\nCloses-Bug: #1519729\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-ceilometerclient/commit/b398841ebf1bb8acd0fea7c88dae613dad788d08"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-ceilometerclient/commit/b398841ebf1bb8acd0fea7c88dae613dad788d08"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}