)]}'
{"ceilometerclient/common/utils.py":[{"author":{"_account_id":4491,"name":"Lianhao Lu","email":"llh_misc@outlook.com","username":"lianhao-lu"},"change_message_id":"ebd7c1618b0ef75a0b3ad32d7caa4fa5d47c5457","unresolved":false,"context_lines":[{"line_number":35,"context_line":"        temp \u003d {}"},{"line_number":36,"context_line":"        # If the input data is a dict, create an equivalent dict with a"},{"line_number":37,"context_line":"        # predictable insertion order to avoid inconsistencies in the"},{"line_number":38,"context_line":"        # message signature computation for equivalent payloads modulo"},{"line_number":39,"context_line":"        # ordering"},{"line_number":40,"context_line":"        for key, value in sorted(six.iteritems(input)):"},{"line_number":41,"context_line":"            temp[decode_unicode(key)] \u003d decode_unicode(value)"}],"source_content_type":"text/x-python","patch_set":5,"id":"da6ed579_112967e6","line":38,"range":{"start_line":38,"start_character":64,"end_line":38,"end_character":70},"updated":"2016-01-14 03:19:35.000000000","message":"how could this affect message signature? Is this function only used by print_dict? I guess this function is copied from ceilometer.utils module, right? \n\nIf this function is only used by print_dict() down below, I think you can optimize to avoiding do 2 times iterations here and below in print_dict()","commit_id":"a11efb2a76b0cf4b48a5b57734a04e0eb6c1ce49"},{"author":{"_account_id":8290,"name":"liusheng","email":"liusheng2048@gmail.com","username":"LiuSheng"},"change_message_id":"50ad7ff371458aee54a148a488ef7ccaf01629ce","unresolved":false,"context_lines":[{"line_number":35,"context_line":"        temp \u003d {}"},{"line_number":36,"context_line":"        # If the input data is a dict, create an equivalent dict with a"},{"line_number":37,"context_line":"        # predictable insertion order to avoid inconsistencies in the"},{"line_number":38,"context_line":"        # message signature computation for equivalent payloads modulo"},{"line_number":39,"context_line":"        # ordering"},{"line_number":40,"context_line":"        for key, value in sorted(six.iteritems(input)):"},{"line_number":41,"context_line":"            temp[decode_unicode(key)] \u003d decode_unicode(value)"}],"source_content_type":"text/x-python","patch_set":5,"id":"da6ed579_bbbdd1b8","line":38,"range":{"start_line":38,"start_character":64,"end_line":38,"end_character":70},"in_reply_to":"da6ed579_112967e6","updated":"2016-01-14 07:19:49.000000000","message":"yeah, agree, don\u0027t need this complex process if only used in print_dict()","commit_id":"a11efb2a76b0cf4b48a5b57734a04e0eb6c1ce49"},{"author":{"_account_id":4491,"name":"Lianhao Lu","email":"llh_misc@outlook.com","username":"lianhao-lu"},"change_message_id":"cebbf4e90c5ed6a92402b4ffd3cbe23fe9e5f79b","unresolved":false,"context_lines":[{"line_number":110,"context_line":"        if isinstance(v, dict):"},{"line_number":111,"context_line":"            v \u003d jsonutils.dumps(v)"},{"line_number":112,"context_line":"        if isinstance(v, list):"},{"line_number":113,"context_line":"            v \u003d decode_unicode(v)"},{"line_number":114,"context_line":"        # if value has a newline, add in multiple rows"},{"line_number":115,"context_line":"        # e.g. fault with stacktrace"},{"line_number":116,"context_line":"        if v and isinstance(v, six.string_types) and r\u0027\\n\u0027 in v:"}],"source_content_type":"text/x-python","patch_set":6,"id":"da6ed579_733f7d24","line":113,"range":{"start_line":113,"start_character":32,"end_line":113,"end_character":33},"updated":"2016-01-14 09:10:38.000000000","message":"Instead of treating list different than dict, can we jsonutils.dump the list either? It would be much simpler. Just a question","commit_id":"16c1b943677d23ec2f663ceea97b9d9ad4f862de"}]}