)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":4491,"name":"Lianhao Lu","email":"llh_misc@outlook.com","username":"lianhao-lu"},"change_message_id":"ccd4af83c54720cb2b39a4b6ec0c2953af4c4d61","unresolved":false,"context_lines":[{"line_number":13,"context_line":"This patch enhances the ceilometer-client to support"},{"line_number":14,"context_line":"the unique argument in the shell and the client bindings."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"see: https://review.openstack.org/#/c/259626/"},{"line_number":17,"context_line":"DocImpact"},{"line_number":18,"context_line":"Closes-Bug: bug/1506959"},{"line_number":19,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"7a5de9d1_2d27bf13","line":16,"range":{"start_line":16,"start_character":44,"end_line":16,"end_character":45},"updated":"2016-01-28 09:10:50.000000000","message":"If you means cross project dependency, please use Depends-On tag, see http://docs.openstack.org/infra/manual/developers.html#cross-repository-dependencies","commit_id":"4a5a348dfb58121970ed5c8a13ba1786611078d5"},{"author":{"_account_id":4491,"name":"Lianhao Lu","email":"llh_misc@outlook.com","username":"lianhao-lu"},"change_message_id":"ccd4af83c54720cb2b39a4b6ec0c2953af4c4d61","unresolved":false,"context_lines":[{"line_number":15,"context_line":""},{"line_number":16,"context_line":"see: https://review.openstack.org/#/c/259626/"},{"line_number":17,"context_line":"DocImpact"},{"line_number":18,"context_line":"Closes-Bug: bug/1506959"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"Change-Id: I011ca725c25e1cdbe9891c3719f13f5cd34142ea"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"7a5de9d1_4d6b1b1f","line":18,"range":{"start_line":18,"start_character":16,"end_line":18,"end_character":23},"updated":"2016-01-28 09:10:50.000000000","message":"Closes-Bug: #1506959","commit_id":"4a5a348dfb58121970ed5c8a13ba1786611078d5"},{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"df9cbfc59c5547106de7d44ca3f268ee14f022ea","unresolved":false,"context_lines":[{"line_number":13,"context_line":"This patch enhances the ceilometer-client to support"},{"line_number":14,"context_line":"the unique argument in the shell and the client bindings."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Depends-On: https://review.openstack.org/#/c/259626/"},{"line_number":17,"context_line":"DocImpact"},{"line_number":18,"context_line":"Closes-Bug: #1506959"},{"line_number":19,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"7a5de9d1_d36b771c","line":16,"updated":"2016-02-01 23:23:09.000000000","message":"let\u0027s remove this. it should be a changeid... not exactly sure what happens when you put a url in","commit_id":"25831f43d48d2119c3e9058c9ef4477d72363226"}],"ceilometerclient/v2/meters.py":[{"author":{"_account_id":7478,"name":"Nadya Shakhat","email":"nadmi4@gmail.com","username":"nprivalova"},"change_message_id":"af0516e7da6d7677ece58fc41fffe5b500c81247","unresolved":false,"context_lines":[{"line_number":28,"context_line":"    def list(self, q\u003dNone, limit\u003dNone, unique\u003dFalse):"},{"line_number":29,"context_line":"        path \u003d \u0027/v2/meters\u0027"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"        params \u003d []"},{"line_number":32,"context_line":"        if limit:"},{"line_number":33,"context_line":"            params.append(\u0027limit\u003d%s\u0027 % limit)"},{"line_number":34,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"7a5de9d1_e27614d6","line":31,"updated":"2016-01-31 17:47:37.000000000","message":"IMHO, you use two approaches to solve the same problem.\nProbably, it would be easier to read if you use two \"if\"s or two \"params.append\".\nAlso, is the ok to put \u0027\u0027 in params? It will be just ignored, won\u0027t it?","commit_id":"105996767f57aaf61e1231aaaffb1cfcf5567e6e"},{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"df9cbfc59c5547106de7d44ca3f268ee14f022ea","unresolved":false,"context_lines":[{"line_number":29,"context_line":"        path \u003d \u0027/v2/meters\u0027"},{"line_number":30,"context_line":"        params \u003d []"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"        params.append(\u0027limit\u003d%s\u0027 % limit if limit else None)"},{"line_number":33,"context_line":"        params.append(\u0027unique\u003d%s\u0027 % str(unique) if unique else \u0027\u0027)"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"        return self._list(options.build_url(path, q, params))"}],"source_content_type":"text/x-python","patch_set":4,"id":"7a5de9d1_33bf6b62","line":32,"updated":"2016-02-01 23:23:09.000000000","message":"this is not the same. before params\u003dNone if limit not defined... now it\u0027s params\u003d[None], which will create http://url?None","commit_id":"25831f43d48d2119c3e9058c9ef4477d72363226"}],"ceilometerclient/v2/shell.py":[{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"881fa56814ad09ca58ef2584bb016765a52c621a","unresolved":false,"context_lines":[{"line_number":266,"context_line":"                \u0027but if supplied must be string, integer, float, or boolean.\u0027)"},{"line_number":267,"context_line":"@utils.arg(\u0027-l\u0027, \u0027--limit\u0027, metavar\u003d\u0027\u003cNUMBER\u003e\u0027,"},{"line_number":268,"context_line":"           help\u003d\u0027Maximum number of meters to return. %s\u0027 % DEFAULT_API_LIMIT)"},{"line_number":269,"context_line":"@utils.arg(\u0027--unique\u0027, dest\u003d\u0027unique\u0027, action\u003d\u0027store_true\u0027,"},{"line_number":270,"context_line":"           help\u003d\u0027Retrieves unique list of meters.\u0027)"},{"line_number":271,"context_line":"def do_meter_list(cc, args\u003d{}):"},{"line_number":272,"context_line":"    \"\"\"List the user\u0027s meters.\"\"\""}],"source_content_type":"text/x-python","patch_set":5,"id":"5a5ae5dd_a5b35599","line":269,"updated":"2016-02-05 19:19:22.000000000","message":"i think we should include type\u003dlambda v: strutils.bool_from_string(v, True) so we actually enforce the value rather than let any input be given","commit_id":"4605d5f9aa0e6c1d3820037c7eec4544baab021e"}]}