)]}'
{"id":"openstack%2Fpython-ceilometerclient~289238","triplet_id":"openstack%2Fpython-ceilometerclient~master~I39c28294db3e55141bb8a2024a6ddfdf8acf5e0d","project":"openstack/python-ceilometerclient","branch":"master","topic":"bug/1539092","hashtags":[],"change_id":"I39c28294db3e55141bb8a2024a6ddfdf8acf5e0d","subject":"remove default value of repeat-actions","status":"MERGED","created":"2016-03-07 09:52:09.000000000","updated":"2016-03-14 10:50:12.000000000","submitted":"2016-03-14 10:50:12.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":1,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"3a8005185828e48ec978938886fdd56fa0ee18f9","_number":289238,"virtual_id_number":289238,"owner":{"_account_id":6676,"name":"zqfan","email":"aji.zqfan@gmail.com","username":"aji-zqfan"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":0,"_account_id":8290,"name":"liusheng","email":"liusheng2048@gmail.com","username":"LiuSheng"},{"value":2,"date":"2016-03-14 10:50:12.000000000","post_submit":true,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},{"value":0,"_account_id":10987,"name":"Igor Degtiarov","username":"tovstun","inactive":true}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":8290,"name":"liusheng","email":"liusheng2048@gmail.com","username":"LiuSheng"},"all":[{"value":2,"date":"2016-03-14 09:37:44.000000000","_account_id":8290,"name":"liusheng","email":"liusheng2048@gmail.com","username":"LiuSheng"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":2,"date":"2016-03-10 12:40:28.000000000","_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},{"value":1,"date":"2016-03-10 09:46:20.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":10987,"name":"Igor Degtiarov","username":"tovstun","inactive":true}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":8290,"name":"liusheng","email":"liusheng2048@gmail.com","username":"LiuSheng"},"all":[{"value":1,"date":"2016-03-14 09:37:44.000000000","_account_id":8290,"name":"liusheng","email":"liusheng2048@gmail.com","username":"LiuSheng"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},{"value":0,"_account_id":10987,"name":"Igor Degtiarov","username":"tovstun","inactive":true}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},{"_account_id":8290,"name":"liusheng","email":"liusheng2048@gmail.com","username":"LiuSheng"},{"_account_id":10987,"name":"Igor Degtiarov","username":"tovstun","inactive":true}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2016-03-10 09:46:20.000000000","updated_by":{"_account_id":10987,"name":"Igor Degtiarov","username":"tovstun","inactive":true},"reviewer":{"_account_id":10987,"name":"Igor Degtiarov","username":"tovstun","inactive":true},"state":"REVIEWER"},{"updated":"2016-03-10 12:40:28.000000000","updated_by":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"reviewer":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"state":"REVIEWER"},{"updated":"2016-03-14 09:37:44.000000000","updated_by":{"_account_id":8290,"name":"liusheng","email":"liusheng2048@gmail.com","username":"LiuSheng"},"reviewer":{"_account_id":8290,"name":"liusheng","email":"liusheng2048@gmail.com","username":"LiuSheng"},"state":"REVIEWER"},{"updated":"2016-03-14 10:50:12.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"a9614f9157191c763a86fa4bfcb98fddb4340de5","author":{"_account_id":6676,"name":"zqfan","email":"aji.zqfan@gmail.com","username":"aji-zqfan"},"date":"2016-03-07 09:52:09.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"7944427d2cb6743ec22559925e2d12df47b414ef","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-03-07 10:59:30.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-ceilometerclient-pep8 http://logs.openstack.org/38/289238/1/check/gate-python-ceilometerclient-pep8/70b31cc/ : SUCCESS in 1m 33s\n- gate-python-ceilometerclient-docs http://docs-draft.openstack.org/38/289238/1/check/gate-python-ceilometerclient-docs/20f64a5//doc/build/html/ : SUCCESS in 2m 04s\n- gate-python-ceilometerclient-python27 http://logs.openstack.org/38/289238/1/check/gate-python-ceilometerclient-python27/075d061/ : SUCCESS in 3m 05s\n- gate-python-ceilometerclient-python34 http://logs.openstack.org/38/289238/1/check/gate-python-ceilometerclient-python34/89eb3ae/ : SUCCESS in 2m 03s\n- gate-python-ceilometerclient-pypy http://logs.openstack.org/38/289238/1/check/gate-python-ceilometerclient-pypy/f7536d6/ : SUCCESS in 4m 21s (non-voting)\n- gate-tempest-dsvm-neutron-src-python-ceilometerclient-plugin http://logs.openstack.org/38/289238/1/check/gate-tempest-dsvm-neutron-src-python-ceilometerclient-plugin/3374c55/ : SUCCESS in 1h 07m 14s\n- gate-ceilometerclient-dsvm-functional http://logs.openstack.org/38/289238/1/check/gate-ceilometerclient-dsvm-functional/d67a224/ : SUCCESS in 13m 15s\n- gate-telemetry-dsvm-integration-python-ceilometerclient http://logs.openstack.org/38/289238/1/check/gate-telemetry-dsvm-integration-python-ceilometerclient/f8ec4d3/ : SUCCESS in 36m 35s","accounts_in_message":[],"_revision_number":1},{"id":"6d0d18c1642784b130ab2c6b658307e3a73c5c3d","author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"date":"2016-03-09 19:19:28.000000000","message":"Patch Set 1: Code-Review-1\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"1023aa5bcf21bff3ba0be582d0f7828334c3d29e","author":{"_account_id":6676,"name":"zqfan","email":"aji.zqfan@gmail.com","username":"aji-zqfan"},"date":"2016-03-10 05:43:17.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"5308f9e6f410dd56bfeee6504b903c98fde209a2","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-03-10 06:47:48.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-ceilometerclient-pep8 http://logs.openstack.org/38/289238/2/check/gate-python-ceilometerclient-pep8/2523a3e/ : SUCCESS in 2m 26s\n- gate-python-ceilometerclient-docs http://docs-draft.openstack.org/38/289238/2/check/gate-python-ceilometerclient-docs/556fddb//doc/build/html/ : SUCCESS in 2m 21s\n- gate-python-ceilometerclient-python27 http://logs.openstack.org/38/289238/2/check/gate-python-ceilometerclient-python27/5f4f840/ : SUCCESS in 2m 34s\n- gate-python-ceilometerclient-python34 http://logs.openstack.org/38/289238/2/check/gate-python-ceilometerclient-python34/42cb66e/ : SUCCESS in 3m 55s\n- gate-python-ceilometerclient-pypy http://logs.openstack.org/38/289238/2/check/gate-python-ceilometerclient-pypy/20b023f/ : SUCCESS in 3m 42s (non-voting)\n- gate-tempest-dsvm-neutron-src-python-ceilometerclient-plugin http://logs.openstack.org/38/289238/2/check/gate-tempest-dsvm-neutron-src-python-ceilometerclient-plugin/10b76b6/ : SUCCESS in 1h 04m 24s\n- gate-ceilometerclient-dsvm-functional http://logs.openstack.org/38/289238/2/check/gate-ceilometerclient-dsvm-functional/7d370e6/ : SUCCESS in 20m 43s\n- gate-telemetry-dsvm-integration-python-ceilometerclient http://logs.openstack.org/38/289238/2/check/gate-telemetry-dsvm-integration-python-ceilometerclient/2885c07/ : SUCCESS in 36m 24s","accounts_in_message":[],"_revision_number":2},{"id":"d462e80b069fb1fa348ef649bccd992ac41b4d36","author":{"_account_id":10987,"name":"Igor Degtiarov","username":"tovstun","inactive":true},"date":"2016-03-10 09:46:20.000000000","message":"Patch Set 2: Code-Review+1","accounts_in_message":[],"_revision_number":2},{"id":"caf5606f91d00a4e95a0168b03bc7e1d386ce921","author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"date":"2016-03-10 12:40:28.000000000","message":"Patch Set 2: Code-Review+2","accounts_in_message":[],"_revision_number":2},{"id":"8d0cb7b37bf8ebc4418aceb4d40c49ed2d83c2e4","author":{"_account_id":8290,"name":"liusheng","email":"liusheng2048@gmail.com","username":"LiuSheng"},"date":"2016-03-14 09:37:44.000000000","message":"Patch Set 2: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":2},{"id":"f74cb7946d250f070d5789d92690c8a9b10eacbf","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-03-14 09:37:49.000000000","message":"Patch Set 2: -Verified\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":2},{"id":"285355cd1414f5e945153b8282dbae61ecac3751","date":"2016-03-14 10:50:12.000000000","message":"Change has been successfully merged into the git repository by Jenkins","accounts_in_message":[],"_revision_number":2},{"id":"7b20a156cdb0a2d8a1ecb7b6d476ab64daea4c02","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-03-14 10:50:12.000000000","message":"Patch Set 2: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- gate-python-ceilometerclient-docs http://docs-draft.openstack.org/38/289238/2/gate/gate-python-ceilometerclient-docs/69a80d9//doc/build/html/ : SUCCESS in 3m 36s\n- gate-python-ceilometerclient-pep8 http://logs.openstack.org/38/289238/2/gate/gate-python-ceilometerclient-pep8/b383837/ : SUCCESS in 3m 20s\n- gate-python-ceilometerclient-python27 http://logs.openstack.org/38/289238/2/gate/gate-python-ceilometerclient-python27/f97f3b5/ : SUCCESS in 3m 50s\n- gate-python-ceilometerclient-python34 http://logs.openstack.org/38/289238/2/gate/gate-python-ceilometerclient-python34/ff32ed5/ : SUCCESS in 3m 05s\n- gate-tempest-dsvm-neutron-src-python-ceilometerclient-plugin http://logs.openstack.org/38/289238/2/gate/gate-tempest-dsvm-neutron-src-python-ceilometerclient-plugin/16c5a81/ : SUCCESS in 1h 12m 18s\n- gate-ceilometerclient-dsvm-functional http://logs.openstack.org/38/289238/2/gate/gate-ceilometerclient-dsvm-functional/861fc37/ : SUCCESS in 21m 12s\n- gate-telemetry-dsvm-integration-python-ceilometerclient http://logs.openstack.org/38/289238/2/gate/gate-telemetry-dsvm-integration-python-ceilometerclient/072b346/ : SUCCESS in 33m 56s","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"c8ff0e7f9672298859298960084721ee520fa060","revisions":{"a3fe4289dd7a0baae2ae29f3f4a7f65c8a551d72":{"kind":"REWORK","_number":1,"created":"2016-03-07 09:52:09.000000000","uploader":{"_account_id":6676,"name":"zqfan","email":"aji.zqfan@gmail.com","username":"aji-zqfan"},"ref":"refs/changes/38/289238/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-ceilometerclient","ref":"refs/changes/38/289238/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-ceilometerclient refs/changes/38/289238/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-ceilometerclient refs/changes/38/289238/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-ceilometerclient refs/changes/38/289238/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-ceilometerclient refs/changes/38/289238/1"}}},"commit":{"parents":[{"commit":"b4e91a250ccd3b34f0d44732aaedee380f258e08","subject":"Merge \"Trivial: remove `None` as a redundant argument to dict.get()\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-ceilometerclient/commit/b4e91a250ccd3b34f0d44732aaedee380f258e08"}]}],"author":{"name":"ZhiQiang Fan","email":"aji.zqfan@gmail.com","date":"2016-03-07 17:43:44.000000000","tz":480},"committer":{"name":"ZhiQiang Fan","email":"aji.zqfan@gmail.com","date":"2016-03-07 17:43:44.000000000","tz":480},"subject":"remove default value of repeat-actions","message":"remove default value of repeat-actions\n\nI94468ff649dd4367848c74e94a3feb08494bb223 fixes problem that ceilometeclient\nincorrectly reset repeat-actions when update any attribute.\n\nI53f3af447a8f814388985f6e4ab57a8ffec18a2a reverts most of the above change,\nwhich leading to bug 1539092. Because repeat-actions has default value False,\nno matter we set it or not, it will replace this bit when we get alarm from API.\n\nThe unit test doesn\u0027t cover such case, so this change still succeeds in CI test.\n\nWe don\u0027t need to revert it again, because the redundant code for create and update\nis not needed, repeat-actions has default value (False) in API side, so the proper\nway is simply removing the default value in CLI side.\n\nChange-Id: I39c28294db3e55141bb8a2024a6ddfdf8acf5e0d\nCloses-Bug: #1539092\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-ceilometerclient/commit/a3fe4289dd7a0baae2ae29f3f4a7f65c8a551d72"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-ceilometerclient/commit/a3fe4289dd7a0baae2ae29f3f4a7f65c8a551d72"}]},"branch":"refs/heads/master"},"c8ff0e7f9672298859298960084721ee520fa060":{"kind":"REWORK","_number":2,"created":"2016-03-10 05:43:17.000000000","uploader":{"_account_id":6676,"name":"zqfan","email":"aji.zqfan@gmail.com","username":"aji-zqfan"},"ref":"refs/changes/38/289238/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-ceilometerclient","ref":"refs/changes/38/289238/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-ceilometerclient refs/changes/38/289238/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-ceilometerclient refs/changes/38/289238/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-ceilometerclient refs/changes/38/289238/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-ceilometerclient refs/changes/38/289238/2"}}},"commit":{"parents":[{"commit":"b4e91a250ccd3b34f0d44732aaedee380f258e08","subject":"Merge \"Trivial: remove `None` as a redundant argument to dict.get()\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-ceilometerclient/commit/b4e91a250ccd3b34f0d44732aaedee380f258e08"}]}],"author":{"name":"ZhiQiang Fan","email":"aji.zqfan@gmail.com","date":"2016-03-07 17:43:44.000000000","tz":480},"committer":{"name":"ZhiQiang Fan","email":"aji.zqfan@gmail.com","date":"2016-03-10 13:43:09.000000000","tz":480},"subject":"remove default value of repeat-actions","message":"remove default value of repeat-actions\n\nI94468ff649dd4367848c74e94a3feb08494bb223 fixes problem that ceilometeclient\nincorrectly reset repeat-actions when update any attribute.\n\nI53f3af447a8f814388985f6e4ab57a8ffec18a2a reverts most of the above change,\nwhich leading to bug 1539092. Because repeat-actions has default value False,\nno matter we set it or not, it will replace this bit when we get alarm from API.\n\nThe unit test doesn\u0027t cover such case, so this change still succeeds in CI test.\n\nWe don\u0027t need to revert it again, because the redundant code for create and update\nis not needed, repeat-actions has default value (False) in API side, so the proper\nway is simply removing the default value in CLI side.\n\nChange-Id: I39c28294db3e55141bb8a2024a6ddfdf8acf5e0d\nCloses-Bug: #1539092\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-ceilometerclient/commit/c8ff0e7f9672298859298960084721ee520fa060"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-ceilometerclient/commit/c8ff0e7f9672298859298960084721ee520fa060"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}