)]}'
{"id":"openstack%2Fpython-ceilometerclient~348703","triplet_id":"openstack%2Fpython-ceilometerclient~master~I4467d5efb1eed9f4c473c947c93afcfaf9be6ea6","project":"openstack/python-ceilometerclient","branch":"master","topic":"assertEqual-correct","hashtags":[],"change_id":"I4467d5efb1eed9f4c473c947c93afcfaf9be6ea6","subject":"Correct the parameters\u0027s position of assertEqual","status":"MERGED","created":"2016-07-29 03:12:33.000000000","updated":"2016-08-08 15:20:45.000000000","submitted":"2016-08-08 15:20:45.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"db6b485339976dfb0164f73b18695f6a3cbd81d8","_number":348703,"virtual_id_number":348703,"owner":{"_account_id":22739,"name":"Zhuangqing Xiao","email":"zhuangqing.xiao@easystack.cn","username":"xiaozhuangqing"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":2,"date":"2016-08-08 15:20:45.000000000","post_submit":true,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":1669,"name":"Julien Danjou","display_name":"jd","email":"julien@danjou.info","username":"jdanjou"},{"value":0,"_account_id":12807,"name":"Steve Lewis (stevelle)","email":"stevelle@gmail.com","username":"stevelle"},{"value":0,"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":1669,"name":"Julien Danjou","display_name":"jd","email":"julien@danjou.info","username":"jdanjou"},"all":[{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":2,"date":"2016-07-29 09:16:26.000000000","_account_id":1669,"name":"Julien Danjou","display_name":"jd","email":"julien@danjou.info","username":"jdanjou"},{"value":1,"date":"2016-08-05 19:18:35.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":12807,"name":"Steve Lewis (stevelle)","email":"stevelle@gmail.com","username":"stevelle"},{"value":2,"date":"2016-08-08 14:11:03.000000000","_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"all":[{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":1669,"name":"Julien Danjou","display_name":"jd","email":"julien@danjou.info","username":"jdanjou"},{"value":0,"_account_id":12807,"name":"Steve Lewis (stevelle)","email":"stevelle@gmail.com","username":"stevelle"},{"value":1,"date":"2016-08-08 14:11:03.000000000","_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":1669,"name":"Julien Danjou","display_name":"jd","email":"julien@danjou.info","username":"jdanjou"},{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},{"_account_id":12807,"name":"Steve Lewis (stevelle)","email":"stevelle@gmail.com","username":"stevelle"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2016-07-29 09:16:26.000000000","updated_by":{"_account_id":1669,"name":"Julien Danjou","display_name":"jd","email":"julien@danjou.info","username":"jdanjou"},"reviewer":{"_account_id":1669,"name":"Julien Danjou","display_name":"jd","email":"julien@danjou.info","username":"jdanjou"},"state":"REVIEWER"},{"updated":"2016-08-05 19:18:35.000000000","updated_by":{"_account_id":12807,"name":"Steve Lewis (stevelle)","email":"stevelle@gmail.com","username":"stevelle"},"reviewer":{"_account_id":12807,"name":"Steve Lewis (stevelle)","email":"stevelle@gmail.com","username":"stevelle"},"state":"REVIEWER"},{"updated":"2016-08-08 14:11:03.000000000","updated_by":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"reviewer":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"state":"REVIEWER"},{"updated":"2016-08-08 15:20:45.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"0755b7ded5ff877a028069643b64d18e26c6693a","author":{"_account_id":22739,"name":"Zhuangqing Xiao","email":"zhuangqing.xiao@easystack.cn","username":"xiaozhuangqing"},"date":"2016-07-29 03:12:33.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"46d108b7a8fd5da5d0054475c9887d602f6291de","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-07-29 05:09:43.000000000","message":"Patch Set 1: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see http://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n- gate-python-ceilometerclient-docs-ubuntu-xenial http://docs-draft.openstack.org/03/348703/1/check/gate-python-ceilometerclient-docs-ubuntu-xenial/f591da5//doc/build/html/ : SUCCESS in 11m 44s\n- gate-python-ceilometerclient-pep8-ubuntu-xenial http://logs.openstack.org/03/348703/1/check/gate-python-ceilometerclient-pep8-ubuntu-xenial/82f241e/ : SUCCESS in 4m 58s\n- gate-python-ceilometerclient-python27-ubuntu-xenial http://logs.openstack.org/03/348703/1/check/gate-python-ceilometerclient-python27-ubuntu-xenial/6baa93e/ : SUCCESS in 4m 44s\n- gate-python-ceilometerclient-python34 http://logs.openstack.org/03/348703/1/check/gate-python-ceilometerclient-python34/7b1fa42/ : SUCCESS in 9m 47s\n- gate-python-ceilometerclient-python35 http://logs.openstack.org/03/348703/1/check/gate-python-ceilometerclient-python35/468e9c1/ : SUCCESS in 4m 12s\n- gate-python-ceilometerclient-pypy http://logs.openstack.org/03/348703/1/check/gate-python-ceilometerclient-pypy/8853896/ : SUCCESS in 13m 03s (non-voting)\n- gate-tempest-dsvm-neutron-src-python-ceilometerclient-plugin http://logs.openstack.org/03/348703/1/check/gate-tempest-dsvm-neutron-src-python-ceilometerclient-plugin/35e7e54/ : SUCCESS in 1h 23m 04s\n- gate-ceilometerclient-dsvm-functional http://logs.openstack.org/03/348703/1/check/gate-ceilometerclient-dsvm-functional/17daccd/ : SUCCESS in 31m 40s\n- gate-ceilometerclient-dsvm-functional-identity-v3-only http://logs.openstack.org/03/348703/1/check/gate-ceilometerclient-dsvm-functional-identity-v3-only/34595fa/ : SUCCESS in 37m 57s\n- gate-telemetry-dsvm-integration-python-ceilometerclient http://logs.openstack.org/03/348703/1/check/gate-telemetry-dsvm-integration-python-ceilometerclient/d0708d9/ : FAILURE in 54m 11s","accounts_in_message":[],"_revision_number":1},{"id":"7078177d056f85d170b428dd0440bb75be532c48","author":{"_account_id":1669,"name":"Julien Danjou","display_name":"jd","email":"julien@danjou.info","username":"jdanjou"},"date":"2016-07-29 09:16:26.000000000","message":"Patch Set 1: Code-Review+2\n\nrecheck","accounts_in_message":[],"_revision_number":1},{"id":"62fcb87caf61cef2198120b2fcbdf0ed5d73c835","author":{"_account_id":22739,"name":"Zhuangqing Xiao","email":"zhuangqing.xiao@easystack.cn","username":"xiaozhuangqing"},"date":"2016-07-29 10:00:01.000000000","message":"Patch Set 1:\n\nrecheck","accounts_in_message":[],"_revision_number":1},{"id":"6aabea9dd434455cecf655994c78a59544e35a1e","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-07-29 10:44:19.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-ceilometerclient-docs-ubuntu-xenial http://docs-draft.openstack.org/03/348703/1/check/gate-python-ceilometerclient-docs-ubuntu-xenial/38f1752//doc/build/html/ : SUCCESS in 4m 18s\n- gate-python-ceilometerclient-pep8-ubuntu-xenial http://logs.openstack.org/03/348703/1/check/gate-python-ceilometerclient-pep8-ubuntu-xenial/f9e9c69/ : SUCCESS in 6m 58s\n- gate-python-ceilometerclient-python27-ubuntu-xenial http://logs.openstack.org/03/348703/1/check/gate-python-ceilometerclient-python27-ubuntu-xenial/41305f1/ : SUCCESS in 7m 36s\n- gate-python-ceilometerclient-python34 http://logs.openstack.org/03/348703/1/check/gate-python-ceilometerclient-python34/9695891/ : SUCCESS in 4m 30s\n- gate-python-ceilometerclient-python35 http://logs.openstack.org/03/348703/1/check/gate-python-ceilometerclient-python35/d79c2b1/ : SUCCESS in 4m 04s\n- gate-python-ceilometerclient-pypy http://logs.openstack.org/03/348703/1/check/gate-python-ceilometerclient-pypy/ea621b5/ : SUCCESS in 6m 04s (non-voting)\n- gate-tempest-dsvm-neutron-src-python-ceilometerclient-plugin http://logs.openstack.org/03/348703/1/check/gate-tempest-dsvm-neutron-src-python-ceilometerclient-plugin/cd682aa/ : SUCCESS in 1h 16m 36s\n- gate-ceilometerclient-dsvm-functional http://logs.openstack.org/03/348703/1/check/gate-ceilometerclient-dsvm-functional/bb30856/ : SUCCESS in 37m 24s\n- gate-ceilometerclient-dsvm-functional-identity-v3-only http://logs.openstack.org/03/348703/1/check/gate-ceilometerclient-dsvm-functional-identity-v3-only/c8315f4/ : SUCCESS in 42m 06s\n- gate-telemetry-dsvm-integration-python-ceilometerclient http://logs.openstack.org/03/348703/1/check/gate-telemetry-dsvm-integration-python-ceilometerclient/b35bed8/ : SUCCESS in 49m 41s","accounts_in_message":[],"_revision_number":1},{"id":"6591a9d8bac36b5d01feb7885e7da5aeb4119af0","author":{"_account_id":12807,"name":"Steve Lewis (stevelle)","email":"stevelle@gmail.com","username":"stevelle"},"date":"2016-08-05 19:18:35.000000000","message":"Patch Set 1: Code-Review+1\n\nI see no issues introduced by the changes and the consistency of use would be helpful","accounts_in_message":[],"_revision_number":1},{"id":"777bc020f107e9c6cc20d6034a9354f9f8cb0c1b","author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"date":"2016-08-08 14:11:03.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":1},{"id":"1afd31ba11c9e10228c824b871c58fd52a69f1bc","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-08-08 14:11:14.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":1},{"id":"16a7ea2582100d174da7951e2f7072c5f997c7d0","date":"2016-08-08 15:20:45.000000000","message":"Change has been successfully merged into the git repository by Jenkins","accounts_in_message":[],"_revision_number":1},{"id":"1695de316251247fc126054f44c9f90c6a2556db","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-08-08 15:20:45.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- gate-python-ceilometerclient-docs-ubuntu-xenial http://docs-draft.openstack.org/03/348703/1/gate/gate-python-ceilometerclient-docs-ubuntu-xenial/9fcca10//doc/build/html/ : SUCCESS in 4m 42s\n- gate-python-ceilometerclient-pep8-ubuntu-xenial http://logs.openstack.org/03/348703/1/gate/gate-python-ceilometerclient-pep8-ubuntu-xenial/420dab0/ : SUCCESS in 2m 03s\n- gate-python-ceilometerclient-python27-ubuntu-xenial http://logs.openstack.org/03/348703/1/gate/gate-python-ceilometerclient-python27-ubuntu-xenial/2cccfc8/ : SUCCESS in 3m 50s\n- gate-python-ceilometerclient-python34 http://logs.openstack.org/03/348703/1/gate/gate-python-ceilometerclient-python34/516942b/ : SUCCESS in 3m 11s\n- gate-python-ceilometerclient-python35 http://logs.openstack.org/03/348703/1/gate/gate-python-ceilometerclient-python35/8f3f50d/ : SUCCESS in 5m 06s\n- gate-tempest-dsvm-neutron-src-python-ceilometerclient-plugin http://logs.openstack.org/03/348703/1/gate/gate-tempest-dsvm-neutron-src-python-ceilometerclient-plugin/f85d9d9/ : SUCCESS in 1h 09m 18s\n- gate-ceilometerclient-dsvm-functional http://logs.openstack.org/03/348703/1/gate/gate-ceilometerclient-dsvm-functional/2f4dc76/ : SUCCESS in 33m 46s\n- gate-ceilometerclient-dsvm-functional-identity-v3-only http://logs.openstack.org/03/348703/1/gate/gate-ceilometerclient-dsvm-functional-identity-v3-only/cb24c1b/ : SUCCESS in 33m 26s\n- gate-telemetry-dsvm-integration-python-ceilometerclient http://logs.openstack.org/03/348703/1/gate/gate-telemetry-dsvm-integration-python-ceilometerclient/4fb91b6/ : SUCCESS in 43m 20s","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"481cd7d33bf5f91c39888fa695238c562eda7945","revisions":{"481cd7d33bf5f91c39888fa695238c562eda7945":{"kind":"REWORK","_number":1,"created":"2016-07-29 03:12:33.000000000","uploader":{"_account_id":22739,"name":"Zhuangqing Xiao","email":"zhuangqing.xiao@easystack.cn","username":"xiaozhuangqing"},"ref":"refs/changes/03/348703/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-ceilometerclient","ref":"refs/changes/03/348703/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-ceilometerclient refs/changes/03/348703/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-ceilometerclient refs/changes/03/348703/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-ceilometerclient refs/changes/03/348703/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-ceilometerclient refs/changes/03/348703/1"}}},"commit":{"parents":[{"commit":"3b35aea69e8618331d85aafe6347572e1db06cd5","subject":"Merge \"Remove discover from test-requirements\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-ceilometerclient/commit/3b35aea69e8618331d85aafe6347572e1db06cd5"}]}],"author":{"name":"xiaozhuangqing","email":"zhuangqing.xiao@easystack.cn","date":"2016-07-29 02:47:04.000000000","tz":480},"committer":{"name":"xiaozhuangqing","email":"zhuangqing.xiao@easystack.cn","date":"2016-07-29 03:08:36.000000000","tz":480},"subject":"Correct the parameters\u0027s position of assertEqual","message":"Correct the parameters\u0027s position of assertEqual\n\nassertEqual using should be assertEqual(expected, actual)\n\nmisplace have two impacts:\n1.giving confusing messages when some tests failed.\n2.mislead other developer,new test modules may follow these wrong pattern\n\nsee Partial-Bug  https://bugs.launchpad.net/oslo.config/+bug/1604213\n\nChange-Id: I4467d5efb1eed9f4c473c947c93afcfaf9be6ea6\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-ceilometerclient/commit/481cd7d33bf5f91c39888fa695238c562eda7945"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-ceilometerclient/commit/481cd7d33bf5f91c39888fa695238c562eda7945"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}