)]}'
{"id":"openstack%2Fpython-ceilometerclient~377157","triplet_id":"openstack%2Fpython-ceilometerclient~master~Iae83c4360336cf07b6045615ff38933f52844499","project":"openstack/python-ceilometerclient","branch":"master","hashtags":[],"change_id":"Iae83c4360336cf07b6045615ff38933f52844499","subject":"Using assertIsNone() instead of assertEqual(None)","status":"MERGED","created":"2016-09-27 02:14:35.000000000","updated":"2016-09-27 04:42:26.000000000","submitted":"2016-09-27 04:42:26.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"bca5d2de8a2ede96524701429c5cd308c7507d3b","_number":377157,"virtual_id_number":377157,"owner":{"_account_id":19935,"name":"Anh Tran","email":"anhtt@vn.fujitsu.com","username":"trananhkma"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":2,"date":"2016-09-27 04:42:26.000000000","post_submit":true,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"all":[{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":2,"date":"2016-09-27 04:00:11.000000000","_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"all":[{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":1,"date":"2016-09-27 04:00:11.000000000","_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2016-09-27 04:00:11.000000000","updated_by":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"reviewer":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"state":"REVIEWER"},{"updated":"2016-09-27 04:42:26.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"367809af159cd4a5c456369f1dff6b69508c0be0","author":{"_account_id":19935,"name":"Anh Tran","email":"anhtt@vn.fujitsu.com","username":"trananhkma"},"date":"2016-09-27 02:14:35.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"157db20edc7db5f7f816672eb546ab94e6267ae8","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-09-27 02:56:41.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-ceilometerclient-docs-ubuntu-xenial http://docs-draft.openstack.org/57/377157/1/check/gate-python-ceilometerclient-docs-ubuntu-xenial/231fecb//doc/build/html/ : SUCCESS in 3m 36s\n- gate-python-ceilometerclient-pep8-ubuntu-xenial http://logs.openstack.org/57/377157/1/check/gate-python-ceilometerclient-pep8-ubuntu-xenial/2f6458b/ : SUCCESS in 1m 57s\n- gate-python-ceilometerclient-python27-ubuntu-xenial http://logs.openstack.org/57/377157/1/check/gate-python-ceilometerclient-python27-ubuntu-xenial/4f2fedf/ : SUCCESS in 3m 32s\n- gate-python-ceilometerclient-python34 http://logs.openstack.org/57/377157/1/check/gate-python-ceilometerclient-python34/2e3fd9b/ : SUCCESS in 2m 22s\n- gate-python-ceilometerclient-python35 http://logs.openstack.org/57/377157/1/check/gate-python-ceilometerclient-python35/d640d63/ : SUCCESS in 3m 08s\n- gate-python-ceilometerclient-pypy http://logs.openstack.org/57/377157/1/check/gate-python-ceilometerclient-pypy/65872af/ : SUCCESS in 2m 33s (non-voting)\n- gate-tempest-dsvm-neutron-src-python-ceilometerclient-plugin http://logs.openstack.org/57/377157/1/check/gate-tempest-dsvm-neutron-src-python-ceilometerclient-plugin/801bf69/ : SUCCESS in 41m 54s\n- gate-ceilometerclient-dsvm-functional http://logs.openstack.org/57/377157/1/check/gate-ceilometerclient-dsvm-functional/60c0ba7/ : SUCCESS in 14m 17s\n- gate-ceilometerclient-dsvm-functional-identity-v3-only http://logs.openstack.org/57/377157/1/check/gate-ceilometerclient-dsvm-functional-identity-v3-only/900b794/ : SUCCESS in 14m 30s\n- gate-telemetry-dsvm-integration-python-ceilometerclient-ubuntu-xenial http://logs.openstack.org/57/377157/1/check/gate-telemetry-dsvm-integration-python-ceilometerclient-ubuntu-xenial/d62da83/ : SUCCESS in 32m 52s","accounts_in_message":[],"_revision_number":1},{"id":"c80bcccc397f201f694fb61576aaf2625a218f37","author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"date":"2016-09-27 04:00:11.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":1},{"id":"7c1431ccb43c3e055ce169e1781830ae09a56949","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-09-27 04:00:21.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":1},{"id":"e4a899722c220fa2981b0dc21d9604b11dca2d3a","date":"2016-09-27 04:42:26.000000000","message":"Change has been successfully merged into the git repository by Jenkins","accounts_in_message":[],"_revision_number":1},{"id":"bca5d2de8a2ede96524701429c5cd308c7507d3b","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2016-09-27 04:42:26.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- gate-python-ceilometerclient-docs-ubuntu-xenial http://docs-draft.openstack.org/57/377157/1/gate/gate-python-ceilometerclient-docs-ubuntu-xenial/093183e//doc/build/html/ : SUCCESS in 3m 44s\n- gate-python-ceilometerclient-pep8-ubuntu-xenial http://logs.openstack.org/57/377157/1/gate/gate-python-ceilometerclient-pep8-ubuntu-xenial/913cdeb/ : SUCCESS in 2m 27s\n- gate-python-ceilometerclient-python27-ubuntu-xenial http://logs.openstack.org/57/377157/1/gate/gate-python-ceilometerclient-python27-ubuntu-xenial/e60a248/ : SUCCESS in 3m 36s\n- gate-python-ceilometerclient-python34 http://logs.openstack.org/57/377157/1/gate/gate-python-ceilometerclient-python34/af81c75/ : SUCCESS in 2m 24s\n- gate-python-ceilometerclient-python35 http://logs.openstack.org/57/377157/1/gate/gate-python-ceilometerclient-python35/1918e79/ : SUCCESS in 3m 05s\n- gate-tempest-dsvm-neutron-src-python-ceilometerclient-plugin http://logs.openstack.org/57/377157/1/gate/gate-tempest-dsvm-neutron-src-python-ceilometerclient-plugin/ca19615/ : SUCCESS in 42m 04s\n- gate-ceilometerclient-dsvm-functional http://logs.openstack.org/57/377157/1/gate/gate-ceilometerclient-dsvm-functional/e4c1fdc/ : SUCCESS in 20m 13s\n- gate-ceilometerclient-dsvm-functional-identity-v3-only http://logs.openstack.org/57/377157/1/gate/gate-ceilometerclient-dsvm-functional-identity-v3-only/bfad1f9/ : SUCCESS in 14m 12s\n- gate-telemetry-dsvm-integration-python-ceilometerclient-ubuntu-xenial http://logs.openstack.org/57/377157/1/gate/gate-telemetry-dsvm-integration-python-ceilometerclient-ubuntu-xenial/3cfa9f7/ : SUCCESS in 29m 36s","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"6ed98bd6d67e730fc7dc652dcb020b2883e49916","revisions":{"6ed98bd6d67e730fc7dc652dcb020b2883e49916":{"kind":"REWORK","_number":1,"created":"2016-09-27 02:14:35.000000000","uploader":{"_account_id":19935,"name":"Anh Tran","email":"anhtt@vn.fujitsu.com","username":"trananhkma"},"ref":"refs/changes/57/377157/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-ceilometerclient","ref":"refs/changes/57/377157/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-ceilometerclient refs/changes/57/377157/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-ceilometerclient refs/changes/57/377157/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-ceilometerclient refs/changes/57/377157/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-ceilometerclient refs/changes/57/377157/1"}}},"commit":{"parents":[{"commit":"1c53f7d09837dc670e00886e201152e05084ed14","subject":"Replace assertEqual(None, ...) with assertIsNone(...)","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-ceilometerclient/commit/1c53f7d09837dc670e00886e201152e05084ed14"}]}],"author":{"name":"Anh Tran","email":"anhtt@vn.fujitsu.com","date":"2016-09-27 02:11:44.000000000","tz":420},"committer":{"name":"Anh Tran","email":"anhtt@vn.fujitsu.com","date":"2016-09-27 02:14:00.000000000","tz":420},"subject":"Using assertIsNone() instead of assertEqual(None)","message":"Using assertIsNone() instead of assertEqual(None)\n\nFollowing OpenStack Style Guidelines[1]:\n[H203] Unit test assertions tend to give better messages for more\nspecific assertions. As a result, assertIsNone(...) is preferred\nover assertEqual(None, ...) and assertIs(..,None)\n\n[1] http://docs.openstack.org/developer/hacking/#unit-tests-and-assertraises\n\nChange-Id: Iae83c4360336cf07b6045615ff38933f52844499\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-ceilometerclient/commit/6ed98bd6d67e730fc7dc652dcb020b2883e49916"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-ceilometerclient/commit/6ed98bd6d67e730fc7dc652dcb020b2883e49916"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}