)]}'
{"ceilometerclient/exc.py":[{"author":{"_account_id":19594,"name":"Yarko Tymciurak","email":"yarko.tymciurak@intel.com","username":"yarkot"},"change_message_id":"a56b298f9668de8a91e57b724af391b366571c0a","unresolved":false,"context_lines":[{"line_number":57,"context_line":"            if message:"},{"line_number":58,"context_line":"                message \u003d \" %s\" % message"},{"line_number":59,"context_line":"        return \"%s (HTTP %s)%s\" % (self.__class__.__name__, self.code,"},{"line_number":60,"context_line":"                                   message)"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"class HTTPMultipleChoices(HTTPException):"}],"source_content_type":"text/x-python","patch_set":4,"id":"1a95cdbc_6a0e158d","line":60,"updated":"2016-10-10 07:33:57.000000000","message":"I had a hard time reading through this, wished it were simpler.\nMaybe this is a nit, but how about something like this:\n\ndef __str__(self):\n    message \u003d self.details or \"\"\n    if message:\n        try:\n           data \u003d json.loads(message)\n           message \u003d data.get(\"error_message\", \"\")\n           message \u003d \"ERROR %s\" % message[\"faultstring\"]\n        except (Keyerror, ValueError, TypeError, AttributeError):\n            pass\n...","commit_id":"b8a78396b273c23ba7a633d98365a5dfc969b1f2"},{"author":{"_account_id":2813,"name":"Mehdi Abaakouk","email":"sileht@sileht.net","username":"sileht"},"change_message_id":"2e757c4a110acb4a4cb67196400d3681acafc21f","unresolved":false,"context_lines":[{"line_number":57,"context_line":"            if message:"},{"line_number":58,"context_line":"                message \u003d \" %s\" % message"},{"line_number":59,"context_line":"        return \"%s (HTTP %s)%s\" % (self.__class__.__name__, self.code,"},{"line_number":60,"context_line":"                                   message)"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"class HTTPMultipleChoices(HTTPException):"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa6399be_2eca31a2","line":60,"in_reply_to":"1a95cdbc_6a0e158d","updated":"2016-10-11 07:13:36.000000000","message":"Don\u0027t -1 for nit. The previous code is already ugly, I don\u0027t get why we catch TypeError, AttributeError that why I haven\u0027t removed them.\n\nExplicit checking is always better than catching generic exception special when try/catch is around multiple lines.\n\nAnyways is lib will be deprecated soon. This is just basic maintenance.","commit_id":"b8a78396b273c23ba7a633d98365a5dfc969b1f2"}]}