)]}'
{"ceilometerclient/common/http.py":[{"author":{"_account_id":4715,"name":"Angus Salkeld","email":"asalkeld@redhat.com","username":"asalkeld"},"change_message_id":"946f9dcc9fc6c7523fbd4a5ebaf637b82e70119b","unresolved":false,"context_lines":[{"line_number":53,"context_line":"        self._auth_token \u003d kwargs.get(\u0027token\u0027)"},{"line_number":54,"context_line":"        self.connection_params \u003d self.get_connection_params(endpoint, **kwargs)"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"    @property"},{"line_number":57,"context_line":"    def auth_token(self):"},{"line_number":58,"context_line":"        return self._auth_token()"},{"line_number":59,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAQn%2F%2FUeA%3D","line":56,"updated":"2013-08-02 00:26:12.000000000","message":"I think this should NOT be a property it is misleading and makes it less obvious what is happening. IMO there are very few valid/helpful uses of @property. You could probably reduce the lambda madness in the previous file too.","commit_id":"e2e0d75e559dc18e85126c95479bb8925b92f698"},{"author":{"_account_id":2284,"name":"Eoghan Glynn","email":"eglynn@redhat.com","username":"eglynn"},"change_message_id":"5d2f0dc205c4e605c8781b115c4c3e7595646b94","unresolved":false,"context_lines":[{"line_number":53,"context_line":"        self._auth_token \u003d kwargs.get(\u0027token\u0027)"},{"line_number":54,"context_line":"        self.connection_params \u003d self.get_connection_params(endpoint, **kwargs)"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"    @property"},{"line_number":57,"context_line":"    def auth_token(self):"},{"line_number":58,"context_line":"        return self._auth_token()"},{"line_number":59,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAQn%2F%2FTk8%3D","line":56,"in_reply_to":"AAAAQn%2F%2FUeA%3D","updated":"2013-08-02 06:53:08.000000000","message":"Well the purpose of using @property is simply to make pre-existing usage of self.auth_token look the same as before. But yeah, I take your point, I could just s/self.auth_token/self.auth_token()/ if that\u0027s considered clearer.\n\nIn terms of the lambda madness, wrapping the keystoneclient.auth_token property in a lambda is the key to ensuring that it\u0027s re-evaluated each time it\u0027s accessed, so that the internal will_expire_soon() logic is hit each time.\n\nWell wrapping the keystoneclient auth_token in a lambda was the neatest python-y way to do this that I could come up with at least.","commit_id":"e2e0d75e559dc18e85126c95479bb8925b92f698"}]}