)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":1669,"name":"Julien Danjou","display_name":"jd","email":"julien@danjou.info","username":"jdanjou"},"change_message_id":"9bb433a6c6d9a403f7908298d7dbad9d0c5993c0","unresolved":false,"context_lines":[{"line_number":12,"context_line":""},{"line_number":13,"context_line":"value is often like fdc79c4b63e8492d98271412320e8672"},{"line_number":14,"context_line":"so when change this code to set it as None."},{"line_number":15,"context_line":"close-bug: 1679934"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Change-Id: I95c994406ed7a0b15ba6446e80f01e4f6787ec20"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"9ff52f3f_8d67a026","line":15,"updated":"2017-04-13 10:41:46.000000000","message":"Closes-Bug: #1679934","commit_id":"84b15cf842d2611d9490a4ba8c38dda001db6ce7"}],"ceilometerclient/client.py":[{"author":{"_account_id":13478,"name":"Boris Bobrov","email":"b.bobrov@sap.com","username":"bbobrov"},"change_message_id":"c3ff9dbde8d5534a4df57c117a6d6010bbdaf64a","unresolved":false,"context_lines":[{"line_number":95,"context_line":"    project_domain_id \u003d kwargs.pop(\u0027project_domain_id\u0027, None)"},{"line_number":96,"context_line":"    if v3_auth_url:"},{"line_number":97,"context_line":"        if not user_domain_id:"},{"line_number":98,"context_line":"            user_domain_id \u003d None"},{"line_number":99,"context_line":"        if not user_domain_name:"},{"line_number":100,"context_line":"            user_domain_name \u003d \u0027default\u0027"},{"line_number":101,"context_line":"        if not project_domain_id:"}],"source_content_type":"text/x-python","patch_set":1,"id":"dfeb2761_f3f67cd7","line":98,"range":{"start_line":98,"start_character":12,"end_line":98,"end_character":33},"updated":"2017-04-05 07:04:17.000000000","message":"oh wow, no. user_domain_id should always have some non-None value. I think this code was fine before the change","commit_id":"cfd43e01b00d676f5806e1f18974e2ca44985625"},{"author":{"_account_id":13478,"name":"Boris Bobrov","email":"b.bobrov@sap.com","username":"bbobrov"},"change_message_id":"c3ff9dbde8d5534a4df57c117a6d6010bbdaf64a","unresolved":false,"context_lines":[{"line_number":97,"context_line":"        if not user_domain_id:"},{"line_number":98,"context_line":"            user_domain_id \u003d None"},{"line_number":99,"context_line":"        if not user_domain_name:"},{"line_number":100,"context_line":"            user_domain_name \u003d \u0027default\u0027"},{"line_number":101,"context_line":"        if not project_domain_id:"},{"line_number":102,"context_line":"            project_domain_id \u003d None"},{"line_number":103,"context_line":"        if not project_domain_name:"}],"source_content_type":"text/x-python","patch_set":1,"id":"dfeb2761_f3e43c0f","line":100,"range":{"start_line":100,"start_character":12,"end_line":100,"end_character":40},"updated":"2017-04-05 07:04:17.000000000","message":"and this actually wasn\u0027t. Because domain name is usually \"Default\" (note the the case)","commit_id":"cfd43e01b00d676f5806e1f18974e2ca44985625"},{"author":{"_account_id":13478,"name":"Boris Bobrov","email":"b.bobrov@sap.com","username":"bbobrov"},"change_message_id":"c3ff9dbde8d5534a4df57c117a6d6010bbdaf64a","unresolved":false,"context_lines":[{"line_number":101,"context_line":"        if not project_domain_id:"},{"line_number":102,"context_line":"            project_domain_id \u003d None"},{"line_number":103,"context_line":"        if not project_domain_name:"},{"line_number":104,"context_line":"            project_domain_name \u003d \u0027default\u0027"},{"line_number":105,"context_line":"    auth \u003d None"},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"    use_domain \u003d (user_domain_id or user_domain_name or"}],"source_content_type":"text/x-python","patch_set":1,"id":"dfeb2761_73c26c5b","line":104,"range":{"start_line":104,"start_character":0,"end_line":104,"end_character":43},"updated":"2017-04-05 07:04:17.000000000","message":"this should be fixed too","commit_id":"cfd43e01b00d676f5806e1f18974e2ca44985625"},{"author":{"_account_id":13478,"name":"Boris Bobrov","email":"b.bobrov@sap.com","username":"bbobrov"},"change_message_id":"d740a9c005c8e5aac852b3865e3e73b047dc9abc","unresolved":false,"context_lines":[{"line_number":99,"context_line":"        if not user_domain_name:"},{"line_number":100,"context_line":"            user_domain_name \u003d \u0027default\u0027"},{"line_number":101,"context_line":"        if not project_domain_id:"},{"line_number":102,"context_line":"            project_domain_id \u003d None"},{"line_number":103,"context_line":"        if not project_domain_name:"},{"line_number":104,"context_line":"            project_domain_name \u003d \u0027default\u0027"},{"line_number":105,"context_line":"    auth \u003d None"}],"source_content_type":"text/x-python","patch_set":2,"id":"dfeb2761_d34c98c9","line":102,"range":{"start_line":102,"start_character":12,"end_line":102,"end_character":36},"updated":"2017-04-05 07:16:33.000000000","message":"this shouldn\u0027t be done too. Project is always in a domain.","commit_id":"b20d29ac124eb25017fdd8665e45a83475835be0"},{"author":{"_account_id":1669,"name":"Julien Danjou","display_name":"jd","email":"julien@danjou.info","username":"jdanjou"},"change_message_id":"9bb433a6c6d9a403f7908298d7dbad9d0c5993c0","unresolved":false,"context_lines":[{"line_number":94,"context_line":"    project_domain_name \u003d kwargs.pop(\u0027project_domain_name\u0027, None)"},{"line_number":95,"context_line":"    project_domain_id \u003d kwargs.pop(\u0027project_domain_id\u0027, None)"},{"line_number":96,"context_line":"    if v3_auth_url:"},{"line_number":97,"context_line":"        if not user_domain_id:"},{"line_number":98,"context_line":"            user_domain_id \u003d None"},{"line_number":99,"context_line":"        if not user_domain_name:"},{"line_number":100,"context_line":"            user_domain_name \u003d \u0027default\u0027"},{"line_number":101,"context_line":"        if not project_domain_id:"}],"source_content_type":"text/x-python","patch_set":3,"id":"9ff52f3f_6d6c5c08","line":98,"range":{"start_line":97,"start_character":7,"end_line":98,"end_character":33},"updated":"2017-04-13 10:41:46.000000000","message":"u can just remove those lines entirely","commit_id":"84b15cf842d2611d9490a4ba8c38dda001db6ce7"},{"author":{"_account_id":1669,"name":"Julien Danjou","display_name":"jd","email":"julien@danjou.info","username":"jdanjou"},"change_message_id":"9bb433a6c6d9a403f7908298d7dbad9d0c5993c0","unresolved":false,"context_lines":[{"line_number":96,"context_line":"    if v3_auth_url:"},{"line_number":97,"context_line":"        if not user_domain_id:"},{"line_number":98,"context_line":"            user_domain_id \u003d None"},{"line_number":99,"context_line":"        if not user_domain_name:"},{"line_number":100,"context_line":"            user_domain_name \u003d \u0027default\u0027"},{"line_number":101,"context_line":"        if not project_domain_id:"},{"line_number":102,"context_line":"            project_domain_id \u003d None"},{"line_number":103,"context_line":"        if not project_domain_name:"}],"source_content_type":"text/x-python","patch_set":3,"id":"9ff52f3f_2d7654da","line":100,"range":{"start_line":99,"start_character":7,"end_line":100,"end_character":40},"updated":"2017-04-13 10:41:46.000000000","message":"i guess this could be a problem?","commit_id":"84b15cf842d2611d9490a4ba8c38dda001db6ce7"},{"author":{"_account_id":1669,"name":"Julien Danjou","display_name":"jd","email":"julien@danjou.info","username":"jdanjou"},"change_message_id":"9bb433a6c6d9a403f7908298d7dbad9d0c5993c0","unresolved":false,"context_lines":[{"line_number":98,"context_line":"            user_domain_id \u003d None"},{"line_number":99,"context_line":"        if not user_domain_name:"},{"line_number":100,"context_line":"            user_domain_name \u003d \u0027default\u0027"},{"line_number":101,"context_line":"        if not project_domain_id:"},{"line_number":102,"context_line":"            project_domain_id \u003d None"},{"line_number":103,"context_line":"        if not project_domain_name:"},{"line_number":104,"context_line":"            project_domain_name \u003d \u0027default\u0027"},{"line_number":105,"context_line":"    auth \u003d None"}],"source_content_type":"text/x-python","patch_set":3,"id":"9ff52f3f_4d7198e0","line":102,"range":{"start_line":101,"start_character":7,"end_line":102,"end_character":36},"updated":"2017-04-13 10:41:46.000000000","message":"remove all of that too","commit_id":"84b15cf842d2611d9490a4ba8c38dda001db6ce7"},{"author":{"_account_id":1669,"name":"Julien Danjou","display_name":"jd","email":"julien@danjou.info","username":"jdanjou"},"change_message_id":"9bb433a6c6d9a403f7908298d7dbad9d0c5993c0","unresolved":false,"context_lines":[{"line_number":101,"context_line":"        if not project_domain_id:"},{"line_number":102,"context_line":"            project_domain_id \u003d None"},{"line_number":103,"context_line":"        if not project_domain_name:"},{"line_number":104,"context_line":"            project_domain_name \u003d \u0027default\u0027"},{"line_number":105,"context_line":"    auth \u003d None"},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"    use_domain \u003d (user_domain_id or user_domain_name or"}],"source_content_type":"text/x-python","patch_set":3,"id":"9ff52f3f_0d7390e9","line":104,"updated":"2017-04-13 10:41:46.000000000","message":"same question","commit_id":"84b15cf842d2611d9490a4ba8c38dda001db6ce7"},{"author":{"_account_id":2813,"name":"Mehdi Abaakouk","email":"sileht@sileht.net","username":"sileht"},"change_message_id":"158b84746a06bc170334c54af840599bdfce354f","unresolved":false,"context_lines":[{"line_number":97,"context_line":"        if not user_domain_id:"},{"line_number":98,"context_line":"            user_domain_id \u003d \u0027default\u0027"},{"line_number":99,"context_line":"        if not user_domain_name:"},{"line_number":100,"context_line":"            user_domain_name \u003d \u0027default\u0027"},{"line_number":101,"context_line":"        if not project_domain_id:"},{"line_number":102,"context_line":"            project_domain_id \u003d \u0027default\u0027"},{"line_number":103,"context_line":"        if not project_domain_name:"}],"source_content_type":"text/x-python","patch_set":6,"id":"3f044301_9f7761d5","side":"PARENT","line":100,"range":{"start_line":100,"start_character":32,"end_line":100,"end_character":39},"updated":"2017-05-09 14:02:22.000000000","message":"This will reintroduce the original problem I guess.\n\nTo fix both, this should be \u0027Default\u0027 not \u0027default\u0027 according devstack and the install doc.\n\nhttps://github.com/openstack-dev/devstack/blob/6612f66374303e552a148f98c11714eb588e4870/lib/keystone#L103\n\nhttps://docs.openstack.org/ocata/install-guide-ubuntu/keystone-install.html","commit_id":"6fcc675245677d581e7aca86757f2f9646d84210"}]}