)]}'
{"ceilometerclient/client.py":[{"author":{"_account_id":7203,"name":"yuuichi fujioka","email":"fujioka.yuuichi@gmail.com","username":"FujiokaYuuichi"},"change_message_id":"04094158d6de79fd36c6cdc4a4a34124df3a9e88","unresolved":false,"context_lines":[{"line_number":61,"context_line":"    if kwargs.get(\u0027os_auth_token\u0027) and kwargs.get(\u0027ceilometer_url\u0027):"},{"line_number":62,"context_line":"        token \u003d ((kwargs.get(\u0027os_auth_token\u0027))"},{"line_number":63,"context_line":"                 if isinstance(kwargs.get(\u0027os_auth_token\u0027), type(lambda: None))"},{"line_number":64,"context_line":"                 and kwargs.get(\u0027os_auth_token\u0027).__name__ \u003d\u003d \u0027\u003clambda\u003e\u0027"},{"line_number":65,"context_line":"                 else (lambda: kwargs.get(\u0027os_auth_token\u0027)))"},{"line_number":66,"context_line":"        endpoint \u003d kwargs.get(\u0027ceilometer_url\u0027)"},{"line_number":67,"context_line":"    elif (kwargs.get(\u0027os_username\u0027) and"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAATn%2F%2BhNo%3D","line":64,"updated":"2013-11-25 08:15:25.000000000","message":"If the os_auth_token is function(not lambda), ceilometer.common.http.HTTPClient would throw exception.\n\nHow about\n\n import six\n\n token \u003d kwargs.get(\u0027os_auth_token\u0027)\n token \u003d (token if six.callable(token) else lambda: token)","commit_id":"ef3c7a6c2569f15cec4dfe91b8f5595a54412af8"},{"author":{"_account_id":4491,"name":"Lianhao Lu","email":"llh_misc@outlook.com","username":"lianhao-lu"},"change_message_id":"27fed1e860cca88e67e7167b4ef8f716366bcde2","unresolved":false,"context_lines":[{"line_number":10,"context_line":"#    License for the specific language governing permissions and limitations"},{"line_number":11,"context_line":"#    under the License."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"from ceilometerclient.common import utils"},{"line_number":14,"context_line":"from keystoneclient.v2_0 import client as ksclient"},{"line_number":15,"context_line":"import six"},{"line_number":16,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAATn%2F%2BQzQ%3D","line":13,"updated":"2013-11-28 08:00:20.000000000","message":"ceilometerclient module should be imported last with a empty line separating the other 2 modules.\n\nPlease see http://docs.openstack.org/developer/hacking/#imports","commit_id":"cebdc3e02c950d0ce20e5734c7b9040a2a3725b7"},{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"698e6f2581add00dc7cfe5ffbec7bf8062debd5a","unresolved":false,"context_lines":[{"line_number":62,"context_line":"    \"\"\""},{"line_number":63,"context_line":"    if kwargs.get(\u0027os_auth_token\u0027) and kwargs.get(\u0027ceilometer_url\u0027):"},{"line_number":64,"context_line":"        token \u003d kwargs.get(\u0027os_auth_token\u0027)"},{"line_number":65,"context_line":"        token \u003d (token if six.callable(token) else lambda: token)"},{"line_number":66,"context_line":"        endpoint \u003d kwargs.get(\u0027ceilometer_url\u0027)"},{"line_number":67,"context_line":"    elif (kwargs.get(\u0027os_username\u0027) and"},{"line_number":68,"context_line":"          kwargs.get(\u0027os_password\u0027) and"}],"source_content_type":"text/x-python","patch_set":8,"id":"AAAAUH%2F9u1U%3D","line":65,"updated":"2014-02-04 15:40:04.000000000","message":"might be better if we build this outside of if/elif so that we can check if token is callable for this case and the one below. doesn\u0027t seem right we only check here and assume it isn\u0027t callable below","commit_id":"fad3c5a9f690de0b280263be5bb0378d19587840"},{"author":{"_account_id":9100,"name":"Marc Solanas","email":"msolanas@cisco.com","username":"msolanas"},"change_message_id":"b900942a0c8daffe82e41d914c379b74ba614c8f","unresolved":false,"context_lines":[{"line_number":62,"context_line":"    \"\"\""},{"line_number":63,"context_line":"    if kwargs.get(\u0027os_auth_token\u0027) and kwargs.get(\u0027ceilometer_url\u0027):"},{"line_number":64,"context_line":"        token \u003d kwargs.get(\u0027os_auth_token\u0027)"},{"line_number":65,"context_line":"        token \u003d (token if six.callable(token) else lambda: token)"},{"line_number":66,"context_line":"        endpoint \u003d kwargs.get(\u0027ceilometer_url\u0027)"},{"line_number":67,"context_line":"    elif (kwargs.get(\u0027os_username\u0027) and"},{"line_number":68,"context_line":"          kwargs.get(\u0027os_password\u0027) and"}],"source_content_type":"text/x-python","patch_set":8,"id":"AAAAUH%2F9tsc%3D","line":65,"in_reply_to":"AAAAUH%2F9u1U%3D","updated":"2014-02-04 18:41:05.000000000","message":"Done","commit_id":"fad3c5a9f690de0b280263be5bb0378d19587840"},{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"4d87066f9a5d0e81587cae05173b90245201e54a","unresolved":false,"context_lines":[{"line_number":85,"context_line":"        }"},{"line_number":86,"context_line":"        _ksclient \u003d _get_ksclient(**ks_kwargs)"},{"line_number":87,"context_line":"        if not token:"},{"line_number":88,"context_line":"            token \u003d lambda: _ksclient.auth_token"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"        endpoint \u003d kwargs.get(\u0027ceilometer_url\u0027) or \\"},{"line_number":91,"context_line":"            _get_endpoint(_ksclient, **ks_kwargs)"}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAAUH%2F9tkg%3D","line":88,"updated":"2014-02-04 18:54:41.000000000","message":"this could be token \u003d token or lambda: _ksclient.auth_token","commit_id":"acb385adb01fe930dab3c74217f15be8da97e7ef"}],"ceilometerclient/tests/test_client.py":[{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"57d7ec6c66eab71cbf99df37c3ee21b24acbc259","unresolved":false,"context_lines":[{"line_number":27,"context_line":""},{"line_number":28,"context_line":"class ClientTest(utils.BaseTestCase):"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"    def create_client(self, api_version\u003d1, exclude\u003d[]):"},{"line_number":31,"context_line":"        env \u003d dict((k, v) for k, v in FAKE_ENV.items() if k not in exclude)"},{"line_number":32,"context_line":"        return client.get_client(api_version, **env)"},{"line_number":33,"context_line":""}],"source_content_type":"text/x-python","patch_set":12,"id":"AAAAWH%2F%2F0Bs%3D","line":30,"updated":"2014-03-13 16:44:17.000000000","message":"what\u0027s exclude param for? future work?","commit_id":"190426e3e9b9d128baa81197b7a55a0b3bf79be4"},{"author":{"_account_id":9100,"name":"Marc Solanas","email":"msolanas@cisco.com","username":"msolanas"},"change_message_id":"09b2c20130b9de796497159a22d7c578cedb8669","unresolved":false,"context_lines":[{"line_number":27,"context_line":""},{"line_number":28,"context_line":"class ClientTest(utils.BaseTestCase):"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"    def create_client(self, api_version\u003d1, exclude\u003d[]):"},{"line_number":31,"context_line":"        env \u003d dict((k, v) for k, v in FAKE_ENV.items() if k not in exclude)"},{"line_number":32,"context_line":"        return client.get_client(api_version, **env)"},{"line_number":33,"context_line":""}],"source_content_type":"text/x-python","patch_set":12,"id":"AAAAWH%2F%2Fz7s%3D","line":30,"in_reply_to":"AAAAWH%2F%2F0Bs%3D","updated":"2014-03-13 16:56:15.000000000","message":"Yes, it is there for future tests.","commit_id":"190426e3e9b9d128baa81197b7a55a0b3bf79be4"},{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"57d7ec6c66eab71cbf99df37c3ee21b24acbc259","unresolved":false,"context_lines":[{"line_number":36,"context_line":""},{"line_number":37,"context_line":"    def test_client_version(self):"},{"line_number":38,"context_line":"        c1 \u003d self.create_client(api_version\u003d1)"},{"line_number":39,"context_line":"        self.assertEqual(isinstance(c1, v1client.Client), True)"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"        c2 \u003d self.create_client(api_version\u003d2)"},{"line_number":42,"context_line":"        self.assertEqual(isinstance(c2, v2client.Client), True)"}],"source_content_type":"text/x-python","patch_set":12,"id":"AAAAWH%2F%2F0D0%3D","line":39,"updated":"2014-03-13 16:44:17.000000000","message":"use assertIsInstance(obj, class) instance of assertEqual..\n\nsame for below","commit_id":"190426e3e9b9d128baa81197b7a55a0b3bf79be4"},{"author":{"_account_id":9100,"name":"Marc Solanas","email":"msolanas@cisco.com","username":"msolanas"},"change_message_id":"09b2c20130b9de796497159a22d7c578cedb8669","unresolved":false,"context_lines":[{"line_number":36,"context_line":""},{"line_number":37,"context_line":"    def test_client_version(self):"},{"line_number":38,"context_line":"        c1 \u003d self.create_client(api_version\u003d1)"},{"line_number":39,"context_line":"        self.assertEqual(isinstance(c1, v1client.Client), True)"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"        c2 \u003d self.create_client(api_version\u003d2)"},{"line_number":42,"context_line":"        self.assertEqual(isinstance(c2, v2client.Client), True)"}],"source_content_type":"text/x-python","patch_set":12,"id":"AAAAWH%2F%2Fz7o%3D","line":39,"in_reply_to":"AAAAWH%2F%2F0D0%3D","updated":"2014-03-13 16:56:15.000000000","message":"Done","commit_id":"190426e3e9b9d128baa81197b7a55a0b3bf79be4"},{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"5fa0d7673ba5c509b5255af3a53329236f162058","unresolved":false,"context_lines":[{"line_number":27,"context_line":""},{"line_number":28,"context_line":"class ClientTest(utils.BaseTestCase):"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"    def create_client(self, api_version\u003d1, exclude\u003d[]):"},{"line_number":31,"context_line":"        env \u003d dict((k, v) for k, v in FAKE_ENV.items() if k not in exclude)"},{"line_number":32,"context_line":"        return client.get_client(api_version, **env)"},{"line_number":33,"context_line":""}],"source_content_type":"text/x-python","patch_set":14,"id":"AAAAWH%2F%2Fvk0%3D","line":30,"updated":"2014-03-14 03:25:54.000000000","message":"not important but if you do have to upload a new patch, can you default this to api_version\u003d2, just so we\u0027re using current.","commit_id":"a0ba6240e1ea88dfd760fecc7ef5273c9782a330"},{"author":{"_account_id":9100,"name":"Marc Solanas","email":"msolanas@cisco.com","username":"msolanas"},"change_message_id":"379fa34da50342692b7cea23e411a687bdc66aa7","unresolved":false,"context_lines":[{"line_number":27,"context_line":""},{"line_number":28,"context_line":"class ClientTest(utils.BaseTestCase):"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"    def create_client(self, api_version\u003d1, exclude\u003d[]):"},{"line_number":31,"context_line":"        env \u003d dict((k, v) for k, v in FAKE_ENV.items() if k not in exclude)"},{"line_number":32,"context_line":"        return client.get_client(api_version, **env)"},{"line_number":33,"context_line":""}],"source_content_type":"text/x-python","patch_set":14,"id":"AAAAWH%2F%2Fu1w%3D","line":30,"in_reply_to":"AAAAWH%2F%2Fvk0%3D","updated":"2014-03-14 06:12:02.000000000","message":"Done","commit_id":"a0ba6240e1ea88dfd760fecc7ef5273c9782a330"}]}