)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6676,"name":"zqfan","email":"aji.zqfan@gmail.com","username":"aji-zqfan"},"change_message_id":"1dbc60794ec17a9c481343b9c14a1dbb3b77a410","unresolved":false,"context_lines":[{"line_number":14,"context_line":"redundant parameter"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Change-Id: I1fbc85aa253929bfbb5e73ed834a725b9cf828b4"},{"line_number":17,"context_line":"Closes-bug: #1268557"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"AAAAUH%2F%2BfRw%3D","line":17,"updated":"2014-01-25 02:07:49.000000000","message":"DocImpact","commit_id":"4a16cf28b9739a07992559290b2b875f5b8d1969"},{"author":{"_account_id":3012,"name":"Dina Belova","email":"dbelova@mirantis.com","username":"dbelova"},"change_message_id":"a3c2a028aaec8c29c947da6e0c03fd6da822aa3d","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Reduce redundant parameter of some commands in CLI"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When deleting an alarm, we use \"ceilometer alarm-delete -a \u003cALARM_ID\u003e\""},{"line_number":10,"context_line":", unlike other deleting commands of openstack, the parameter-a/--alarm_id"},{"line_number":11,"context_line":"is redundant. The similar situations exist in showing alarm, geting alarm"},{"line_number":12,"context_line":"state, showing resource and so on."},{"line_number":13,"context_line":"It is more easy to use for reducing these parameters."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"AAAAXX%2F%2FsdE%3D","line":10,"updated":"2014-04-28 16:30:14.000000000","message":"may you please move comma to the previous line?","commit_id":"377f2788831e692eba641d2275b9445b2f19139a"},{"author":{"_account_id":3012,"name":"Dina Belova","email":"dbelova@mirantis.com","username":"dbelova"},"change_message_id":"a3c2a028aaec8c29c947da6e0c03fd6da822aa3d","unresolved":false,"context_lines":[{"line_number":10,"context_line":", unlike other deleting commands of openstack, the parameter-a/--alarm_id"},{"line_number":11,"context_line":"is redundant. The similar situations exist in showing alarm, geting alarm"},{"line_number":12,"context_line":"state, showing resource and so on."},{"line_number":13,"context_line":"It is more easy to use for reducing these parameters."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: I1fbc85aa253929bfbb5e73ed834a725b9cf828b4"},{"line_number":16,"context_line":"Closes-bug: #1268557"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"AAAAXX%2F%2Fsc4%3D","line":13,"updated":"2014-04-28 16:30:14.000000000","message":"word *easier* will be better here. And overall sentence I guess might look like \"Usage is easier and more user friendly without these params.\"","commit_id":"377f2788831e692eba641d2275b9445b2f19139a"},{"author":{"_account_id":7729,"name":"Ilya Tyaptin","email":"ityaptin@mirantis.com","username":"ityaptin"},"change_message_id":"354e483daf5409e7cb19e1607fef4a70288b2c26","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Reduce redundant parameter of some commands in CLI"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When deleting an alarm, we use \"ceilometer alarm-delete -a \u003cALARM_ID\u003e\""},{"line_number":10,"context_line":", unlike other deleting commands of openstack, the parameter-a/--alarm_id"},{"line_number":11,"context_line":"is redundant. The similar situations exist in showing alarm, geting alarm"},{"line_number":12,"context_line":"state, showing resource and so on."},{"line_number":13,"context_line":"It is more easy to use for reducing these parameters."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":11,"id":"7adec928_e1823951","line":10,"updated":"2014-05-23 14:14:14.000000000","message":"Please, add space between \u0027parameter\u0027 and \u0027-a\u0027","commit_id":"1db9f17d9499e97511ed71ab86aa949d96f20969"},{"author":{"_account_id":8290,"name":"liusheng","email":"liusheng2048@gmail.com","username":"LiuSheng"},"change_message_id":"1990682cddaa805218e7672b6df81f0e0bb60c9f","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Reduce redundant parameter of some commands in CLI"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When deleting an alarm, we use \"ceilometer alarm-delete -a \u003cALARM_ID\u003e\""},{"line_number":10,"context_line":", unlike other deleting commands of openstack, the parameter-a/--alarm_id"},{"line_number":11,"context_line":"is redundant. The similar situations exist in showing alarm, geting alarm"},{"line_number":12,"context_line":"state, showing resource and so on."},{"line_number":13,"context_line":"It is more easy to use for reducing these parameters."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":11,"id":"5adbc538_83464222","line":10,"in_reply_to":"7adec928_e1823951","updated":"2014-05-24 00:35:34.000000000","message":"Done","commit_id":"1db9f17d9499e97511ed71ab86aa949d96f20969"},{"author":{"_account_id":7729,"name":"Ilya Tyaptin","email":"ityaptin@mirantis.com","username":"ityaptin"},"change_message_id":"354e483daf5409e7cb19e1607fef4a70288b2c26","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When deleting an alarm, we use \"ceilometer alarm-delete -a \u003cALARM_ID\u003e\""},{"line_number":10,"context_line":", unlike other deleting commands of openstack, the parameter-a/--alarm_id"},{"line_number":11,"context_line":"is redundant. The similar situations exist in showing alarm, geting alarm"},{"line_number":12,"context_line":"state, showing resource and so on."},{"line_number":13,"context_line":"It is more easy to use for reducing these parameters."},{"line_number":14,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":11,"id":"7adec928_61af09e4","line":11,"updated":"2014-05-23 14:14:14.000000000","message":"Please, change \u0027geting\u0027 -\u003e \u0027getting\u0027.","commit_id":"1db9f17d9499e97511ed71ab86aa949d96f20969"},{"author":{"_account_id":8290,"name":"liusheng","email":"liusheng2048@gmail.com","username":"LiuSheng"},"change_message_id":"1990682cddaa805218e7672b6df81f0e0bb60c9f","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When deleting an alarm, we use \"ceilometer alarm-delete -a \u003cALARM_ID\u003e\""},{"line_number":10,"context_line":", unlike other deleting commands of openstack, the parameter-a/--alarm_id"},{"line_number":11,"context_line":"is redundant. The similar situations exist in showing alarm, geting alarm"},{"line_number":12,"context_line":"state, showing resource and so on."},{"line_number":13,"context_line":"It is more easy to use for reducing these parameters."},{"line_number":14,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":11,"id":"5adbc538_a34a5e25","line":11,"in_reply_to":"7adec928_61af09e4","updated":"2014-05-24 00:35:34.000000000","message":"Done","commit_id":"1db9f17d9499e97511ed71ab86aa949d96f20969"},{"author":{"_account_id":10987,"name":"Igor Degtiarov","username":"tovstun","inactive":true},"change_message_id":"3ba5a72f3c819bc2da2731a8f337dc2e7ede4aff","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Reduce redundant parameter of some commands in CLI"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When deleting an alarm, we use \"ceilometer alarm-delete -a \u003cALARM_ID\u003e\""},{"line_number":10,"context_line":", unlike other deleting commands of openstack, the parameter-a/--alarm_id"},{"line_number":11,"context_line":"is redundant. The similar situations exist in showing alarm, geting alarm"},{"line_number":12,"context_line":"state, showing resource and so on."},{"line_number":13,"context_line":"It is more easy to use for reducing these parameters."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":17,"id":"fa98f980_f2a1d646","line":10,"updated":"2014-09-12 11:37:54.000000000","message":"Please move comma on upper string","commit_id":"165abecb5f1113357c82ef0163282d881bd8ed1f"},{"author":{"_account_id":8290,"name":"liusheng","email":"liusheng2048@gmail.com","username":"LiuSheng"},"change_message_id":"ce75e73f1aef7a6b884ea8ff95e2e076a9fe1a13","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Reduce redundant parameter of some commands in CLI"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When deleting an alarm, we use \"ceilometer alarm-delete -a \u003cALARM_ID\u003e\""},{"line_number":10,"context_line":", unlike other deleting commands of openstack, the parameter-a/--alarm_id"},{"line_number":11,"context_line":"is redundant. The similar situations exist in showing alarm, geting alarm"},{"line_number":12,"context_line":"state, showing resource and so on."},{"line_number":13,"context_line":"It is more easy to use for reducing these parameters."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":17,"id":"fa98f980_ccb8ae77","line":10,"in_reply_to":"fa98f980_f2a1d646","updated":"2014-09-12 16:19:19.000000000","message":"Done","commit_id":"165abecb5f1113357c82ef0163282d881bd8ed1f"},{"author":{"_account_id":2284,"name":"Eoghan Glynn","email":"eglynn@redhat.com","username":"eglynn"},"change_message_id":"72dae57e114b36e5eea60bfb195d95fdfc1f4844","unresolved":false,"context_lines":[{"line_number":28,"context_line":"$ ceilometer alarm-show abcde"},{"line_number":29,"context_line":"Not Found (HTTP 404)"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"$ ceilometer alarm-show -a abcde"},{"line_number":32,"context_line":"-a is obsolete! See help for more details."},{"line_number":33,"context_line":"Not Found (HTTP 404)"},{"line_number":34,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":19,"id":"fa98f980_00bacee0","line":31,"updated":"2014-09-19 12:45:32.000000000","message":"For completeness, can you add an example with the long-form option also?\n\n  $ ceilometer alarm-show --alarm-id abcde","commit_id":"f500b0f14b6ea6938ad9ce96dd5a1eb57683055b"}],"ceilometerclient/shell.py":[{"author":{"_account_id":8290,"name":"liusheng","email":"liusheng2048@gmail.com","username":"LiuSheng"},"change_message_id":"86208ac8eebe1f1cad1161fc8a735be6c58cb342","unresolved":false,"context_lines":[{"line_number":257,"context_line":""},{"line_number":258,"context_line":"class HelpFormatter(argparse.HelpFormatter):"},{"line_number":259,"context_line":"    INDENT_BEFORE_ARGUMENTS \u003d 6"},{"line_number":260,"context_line":"    MAX_WIDTH_ARGUMENTS \u003d 32"},{"line_number":261,"context_line":""},{"line_number":262,"context_line":"    def add_arguments(self, actions):"},{"line_number":263,"context_line":"        for action in filter(lambda x: not x.option_strings, actions):"}],"source_content_type":"text/x-python","patch_set":17,"id":"fa98f980_a8c44892","side":"PARENT","line":260,"updated":"2014-09-12 04:16:52.000000000","message":"this add_arguments() method was redefined by change:https://review.openstack.org/#/c/97881/7, but the change will lead \"NoneType\" error if we use *positional* parameters in ceilometer CLI(previously, all parameters in ceilometer CLI are *optional* parameters , like:--alarm-id.). for this change ,we use positional parameters, so this method should be changed, the right change is reference to novaclient code(https://github.com/openstack/python-novaclient/blob/master/novaclient/shell.py#L785). and this change can also fix the bug the https://review.openstack.org/#/c/97881/7 fixed.","commit_id":"4cef2bf39a377759e22042609abb35aaad2da2b4"}],"ceilometerclient/tests/v2/test_shell.py":[{"author":{"_account_id":8290,"name":"liusheng","email":"liusheng2048@gmail.com","username":"LiuSheng"},"change_message_id":"86208ac8eebe1f1cad1161fc8a735be6c58cb342","unresolved":false,"context_lines":[{"line_number":825,"context_line":"    def test_alarm_show_with_empty_id(self):"},{"line_number":826,"context_line":"        self._test_alarm_action_with_empty_ids(\u0027alarm-show\u0027)"},{"line_number":827,"context_line":""},{"line_number":828,"context_line":"    def test_alarm_update_with_empty_id(self):"},{"line_number":829,"context_line":"        self._test_alarm_action_with_empty_ids(\u0027alarm-update\u0027)"},{"line_number":830,"context_line":""},{"line_number":831,"context_line":"    def test_alarm_threshold_update_with_empty_id(self):"}],"source_content_type":"text/x-python","patch_set":17,"id":"fa98f980_88430412","side":"PARENT","line":828,"updated":"2014-09-12 04:16:52.000000000","message":"remove this block, because in _test_entity_action_with_empty_value() method will add \"--\" to entity, that will lead failure when run UT.","commit_id":"4cef2bf39a377759e22042609abb35aaad2da2b4"}],"ceilometerclient/v2/shell.py":[{"author":{"_account_id":6676,"name":"zqfan","email":"aji.zqfan@gmail.com","username":"aji-zqfan"},"change_message_id":"1dbc60794ec17a9c481343b9c14a1dbb3b77a410","unresolved":false,"context_lines":[{"line_number":371,"context_line":"    _display_alarm(alarm)"},{"line_number":372,"context_line":""},{"line_number":373,"context_line":""},{"line_number":374,"context_line":"@utils.arg(\u0027-a\u0027, \u0027--alarm_id\u0027, metavar\u003d\u0027\u003cALARM_ID\u003e\u0027, required\u003dTrue,"},{"line_number":375,"context_line":"           help\u003d\u0027ID of the alarm to update.\u0027)"},{"line_number":376,"context_line":"@common_alarm_arguments()"},{"line_number":377,"context_line":"@utils.arg(\u0027--period\u0027, type\u003dint, metavar\u003d\u0027\u003cPERIOD\u003e\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAUH%2F%2BfS0%3D","line":374,"updated":"2014-01-25 02:07:49.000000000","message":"maybe this can be reduced too","commit_id":"4a16cf28b9739a07992559290b2b875f5b8d1969"},{"author":{"_account_id":8290,"name":"liusheng","email":"liusheng2048@gmail.com","username":"LiuSheng"},"change_message_id":"baeaef05386b31724760f6f7afa435a87af38bc4","unresolved":false,"context_lines":[{"line_number":371,"context_line":"    _display_alarm(alarm)"},{"line_number":372,"context_line":""},{"line_number":373,"context_line":""},{"line_number":374,"context_line":"@utils.arg(\u0027-a\u0027, \u0027--alarm_id\u0027, metavar\u003d\u0027\u003cALARM_ID\u003e\u0027, required\u003dTrue,"},{"line_number":375,"context_line":"           help\u003d\u0027ID of the alarm to update.\u0027)"},{"line_number":376,"context_line":"@common_alarm_arguments()"},{"line_number":377,"context_line":"@utils.arg(\u0027--period\u0027, type\u003dint, metavar\u003d\u0027\u003cPERIOD\u003e\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAUH%2F%2BdCM%3D","line":374,"in_reply_to":"AAAAUH%2F%2BfS0%3D","updated":"2014-01-26 03:25:21.000000000","message":"thanks for your reviewing, you are right!","commit_id":"4a16cf28b9739a07992559290b2b875f5b8d1969"},{"author":{"_account_id":6676,"name":"zqfan","email":"aji.zqfan@gmail.com","username":"aji-zqfan"},"change_message_id":"1dbc60794ec17a9c481343b9c14a1dbb3b77a410","unresolved":false,"context_lines":[{"line_number":406,"context_line":"    _display_alarm(alarm)"},{"line_number":407,"context_line":""},{"line_number":408,"context_line":""},{"line_number":409,"context_line":"@utils.arg(\u0027-a\u0027, \u0027--alarm_id\u0027, metavar\u003d\u0027\u003cALARM_ID\u003e\u0027, required\u003dTrue,"},{"line_number":410,"context_line":"           help\u003d\u0027ID of the alarm to update.\u0027)"},{"line_number":411,"context_line":"@common_alarm_arguments()"},{"line_number":412,"context_line":"@utils.arg(\u0027--meter-name\u0027, metavar\u003d\u0027\u003cMETRIC\u003e\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAUH%2F%2BfSo%3D","line":409,"updated":"2014-01-25 02:07:49.000000000","message":"ditto","commit_id":"4a16cf28b9739a07992559290b2b875f5b8d1969"},{"author":{"_account_id":6676,"name":"zqfan","email":"aji.zqfan@gmail.com","username":"aji-zqfan"},"change_message_id":"1dbc60794ec17a9c481343b9c14a1dbb3b77a410","unresolved":false,"context_lines":[{"line_number":450,"context_line":"    _display_alarm(alarm)"},{"line_number":451,"context_line":""},{"line_number":452,"context_line":""},{"line_number":453,"context_line":"@utils.arg(\u0027-a\u0027, \u0027--alarm_id\u0027, metavar\u003d\u0027\u003cALARM_ID\u003e\u0027, required\u003dTrue,"},{"line_number":454,"context_line":"           help\u003d\u0027ID of the alarm to update.\u0027)"},{"line_number":455,"context_line":"@common_alarm_arguments()"},{"line_number":456,"context_line":"@utils.arg(\u0027--alarm_ids\u0027, action\u003d\u0027append\u0027, metavar\u003d\u0027\u003cALARM IDS\u003e\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAUH%2F%2BfSQ%3D","line":453,"updated":"2014-01-25 02:07:49.000000000","message":"ditto","commit_id":"4a16cf28b9739a07992559290b2b875f5b8d1969"},{"author":{"_account_id":6676,"name":"zqfan","email":"aji.zqfan@gmail.com","username":"aji-zqfan"},"change_message_id":"1dbc60794ec17a9c481343b9c14a1dbb3b77a410","unresolved":false,"context_lines":[{"line_number":487,"context_line":"        raise exc.CommandError(\u0027Alarm not found: %s\u0027 % args.alarm_id)"},{"line_number":488,"context_line":""},{"line_number":489,"context_line":""},{"line_number":490,"context_line":"@utils.arg(\u0027-a\u0027, \u0027--alarm_id\u0027, metavar\u003d\u0027\u003cALARM_ID\u003e\u0027, required\u003dTrue,"},{"line_number":491,"context_line":"           help\u003d\u0027ID of the alarm state to set.\u0027)"},{"line_number":492,"context_line":"@utils.arg(\u0027--state\u0027, metavar\u003d\u0027\u003cSTATE\u003e\u0027, required\u003dTrue,"},{"line_number":493,"context_line":"           help\u003d\u0027State of the alarm, one of: \u0027 + str(ALARM_STATES))"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAUH%2F%2BfTU%3D","line":490,"updated":"2014-01-25 02:07:49.000000000","message":"ditto","commit_id":"4a16cf28b9739a07992559290b2b875f5b8d1969"},{"author":{"_account_id":6676,"name":"zqfan","email":"aji.zqfan@gmail.com","username":"aji-zqfan"},"change_message_id":"1dbc60794ec17a9c481343b9c14a1dbb3b77a410","unresolved":false,"context_lines":[{"line_number":511,"context_line":"    utils.print_dict({\u0027state\u0027: state}, wrap\u003d72)"},{"line_number":512,"context_line":""},{"line_number":513,"context_line":""},{"line_number":514,"context_line":"@utils.arg(\u0027-a\u0027, \u0027--alarm_id\u0027, metavar\u003d\u0027\u003cALARM_ID\u003e\u0027, required\u003dTrue,"},{"line_number":515,"context_line":"           help\u003d\u0027ID of the alarm for which history is shown.\u0027)"},{"line_number":516,"context_line":"@utils.arg(\u0027-q\u0027, \u0027--query\u0027, metavar\u003d\u0027\u003cQUERY\u003e\u0027,"},{"line_number":517,"context_line":"           help\u003d\u0027key[op]data_type::value; list. data_type is optional, \u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAUH%2F%2BfSA%3D","line":514,"updated":"2014-01-25 02:07:49.000000000","message":"ditto","commit_id":"4a16cf28b9739a07992559290b2b875f5b8d1969"},{"author":{"_account_id":6676,"name":"zqfan","email":"aji.zqfan@gmail.com","username":"aji-zqfan"},"change_message_id":"1dbc60794ec17a9c481343b9c14a1dbb3b77a410","unresolved":false,"context_lines":[{"line_number":574,"context_line":""},{"line_number":575,"context_line":""},{"line_number":576,"context_line":"@utils.arg(\u0027-m\u0027, \u0027--message_id\u0027, metavar\u003d\u0027\u003cmessage_id\u003e\u0027,"},{"line_number":577,"context_line":"           help\u003d\u0027The id of the event. Should be a UUID\u0027,"},{"line_number":578,"context_line":"           required\u003dTrue)"},{"line_number":579,"context_line":"def do_event_show(cc, args\u003d{}):"},{"line_number":580,"context_line":"    \u0027\u0027\u0027Show a particular event.\u0027\u0027\u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAUH%2F%2BfR0%3D","line":577,"updated":"2014-01-25 02:07:49.000000000","message":"how about reduced this too?","commit_id":"4a16cf28b9739a07992559290b2b875f5b8d1969"},{"author":{"_account_id":2284,"name":"Eoghan Glynn","email":"eglynn@redhat.com","username":"eglynn"},"change_message_id":"c47708f6a4940e6eac20501652bc620530937f5b","unresolved":false,"context_lines":[{"line_number":61,"context_line":"    class ObsoletedByAction(argparse.Action):"},{"line_number":62,"context_line":"        def __call__(self, parser, namespace, values, option_string\u003dNone):"},{"line_number":63,"context_line":"            old_dest \u003d option_string or self.dest"},{"line_number":64,"context_line":"            print(\u0027%s is obsolete! See help for more details.\u0027 % old_dest)"},{"line_number":65,"context_line":"            setattr(namespace, new_dest, values)"},{"line_number":66,"context_line":"    return ObsoletedByAction"},{"line_number":67,"context_line":""}],"source_content_type":"text/x-python","patch_set":21,"id":"fa98f980_80887ec7","line":64,"updated":"2014-09-19 13:06:02.000000000","message":"Is \"obsolete\" a bit strong here, as it\u0027s still supported?\n\nHow about \"--alarm-id is deprecated\" instead?","commit_id":"97e9c254e3e7113bb096be689fa9159293b3920b"}]}