)]}'
{"id":"openstack%2Fpython-ceilometerclient~67641","triplet_id":"openstack%2Fpython-ceilometerclient~master~Idd931d27b13a46800e27393a98da096d41442320","project":"openstack/python-ceilometerclient","branch":"master","topic":"bug/1268480","hashtags":[],"change_id":"Idd931d27b13a46800e27393a98da096d41442320","subject":"replace assertTrue(isinstance) to assertIsInstance","status":"MERGED","created":"2014-01-18 07:22:46.000000000","updated":"2014-01-23 03:10:16.000000000","submitted":"2014-01-23 03:10:16.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":1,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"34e1d97bc4c6779a688882b6914eca2ce6e3199c","_number":67641,"virtual_id_number":67641,"owner":{"_account_id":8290,"name":"liusheng","email":"liusheng2048@gmail.com","username":"LiuSheng"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":0,"_account_id":8289,"name":"huangtianhua","email":"tiantian223@163.com","username":"huangtianhua"},{"value":0,"_account_id":8290,"name":"liusheng","email":"liusheng2048@gmail.com","username":"LiuSheng"},{"value":2,"date":"2014-01-23 03:10:16.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":6676,"name":"zqfan","email":"aji.zqfan@gmail.com","username":"aji-zqfan"},{"value":0,"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},{"value":0,"_account_id":2813,"name":"Mehdi Abaakouk","email":"sileht@sileht.net","username":"sileht"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"recommended":{"_account_id":6676,"name":"zqfan","email":"aji.zqfan@gmail.com","username":"aji-zqfan"},"all":[{"value":1,"date":"2014-01-21 02:11:10.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":8289,"name":"huangtianhua","email":"tiantian223@163.com","username":"huangtianhua"},{"value":0,"_account_id":8290,"name":"liusheng","email":"liusheng2048@gmail.com","username":"LiuSheng"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":1,"date":"2014-01-18 07:34:04.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":6676,"name":"zqfan","email":"aji.zqfan@gmail.com","username":"aji-zqfan"},{"value":2,"date":"2014-01-20 15:51:11.000000000","_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},{"value":2,"date":"2014-01-21 08:03:33.000000000","_account_id":2813,"name":"Mehdi Abaakouk","email":"sileht@sileht.net","username":"sileht"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":1,"default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":2813,"name":"Mehdi Abaakouk","email":"sileht@sileht.net","username":"sileht"},"all":[{"value":0,"_account_id":8289,"name":"huangtianhua","email":"tiantian223@163.com","username":"huangtianhua"},{"value":0,"date":"2014-01-18 07:29:02.000000000","_account_id":8290,"name":"liusheng","email":"liusheng2048@gmail.com","username":"LiuSheng"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":6676,"name":"zqfan","email":"aji.zqfan@gmail.com","username":"aji-zqfan"},{"value":0,"date":"2014-01-20 15:51:11.000000000","_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},{"value":1,"date":"2014-01-21 08:03:33.000000000","_account_id":2813,"name":"Mehdi Abaakouk","email":"sileht@sileht.net","username":"sileht"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":2813,"name":"Mehdi Abaakouk","email":"sileht@sileht.net","username":"sileht"},{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},{"_account_id":6676,"name":"zqfan","email":"aji.zqfan@gmail.com","username":"aji-zqfan"},{"_account_id":8289,"name":"huangtianhua","email":"tiantian223@163.com","username":"huangtianhua"},{"_account_id":8290,"name":"liusheng","email":"liusheng2048@gmail.com","username":"LiuSheng"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2014-01-18 07:34:04.000000000","updated_by":{"_account_id":6676,"name":"zqfan","email":"aji.zqfan@gmail.com","username":"aji-zqfan"},"reviewer":{"_account_id":6676,"name":"zqfan","email":"aji.zqfan@gmail.com","username":"aji-zqfan"},"state":"REVIEWER"},{"updated":"2014-01-20 15:51:11.000000000","updated_by":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"reviewer":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"state":"REVIEWER"},{"updated":"2014-01-21 02:11:10.000000000","updated_by":{"_account_id":8289,"name":"huangtianhua","email":"tiantian223@163.com","username":"huangtianhua"},"reviewer":{"_account_id":8289,"name":"huangtianhua","email":"tiantian223@163.com","username":"huangtianhua"},"state":"REVIEWER"},{"updated":"2014-01-21 08:03:33.000000000","updated_by":{"_account_id":2813,"name":"Mehdi Abaakouk","email":"sileht@sileht.net","username":"sileht"},"reviewer":{"_account_id":2813,"name":"Mehdi Abaakouk","email":"sileht@sileht.net","username":"sileht"},"state":"REVIEWER"},{"updated":"2014-01-23 03:10:16.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"663407e91d82f59897be1de8d7216ae8e2a1fc00","author":{"_account_id":6676,"name":"zqfan","email":"aji.zqfan@gmail.com","username":"aji-zqfan"},"date":"2014-01-18 07:25:31.000000000","message":"Patch Set 1: I would prefer that you didn\u0027t merge this\n\n(1 inline comment)\n\n","accounts_in_message":[],"_revision_number":1},{"id":"6580f3d5d1c09833abba7ee4ab32d7afe1954973","author":{"_account_id":6676,"name":"zqfan","email":"aji.zqfan@gmail.com","username":"aji-zqfan"},"date":"2014-01-18 07:26:19.000000000","message":"Patch Set 1:\n\nplease run tox before commit","accounts_in_message":[],"_revision_number":1},{"id":"b17c10f61e9a135bc853126e14b9eb7d63e948d7","author":{"_account_id":8290,"name":"liusheng","email":"liusheng2048@gmail.com","username":"LiuSheng"},"date":"2014-01-18 07:29:02.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"9629521d26959a0fd49360e3d248ce112e37fff8","author":{"_account_id":6676,"name":"zqfan","email":"aji.zqfan@gmail.com","username":"aji-zqfan"},"date":"2014-01-18 07:34:04.000000000","message":"Patch Set 2: Looks good to me, but someone else must approve\n\n","accounts_in_message":[],"_revision_number":2},{"id":"ad8f2effca14163f8948e98410277e8a9b9e8106","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-01-18 08:49:52.000000000","message":"Patch Set 2: Works for me\n\nBuild succeeded.\n\n- gate-python-ceilometerclient-pep8 http://logs.openstack.org/41/67641/2/check/gate-python-ceilometerclient-pep8/c2cc60e : SUCCESS in 56s\n- gate-python-ceilometerclient-docs http://docs-draft.openstack.org/41/67641/2/check/gate-python-ceilometerclient-docs/d1320c4/doc/build/html/ : SUCCESS in 57s\n- gate-python-ceilometerclient-python26 http://logs.openstack.org/41/67641/2/check/gate-python-ceilometerclient-python26/e7af3db : SUCCESS in 42s\n- gate-python-ceilometerclient-python27 http://logs.openstack.org/41/67641/2/check/gate-python-ceilometerclient-python27/fc16389 : SUCCESS in 46s\n- gate-python-ceilometerclient-python33 http://logs.openstack.org/41/67641/2/check/gate-python-ceilometerclient-python33/f72598f : FAILURE in 4m 04s (non-voting)\n- gate-python-ceilometerclient-pypy http://logs.openstack.org/41/67641/2/check/gate-python-ceilometerclient-pypy/4e3a9be : SUCCESS in 1m 54s\n- check-tempest-dsvm-full http://logs.openstack.org/41/67641/2/check/check-tempest-dsvm-full/923e90b : SUCCESS in 52m 51s\n- check-tempest-dsvm-postgres-full http://logs.openstack.org/41/67641/2/check/check-tempest-dsvm-postgres-full/760db6d : SUCCESS in 54m 16s\n- check-tempest-dsvm-neutron http://logs.openstack.org/41/67641/2/check/check-tempest-dsvm-neutron/ce3bb1a : SUCCESS in 35m 18s\n- gate-tempest-dsvm-large-ops http://logs.openstack.org/41/67641/2/check/gate-tempest-dsvm-large-ops/b7349ab : SUCCESS in 10m 48s\n- gate-tempest-dsvm-neutron-large-ops http://logs.openstack.org/41/67641/2/check/gate-tempest-dsvm-neutron-large-ops/5054838 : SUCCESS in 13m 14s\n","accounts_in_message":[],"_revision_number":2},{"id":"23555d64d43ed41859ad869509bb72eb1bbcf015","author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"date":"2014-01-20 15:51:11.000000000","message":"Patch Set 2: Looks good to me (core reviewer)\n\n","accounts_in_message":[],"_revision_number":2},{"id":"839ea2675c3b2529ec02cc11da145200453b91c6","author":{"_account_id":8289,"name":"huangtianhua","email":"tiantian223@163.com","username":"huangtianhua"},"date":"2014-01-21 02:11:10.000000000","message":"Patch Set 2: Looks good to me, but someone else must approve\n\n","accounts_in_message":[],"_revision_number":2},{"id":"362002a0689f4f0d876eea33fe1a84212f3fd2d2","author":{"_account_id":2813,"name":"Mehdi Abaakouk","email":"sileht@sileht.net","username":"sileht"},"date":"2014-01-21 08:03:33.000000000","message":"Patch Set 2: Looks good to me (core reviewer); Approved\n\n","accounts_in_message":[],"_revision_number":2},{"id":"304bbd968dfd729147a207b67c83ef51668f7de0","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-01-21 09:38:08.000000000","message":"Patch Set 2: No score\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":2},{"id":"9b241b9d0c5980899fa05d08f3e9bbda7901de6a","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-01-22 20:57:22.000000000","message":"Patch Set 2:\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":2},{"id":"282ce4ca3312bc1c4fb89c8e2e39bed485648235","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-01-23 03:10:16.000000000","message":"Patch Set 2: Verified\n\nBuild succeeded.\n\n- gate-python-ceilometerclient-docs http://docs-draft.openstack.org/41/67641/2/gate/gate-python-ceilometerclient-docs/1303c94/doc/build/html/ : SUCCESS in 59s\n- gate-python-ceilometerclient-pep8 http://logs.openstack.org/41/67641/2/gate/gate-python-ceilometerclient-pep8/b901907 : SUCCESS in 45s\n- gate-python-ceilometerclient-python26 http://logs.openstack.org/41/67641/2/gate/gate-python-ceilometerclient-python26/3f9f744 : SUCCESS in 1m 09s\n- gate-python-ceilometerclient-python27 http://logs.openstack.org/41/67641/2/gate/gate-python-ceilometerclient-python27/dbcd075 : SUCCESS in 1m 21s\n- gate-python-ceilometerclient-pypy http://logs.openstack.org/41/67641/2/gate/gate-python-ceilometerclient-pypy/7cc30ab : SUCCESS in 1m 59s\n- gate-tempest-dsvm-full http://logs.openstack.org/41/67641/2/gate/gate-tempest-dsvm-full/26b13f7 : SUCCESS in 57m 31s\n- gate-tempest-dsvm-postgres-full http://logs.openstack.org/41/67641/2/gate/gate-tempest-dsvm-postgres-full/ff600ba : SUCCESS in 57m 21s\n- gate-tempest-dsvm-neutron http://logs.openstack.org/41/67641/2/gate/gate-tempest-dsvm-neutron/bc7cfe9 : SUCCESS in 34m 20s\n- gate-tempest-dsvm-large-ops http://logs.openstack.org/41/67641/2/gate/gate-tempest-dsvm-large-ops/195a401 : SUCCESS in 12m 30s\n- gate-tempest-dsvm-neutron-large-ops http://logs.openstack.org/41/67641/2/gate/gate-tempest-dsvm-neutron-large-ops/a1d2e5b : SUCCESS in 13m 18s\n","accounts_in_message":[],"_revision_number":2},{"id":"258329f37b09d1bd35ade17f4c8b6c5939042e43","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-01-23 03:10:16.000000000","message":"Change has been successfully merged into the git repository.","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"8744c636c1cb8924edd1f3a1e7d3dab467e23ad0","revisions":{"b9e072d5bc0deaadaadcdc8b9e945bc460ffd965":{"kind":"REWORK","_number":1,"created":"2014-01-18 07:22:46.000000000","uploader":{"_account_id":8290,"name":"liusheng","email":"liusheng2048@gmail.com","username":"LiuSheng"},"ref":"refs/changes/41/67641/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-ceilometerclient","ref":"refs/changes/41/67641/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-ceilometerclient refs/changes/41/67641/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-ceilometerclient refs/changes/41/67641/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-ceilometerclient refs/changes/41/67641/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-ceilometerclient refs/changes/41/67641/1"}}},"commit":{"parents":[{"commit":"ff3172c8efccd5df76f35b57914ada605b2d3c68","subject":"Merge \"fix optional parameter of creating sample\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-ceilometerclient/commit/ff3172c8efccd5df76f35b57914ada605b2d3c68"}]}],"author":{"name":"ls1175","email":"liusheng@huawei.com","date":"2014-01-18 07:21:31.000000000","tz":480},"committer":{"name":"ls1175","email":"liusheng@huawei.com","date":"2014-01-18 07:21:31.000000000","tz":480},"subject":"replace assertTrue(isinstance) to assertIsInstance","message":"replace assertTrue(isinstance) to assertIsInstance\n\nsome of tests use different method of assertTrue(isinstance(A, B))\nor assertEqual(type(A), B). The correct way is to use\nassertIsInstance(A, B) provided by testtools\n\nChange-Id: Idd931d27b13a46800e27393a98da096d41442320\nCloses-bug: #1268480\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-ceilometerclient/commit/b9e072d5bc0deaadaadcdc8b9e945bc460ffd965"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-ceilometerclient/commit/b9e072d5bc0deaadaadcdc8b9e945bc460ffd965"}]},"branch":"refs/heads/master"},"8744c636c1cb8924edd1f3a1e7d3dab467e23ad0":{"kind":"REWORK","_number":2,"created":"2014-01-18 07:29:02.000000000","uploader":{"_account_id":8290,"name":"liusheng","email":"liusheng2048@gmail.com","username":"LiuSheng"},"ref":"refs/changes/41/67641/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-ceilometerclient","ref":"refs/changes/41/67641/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-ceilometerclient refs/changes/41/67641/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-ceilometerclient refs/changes/41/67641/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-ceilometerclient refs/changes/41/67641/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-ceilometerclient refs/changes/41/67641/2"}}},"commit":{"parents":[{"commit":"ff3172c8efccd5df76f35b57914ada605b2d3c68","subject":"Merge \"fix optional parameter of creating sample\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-ceilometerclient/commit/ff3172c8efccd5df76f35b57914ada605b2d3c68"}]}],"author":{"name":"ls1175","email":"liusheng@huawei.com","date":"2014-01-18 07:21:31.000000000","tz":480},"committer":{"name":"ls1175","email":"liusheng@huawei.com","date":"2014-01-18 07:28:38.000000000","tz":480},"subject":"replace assertTrue(isinstance) to assertIsInstance","message":"replace assertTrue(isinstance) to assertIsInstance\n\nsome of tests use different method of assertTrue(isinstance(A, B))\nor assertEqual(type(A), B). The correct way is to use\nassertIsInstance(A, B) provided by testtools\n\nChange-Id: Idd931d27b13a46800e27393a98da096d41442320\nCloses-bug: #1268480\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-ceilometerclient/commit/8744c636c1cb8924edd1f3a1e7d3dab467e23ad0"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-ceilometerclient/commit/8744c636c1cb8924edd1f3a1e7d3dab467e23ad0"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}