)]}'
{"ceilometerclient/tests/v2/test_statistics.py":[{"author":{"_account_id":6676,"name":"zqfan","email":"aji.zqfan@gmail.com","username":"aji-zqfan"},"change_message_id":"90066174fc0779e4d5fdc05339e96a60dc88b9f6","unresolved":false,"context_lines":[{"line_number":170,"context_line":"            (\u0027GET\u0027,"},{"line_number":171,"context_line":"             \u0027%s?%s%s\u0027 % (base_url, qry, groupby), {}, None),"},{"line_number":172,"context_line":"        ]"},{"line_number":173,"context_line":"        self.assertEqual(self.api.calls, expect)"},{"line_number":174,"context_line":"        self.assertEqual(len(stats), 2)"},{"line_number":175,"context_line":"        self.assertEqual(stats[0].count, 135)"},{"line_number":176,"context_line":"        self.assertEqual(stats[1].count, 12)"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAWH%2F%2ByOE%3D","line":173,"updated":"2014-03-24 11:43:48.000000000","message":"it seems that someone else like to fix the order of assertEqual, since it will be helpful when test is fail. my opinion is that we should not use it wrongly in new code but not worth to fix old code.\n\nso can you adjust the assertEqual to (expected, actual) order here, and the following statements?","commit_id":"b7879b4ec424fa077a60ef31c1434004c0efd7d9"}],"ceilometerclient/v2/statistics.py":[{"author":{"_account_id":2284,"name":"Eoghan Glynn","email":"eglynn@redhat.com","username":"eglynn"},"change_message_id":"fcb831319ee3900dd1a66a11fb98107f4bf8cbc4","unresolved":false,"context_lines":[{"line_number":25,"context_line":""},{"line_number":26,"context_line":"    def list(self, meter_name, q\u003dNone, period\u003dNone, groupby\u003d[]):"},{"line_number":27,"context_line":"        p \u003d [\u0027period\u003d%s\u0027 % period] if period else []"},{"line_number":28,"context_line":"        if isinstance(groupby, str):"},{"line_number":29,"context_line":"            groupby \u003d [groupby]"},{"line_number":30,"context_line":"        p.extend([\u0027groupby\u003d%s\u0027 % g for g in groupby] if groupby else [])"},{"line_number":31,"context_line":"        return self._list(options.build_url("}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAWH%2F%2Bwzg%3D","line":28,"updated":"2014-03-24 14:57:10.000000000","message":"More conventional to use:\n\n  isinstance(groupby, basestring)","commit_id":"969887fa56c3e90a16eaa027187e1c686789925f"}]}