)]}'
{"id":"openstack%2Fpython-cinderclient~11851","triplet_id":"openstack%2Fpython-cinderclient~master~If926bb3b8fa85d628aea197496cf976f71bcdd08","project":"openstack/python-cinderclient","branch":"master","topic":"bp/command-options","hashtags":[],"change_id":"If926bb3b8fa85d628aea197496cf976f71bcdd08","subject":"Change \u0027_\u0027 to \u0027-\u0027 in options","status":"MERGED","created":"2012-08-23 06:24:04.000000000","updated":"2012-08-30 15:15:12.000000000","submitted":"2012-08-30 15:15:12.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"7c26ccb4e9862296b0c6f6cd9e1e9037d328fb05","_number":11851,"virtual_id_number":11851,"owner":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":2,"date":"2012-08-30 15:15:12.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},{"value":0,"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},{"value":0,"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},"all":[{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":2,"date":"2012-08-23 19:59:37.000000000","_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},{"value":0,"date":"2012-08-30 14:48:33.000000000","permitted_voting_range":{"min":0,"max":1},"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},{"value":0,"date":"2012-08-29 19:37:51.000000000","permitted_voting_range":{"min":0,"max":1},"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},"all":[{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":1,"date":"2012-08-30 15:13:33.000000000","_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},{"value":0,"date":"2012-08-23 19:40:39.000000000","_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},{"value":0,"date":"2012-08-29 19:37:51.000000000","_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},{"value":0,"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},{"value":0,"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"}],"values":{"-1":"Branch Freeze"," 0":"No Priority","+1":"Important Change","+2":"Gate Blocker Fix / Urgent Change"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},{"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2012-08-29 19:37:51.000000000","updated_by":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"reviewer":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"state":"REVIEWER"},{"updated":"2012-08-30 15:13:33.000000000","updated_by":{"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},"reviewer":{"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},"state":"REVIEWER"},{"updated":"2012-08-30 15:15:12.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"753036b250a288cb437195a7d1a344aca5702ea1","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2012-08-23 06:26:46.000000000","message":"Patch Set 1: Works for me\n\nBuild successful\n\n- https://jenkins.openstack.org/job/gate-python-cinderclient-merge/75/consoleFull : SUCCESS\n- https://jenkins.openstack.org/job/gate-python-cinderclient-docs/44/consoleFull : SUCCESS\n- https://jenkins.openstack.org/job/gate-python-cinderclient-pep8/74/consoleFull : SUCCESS\n- https://jenkins.openstack.org/job/gate-python-cinderclient-python26/73/consoleFull : SUCCESS\n- https://jenkins.openstack.org/job/gate-python-cinderclient-python27/74/consoleFull : SUCCESS\n","accounts_in_message":[],"_revision_number":1},{"id":"a7b2566812b8e169263b0f75fdb61077faa1873b","author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"date":"2012-08-23 19:40:39.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"a002b509a8dee5c408d5a714208d74b12844509e","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2012-08-23 19:43:15.000000000","message":"Patch Set 2: Works for me\n\nBuild successful\n\n- https://jenkins.openstack.org/job/gate-python-cinderclient-merge/77/consoleFull : SUCCESS\n- https://jenkins.openstack.org/job/gate-python-cinderclient-docs/46/consoleFull : SUCCESS\n- https://jenkins.openstack.org/job/gate-python-cinderclient-pep8/76/consoleFull : SUCCESS\n- https://jenkins.openstack.org/job/gate-python-cinderclient-python26/75/consoleFull : SUCCESS\n- https://jenkins.openstack.org/job/gate-python-cinderclient-python27/76/consoleFull : SUCCESS\n","accounts_in_message":[],"_revision_number":2},{"id":"82913ab77535759245999d710e0a07392bc21af1","author":{"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},"date":"2012-08-23 19:59:37.000000000","message":"Patch Set 2: Looks good to me (core reviewer)\n\n","accounts_in_message":[],"_revision_number":2},{"id":"051d1401a6a3bea81fe99a5c48ac634533ff1ca2","author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"date":"2012-08-29 19:37:51.000000000","message":"Patch Set 2:\n\nWow, so um... that looks like it was a bunch of work, thanks doing this!\n\nI guess I\u0027m lazy but I would rather see the translation handled dynamically, e.g.\n\nhttps://github.com/clayg/python-cinderclient/compare/dash-args\n\nThe benefit here is that we can leave in support for _ args as long as needed without any extra burden or cruft (except in our ArgumentParser subclasss).  We can update the decorators at our leisure, but it\u0027s no big deal.  But, *most* of all users don\u0027t have to know/care which opts are \"legacy compatible\" and which are new (and wouldn\u0027t support underscores without the double def).  All args support both for free!\n\nPlus there\u0027s the muscle memory argument... it could take me a year to get used to typing the dashes.  Meanwhile I\u0027m cursing being forced to type dashes on SOME opts.  And even after that some hackers may like having the the python/json var display_name mentally map directly to the command line arg --display_name (I sorta assumed that\u0027s why the convention was adopted in the first place).\n\nAny interest in trying this approach with this branch, or I could possibly try to pull in your changes to my example/hack and put up for review?\n\nIt\u0027s just an idea, if someone else wants to come along and merge this - I\u0027m not going to cry a river.  Something like I\u0027m describing could even be added later in a modified form if some of my concerns turn out to actually be a problem (they may not).\n\nBest Regards,\n\n-clayg","accounts_in_message":[],"_revision_number":2},{"id":"4ca999baa74811536c78cacdd7606311d4c1db4f","author":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"date":"2012-08-30 14:48:33.000000000","message":"Patch Set 2:\n\n* The support of the underscore form of options is transitional at best.  It may be around for a year or more but it is not permanent.\n* Not supporting underscore forms for new options is part of encouraging the switch to dashes.  We don\u0027t break existing scripts but we do begin to re-train fingers.  Most of the users will learn to just use dashes in all long options.\n\nThis is the last CLI binary to be patched in this manner.  I\u0027m looking to provide a _consistent_ user experience.","accounts_in_message":[],"_revision_number":2},{"id":"23233c7a2b03b54c8d357cc6678823fe33b25d86","author":{"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},"date":"2012-08-30 15:13:33.000000000","message":"Patch Set 2: Approved\n\nI\u0027d prefer consistency and even if it\u0027s easy I don\u0027t see any point in preserving both.\n\nAlso, I want to follow the other projects which are moving this way.","accounts_in_message":[],"_revision_number":2},{"id":"a0ebc240511f924ab5b448a7d7fe8650ce115f4e","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2012-08-30 15:13:34.000000000","message":"Patch Set 2: No score\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":2},{"id":"fb19ce55dc924a14d26be5edb3e3e35ee3f34aa0","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2012-08-30 15:15:12.000000000","message":"Patch Set 2: Verified\n\nBuild successful\n\n- http://logs.openstack.org/11851/2/gate/gate-python-cinderclient-merge/91 : SUCCESS\n- http://logs.openstack.org/11851/2/gate/gate-python-cinderclient-docs/60 : SUCCESS\n- http://logs.openstack.org/11851/2/gate/gate-python-cinderclient-pep8/90 : SUCCESS\n- http://logs.openstack.org/11851/2/gate/gate-python-cinderclient-python26/89 : SUCCESS\n- http://logs.openstack.org/11851/2/gate/gate-python-cinderclient-python27/90 : SUCCESS\n","accounts_in_message":[],"_revision_number":2},{"id":"6a069b03510a974918a64501ee656c3e8dd94d25","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2012-08-30 15:15:12.000000000","message":"Change has been successfully merged into the git repository.","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"d7b09bd097265691b60608f6cf32fd4f4ea3bc65","revisions":{"bd4a3443b290bbf43ccc0e272754f5de25ddd7fe":{"kind":"REWORK","_number":1,"created":"2012-08-23 06:24:04.000000000","uploader":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"ref":"refs/changes/51/11851/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-cinderclient","ref":"refs/changes/51/11851/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-cinderclient refs/changes/51/11851/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-cinderclient refs/changes/51/11851/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-cinderclient refs/changes/51/11851/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-cinderclient refs/changes/51/11851/1"}}},"commit":{"parents":[{"commit":"0bba3857d19bdfbc7ac3a408b3889b92245ed812","subject":"Add ability to provide metadata on volume creation","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-cinderclient/commit/0bba3857d19bdfbc7ac3a408b3889b92245ed812"}]}],"author":{"name":"Dean Troyer","email":"dtroyer@gmail.com","date":"2012-08-23 04:42:26.000000000","tz":-300},"committer":{"name":"Dean Troyer","email":"dtroyer@gmail.com","date":"2012-08-23 06:23:57.000000000","tz":-300},"subject":"Change \u0027_\u0027 to \u0027-\u0027 in options","message":"Change \u0027_\u0027 to \u0027-\u0027 in options\n\nThis changes every command-line option with a \u0027_\u0027 in its name\nand changes them to \u0027-\u0027.  The old option names are maintained\nfor backward compatibility but are no longer in the help text.\n\nBP command-options\n\nChange-Id: If926bb3b8fa85d628aea197496cf976f71bcdd08\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-cinderclient/commit/bd4a3443b290bbf43ccc0e272754f5de25ddd7fe"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-cinderclient/commit/bd4a3443b290bbf43ccc0e272754f5de25ddd7fe"}]},"branch":"refs/heads/master"},"d7b09bd097265691b60608f6cf32fd4f4ea3bc65":{"kind":"REWORK","_number":2,"created":"2012-08-23 19:40:39.000000000","uploader":{"_account_id":970,"name":"Dean Troyer","email":"dtroyer@gmail.com","username":"dtroyer"},"ref":"refs/changes/51/11851/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-cinderclient","ref":"refs/changes/51/11851/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-cinderclient refs/changes/51/11851/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-cinderclient refs/changes/51/11851/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-cinderclient refs/changes/51/11851/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-cinderclient refs/changes/51/11851/2"}}},"commit":{"parents":[{"commit":"0bba3857d19bdfbc7ac3a408b3889b92245ed812","subject":"Add ability to provide metadata on volume creation","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-cinderclient/commit/0bba3857d19bdfbc7ac3a408b3889b92245ed812"}]}],"author":{"name":"Dean Troyer","email":"dtroyer@gmail.com","date":"2012-08-23 04:42:26.000000000","tz":-300},"committer":{"name":"Dean Troyer","email":"dtroyer@gmail.com","date":"2012-08-23 19:40:09.000000000","tz":-300},"subject":"Change \u0027_\u0027 to \u0027-\u0027 in options","message":"Change \u0027_\u0027 to \u0027-\u0027 in options\n\nThis changes every command-line option with a \u0027_\u0027 in its name\nand changes them to \u0027-\u0027.  The old option names are maintained\nfor backward compatibility but are no longer in the help text.\n\nBP command-options\n\nChange-Id: If926bb3b8fa85d628aea197496cf976f71bcdd08\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-cinderclient/commit/d7b09bd097265691b60608f6cf32fd4f4ea3bc65"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-cinderclient/commit/d7b09bd097265691b60608f6cf32fd4f4ea3bc65"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}