)]}'
{"id":"openstack%2Fpython-cinderclient~12807","triplet_id":"openstack%2Fpython-cinderclient~master~I0c1bdbdabd9acc29133a48a798750323011f1f18","project":"openstack/python-cinderclient","branch":"master","topic":"tenant-id","hashtags":[],"change_id":"I0c1bdbdabd9acc29133a48a798750323011f1f18","subject":"add tenant_id and make projectid optional","status":"MERGED","created":"2012-09-11 17:38:05.000000000","updated":"2012-09-12 21:17:30.000000000","submitted":"2012-09-12 21:17:30.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"df14faa2e9c605017abd02d21c3b5eae6f0ad5b3","_number":12807,"virtual_id_number":12807,"owner":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":0,"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},{"value":2,"date":"2012-09-12 21:17:30.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":1207,"name":"Duncan Thomas","email":"duncan.thomas@gmail.com","username":"duncan-thomas"},{"value":0,"_account_id":5230,"name":"Dermot Tynan","inactive":true}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},"all":[{"value":2,"date":"2012-09-12 15:26:03.000000000","_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":2,"date":"2012-09-12 16:45:31.000000000","_account_id":1207,"name":"Duncan Thomas","email":"duncan.thomas@gmail.com","username":"duncan-thomas"},{"value":1,"date":"2012-09-12 16:46:44.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":5230,"name":"Dermot Tynan","inactive":true}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},"all":[{"value":1,"date":"2012-09-12 21:14:33.000000000","_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"date":"2012-09-12 16:45:31.000000000","_account_id":1207,"name":"Duncan Thomas","email":"duncan.thomas@gmail.com","username":"duncan-thomas"},{"value":0,"_account_id":5230,"name":"Dermot Tynan","inactive":true}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":1207,"name":"Duncan Thomas","email":"duncan.thomas@gmail.com","username":"duncan-thomas"},{"value":0,"_account_id":5230,"name":"Dermot Tynan","inactive":true}],"values":{"-1":"Branch Freeze"," 0":"No Priority","+1":"Important Change","+2":"Gate Blocker Fix / Urgent Change"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":1207,"name":"Duncan Thomas","email":"duncan.thomas@gmail.com","username":"duncan-thomas"},{"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},{"_account_id":5230,"name":"Dermot Tynan","inactive":true}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2012-09-12 16:45:31.000000000","updated_by":{"_account_id":1207,"name":"Duncan Thomas","email":"duncan.thomas@gmail.com","username":"duncan-thomas"},"reviewer":{"_account_id":1207,"name":"Duncan Thomas","email":"duncan.thomas@gmail.com","username":"duncan-thomas"},"state":"REVIEWER"},{"updated":"2012-09-12 16:46:44.000000000","updated_by":{"_account_id":5230,"name":"Dermot Tynan","inactive":true},"reviewer":{"_account_id":5230,"name":"Dermot Tynan","inactive":true},"state":"REVIEWER"},{"updated":"2012-09-12 21:14:33.000000000","updated_by":{"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},"reviewer":{"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},"state":"REVIEWER"},{"updated":"2012-09-12 21:17:30.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"3a74ac90fb5144d718a0c6d624f9feeb5f052bef","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2012-09-11 17:44:35.000000000","message":"Patch Set 1: Works for me\n\nBuild successful\n\n- http://logs.openstack.org/12807/1/check/gate-python-cinderclient-merge/98 : SUCCESS\n- http://logs.openstack.org/12807/1/check/gate-python-cinderclient-docs/67 : SUCCESS\n- http://logs.openstack.org/12807/1/check/gate-python-cinderclient-pep8/97 : SUCCESS\n- http://logs.openstack.org/12807/1/check/gate-python-cinderclient-python26/96 : SUCCESS\n- http://logs.openstack.org/12807/1/check/gate-python-cinderclient-python27/97 : SUCCESS\n","accounts_in_message":[],"_revision_number":1},{"id":"4216db2e38e9f7cf10d0c2c58359b7c9e33dca24","author":{"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},"date":"2012-09-12 15:26:03.000000000","message":"Patch Set 1: Looks good to me (core reviewer)\n\n","accounts_in_message":[],"_revision_number":1},{"id":"1896b1431049a4a36a462d0e3979bbbe5e03ed87","author":{"_account_id":1207,"name":"Duncan Thomas","email":"duncan.thomas@gmail.com","username":"duncan-thomas"},"date":"2012-09-12 16:45:31.000000000","message":"Patch Set 1: Looks good to me (core reviewer)\n\n","accounts_in_message":[],"_revision_number":1},{"id":"96fdab3cbead778432af63c59d6b1bf2a6b4bd4a","author":{"_account_id":5230,"name":"Dermot Tynan","inactive":true},"date":"2012-09-12 16:46:44.000000000","message":"Patch Set 1: Looks good to me, but someone else must approve\n\n","accounts_in_message":[],"_revision_number":1},{"id":"faa6832f7374fd3d9988d1141a0b8369e0e2d220","author":{"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},"date":"2012-09-12 21:14:33.000000000","message":"Patch Set 1: Approved\n\n","accounts_in_message":[],"_revision_number":1},{"id":"cdc10d675046942884d0829a2e7f7d7bde080877","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2012-09-12 21:14:43.000000000","message":"Patch Set 1: No score\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":1},{"id":"bc0d2d3e69089ed53ea4896eb8fa42d088b9837c","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2012-09-12 21:17:30.000000000","message":"Patch Set 1: Verified\n\nBuild successful\n\n- http://logs.openstack.org/12807/1/gate/gate-python-cinderclient-merge/102 : SUCCESS\n- http://logs.openstack.org/12807/1/gate/gate-python-cinderclient-docs/71 : SUCCESS\n- http://logs.openstack.org/12807/1/gate/gate-python-cinderclient-pep8/101 : SUCCESS\n- http://logs.openstack.org/12807/1/gate/gate-python-cinderclient-python26/100 : SUCCESS\n- http://logs.openstack.org/12807/1/gate/gate-python-cinderclient-python27/101 : SUCCESS\n","accounts_in_message":[],"_revision_number":1},{"id":"eec811a2a32702e39540381a6449fe2601bd4315","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2012-09-12 21:17:30.000000000","message":"Change has been successfully merged into the git repository.","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"2313ddfc8c89074b3aaf269097236c5d93b59fdf","revisions":{"2313ddfc8c89074b3aaf269097236c5d93b59fdf":{"kind":"REWORK","_number":1,"created":"2012-09-11 17:38:05.000000000","uploader":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"ref":"refs/changes/07/12807/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-cinderclient","ref":"refs/changes/07/12807/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-cinderclient refs/changes/07/12807/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-cinderclient refs/changes/07/12807/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-cinderclient refs/changes/07/12807/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-cinderclient refs/changes/07/12807/1"}}},"commit":{"parents":[{"commit":"a4d46014325f4f34ac9db82c863f5764c8560a3e","subject":"Add begin_detaching and roll_detaching functions","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-cinderclient/commit/a4d46014325f4f34ac9db82c863f5764c8560a3e"}]}],"author":{"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","date":"2012-09-11 17:13:46.000000000","tz":-300},"committer":{"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","date":"2012-09-11 17:38:09.000000000","tz":-300},"subject":"add tenant_id and make projectid optional","message":"add tenant_id and make projectid optional\n\nAdd a new optional tenant_id keyword argument to the client classes\ncinderclient.client.HTTPClient and cinderclient.v1.client.Client to\nsupport authentication with tenant_id instead of projectid (which is\nacctually used as \"tenantName\" in the auth request body).\n\nKeystone can provide tokens without specifiying the tenant in any form,\nbut a tenantName _or_ tenantId is required to generate the catalog (the\nkeystone service code seems to prefer tenantName if both are specified).\n\nWhen using cinderclient programatically, it may be more convienent,\ndepending on the context to authenticate with out specificying the\ntenant, or by tenant_id instead of tenant_name.  Either way it\u0027s\nimpractial to make the requirement in the client for projectid\n(tenantName) if the auth system has no such limitation.\n\nThe new client signature is backwards compatible.  There is no change in\nbehavior for the shell client.\n\nChange-Id: I0c1bdbdabd9acc29133a48a798750323011f1f18\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-cinderclient/commit/2313ddfc8c89074b3aaf269097236c5d93b59fdf"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-cinderclient/commit/2313ddfc8c89074b3aaf269097236c5d93b59fdf"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}