)]}'
{"id":"openstack%2Fpython-cinderclient~12847","triplet_id":"openstack%2Fpython-cinderclient~master~I0207a558edbfae8f5e69913c421c31e35fefcf4c","project":"openstack/python-cinderclient","branch":"master","topic":"clean-up","hashtags":[],"change_id":"I0207a558edbfae8f5e69913c421c31e35fefcf4c","subject":"Remove unused methods in FakeHTTPClient and unused unittests","status":"MERGED","created":"2012-09-12 03:28:32.000000000","updated":"2012-09-13 05:24:41.000000000","submitted":"2012-09-13 05:24:41.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"fc90722ab385902119413f3dd5fecba8e3607c24","_number":12847,"virtual_id_number":12847,"owner":{"_account_id":2481,"name":"Rongze Zhu","email":"zrzhit@gmail.com","username":"zrzhit"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":0,"_account_id":2481,"name":"Rongze Zhu","email":"zrzhit@gmail.com","username":"zrzhit"},{"value":0,"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},{"value":2,"date":"2012-09-13 05:24:41.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},"all":[{"value":0,"_account_id":2481,"name":"Rongze Zhu","email":"zrzhit@gmail.com","username":"zrzhit"},{"value":2,"date":"2012-09-13 04:17:39.000000000","_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":2,"date":"2012-09-13 05:22:57.000000000","_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"all":[{"value":0,"date":"2012-09-13 02:58:38.000000000","_account_id":2481,"name":"Rongze Zhu","email":"zrzhit@gmail.com","username":"zrzhit"},{"value":0,"date":"2012-09-13 04:17:39.000000000","_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":1,"date":"2012-09-13 05:22:57.000000000","_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"_account_id":2481,"name":"Rongze Zhu","email":"zrzhit@gmail.com","username":"zrzhit"},{"value":0,"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"}],"values":{"-1":"Branch Freeze"," 0":"No Priority","+1":"Important Change","+2":"Gate Blocker Fix / Urgent Change"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},{"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},{"_account_id":2481,"name":"Rongze Zhu","email":"zrzhit@gmail.com","username":"zrzhit"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2012-09-13 04:17:39.000000000","updated_by":{"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},"reviewer":{"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},"state":"REVIEWER"},{"updated":"2012-09-13 05:22:57.000000000","updated_by":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"reviewer":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"state":"REVIEWER"},{"updated":"2012-09-13 05:24:41.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"3114b1b7fedb51650197c3efea4fb5691a5aa3cf","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2012-09-12 03:30:38.000000000","message":"Patch Set 1: Works for me\n\nBuild successful\n\n- http://logs.openstack.org/12847/1/check/gate-python-cinderclient-merge/100 : SUCCESS\n- http://logs.openstack.org/12847/1/check/gate-python-cinderclient-docs/69 : SUCCESS\n- http://logs.openstack.org/12847/1/check/gate-python-cinderclient-pep8/99 : SUCCESS\n- http://logs.openstack.org/12847/1/check/gate-python-cinderclient-python26/98 : SUCCESS\n- http://logs.openstack.org/12847/1/check/gate-python-cinderclient-python27/99 : SUCCESS\n","accounts_in_message":[],"_revision_number":1},{"id":"1d8f98dc601d374a3184bc73132f8269fa617ea0","author":{"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},"date":"2012-09-12 15:24:51.000000000","message":"Patch Set 1: Looks good to me (core reviewer)\n\n","accounts_in_message":[],"_revision_number":1},{"id":"e98a43519b3f4890e7d376bd673b1aca89f24e7b","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2012-09-12 22:12:19.000000000","message":"Patch Set 1: No score\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":1},{"id":"5474f987eae6f30121c6e0b0d5fc55b02906c008","author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"date":"2012-09-12 22:12:19.000000000","message":"Patch Set 1: Looks good to me (core reviewer); Approved\n\nYES PLEASE!","accounts_in_message":[],"_revision_number":1},{"id":"ca2f868a322296eb5de7f1f526a9e4629ecd85a7","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2012-09-12 22:12:20.000000000","message":"Patch Set 1: Fails\n\nBuild failed\n\nThis change was unable to be automatically merged with the current state of the repository. Please rebase your change and upload a new patchset.","accounts_in_message":[],"_revision_number":1},{"id":"9652885ccf7f9f789dfab76865f2e29c91795d98","author":{"_account_id":2481,"name":"Rongze Zhu","email":"zrzhit@gmail.com","username":"zrzhit"},"date":"2012-09-13 02:43:23.000000000","message":"Patch Set 1: Work In Progress","accounts_in_message":[],"_revision_number":1},{"id":"6a187b6cb3d5d8edf23a1cc19f417b5b509234a9","author":{"_account_id":2481,"name":"Rongze Zhu","email":"zrzhit@gmail.com","username":"zrzhit"},"date":"2012-09-13 02:58:38.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"ca7f529076f13834b6eca42c52d053c64fa92249","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2012-09-13 03:00:35.000000000","message":"Patch Set 2: Works for me\n\nBuild successful\n\n- http://logs.openstack.org/12847/2/check/gate-python-cinderclient-merge/106 : SUCCESS\n- http://logs.openstack.org/12847/2/check/gate-python-cinderclient-docs/75 : SUCCESS\n- http://logs.openstack.org/12847/2/check/gate-python-cinderclient-pep8/105 : SUCCESS\n- http://logs.openstack.org/12847/2/check/gate-python-cinderclient-python26/104 : SUCCESS\n- http://logs.openstack.org/12847/2/check/gate-python-cinderclient-python27/105 : SUCCESS\n","accounts_in_message":[],"_revision_number":2},{"id":"bc5bf4649170c613961b0b74dc8c6de5913fbe1b","author":{"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},"date":"2012-09-13 04:17:39.000000000","message":"Patch Set 2: Looks good to me (core reviewer)\n\n","accounts_in_message":[],"_revision_number":2},{"id":"44f45a130941c786ed04a3fd7e33b9bc5445518a","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2012-09-13 05:22:57.000000000","message":"Patch Set 2: No score\n\nStarting gate jobs.","accounts_in_message":[],"_revision_number":2},{"id":"2bfbd08b1eef7a314508d8b09f731a10b1b99419","author":{"_account_id":1179,"name":"Clay Gerrard","email":"clay.gerrard@gmail.com","username":"clay-gerrard"},"date":"2012-09-13 05:22:57.000000000","message":"Patch Set 2: Looks good to me (core reviewer); Approved\n\n","accounts_in_message":[],"_revision_number":2},{"id":"2b5e8c8c6a3989bd069caed05e4df98c98fd0767","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2012-09-13 05:24:41.000000000","message":"Patch Set 2: Verified\n\nBuild successful\n\n- http://logs.openstack.org/12847/2/gate/gate-python-cinderclient-merge/107 : SUCCESS\n- http://logs.openstack.org/12847/2/gate/gate-python-cinderclient-docs/76 : SUCCESS\n- http://logs.openstack.org/12847/2/gate/gate-python-cinderclient-pep8/106 : SUCCESS\n- http://logs.openstack.org/12847/2/gate/gate-python-cinderclient-python26/105 : SUCCESS\n- http://logs.openstack.org/12847/2/gate/gate-python-cinderclient-python27/106 : SUCCESS\n","accounts_in_message":[],"_revision_number":2},{"id":"4f1bcfab488f41831714bcbd03000e1a87a217b3","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2012-09-13 05:24:41.000000000","message":"Change has been successfully merged into the git repository.","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"f2424f2921bba614603b1899aea638221f7efc1c","revisions":{"a774b36b2d67a6a81cc11f1b360d6d294bfa6528":{"kind":"REWORK","_number":1,"created":"2012-09-12 03:28:32.000000000","uploader":{"_account_id":2481,"name":"Rongze Zhu","email":"zrzhit@gmail.com","username":"zrzhit"},"ref":"refs/changes/47/12847/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-cinderclient","ref":"refs/changes/47/12847/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-cinderclient refs/changes/47/12847/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-cinderclient refs/changes/47/12847/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-cinderclient refs/changes/47/12847/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-cinderclient refs/changes/47/12847/1"}}},"commit":{"parents":[{"commit":"a4d46014325f4f34ac9db82c863f5764c8560a3e","subject":"Add begin_detaching and roll_detaching functions","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-cinderclient/commit/a4d46014325f4f34ac9db82c863f5764c8560a3e"}]}],"author":{"name":"Rongze Zhu","email":"zrzhit@gmail.com","date":"2012-09-12 03:21:12.000000000","tz":0},"committer":{"name":"Rongze Zhu","email":"zrzhit@gmail.com","date":"2012-09-12 03:27:05.000000000","tz":0},"subject":"Remove unused methods in FakeHTTPClient","message":"Remove unused methods in FakeHTTPClient\n\nRemoved methods:\n\nget_limits\npost_servers\nget_servers_1234\nget_servers_5678\nput_servers_1234\ndelete_servers_1234\ndelete_servers_1234_metadata_test_key\ndelete_servers_1234_metadata_key1\ndelete_servers_1234_metadata_key2\npost_servers_1234_metadata\nget_servers_1234_diagnostics\nget_servers_1234_actions\nget_servers_1234_ips\nget_servers_1234_ips_public\nget_servers_1234_ips_private\ndelete_servers_1234_ips_public_1_2_3_4\npost_servers_1234_action\nget_os_cloudpipe\npost_os_cloudpipe\nget_flavors\nget_flavors_detail\nget_flavors_1\nget_flavors_2\nget_flavors_3\ndelete_flavors_flavordelete\npost_flavors\nget_os_floating_ip_pools\nget_os_floating_ips\nget_os_floating_ips_1\npost_os_floating_ips\npost_os_floating_ips\ndelete_os_floating_ips_1\nget_os_floating_ip_dns\nget_os_floating_ip_dns_testdomain_entries\nget_os_floating_ip_dns_testdomain_entries_testname\nput_os_floating_ip_dns_testdomain\nput_os_floating_ip_dns_testdomain_entries_testname\ndelete_os_floating_ip_dns_testdomain\ndelete_os_floating_ip_dns_testdomain_entries_testname\nget_images\nget_images_detail\nget_images_1\nget_images_2\npost_images\npost_images_1_metadata\ndelete_images_1\ndelete_images_1_metadata_test_key\nget_os_keypairs\ndelete_os_keypairs_test\npost_os_keypairs\nget_servers_1234_os_virtual_interfaces\nget_os_quota_sets_test\nget_os_quota_sets_test_defaults\nput_os_quota_sets_test\nget_os_quota_class_sets_test\nput_os_quota_class_sets_test\nget_os_security_groups\nget_os_security_groups_1\ndelete_os_security_groups_1\npost_os_security_groups\nget_os_security_group_rules\ndelete_os_security_group_rules_1\npost_os_security_group_rules\nget_os_simple_tenant_usage\nget_os_simple_tenant_usage_tenantfoo\nget_os_certificates_root\npost_os_certificates\nget_os_aggregates\n_return_aggregate\nget_os_aggregates_1\npost_os_aggregates\nput_os_aggregates_1\nput_os_aggregates_2\npost_os_aggregates_1_action\npost_os_aggregates_2_action\ndelete_os_aggregates_1\nget_os_hosts_host\nget_os_hosts_sample_host\nput_os_hosts_sample_host_1\nput_os_hosts_sample_host_2\nput_os_hosts_sample_host_3\nget_os_hosts_sample_host_startup\nget_os_hosts_sample_host_reboot\nget_os_hosts_sample_host_shutdown\nput_os_hosts_sample_host\n\nChange-Id: I0207a558edbfae8f5e69913c421c31e35fefcf4c\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-cinderclient/commit/a774b36b2d67a6a81cc11f1b360d6d294bfa6528"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-cinderclient/commit/a774b36b2d67a6a81cc11f1b360d6d294bfa6528"}]},"branch":"refs/heads/master"},"f2424f2921bba614603b1899aea638221f7efc1c":{"kind":"REWORK","_number":2,"created":"2012-09-13 02:58:38.000000000","uploader":{"_account_id":2481,"name":"Rongze Zhu","email":"zrzhit@gmail.com","username":"zrzhit"},"ref":"refs/changes/47/12847/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-cinderclient","ref":"refs/changes/47/12847/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-cinderclient refs/changes/47/12847/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-cinderclient refs/changes/47/12847/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-cinderclient refs/changes/47/12847/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-cinderclient refs/changes/47/12847/2"}}},"commit":{"parents":[{"commit":"67b5cba433e0b5472df51793e4b4290a9cfb096a","subject":"Merge \"Patch for bug #1004382\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-cinderclient/commit/67b5cba433e0b5472df51793e4b4290a9cfb096a"}]}],"author":{"name":"Rongze Zhu","email":"zrzhit@gmail.com","date":"2012-09-12 03:21:12.000000000","tz":0},"committer":{"name":"Rongze Zhu","email":"zrzhit@gmail.com","date":"2012-09-13 02:53:33.000000000","tz":0},"subject":"Remove unused methods in FakeHTTPClient and unused unittests","message":"Remove unused methods in FakeHTTPClient and unused unittests\n\nRemoved unittests:\n\ntests/v1/test_limits.py\n\nModified methods:\n\nget_os_quota_sets_test\nget_os_quota_sets_test_defaults\nput_os_quota_sets_test\nget_os_quota_class_sets_test\nput_os_quota_class_sets_test\n\nRemoved methods:\n\nget_limits\npost_servers\nget_servers_1234\nget_servers_5678\nput_servers_1234\ndelete_servers_1234\ndelete_servers_1234_metadata_test_key\ndelete_servers_1234_metadata_key1\ndelete_servers_1234_metadata_key2\npost_servers_1234_metadata\nget_servers_1234_diagnostics\nget_servers_1234_actions\nget_servers_1234_ips\nget_servers_1234_ips_public\nget_servers_1234_ips_private\ndelete_servers_1234_ips_public_1_2_3_4\npost_servers_1234_action\nget_os_cloudpipe\npost_os_cloudpipe\nget_flavors\nget_flavors_detail\nget_flavors_1\nget_flavors_2\nget_flavors_3\ndelete_flavors_flavordelete\npost_flavors\nget_os_floating_ip_pools\nget_os_floating_ips\nget_os_floating_ips_1\npost_os_floating_ips\npost_os_floating_ips\ndelete_os_floating_ips_1\nget_os_floating_ip_dns\nget_os_floating_ip_dns_testdomain_entries\nget_os_floating_ip_dns_testdomain_entries_testname\nput_os_floating_ip_dns_testdomain\nput_os_floating_ip_dns_testdomain_entries_testname\ndelete_os_floating_ip_dns_testdomain\ndelete_os_floating_ip_dns_testdomain_entries_testname\nget_images\nget_images_detail\nget_images_1\nget_images_2\npost_images\npost_images_1_metadata\ndelete_images_1\ndelete_images_1_metadata_test_key\nget_os_keypairs\ndelete_os_keypairs_test\npost_os_keypairs\nget_servers_1234_os_virtual_interfaces\nget_os_security_groups\nget_os_security_groups_1\ndelete_os_security_groups_1\npost_os_security_groups\nget_os_security_group_rules\ndelete_os_security_group_rules_1\npost_os_security_group_rules\nget_os_simple_tenant_usage\nget_os_simple_tenant_usage_tenantfoo\nget_os_certificates_root\npost_os_certificates\nget_os_aggregates\n_return_aggregate\nget_os_aggregates_1\npost_os_aggregates\nput_os_aggregates_1\nput_os_aggregates_2\npost_os_aggregates_1_action\npost_os_aggregates_2_action\ndelete_os_aggregates_1\nget_os_hosts_host\nget_os_hosts_sample_host\nput_os_hosts_sample_host_1\nput_os_hosts_sample_host_2\nput_os_hosts_sample_host_3\nget_os_hosts_sample_host_startup\nget_os_hosts_sample_host_reboot\nget_os_hosts_sample_host_shutdown\nput_os_hosts_sample_host\n\nChange-Id: I0207a558edbfae8f5e69913c421c31e35fefcf4c\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-cinderclient/commit/f2424f2921bba614603b1899aea638221f7efc1c"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-cinderclient/commit/f2424f2921bba614603b1899aea638221f7efc1c"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}