)]}'
{"cinderclient/v2/volumes.py":[{"author":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"change_message_id":"91cc45b2edced6ac7d3f888b93e11283d4ebf385","unresolved":false,"context_lines":[{"line_number":259,"context_line":""},{"line_number":260,"context_line":"        if sort_key is not None:"},{"line_number":261,"context_line":"            if sort_key in SORT_KEY_VALUES:"},{"line_number":262,"context_line":"                qparams[\u0027sort_key\u0027] \u003d SORT_KEY_MAPPINGS.get(sort_key, sort_key)"},{"line_number":263,"context_line":"            else:"},{"line_number":264,"context_line":"                raise ValueError(\u0027sort_key must be one of the following: %s.\u0027"},{"line_number":265,"context_line":"                                 % \u0027, \u0027.join(SORT_KEY_VALUES))"}],"source_content_type":"text/x-python","patch_set":4,"id":"3a961159_70b48135","line":262,"updated":"2014-12-29 15:04:14.000000000","message":"This line should be change to:\n qparams[\u0027sort_key\u0027] \u003d SORT_KEY_MAPPINGS[sort_key]","commit_id":"6e5c3bd4f0b2790c0bb6611fe98cde3e5b519889"},{"author":{"_account_id":10559,"name":"Steven Kaufer","email":"kaufer@us.ibm.com","username":"kaufer"},"change_message_id":"8e61b563fe3464c18bfb293d5ef9a611bb7719a1","unresolved":false,"context_lines":[{"line_number":259,"context_line":""},{"line_number":260,"context_line":"        if sort_key is not None:"},{"line_number":261,"context_line":"            if sort_key in SORT_KEY_VALUES:"},{"line_number":262,"context_line":"                qparams[\u0027sort_key\u0027] \u003d SORT_KEY_MAPPINGS.get(sort_key, sort_key)"},{"line_number":263,"context_line":"            else:"},{"line_number":264,"context_line":"                raise ValueError(\u0027sort_key must be one of the following: %s.\u0027"},{"line_number":265,"context_line":"                                 % \u0027, \u0027.join(SORT_KEY_VALUES))"}],"source_content_type":"text/x-python","patch_set":4,"id":"3a961159_d9246710","line":262,"in_reply_to":"3a961159_70b48135","updated":"2014-12-30 21:38:41.000000000","message":"This is not correct, the SORT_KEY_MAPPINGS only contains those keys that have a mapping (eg, \u0027name\u0027 \u003c-\u003e \u0027display_name\u0027).  Passing the 2nd arg to the get fn allows the value to be defaulted for any key that is not mapped.\n\nIf the change suggested above is made, then an exception would be raised for any key other than \u0027name\u0027.","commit_id":"6e5c3bd4f0b2790c0bb6611fe98cde3e5b519889"},{"author":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"change_message_id":"7096ab2e68d0f70058630934b9d9661fa9829361","unresolved":false,"context_lines":[{"line_number":259,"context_line":""},{"line_number":260,"context_line":"        if sort_key is not None:"},{"line_number":261,"context_line":"            if sort_key in SORT_KEY_VALUES:"},{"line_number":262,"context_line":"                qparams[\u0027sort_key\u0027] \u003d SORT_KEY_MAPPINGS.get(sort_key, sort_key)"},{"line_number":263,"context_line":"            else:"},{"line_number":264,"context_line":"                raise ValueError(\u0027sort_key must be one of the following: %s.\u0027"},{"line_number":265,"context_line":"                                 % \u0027, \u0027.join(SORT_KEY_VALUES))"}],"source_content_type":"text/x-python","patch_set":4,"id":"3a961159_e21cd268","line":262,"in_reply_to":"3a961159_d9246710","updated":"2015-01-05 19:20:52.000000000","message":"It\u0027s my misunderstood  this code. Steven, thanks for clarification it.","commit_id":"6e5c3bd4f0b2790c0bb6611fe98cde3e5b519889"},{"author":{"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},"change_message_id":"9aa144409f96252e421b644f375e9f00ceda89b7","unresolved":false,"context_lines":[{"line_number":27,"context_line":"# Valid sort directions and client sort keys"},{"line_number":28,"context_line":"SORT_DIR_VALUES \u003d (\u0027asc\u0027, \u0027desc\u0027)"},{"line_number":29,"context_line":"SORT_KEY_VALUES \u003d (\u0027id\u0027, \u0027status\u0027, \u0027size\u0027, \u0027availability_zone\u0027, \u0027name\u0027,"},{"line_number":30,"context_line":"                   \u0027bootable\u0027, \u0027created_at\u0027)"},{"line_number":31,"context_line":"# Mapping of client keys to actual sort keys"},{"line_number":32,"context_line":"SORT_KEY_MAPPINGS \u003d {\u0027name\u0027: \u0027display_name\u0027}"},{"line_number":33,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"1a930d6b_443c02e3","line":30,"updated":"2015-01-22 20:01:22.000000000","message":"should we have had display_name here for backwards compat?","commit_id":"0560f7883353ea74fd31bf52535883cc18adecf5"}]}