)]}'
{"id":"openstack%2Fpython-cinderclient~147374","triplet_id":"openstack%2Fpython-cinderclient~master~Iad8c88e20268265f9063e2faa2a21514439150ad","project":"openstack/python-cinderclient","branch":"master","topic":"remove_commented","hashtags":[],"change_id":"Iad8c88e20268265f9063e2faa2a21514439150ad","subject":"Remove commented code in cinderclient/v1/volumes.py","status":"MERGED","created":"2015-01-15 03:06:16.000000000","updated":"2015-01-20 12:38:12.000000000","submitted":"2015-01-20 12:38:10.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"07abbf037bc21d9210150d5e9ee0d5a5a2e9e101","_number":147374,"virtual_id_number":147374,"owner":{"_account_id":2759,"name":"Huang Zhiteng","email":"winston.d@gmail.com","username":"zhiteng-huang"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":0,"_account_id":5538,"name":"Rushi Agrawal","email":"rushi.openstack@gmail.com","username":"rushiagr"},{"value":0,"_account_id":7219,"name":"git-harry","email":"git-harry@live.co.uk","username":"git-harry"},{"value":0,"_account_id":4355,"name":"Avishay Traeger","email":"avishay@stratoscale.com","username":"avishay-il"},{"value":2,"date":"2015-01-20 12:38:10.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":13636,"name":"aarefiev","display_name":"Anton","email":"arefyevanton@gmail.com","username":"aarefiev"},{"value":0,"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},{"value":0,"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":4355,"name":"Avishay Traeger","email":"avishay@stratoscale.com","username":"avishay-il"},"recommended":{"_account_id":7219,"name":"git-harry","email":"git-harry@live.co.uk","username":"git-harry"},"all":[{"value":1,"date":"2015-01-20 05:05:18.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":5538,"name":"Rushi Agrawal","email":"rushi.openstack@gmail.com","username":"rushiagr"},{"value":1,"date":"2015-01-20 11:59:34.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":7219,"name":"git-harry","email":"git-harry@live.co.uk","username":"git-harry"},{"value":2,"date":"2015-01-20 12:06:52.000000000","_account_id":4355,"name":"Avishay Traeger","email":"avishay@stratoscale.com","username":"avishay-il"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":1,"date":"2015-01-20 10:08:31.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":13636,"name":"aarefiev","display_name":"Anton","email":"arefyevanton@gmail.com","username":"aarefiev"},{"value":1,"date":"2015-01-19 18:16:17.000000000","permitted_voting_range":{"min":1,"max":2},"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},{"value":2,"date":"2015-01-19 18:18:03.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":1,"default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":4355,"name":"Avishay Traeger","email":"avishay@stratoscale.com","username":"avishay-il"},"all":[{"value":0,"_account_id":5538,"name":"Rushi Agrawal","email":"rushi.openstack@gmail.com","username":"rushiagr"},{"value":0,"_account_id":7219,"name":"git-harry","email":"git-harry@live.co.uk","username":"git-harry"},{"value":1,"date":"2015-01-20 12:06:52.000000000","_account_id":4355,"name":"Avishay Traeger","email":"avishay@stratoscale.com","username":"avishay-il"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":13636,"name":"aarefiev","display_name":"Anton","email":"arefyevanton@gmail.com","username":"aarefiev"},{"value":0,"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},{"value":0,"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"_account_id":5538,"name":"Rushi Agrawal","email":"rushi.openstack@gmail.com","username":"rushiagr"},{"value":0,"_account_id":7219,"name":"git-harry","email":"git-harry@live.co.uk","username":"git-harry"},{"value":0,"_account_id":4355,"name":"Avishay Traeger","email":"avishay@stratoscale.com","username":"avishay-il"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":13636,"name":"aarefiev","display_name":"Anton","email":"arefyevanton@gmail.com","username":"aarefiev"},{"value":0,"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},{"value":0,"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"}],"values":{"-1":"Branch Freeze"," 0":"No Priority","+1":"Important Change","+2":"Gate Blocker Fix / Urgent Change"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},{"_account_id":4355,"name":"Avishay Traeger","email":"avishay@stratoscale.com","username":"avishay-il"},{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},{"_account_id":5538,"name":"Rushi Agrawal","email":"rushi.openstack@gmail.com","username":"rushiagr"},{"_account_id":7219,"name":"git-harry","email":"git-harry@live.co.uk","username":"git-harry"},{"_account_id":13636,"name":"aarefiev","display_name":"Anton","email":"arefyevanton@gmail.com","username":"aarefiev"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2015-01-19 18:16:17.000000000","updated_by":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"reviewer":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"state":"REVIEWER"},{"updated":"2015-01-19 18:18:03.000000000","updated_by":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"reviewer":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"state":"REVIEWER"},{"updated":"2015-01-20 05:05:18.000000000","updated_by":{"_account_id":5538,"name":"Rushi Agrawal","email":"rushi.openstack@gmail.com","username":"rushiagr"},"reviewer":{"_account_id":5538,"name":"Rushi Agrawal","email":"rushi.openstack@gmail.com","username":"rushiagr"},"state":"REVIEWER"},{"updated":"2015-01-20 10:08:31.000000000","updated_by":{"_account_id":13636,"name":"aarefiev","display_name":"Anton","email":"arefyevanton@gmail.com","username":"aarefiev"},"reviewer":{"_account_id":13636,"name":"aarefiev","display_name":"Anton","email":"arefyevanton@gmail.com","username":"aarefiev"},"state":"REVIEWER"},{"updated":"2015-01-20 11:59:34.000000000","updated_by":{"_account_id":7219,"name":"git-harry","email":"git-harry@live.co.uk","username":"git-harry"},"reviewer":{"_account_id":7219,"name":"git-harry","email":"git-harry@live.co.uk","username":"git-harry"},"state":"REVIEWER"},{"updated":"2015-01-20 12:06:52.000000000","updated_by":{"_account_id":4355,"name":"Avishay Traeger","email":"avishay@stratoscale.com","username":"avishay-il"},"reviewer":{"_account_id":4355,"name":"Avishay Traeger","email":"avishay@stratoscale.com","username":"avishay-il"},"state":"REVIEWER"},{"updated":"2015-01-20 12:38:10.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"92efe124755cc522b0f165ce6ce2827ece654fd5","author":{"_account_id":2759,"name":"Huang Zhiteng","email":"winston.d@gmail.com","username":"zhiteng-huang"},"date":"2015-01-15 03:06:16.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"eddd1e8fe9ad5b672ff3413e0061caee46b98137","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-01-15 03:45:45.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-cinderclient-python26 http://logs.openstack.org/74/147374/1/check/gate-python-cinderclient-python26/7c5e8e5/ : SUCCESS in 45s\n- gate-python-cinderclient-pep8 http://logs.openstack.org/74/147374/1/check/gate-python-cinderclient-pep8/241d036/ : SUCCESS in 45s\n- gate-python-cinderclient-docs http://docs-draft.openstack.org/74/147374/1/check/gate-python-cinderclient-docs/6d58b00//doc/build/html/ : SUCCESS in 46s\n- gate-python-cinderclient-python27 http://logs.openstack.org/74/147374/1/check/gate-python-cinderclient-python27/eb09b77/ : SUCCESS in 42s\n- gate-python-cinderclient-python33 http://logs.openstack.org/74/147374/1/check/gate-python-cinderclient-python33/4bfe41d/ : SUCCESS in 1m 45s\n- gate-tempest-dsvm-neutron-src-python-cinderclient http://logs.openstack.org/74/147374/1/check/gate-tempest-dsvm-neutron-src-python-cinderclient/0e64823/ : SUCCESS in 38m 36s\n- gate-tempest-dsvm-neutron-src-python-cinderclient-icehouse http://logs.openstack.org/74/147374/1/check/gate-tempest-dsvm-neutron-src-python-cinderclient-icehouse/24c0578/ : SUCCESS in 28m 19s\n- gate-tempest-dsvm-neutron-src-python-cinderclient-juno http://logs.openstack.org/74/147374/1/check/gate-tempest-dsvm-neutron-src-python-cinderclient-juno/21c6316/ : SUCCESS in 35m 50s\n- gate-python-cinderclient-pypy http://logs.openstack.org/74/147374/1/check/gate-python-cinderclient-pypy/a120837/ : SUCCESS in 1m 24s","accounts_in_message":[],"_revision_number":1},{"id":"4a85df56ca159478f37bfe4536e999de86fdde13","author":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"date":"2015-01-19 18:16:17.000000000","message":"Patch Set 1: Code-Review+1\n\nThanks, Huang! Commented code in VCS is a bad practice.","accounts_in_message":[],"_revision_number":1},{"id":"1bc4eab8c822d5e5755921f38399a370adf71d8d","author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"date":"2015-01-19 18:18:03.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"6456440a8896d8f848c6037d46414e46afff3d05","author":{"_account_id":5538,"name":"Rushi Agrawal","email":"rushi.openstack@gmail.com","username":"rushiagr"},"date":"2015-01-20 05:05:18.000000000","message":"Patch Set 1: Code-Review+1","accounts_in_message":[],"_revision_number":1},{"id":"4edabf46da9fa399602e219787915df700da9f02","author":{"_account_id":13636,"name":"aarefiev","display_name":"Anton","email":"arefyevanton@gmail.com","username":"aarefiev"},"date":"2015-01-20 10:08:31.000000000","message":"Patch Set 1: Code-Review+1","accounts_in_message":[],"_revision_number":1},{"id":"3a4875ab76fc3ae69f2ebad0ff3d5c3c711cdcfb","author":{"_account_id":7219,"name":"git-harry","email":"git-harry@live.co.uk","username":"git-harry"},"date":"2015-01-20 11:59:34.000000000","message":"Patch Set 1: Code-Review+1","accounts_in_message":[],"_revision_number":1},{"id":"d0c97d911378c7d3a1745762959b3ad9481735ca","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-01-20 12:06:52.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":1},{"id":"3f74984effa1ec5d05262294b2bc395726f1af13","author":{"_account_id":4355,"name":"Avishay Traeger","email":"avishay@stratoscale.com","username":"avishay-il"},"date":"2015-01-20 12:06:52.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":1},{"id":"09e9170e66e38b5d20c0f6a218d3b0e59c24c838","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-01-20 12:38:10.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- gate-python-cinderclient-python26 http://logs.openstack.org/74/147374/1/gate/gate-python-cinderclient-python26/99f2575/ : SUCCESS in 44s\n- gate-python-cinderclient-docs http://docs-draft.openstack.org/74/147374/1/gate/gate-python-cinderclient-docs/6afee98//doc/build/html/ : SUCCESS in 1m 16s\n- gate-python-cinderclient-pep8 http://logs.openstack.org/74/147374/1/gate/gate-python-cinderclient-pep8/40b38da/ : SUCCESS in 43s\n- gate-python-cinderclient-python27 http://logs.openstack.org/74/147374/1/gate/gate-python-cinderclient-python27/08a1846/ : SUCCESS in 32s\n- gate-python-cinderclient-python33 http://logs.openstack.org/74/147374/1/gate/gate-python-cinderclient-python33/fd8d595/ : SUCCESS in 1m 58s\n- gate-tempest-dsvm-neutron-src-python-cinderclient http://logs.openstack.org/74/147374/1/gate/gate-tempest-dsvm-neutron-src-python-cinderclient/0088de3/ : SUCCESS in 31m 13s\n- gate-python-cinderclient-pypy http://logs.openstack.org/74/147374/1/gate/gate-python-cinderclient-pypy/5bef57d/ : SUCCESS in 1m 04s","accounts_in_message":[],"_revision_number":1},{"id":"7094ce9e33f363f678642b1070750214cdd75cfa","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-01-20 12:38:12.000000000","message":"Change has been successfully merged into the git repository.","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"200aeae76c54aa72c6eb76bae1657a62efd05308","revisions":{"200aeae76c54aa72c6eb76bae1657a62efd05308":{"kind":"REWORK","_number":1,"created":"2015-01-15 03:06:16.000000000","uploader":{"_account_id":2759,"name":"Huang Zhiteng","email":"winston.d@gmail.com","username":"zhiteng-huang"},"ref":"refs/changes/74/147374/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-cinderclient","ref":"refs/changes/74/147374/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-cinderclient refs/changes/74/147374/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-cinderclient refs/changes/74/147374/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-cinderclient refs/changes/74/147374/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-cinderclient refs/changes/74/147374/1"}}},"commit":{"parents":[{"commit":"fdf6fd1d67f2d0061ad8db1f55feb5bd722f1b9f","subject":"Merge \"Add command to show pool information for backends\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-cinderclient/commit/fdf6fd1d67f2d0061ad8db1f55feb5bd722f1b9f"}]}],"author":{"name":"Zhiteng Huang","email":"zhithuang@ebaysf.com","date":"2015-01-15 02:56:27.000000000","tz":480},"committer":{"name":"Zhiteng Huang","email":"zhithuang@ebaysf.com","date":"2015-01-15 02:56:27.000000000","tz":480},"subject":"Remove commented code in cinderclient/v1/volumes.py","message":"Remove commented code in cinderclient/v1/volumes.py\n\nmigrate_volume_completion() function in Volume class was commented\nout when it was added.  It hasn\u0027t been changed since then.  This\nchange remove it.\n\nChange-Id: Iad8c88e20268265f9063e2faa2a21514439150ad\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-cinderclient/commit/200aeae76c54aa72c6eb76bae1657a62efd05308"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-cinderclient/commit/200aeae76c54aa72c6eb76bae1657a62efd05308"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}