)]}'
{"cinderclient/client.py":[{"author":{"_account_id":7160,"name":"arkady kanevsky","email":"akanevsk@redhat.com","username":"arkady"},"change_message_id":"4fdf26b787c682c20b150dc6928b4f5c5c863413","unresolved":false,"context_lines":[{"line_number":76,"context_line":"        kwargs.setdefault(\u0027authenticated\u0027, False)"},{"line_number":77,"context_line":"        kwargs.setdefault(\u0027raise_exc\u0027, False)"},{"line_number":78,"context_line":"        resp, body \u003d super(SessionClient, self).request(*args, **kwargs)"},{"line_number":79,"context_line":"        if resp.status_code \u003e\u003d 400:"},{"line_number":80,"context_line":"            raise exceptions.from_response(resp, body)"},{"line_number":81,"context_line":"        return resp, body"},{"line_number":82,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"fa81d914_0192fc9e","line":79,"updated":"2015-01-28 22:38:16.000000000","message":"why \u003e\u003d400 instead of \u003e200?","commit_id":"3b8c56f39134f4fedcfc8c2cf11f16db9444edea"},{"author":{"_account_id":10559,"name":"Steven Kaufer","email":"kaufer@us.ibm.com","username":"kaufer"},"change_message_id":"e595ac0bca3d726ab00ae65aa8f1f4c134719897","unresolved":false,"context_lines":[{"line_number":76,"context_line":"        kwargs.setdefault(\u0027authenticated\u0027, False)"},{"line_number":77,"context_line":"        kwargs.setdefault(\u0027raise_exc\u0027, False)"},{"line_number":78,"context_line":"        resp, body \u003d super(SessionClient, self).request(*args, **kwargs)"},{"line_number":79,"context_line":"        if resp.status_code \u003e\u003d 400:"},{"line_number":80,"context_line":"            raise exceptions.from_response(resp, body)"},{"line_number":81,"context_line":"        return resp, body"},{"line_number":82,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"fa81d914_8c862364","line":79,"in_reply_to":"fa81d914_0192fc9e","updated":"2015-01-28 22:50:11.000000000","message":"HTTP status code 2xx means that the request was successful and code 4xx means that the request has erred. We only want to raise an exception for errors.  See [1].\n\nAlso, this is consistent with the keystone client [2].\n\n[1] http://www.w3.org/Protocols/rfc2616/rfc2616-sec10.html\n\n[2] https://github.com/openstack/python-keystoneclient/blob/master/keystoneclient/session.py#L375-L378","commit_id":"3b8c56f39134f4fedcfc8c2cf11f16db9444edea"},{"author":{"_account_id":7160,"name":"arkady kanevsky","email":"akanevsk@redhat.com","username":"arkady"},"change_message_id":"78a488a17de9dc5248500c2f04c80e1366633479","unresolved":false,"context_lines":[{"line_number":75,"context_line":"        kwargs.setdefault(\u0027authenticated\u0027, False)"},{"line_number":76,"context_line":"        kwargs.setdefault(\u0027raise_exc\u0027, False)"},{"line_number":77,"context_line":"        resp, body \u003d super(SessionClient, self).request(*args, **kwargs)"},{"line_number":78,"context_line":"        if resp.status_code \u003e\u003d 400:"},{"line_number":79,"context_line":"            raise exceptions.from_response(resp, body)"},{"line_number":80,"context_line":"        return resp, body"},{"line_number":81,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"9aa53dc9_688617bb","line":78,"updated":"2015-04-06 13:50:23.000000000","message":"Please, change 400 to 300.","commit_id":"af58fc7ab8b7fc6ea5130650b22156c5bcbebfd0"},{"author":{"_account_id":10559,"name":"Steven Kaufer","email":"kaufer@us.ibm.com","username":"kaufer"},"change_message_id":"350327b3eedc4deaf73b793a8121ad9830e88c16","unresolved":false,"context_lines":[{"line_number":75,"context_line":"        kwargs.setdefault(\u0027authenticated\u0027, False)"},{"line_number":76,"context_line":"        kwargs.setdefault(\u0027raise_exc\u0027, False)"},{"line_number":77,"context_line":"        resp, body \u003d super(SessionClient, self).request(*args, **kwargs)"},{"line_number":78,"context_line":"        if resp.status_code \u003e\u003d 400:"},{"line_number":79,"context_line":"            raise exceptions.from_response(resp, body)"},{"line_number":80,"context_line":"        return resp, body"},{"line_number":81,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"9aa53dc9_13821c53","line":78,"in_reply_to":"9aa53dc9_688617bb","updated":"2015-04-06 13:58:38.000000000","message":"Arkady, I feel like we already had this conversation on v1 of this patch.  You never replied to my last question about this:\n\n- Arkady: But wouldn\u0027t changing the code to raise an error for any status code \u003e\u003d 300 be changing the current logic?\n- As I stated before, IMHO, changing the condition under which an exception is raised should be addressed in a separate patch set.\n\nPlease indicate exactly why you believe that this needs to be changed and why this needs to happen in this patch set.","commit_id":"af58fc7ab8b7fc6ea5130650b22156c5bcbebfd0"}],"cinderclient/tests/unit/test_client.py":[{"author":{"_account_id":7160,"name":"arkady kanevsky","email":"akanevsk@redhat.com","username":"arkady"},"change_message_id":"f240cc12c3d029a772637a2a5c014c6d12d3584f","unresolved":false,"context_lines":[{"line_number":98,"context_line":""},{"line_number":99,"context_line":"        client \u003d cinderclient.client.SessionClient(None)"},{"line_number":100,"context_line":"        self.assertRaises(cinderclient.exceptions.ClientException,"},{"line_number":101,"context_line":"                          client.request)"}],"source_content_type":"text/x-python","patch_set":2,"id":"baa041b7_b1f33c0a","line":101,"updated":"2015-04-02 14:59:24.000000000","message":"suggest adding a mock test for return value between 200 and 400.\nPick one from http://en.wikipedia.org/wiki/List_of_HTTP_status_codes.\nPossible scenario is redirection during upgrade.","commit_id":"af58fc7ab8b7fc6ea5130650b22156c5bcbebfd0"},{"author":{"_account_id":10263,"name":"Vilobh Meshram","email":"vilobhmm@yahoo-inc.com","username":"vilobhmm"},"change_message_id":"c89a70b2bb2e374b729640eed612ff67cf42f635","unresolved":false,"context_lines":[{"line_number":98,"context_line":""},{"line_number":99,"context_line":"        client \u003d cinderclient.client.SessionClient(None)"},{"line_number":100,"context_line":"        self.assertRaises(cinderclient.exceptions.ClientException,"},{"line_number":101,"context_line":"                          client.request)"}],"source_content_type":"text/x-python","patch_set":2,"id":"baa041b7_436ab41b","line":101,"in_reply_to":"baa041b7_71f93480","updated":"2015-04-03 22:07:34.000000000","message":"I agree with Steven that there is no need for an additional test here. I guess the only way we can benefit by adding error code between 200-400 will just display a specific error code.","commit_id":"af58fc7ab8b7fc6ea5130650b22156c5bcbebfd0"},{"author":{"_account_id":10559,"name":"Steven Kaufer","email":"kaufer@us.ibm.com","username":"kaufer"},"change_message_id":"23c347c63f5c9dfceec16c4e9ca7a8829cb0d512","unresolved":false,"context_lines":[{"line_number":98,"context_line":""},{"line_number":99,"context_line":"        client \u003d cinderclient.client.SessionClient(None)"},{"line_number":100,"context_line":"        self.assertRaises(cinderclient.exceptions.ClientException,"},{"line_number":101,"context_line":"                          client.request)"}],"source_content_type":"text/x-python","patch_set":2,"id":"baa041b7_71f93480","line":101,"in_reply_to":"baa041b7_b1f33c0a","updated":"2015-04-02 15:09:18.000000000","message":"I don\u0027t follow.  So the first test verifies a return value of 200 (no exception raised) and then this test verifies a return value of 400 (exception is raised).\n\nThis exercises the function that is being added, what is the purpose of another test?","commit_id":"af58fc7ab8b7fc6ea5130650b22156c5bcbebfd0"}]}