)]}'
{"cinderclient/v2/shell.py":[{"author":{"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},"change_message_id":"e14523aa80ed60c0bfc5a5b267ecb120be7b9e74","unresolved":false,"context_lines":[{"line_number":428,"context_line":"    \"\"\"Explicitly updates the volume state in the Cinder database."},{"line_number":429,"context_line":""},{"line_number":430,"context_line":"    Note that this does not affect whether the volume is actually attached to"},{"line_number":431,"context_line":"    the Nova compute host or instance and can result in an unusable volume."},{"line_number":432,"context_line":"    \"\"\""},{"line_number":433,"context_line":"    failure_flag \u003d False"},{"line_number":434,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"da86d52c_2ae05795","line":431,"updated":"2015-02-04 18:00:36.000000000","message":"Maybe a more general statement as well?\n\nSomething like:\n\"Being a database change only, this has no impact on the true state of the volume and may not match the actual state especially in the case of changes involving the in-use status\"","commit_id":"cea3313fcedef69691bcff16e456c8eed3899028"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"488ed5111de726a189951f9df26319125515fb8e","unresolved":false,"context_lines":[{"line_number":428,"context_line":"    \"\"\"Explicitly updates the volume state in the Cinder database."},{"line_number":429,"context_line":""},{"line_number":430,"context_line":"    Note that this does not affect whether the volume is actually attached to"},{"line_number":431,"context_line":"    the Nova compute host or instance and can result in an unusable volume."},{"line_number":432,"context_line":"    \"\"\""},{"line_number":433,"context_line":"    failure_flag \u003d False"},{"line_number":434,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"da86d52c_3e2dfc95","line":431,"in_reply_to":"da86d52c_2ae05795","updated":"2015-02-04 18:06:41.000000000","message":"I do like this. The more clarity the better. Still, what\u0027s here is definitely an improvement, so like John I\u0027d leave it up to you.","commit_id":"cea3313fcedef69691bcff16e456c8eed3899028"},{"author":{"_account_id":7173,"name":"Scott DAngelo","email":"scott.dangelo@gmail.com","username":"scottda"},"change_message_id":"ed15444cf4f43fb02e1c2f0edf82177de8645226","unresolved":false,"context_lines":[{"line_number":428,"context_line":"    \"\"\"Explicitly updates the volume state in the Cinder database."},{"line_number":429,"context_line":""},{"line_number":430,"context_line":"    Note that this does not affect whether the volume is actually attached to"},{"line_number":431,"context_line":"    the Nova compute host or instance and can result in an unusable volume."},{"line_number":432,"context_line":"    \"\"\""},{"line_number":433,"context_line":"    failure_flag \u003d False"},{"line_number":434,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"da86d52c_618195c2","line":431,"in_reply_to":"da86d52c_2ae05795","updated":"2015-02-04 20:15:49.000000000","message":"Yes, I like this. I think I\u0027ll call out the state \"available\" since that is the one that gets the admin into trouble.\ni.e.\nBeing a database change only, this has no impact on the true state of the volume and may not match the actual state. This can render a volume unusable in the case of change to the \u0027available\u0027 state.","commit_id":"cea3313fcedef69691bcff16e456c8eed3899028"}]}