)]}'
{"cinderclient/tests/v2/fakes.py":[{"author":{"_account_id":10559,"name":"Steven Kaufer","email":"kaufer@us.ibm.com","username":"kaufer"},"change_message_id":"3cfc200db8d1c01382346ef7abe14a1da8fff61f","unresolved":false,"context_lines":[{"line_number":452,"context_line":"            assert \u0027image_name\u0027 in body[action]"},{"line_number":453,"context_line":"            assert \u0027disk_format\u0027 in body[action]"},{"line_number":454,"context_line":"            assert \u0027container_format\u0027 in body[action]"},{"line_number":455,"context_line":"            assert \u0027store\u0027 in body[action]"},{"line_number":456,"context_line":"            assert \u0027is_public\u0027 in body[action]"},{"line_number":457,"context_line":"            assert \u0027protected\u0027 in body[action]"},{"line_number":458,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":3,"id":"da86d52c_5ecd502f","line":455,"updated":"2015-02-18 15:19:44.000000000","message":"Is the \u0027store\u0027 attribute required?  In volumes.py you added:\n\n    if store is not None:\n        params[\u0027store\u0027] \u003d store","commit_id":"c6e38df5fe3f3f71dfb4cd784689ef60a9da3f03"},{"author":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"change_message_id":"9852d6e4c5461f576bc305c848203d9271682fd3","unresolved":false,"context_lines":[{"line_number":452,"context_line":"            assert \u0027image_name\u0027 in body[action]"},{"line_number":453,"context_line":"            assert \u0027disk_format\u0027 in body[action]"},{"line_number":454,"context_line":"            assert \u0027container_format\u0027 in body[action]"},{"line_number":455,"context_line":"            assert \u0027store\u0027 in body[action]"},{"line_number":456,"context_line":"            assert \u0027is_public\u0027 in body[action]"},{"line_number":457,"context_line":"            assert \u0027protected\u0027 in body[action]"},{"line_number":458,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":3,"id":"da86d52c_f01376b5","line":455,"in_reply_to":"da86d52c_5ecd502f","updated":"2015-02-22 16:59:41.000000000","message":"I have set default value of Store to None. So Store will be always there in body[action]. If required I will remove this.","commit_id":"c6e38df5fe3f3f71dfb4cd784689ef60a9da3f03"}],"cinderclient/tests/v2/test_volumes.py":[{"author":{"_account_id":10559,"name":"Steven Kaufer","email":"kaufer@us.ibm.com","username":"kaufer"},"change_message_id":"3cfc200db8d1c01382346ef7abe14a1da8fff61f","unresolved":false,"context_lines":[{"line_number":161,"context_line":"    def test_upload_volume(self):"},{"line_number":162,"context_line":"        v \u003d cs.volumes.get(\u00271234\u0027)"},{"line_number":163,"context_line":"        cs.volumes.upload_to_image(v, False, \u0027img_name\u0027, \u0027bare\u0027, \u0027raw\u0027,"},{"line_number":164,"context_line":"                                   \u0027file\u0027, True, True,)"},{"line_number":165,"context_line":"        cs.assert_called(\u0027POST\u0027, \u0027/volumes/1234/action\u0027)"},{"line_number":166,"context_line":""},{"line_number":167,"context_line":"    def test_migrate(self):"}],"source_content_type":"text/x-python","patch_set":3,"id":"da86d52c_3e17bca4","line":164,"updated":"2015-02-18 15:19:44.000000000","message":"Please remove trailing comma","commit_id":"c6e38df5fe3f3f71dfb4cd784689ef60a9da3f03"},{"author":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"change_message_id":"9852d6e4c5461f576bc305c848203d9271682fd3","unresolved":false,"context_lines":[{"line_number":161,"context_line":"    def test_upload_volume(self):"},{"line_number":162,"context_line":"        v \u003d cs.volumes.get(\u00271234\u0027)"},{"line_number":163,"context_line":"        cs.volumes.upload_to_image(v, False, \u0027img_name\u0027, \u0027bare\u0027, \u0027raw\u0027,"},{"line_number":164,"context_line":"                                   \u0027file\u0027, True, True,)"},{"line_number":165,"context_line":"        cs.assert_called(\u0027POST\u0027, \u0027/volumes/1234/action\u0027)"},{"line_number":166,"context_line":""},{"line_number":167,"context_line":"    def test_migrate(self):"}],"source_content_type":"text/x-python","patch_set":3,"id":"da86d52c_90ca3a6c","line":164,"in_reply_to":"da86d52c_3e17bca4","updated":"2015-02-22 16:59:41.000000000","message":"Done","commit_id":"c6e38df5fe3f3f71dfb4cd784689ef60a9da3f03"},{"author":{"_account_id":10559,"name":"Steven Kaufer","email":"kaufer@us.ibm.com","username":"kaufer"},"change_message_id":"3cfc200db8d1c01382346ef7abe14a1da8fff61f","unresolved":false,"context_lines":[{"line_number":162,"context_line":"        v \u003d cs.volumes.get(\u00271234\u0027)"},{"line_number":163,"context_line":"        cs.volumes.upload_to_image(v, False, \u0027img_name\u0027, \u0027bare\u0027, \u0027raw\u0027,"},{"line_number":164,"context_line":"                                   \u0027file\u0027, True, True,)"},{"line_number":165,"context_line":"        cs.assert_called(\u0027POST\u0027, \u0027/volumes/1234/action\u0027)"},{"line_number":166,"context_line":""},{"line_number":167,"context_line":"    def test_migrate(self):"},{"line_number":168,"context_line":"        v \u003d cs.volumes.get(\u00271234\u0027)"}],"source_content_type":"text/x-python","patch_set":3,"id":"da86d52c_5e7f10df","line":165,"updated":"2015-02-18 15:19:44.000000000","message":"You should also verify that the body is formatted correctly; for an example see line 100","commit_id":"c6e38df5fe3f3f71dfb4cd784689ef60a9da3f03"}],"cinderclient/v2/volumes.py":[{"author":{"_account_id":10559,"name":"Steven Kaufer","email":"kaufer@us.ibm.com","username":"kaufer"},"change_message_id":"3cfc200db8d1c01382346ef7abe14a1da8fff61f","unresolved":false,"context_lines":[{"line_number":424,"context_line":"                  \u0027is_public\u0027: is_public,"},{"line_number":425,"context_line":"                  \u0027protected\u0027: protected}"},{"line_number":426,"context_line":"        if store is not None:"},{"line_number":427,"context_line":"            params[\u0027store\u0027] \u003d store"},{"line_number":428,"context_line":""},{"line_number":429,"context_line":"        return self._action(\u0027os-volume_upload_image\u0027,"},{"line_number":430,"context_line":"                            volume,"}],"source_content_type":"text/x-python","patch_set":3,"id":"da86d52c_3ec17ce4","line":427,"updated":"2015-02-18 15:19:44.000000000","message":"Looks like you are missing UT for the case when \u0027store\u0027 is None.","commit_id":"c6e38df5fe3f3f71dfb4cd784689ef60a9da3f03"},{"author":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"change_message_id":"9852d6e4c5461f576bc305c848203d9271682fd3","unresolved":false,"context_lines":[{"line_number":424,"context_line":"                  \u0027is_public\u0027: is_public,"},{"line_number":425,"context_line":"                  \u0027protected\u0027: protected}"},{"line_number":426,"context_line":"        if store is not None:"},{"line_number":427,"context_line":"            params[\u0027store\u0027] \u003d store"},{"line_number":428,"context_line":""},{"line_number":429,"context_line":"        return self._action(\u0027os-volume_upload_image\u0027,"},{"line_number":430,"context_line":"                            volume,"}],"source_content_type":"text/x-python","patch_set":3,"id":"da86d52c_f0d45621","line":427,"in_reply_to":"da86d52c_3ec17ce4","updated":"2015-02-22 16:59:41.000000000","message":"I will add the UT for when store is None","commit_id":"c6e38df5fe3f3f71dfb4cd784689ef60a9da3f03"}]}