)]}'
{"id":"openstack%2Fpython-cinderclient~15300","triplet_id":"openstack%2Fpython-cinderclient~master~Iafae444a43c76560020a84e3a1c5c8cb4b6860da","project":"openstack/python-cinderclient","branch":"master","topic":"bug/1052161","hashtags":[],"change_id":"Iafae444a43c76560020a84e3a1c5c8cb4b6860da","subject":"Fixes setup compatibility issue on Windows","status":"MERGED","created":"2012-11-02 20:18:42.000000000","updated":"2012-11-06 20:24:32.000000000","submitted":"2012-11-06 20:24:32.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"d53638bd56ed78a03f7c84dee39d2384400e61d5","_number":15300,"virtual_id_number":15300,"owner":{"_account_id":3185,"name":"Alessandro Pilotti","email":"apilotti@cloudbasesolutions.com","username":"alexpilotti"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":0,"_account_id":3185,"name":"Alessandro Pilotti","email":"apilotti@cloudbasesolutions.com","username":"alexpilotti"},{"value":0,"_account_id":1313,"name":"yaguang","display_name":"Yaguang Tang","email":"heut2008@gmail.com","username":"heut2008"},{"value":2,"date":"2012-11-06 20:24:32.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},{"value":0,"_account_id":2634,"name":"Peng Yong","email":"ppyy@pubyun.com","username":"ppyy"},{"value":0,"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},"all":[{"value":0,"date":"2012-11-06 18:56:17.000000000","permitted_voting_range":{"min":0,"max":1},"_account_id":3185,"name":"Alessandro Pilotti","email":"apilotti@cloudbasesolutions.com","username":"alexpilotti"},{"value":0,"_account_id":1313,"name":"yaguang","display_name":"Yaguang Tang","email":"heut2008@gmail.com","username":"heut2008"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":2,"date":"2012-11-06 17:42:02.000000000","_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},{"value":0,"_account_id":2634,"name":"Peng Yong","email":"ppyy@pubyun.com","username":"ppyy"},{"value":1,"date":"2012-11-06 18:19:14.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},"all":[{"value":0,"_account_id":3185,"name":"Alessandro Pilotti","email":"apilotti@cloudbasesolutions.com","username":"alexpilotti"},{"value":0,"_account_id":1313,"name":"yaguang","display_name":"Yaguang Tang","email":"heut2008@gmail.com","username":"heut2008"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":1,"date":"2012-11-06 18:19:56.000000000","_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},{"value":0,"_account_id":2634,"name":"Peng Yong","email":"ppyy@pubyun.com","username":"ppyy"},{"value":0,"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"_account_id":3185,"name":"Alessandro Pilotti","email":"apilotti@cloudbasesolutions.com","username":"alexpilotti"},{"value":0,"_account_id":1313,"name":"yaguang","display_name":"Yaguang Tang","email":"heut2008@gmail.com","username":"heut2008"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},{"value":0,"_account_id":2634,"name":"Peng Yong","email":"ppyy@pubyun.com","username":"ppyy"},{"value":0,"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"}],"values":{"-1":"Branch Freeze"," 0":"No Priority","+1":"Important Change","+2":"Gate Blocker Fix / Urgent Change"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":1313,"name":"yaguang","display_name":"Yaguang Tang","email":"heut2008@gmail.com","username":"heut2008"},{"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},{"_account_id":2634,"name":"Peng Yong","email":"ppyy@pubyun.com","username":"ppyy"},{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},{"_account_id":3185,"name":"Alessandro Pilotti","email":"apilotti@cloudbasesolutions.com","username":"alexpilotti"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2012-11-03 11:22:48.000000000","updated_by":{"_account_id":2634,"name":"Peng Yong","email":"ppyy@pubyun.com","username":"ppyy"},"reviewer":{"_account_id":2634,"name":"Peng Yong","email":"ppyy@pubyun.com","username":"ppyy"},"state":"REVIEWER"},{"updated":"2012-11-05 13:05:35.000000000","updated_by":{"_account_id":1313,"name":"yaguang","display_name":"Yaguang Tang","email":"heut2008@gmail.com","username":"heut2008"},"reviewer":{"_account_id":1313,"name":"yaguang","display_name":"Yaguang Tang","email":"heut2008@gmail.com","username":"heut2008"},"state":"REVIEWER"},{"updated":"2012-11-06 18:19:14.000000000","updated_by":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"reviewer":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"state":"REVIEWER"},{"updated":"2012-11-06 18:19:56.000000000","updated_by":{"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},"reviewer":{"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},"state":"REVIEWER"},{"updated":"2012-11-06 20:24:32.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"e1faa55db94aa3e3690b0f96652cec8fdaf03786","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2012-11-02 20:20:34.000000000","message":"Patch Set 1: Works for me\n\nBuild successful\n\n- http://logs.openstack.org/15300/1/check/gate-python-cinderclient-merge/141 : SUCCESS\n- http://logs.openstack.org/15300/1/check/gate-python-cinderclient-docs/109 : SUCCESS\n- http://logs.openstack.org/15300/1/check/gate-python-cinderclient-pep8/139 : SUCCESS\n- http://logs.openstack.org/15300/1/check/gate-python-cinderclient-python26/138 : SUCCESS\n- http://logs.openstack.org/15300/1/check/gate-python-cinderclient-python27/139 : SUCCESS\n","accounts_in_message":[],"_revision_number":1},{"id":"ce239d42a26f5f1a66df5c66f8e22d13b07d8f3f","author":{"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},"date":"2012-11-02 21:18:44.000000000","message":"Patch Set 1: Looks good to me (core reviewer)\n\n","accounts_in_message":[],"_revision_number":1},{"id":"273a45865ce3e4a6a9786878cc61f29b4db5ec6f","author":{"_account_id":2634,"name":"Peng Yong","email":"ppyy@pubyun.com","username":"ppyy"},"date":"2012-11-03 11:22:48.000000000","message":"Patch Set 1: Looks good to me, but someone else must approve\n\n","accounts_in_message":[],"_revision_number":1},{"id":"f2a209b04a506e581b440125dd4f3520b4bed303","author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"date":"2012-11-03 11:44:08.000000000","message":"Patch Set 1: I would prefer that you didn\u0027t merge this\n\nThis should land in OpenStack common first, and sync across.","accounts_in_message":[],"_revision_number":1},{"id":"d8030e985991e42170d1bb9a1c26854fcaf06422","author":{"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},"date":"2012-11-03 15:10:38.000000000","message":"Patch Set 1: No score\n\n","accounts_in_message":[],"_revision_number":1},{"id":"2eb30bb2bbc3987baf65ef6ef872e24b58a19f01","author":{"_account_id":3185,"name":"Alessandro Pilotti","email":"apilotti@cloudbasesolutions.com","username":"alexpilotti"},"date":"2012-11-03 19:11:36.000000000","message":"Patch Set 1:\n\nSean,\n\nWe discussed about committing to openstack-common only and we agreed on committing on all the affected python-*clients.\n\nThe patches for python-novaclient and python-keystoneclient have been  committed already.","accounts_in_message":[],"_revision_number":1},{"id":"b867d182f377ed08f2cc8119ecabe88e7562d39f","author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"date":"2012-11-03 20:46:11.000000000","message":"Patch Set 1:\n\nIs there a reference to this discussion? The general policy is that nothing should deviate openstack/common directory in any project from what\u0027s in upstream openstack/common. It lands there first, then update.py is used to sync it from there. http://wiki.openstack.org/CommonLibrary\n\nThis is a good fix, but it should go in through the right process.","accounts_in_message":[],"_revision_number":1},{"id":"fcd9c3c98d81e2eeef95911ab3494cbf51b1e57b","author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"date":"2012-11-03 20:51:49.000000000","message":"Patch Set 1:\n\nbecause this policy wasn\u0027t followed previously, the fix was since removed from nova - https://github.com/openstack/python-novaclient/blob/master/novaclient/openstack/common/setup.py\n\nEverything under openstack/common is managed copy, not to be edited directly by commits.","accounts_in_message":[],"_revision_number":1},{"id":"470413882196e2bb6489cb754e0a42a23c564198","author":{"_account_id":3185,"name":"Alessandro Pilotti","email":"apilotti@cloudbasesolutions.com","username":"alexpilotti"},"date":"2012-11-05 09:03:44.000000000","message":"Patch Set 1:\n\nSean, \n\nok thanks for clarifying. Do we have to resubmit now the same patch on Nova, Quantum, Glance etc or it will be automatically merged? In the second case, how much time will it take?","accounts_in_message":[],"_revision_number":1},{"id":"9f8834f655df4688cfe3f60ba193588710eaa822","author":{"_account_id":1313,"name":"yaguang","display_name":"Yaguang Tang","email":"heut2008@gmail.com","username":"heut2008"},"date":"2012-11-05 13:05:35.000000000","message":"Patch Set 1:\n\nthis has been fixed on openstack-common. https://review.openstack.org/#/c/15329/.\nwe do need fix it on openstack-common first,then sync periodly to anther projects. but I guess thanks to this is a serious bug,so it didn\u0027t follow the normal way.we should avoid doing this in the future.","accounts_in_message":[],"_revision_number":1},{"id":"fb7bf5f824c64955a10712b9ced58323e7f961ef","author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"date":"2012-11-06 13:41:14.000000000","message":"Patch Set 1:\n\nyes, you should resubmit with the update to make sure that this file is in sync with setup.py in openstack-common","accounts_in_message":[],"_revision_number":1},{"id":"9ca740b98c2dc70a6969dfb3d848c2a42c65e96f","author":{"_account_id":3185,"name":"Alessandro Pilotti","email":"apilotti@cloudbasesolutions.com","username":"alexpilotti"},"date":"2012-11-06 17:40:34.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"fe1c592a8aec13983bd94ffa37103fb0a406b928","author":{"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},"date":"2012-11-06 17:42:02.000000000","message":"Patch Set 2: Looks good to me (core reviewer)\n\nCool, thank Alessandro!","accounts_in_message":[],"_revision_number":2},{"id":"6b0b9ced99109a21a40949ab5958895533a5e670","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2012-11-06 18:02:49.000000000","message":"Patch Set 2: Works for me\n\nBuild successful\n\n- http://logs.openstack.org/15300/2/check/gate-python-cinderclient-merge/147 : SUCCESS\n- http://logs.openstack.org/15300/2/check/gate-python-cinderclient-docs/115 : SUCCESS\n- http://logs.openstack.org/15300/2/check/gate-python-cinderclient-pep8/145 : SUCCESS\n- http://logs.openstack.org/15300/2/check/gate-python-cinderclient-python26/144 : SUCCESS\n- http://logs.openstack.org/15300/2/check/gate-python-cinderclient-python27/145 : SUCCESS\n- http://logs.openstack.org/15300/2/check/gate-tempest-devstack-vm/17274 : SUCCESS\n","accounts_in_message":[],"_revision_number":2},{"id":"d1d0e7dc35ec1b3531820b43a303a3f263db013b","author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"date":"2012-11-06 18:19:14.000000000","message":"Patch Set 2: Looks good to me, but someone else must approve\n\n","accounts_in_message":[],"_revision_number":2},{"id":"8ac0747a7ad72c09aaa7da30776ea2d909b2a771","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2012-11-06 18:19:56.000000000","message":"Patch Set 2: No score\n\nStarting gate jobs.\nhttps://jenkins.openstack.org/zuul/status","accounts_in_message":[],"_revision_number":2},{"id":"3495f583a7501cb908edcc773643ef937ff9fd3c","author":{"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},"date":"2012-11-06 18:19:56.000000000","message":"Patch Set 2: Approved\n\n","accounts_in_message":[],"_revision_number":2},{"id":"74ee751218a2b37a1db529440c3520b609ed4136","author":{"_account_id":3185,"name":"Alessandro Pilotti","email":"apilotti@cloudbasesolutions.com","username":"alexpilotti"},"date":"2012-11-06 18:56:17.000000000","message":"Patch Set 2:\n\nreverify","accounts_in_message":[],"_revision_number":2},{"id":"849f92c11a446a6d35fa0b20f2b066214016650c","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2012-11-06 20:24:32.000000000","message":"Patch Set 2: Verified\n\nBuild successful\n\n- http://logs.openstack.org/15300/2/gate/gate-python-cinderclient-merge/150 : SUCCESS\n- http://logs.openstack.org/15300/2/gate/gate-python-cinderclient-docs/118 : SUCCESS\n- http://logs.openstack.org/15300/2/gate/gate-python-cinderclient-pep8/148 : SUCCESS\n- http://logs.openstack.org/15300/2/gate/gate-python-cinderclient-python26/147 : SUCCESS\n- http://logs.openstack.org/15300/2/gate/gate-python-cinderclient-python27/148 : SUCCESS\n- http://logs.openstack.org/15300/2/gate/gate-tempest-devstack-vm/17318 : SUCCESS\n","accounts_in_message":[],"_revision_number":2},{"id":"a97cc8f6472ca836efebcc1c44e861c3c177e8c2","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2012-11-06 20:24:32.000000000","message":"Change has been successfully merged into the git repository.","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"1abc0b4edfa70485cd32bac2060b1b223850752e","revisions":{"74c2e44e5820b17bec31efb4f2e2090a26c003d1":{"kind":"REWORK","_number":1,"created":"2012-11-02 20:18:42.000000000","uploader":{"_account_id":3185,"name":"Alessandro Pilotti","email":"apilotti@cloudbasesolutions.com","username":"alexpilotti"},"ref":"refs/changes/00/15300/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-cinderclient","ref":"refs/changes/00/15300/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-cinderclient refs/changes/00/15300/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-cinderclient refs/changes/00/15300/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-cinderclient refs/changes/00/15300/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-cinderclient refs/changes/00/15300/1"}}},"commit":{"parents":[{"commit":"3b1eda3b3bb6678e9c9ec3e783e3e12b0c42f0a4","subject":"Add retries to cinderclient.","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-cinderclient/commit/3b1eda3b3bb6678e9c9ec3e783e3e12b0c42f0a4"}]}],"author":{"name":"Alessandro Pilotti","email":"ap@pilotti.it","date":"2012-11-02 20:16:01.000000000","tz":120},"committer":{"name":"Alessandro Pilotti","email":"ap@pilotti.it","date":"2012-11-02 20:16:01.000000000","tz":120},"subject":"Fixes setup compatibility issue on Windows","message":"Fixes setup compatibility issue on Windows\n\nFixes Bug #1052161\n\n\"python setup.py build\" fails on Windows due to a hardcoded shell path:\n/bin/sh\n\nChange-Id: Iafae444a43c76560020a84e3a1c5c8cb4b6860da\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-cinderclient/commit/74c2e44e5820b17bec31efb4f2e2090a26c003d1"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-cinderclient/commit/74c2e44e5820b17bec31efb4f2e2090a26c003d1"}]},"branch":"refs/heads/master"},"1abc0b4edfa70485cd32bac2060b1b223850752e":{"kind":"REWORK","_number":2,"created":"2012-11-06 17:40:34.000000000","uploader":{"_account_id":3185,"name":"Alessandro Pilotti","email":"apilotti@cloudbasesolutions.com","username":"alexpilotti"},"ref":"refs/changes/00/15300/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-cinderclient","ref":"refs/changes/00/15300/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-cinderclient refs/changes/00/15300/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-cinderclient refs/changes/00/15300/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-cinderclient refs/changes/00/15300/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-cinderclient refs/changes/00/15300/2"}}},"commit":{"parents":[{"commit":"dcbebd7b78235008e36fe6b8c8cc4a75f5031042","subject":"Revert \"Add retries to cinderclient.\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-cinderclient/commit/dcbebd7b78235008e36fe6b8c8cc4a75f5031042"}]}],"author":{"name":"Alessandro Pilotti","email":"ap@pilotti.it","date":"2012-11-06 17:38:28.000000000","tz":120},"committer":{"name":"Alessandro Pilotti","email":"ap@pilotti.it","date":"2012-11-06 17:38:28.000000000","tz":120},"subject":"Fixes setup compatibility issue on Windows","message":"Fixes setup compatibility issue on Windows\n\nFixes Bug #1052161\n\n\"python setup.py build\" fails on Windows due to a hardcoded shell path:\n/bin/sh\n\nsetup.py updated using openstack-common/update.py\n\nChange-Id: Iafae444a43c76560020a84e3a1c5c8cb4b6860da\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-cinderclient/commit/1abc0b4edfa70485cd32bac2060b1b223850752e"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-cinderclient/commit/1abc0b4edfa70485cd32bac2060b1b223850752e"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}