)]}'
{"cinderclient/tests/test_auth_plugins.py":[{"author":{"_account_id":10559,"name":"Steven Kaufer","email":"kaufer@us.ibm.com","username":"kaufer"},"change_message_id":"284891487f29ced9aec7b43a7787239cfc9ef03c","unresolved":false,"context_lines":[{"line_number":235,"context_line":"            **self.TEST_REQUEST_BASE)"},{"line_number":236,"context_line":""},{"line_number":237,"context_line":"    def test_auth_system_success(self):"},{"line_number":238,"context_line":"        \"\"\"Test that we can authenticate using the auth system.\"\"\""},{"line_number":239,"context_line":"        self._test_auth_success()"},{"line_number":240,"context_line":""},{"line_number":241,"context_line":"    def test_auth_bypass_url(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"da86d52c_275bfbf6","line":238,"updated":"2015-02-05 21:01:45.000000000","message":"I\u0027m wondering if you cloud verify how the different kwargs in these 3 functions affect the functionality?\n\nCould you verify the relevant attributes on the client based on the supplied kwargs?  Maybe the \u0027management_url\u0027, \u0027proxy_url\u0027 and \u0027proxy_token\u0027 attributes?\n\nHow about changing the _test_auth_success to return the cs.client and then verifying the the attributes on the client in the functions below?\n\nAlso, please update the docstring to differentiate the 3 different tests (right now they all match).","commit_id":"62f54486b82a3a00851f0fe6b391c31ad69a8f45"},{"author":{"_account_id":10559,"name":"Steven Kaufer","email":"kaufer@us.ibm.com","username":"kaufer"},"change_message_id":"284891487f29ced9aec7b43a7787239cfc9ef03c","unresolved":false,"context_lines":[{"line_number":240,"context_line":""},{"line_number":241,"context_line":"    def test_auth_bypass_url(self):"},{"line_number":242,"context_line":"        \"\"\"Test that we can authenticate using the auth system.\"\"\""},{"line_number":243,"context_line":"        self._test_auth_success(bypass_url\u003d\u0027auth_url2/v2.0\u0027)"},{"line_number":244,"context_line":""},{"line_number":245,"context_line":"    def test_auth_bypass_url_proxy_token(self):"},{"line_number":246,"context_line":"        \"\"\"Test that we can authenticate using the auth system.\"\"\""}],"source_content_type":"text/x-python","patch_set":1,"id":"da86d52c_87574725","line":243,"updated":"2015-02-05 21:01:45.000000000","message":"For example, maybe this could change to:\n\n    client \u003d self._test_auth_success(bypass_url\u003d\u0027auth_url2/v2.0\u0027)\n    self.assertEqual(\u0027auth_url2/v2.0\u0027, client.bypass_url)\n    self.assertEqual(\u0027auth_url2/v2.0\u0027, client.management_url)\n    self.assertIsNone(client.proxy_token)","commit_id":"62f54486b82a3a00851f0fe6b391c31ad69a8f45"}],"cinderclient/tests/unit/test_auth_plugins.py":[{"author":{"_account_id":2861,"name":"Vincent Hou","email":"shou@us.ibm.com","username":"houshengbo"},"change_message_id":"270a68a1f3d0530907e3ee4d43be4bac3ca699b2","unresolved":false,"context_lines":[{"line_number":217,"context_line":""},{"line_number":218,"context_line":"        auth_plugin.discover_auth_systems()"},{"line_number":219,"context_line":"        plugin \u003d auth_plugin.load_plugin(\"fake\")"},{"line_number":220,"context_line":""},{"line_number":221,"context_line":"        cs \u003d client.Client(\"username\", \"password\", \"project_id\","},{"line_number":222,"context_line":"                           \"auth_url/v2.0\", auth_system\u003d\"fake\","},{"line_number":223,"context_line":"                           auth_plugin\u003dplugin, **client_kwargs)"}],"source_content_type":"text/x-python","patch_set":3,"id":"3afb71cf_5d3874a0","line":220,"updated":"2015-06-08 08:02:31.000000000","message":"Additional line?","commit_id":"0245ebc1f5b5a4ed743f10846b5dd37506f63154"},{"author":{"_account_id":2861,"name":"Vincent Hou","email":"shou@us.ibm.com","username":"houshengbo"},"change_message_id":"270a68a1f3d0530907e3ee4d43be4bac3ca699b2","unresolved":false,"context_lines":[{"line_number":255,"context_line":"                                    bypass_url\u003d\u0027auth_url2/v2.0\u0027)"},{"line_number":256,"context_line":"        self.assertEqual(\u0027auth_url2/v2.0\u0027, c.bypass_url)"},{"line_number":257,"context_line":"        self.assertEqual(\u0027auth_url2/v2.0\u0027, c.management_url)"},{"line_number":258,"context_line":"        self.assertEqual(c.proxy_token, \u0027abc\u0027)"},{"line_number":259,"context_line":""},{"line_number":260,"context_line":"    @mock.patch.object(pkg_resources, \"iter_entry_points\")"},{"line_number":261,"context_line":"    def test_discover_auth_system_options(self, mock_iter_entry_points):"}],"source_content_type":"text/x-python","patch_set":3,"id":"3afb71cf_1df43cf0","line":258,"updated":"2015-06-08 08:02:31.000000000","message":"Expected value first and then actual value.","commit_id":"0245ebc1f5b5a4ed743f10846b5dd37506f63154"}]}