)]}'
{"id":"openstack%2Fpython-cinderclient~161862","triplet_id":"openstack%2Fpython-cinderclient~master~Iecd5bbe52ea4af0cb4911629eacb1b8a7a173c5c","project":"openstack/python-cinderclient","branch":"master","topic":"bug/1428764","hashtags":[],"change_id":"Iecd5bbe52ea4af0cb4911629eacb1b8a7a173c5c","subject":"Raise the right exceptions in client.SessionClient","status":"ABANDONED","created":"2015-03-05 19:53:00.000000000","updated":"2015-03-27 08:46:31.000000000","total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"8237f48f568995ac6fb74fd71509ee280c90faa1","_number":161862,"virtual_id_number":161862,"owner":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"actions":{},"labels":{"Verified":{"recommended":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"_account_id":1011,"name":"Tushar Patil","email":"tushar.vitthal.patil@gmail.com","username":"tpatil"},{"value":1,"date":"2015-03-05 21:07:11.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":7764,"name":"Peter Hamilton","email":"peter.hamilton@jhuapl.edu","username":"Peter"},{"date":"2015-03-23 09:52:36.000000000","_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},{"_account_id":14271,"name":"Kallebe Monteiro","email":"kallebe.monteiro@lsbd.ufc.br","username":"kallebe"},{"_account_id":11903,"name":"Anthony Lee","email":"anthony.mic.lee@hpe.com","username":"leeantho"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":1,"default_value":0,"optional":true},"Code-Review":{"recommended":{"_account_id":11903,"name":"Anthony Lee","email":"anthony.mic.lee@hpe.com","username":"leeantho"},"disliked":{"_account_id":1011,"name":"Tushar Patil","email":"tushar.vitthal.patil@gmail.com","username":"tpatil"},"all":[{"value":-1,"date":"2015-03-20 23:24:13.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":1011,"name":"Tushar Patil","email":"tushar.vitthal.patil@gmail.com","username":"tpatil"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":1,"date":"2015-03-14 18:26:55.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":7764,"name":"Peter Hamilton","email":"peter.hamilton@jhuapl.edu","username":"Peter"},{"value":0,"permitted_voting_range":{"min":-2,"max":2},"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},{"value":1,"date":"2015-03-20 11:53:54.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":14271,"name":"Kallebe Monteiro","email":"kallebe.monteiro@lsbd.ufc.br","username":"kallebe"},{"value":1,"date":"2015-03-19 22:34:52.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":11903,"name":"Anthony Lee","email":"anthony.mic.lee@hpe.com","username":"leeantho"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":-1,"default_value":0,"optional":true},"Workflow":{"all":[{"_account_id":1011,"name":"Tushar Patil","email":"tushar.vitthal.patil@gmail.com","username":"tpatil"},{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":7764,"name":"Peter Hamilton","email":"peter.hamilton@jhuapl.edu","username":"Peter"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},{"_account_id":14271,"name":"Kallebe Monteiro","email":"kallebe.monteiro@lsbd.ufc.br","username":"kallebe"},{"_account_id":11903,"name":"Anthony Lee","email":"anthony.mic.lee@hpe.com","username":"leeantho"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"_account_id":1011,"name":"Tushar Patil","email":"tushar.vitthal.patil@gmail.com","username":"tpatil"},{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":7764,"name":"Peter Hamilton","email":"peter.hamilton@jhuapl.edu","username":"Peter"},{"value":0,"permitted_voting_range":{"min":-1,"max":2},"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},{"_account_id":14271,"name":"Kallebe Monteiro","email":"kallebe.monteiro@lsbd.ufc.br","username":"kallebe"},{"_account_id":11903,"name":"Anthony Lee","email":"anthony.mic.lee@hpe.com","username":"leeantho"}],"values":{"-1":"Branch Freeze"," 0":"No Priority","+1":"Important Change","+2":"Gate Blocker Fix / Urgent Change"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":1011,"name":"Tushar Patil","email":"tushar.vitthal.patil@gmail.com","username":"tpatil"},{"_account_id":7764,"name":"Peter Hamilton","email":"peter.hamilton@jhuapl.edu","username":"Peter"},{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},{"_account_id":11903,"name":"Anthony Lee","email":"anthony.mic.lee@hpe.com","username":"leeantho"},{"_account_id":14271,"name":"Kallebe Monteiro","email":"kallebe.monteiro@lsbd.ufc.br","username":"kallebe"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2015-03-05 21:07:11.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"},{"updated":"2015-03-14 18:26:55.000000000","updated_by":{"_account_id":7764,"name":"Peter Hamilton","email":"peter.hamilton@jhuapl.edu","username":"Peter"},"reviewer":{"_account_id":7764,"name":"Peter Hamilton","email":"peter.hamilton@jhuapl.edu","username":"Peter"},"state":"REVIEWER"},{"updated":"2015-03-19 22:34:52.000000000","updated_by":{"_account_id":11903,"name":"Anthony Lee","email":"anthony.mic.lee@hpe.com","username":"leeantho"},"reviewer":{"_account_id":11903,"name":"Anthony Lee","email":"anthony.mic.lee@hpe.com","username":"leeantho"},"state":"REVIEWER"},{"updated":"2015-03-20 11:53:54.000000000","updated_by":{"_account_id":14271,"name":"Kallebe Monteiro","email":"kallebe.monteiro@lsbd.ufc.br","username":"kallebe"},"reviewer":{"_account_id":14271,"name":"Kallebe Monteiro","email":"kallebe.monteiro@lsbd.ufc.br","username":"kallebe"},"state":"REVIEWER"},{"updated":"2015-03-20 23:24:13.000000000","updated_by":{"_account_id":1011,"name":"Tushar Patil","email":"tushar.vitthal.patil@gmail.com","username":"tpatil"},"reviewer":{"_account_id":1011,"name":"Tushar Patil","email":"tushar.vitthal.patil@gmail.com","username":"tpatil"},"state":"REVIEWER"}],"messages":[{"id":"6a71b26b4a227f3239e8a7f176b8e61bb5efb5d3","author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"date":"2015-03-05 19:53:00.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"de5c66535c1cc18e8fa1d180f8ce30e183a761ca","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-03-05 21:07:11.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-cinderclient-python26 http://logs.openstack.org/62/161862/1/check/gate-python-cinderclient-python26/9bb13c5/ : SUCCESS in 1m 00s\n- gate-python-cinderclient-pep8 http://logs.openstack.org/62/161862/1/check/gate-python-cinderclient-pep8/eed877a/ : SUCCESS in 52s\n- gate-python-cinderclient-docs http://docs-draft.openstack.org/62/161862/1/check/gate-python-cinderclient-docs/4ef610d//doc/build/html/ : SUCCESS in 50s\n- gate-python-cinderclient-python27 http://logs.openstack.org/62/161862/1/check/gate-python-cinderclient-python27/e644750/ : SUCCESS in 55s\n- gate-python-cinderclient-python34 http://logs.openstack.org/62/161862/1/check/gate-python-cinderclient-python34/21d8903/ : SUCCESS in 2m 10s\n- gate-tempest-dsvm-neutron-src-python-cinderclient http://logs.openstack.org/62/161862/1/check/gate-tempest-dsvm-neutron-src-python-cinderclient/9eb303a/ : SUCCESS in 53m 00s\n- gate-tempest-dsvm-neutron-src-python-cinderclient-icehouse http://logs.openstack.org/62/161862/1/check/gate-tempest-dsvm-neutron-src-python-cinderclient-icehouse/4610fa4/ : SUCCESS in 22m 40s\n- gate-tempest-dsvm-neutron-src-python-cinderclient-juno http://logs.openstack.org/62/161862/1/check/gate-tempest-dsvm-neutron-src-python-cinderclient-juno/d1ea6f9/ : SUCCESS in 43m 32s\n- gate-python-cinderclient-pypy http://logs.openstack.org/62/161862/1/check/gate-python-cinderclient-pypy/3ca5143/ : SUCCESS in 1m 46s","accounts_in_message":[],"_revision_number":1},{"id":"1080ac4148f1c26d5e1efec4345de8376e2d52fb","author":{"_account_id":7764,"name":"Peter Hamilton","email":"peter.hamilton@jhuapl.edu","username":"Peter"},"date":"2015-03-14 18:26:55.000000000","message":"Patch Set 1: Code-Review+1","accounts_in_message":[],"_revision_number":1},{"id":"f7b033fd2c3d1ec6cff8432a7f228b7af79ae3f8","author":{"_account_id":11903,"name":"Anthony Lee","email":"anthony.mic.lee@hpe.com","username":"leeantho"},"date":"2015-03-19 22:34:52.000000000","message":"Patch Set 1: Code-Review+1","accounts_in_message":[],"_revision_number":1},{"id":"e341e758828b4203319cca3859fee55c4badc702","author":{"_account_id":14271,"name":"Kallebe Monteiro","email":"kallebe.monteiro@lsbd.ufc.br","username":"kallebe"},"date":"2015-03-20 11:53:54.000000000","message":"Patch Set 1: Code-Review+1","accounts_in_message":[],"_revision_number":1},{"id":"4b4dfe71a974d3302d5a197902907b10521ddb16","author":{"_account_id":1011,"name":"Tushar Patil","email":"tushar.vitthal.patil@gmail.com","username":"tpatil"},"date":"2015-03-20 23:24:13.000000000","message":"Patch Set 1: Code-Review-1\n\nI think we should make use of raise_exc parameter instead of catching generic exception and extracting error message information .\n\nI have fixed same issue in this patch https://review.openstack.org/#/c/166351/. You can find similar code already implemented in nova client. \nhttps://github.com/openstack/python-novaclient/blob/master/novaclient/client.py#L86","accounts_in_message":[],"_revision_number":1},{"id":"ec72403c66e21decbd99a80eec443f397f4e4a1e","author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"date":"2015-03-23 09:52:36.000000000","message":"Patch Set 1:\n\nHi Tushar,\n\nYour solution is indeed more elegant. :)\nI\u0027ll post my comments on your patch.","accounts_in_message":[],"_revision_number":1},{"id":"0461ce1bd2f4fda80d6589613acce73edc0771cc","author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"date":"2015-03-27 08:45:07.000000000","message":"Patch Set 1:\n\nI\u0027ll abandon this patch in favor of https://review.openstack.org/#/c/166351","accounts_in_message":[],"_revision_number":1},{"id":"a79546ab4ad4bb959d49266561008c7703215a37","author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"date":"2015-03-27 08:46:31.000000000","message":"Abandoned\n\nPatch https://review.openstack.org/#/c/166351/ solves same issue with a neater implementation.","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"1cd9c4472f33b4717e29e47e73c0e56fbc79d4f5","revisions":{"1cd9c4472f33b4717e29e47e73c0e56fbc79d4f5":{"kind":"REWORK","_number":1,"created":"2015-03-05 19:53:00.000000000","uploader":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"ref":"refs/changes/62/161862/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-cinderclient","ref":"refs/changes/62/161862/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-cinderclient refs/changes/62/161862/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-cinderclient refs/changes/62/161862/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-cinderclient refs/changes/62/161862/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-cinderclient refs/changes/62/161862/1"}}},"commit":{"parents":[{"commit":"7fc093b504dce43c0ef577a229c2b2b834885663","subject":"Merge \"Adopt CLI sorting argument guidelines\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-cinderclient/commit/7fc093b504dce43c0ef577a229c2b2b834885663"}]}],"author":{"name":"Gorka Eguileor","email":"geguileo@redhat.com","date":"2015-03-05 17:43:05.000000000","tz":60},"committer":{"name":"Gorka Eguileor","email":"geguileo@redhat.com","date":"2015-03-05 19:49:46.000000000","tz":60},"subject":"Raise the right exceptions in client.SessionClient","message":"Raise the right exceptions in client.SessionClient\n\nCurrently client.SessionClient raises exceptions from keystone instead\nof raising cinderclient exceptions. This affected get, put, post and\ndelete methods.\n\nThis patch fixes this by mapping existing cinderclient exceptions and\nleaving non-existent exceptions as they are.\n\nChange-Id: Iecd5bbe52ea4af0cb4911629eacb1b8a7a173c5c\nCloses-Bug: #1428764\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-cinderclient/commit/1cd9c4472f33b4717e29e47e73c0e56fbc79d4f5"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-cinderclient/commit/1cd9c4472f33b4717e29e47e73c0e56fbc79d4f5"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}