)]}'
{"cinderclient/utils.py":[{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"6485690a43297bc598f64828a20a21a363026149","unresolved":false,"context_lines":[{"line_number":168,"context_line":"        # now try to get entity as uuid"},{"line_number":169,"context_line":"        try:"},{"line_number":170,"context_line":"            uuid.UUID(name_or_id)"},{"line_number":171,"context_line":"            return manager.get(name_or_id)"},{"line_number":172,"context_line":"        except (ValueError, exceptions.NotFound):"},{"line_number":173,"context_line":"            pass"},{"line_number":174,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"9a80dd14_d245c3b4","line":171,"updated":"2015-03-19 10:26:06.000000000","message":"Because we don\u0027t need to safe decode the string if it\u0027s a UUID (only digits and -) and if it\u0027s not a UUID it will throw ValueError regardless of the encoding.","commit_id":"5aed2d13fb12ae59bedc349a02cfc92dfcdaddf1"},{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"c872f0687ef33e4c49f49b57e410da7d310434ab","unresolved":false,"context_lines":[{"line_number":168,"context_line":"        # now try to get entity as uuid"},{"line_number":169,"context_line":"        try:"},{"line_number":170,"context_line":"            uuid.UUID(name_or_id)"},{"line_number":171,"context_line":"            return manager.get(name_or_id)"},{"line_number":172,"context_line":"        except (ValueError, exceptions.NotFound):"},{"line_number":173,"context_line":"            pass"},{"line_number":174,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"9a80dd14_83230404","line":171,"updated":"2015-03-19 09:57:26.000000000","message":"Why are you moving this before safe_decode?","commit_id":"5aed2d13fb12ae59bedc349a02cfc92dfcdaddf1"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"6485690a43297bc598f64828a20a21a363026149","unresolved":false,"context_lines":[{"line_number":181,"context_line":"        except exceptions.NotFound:"},{"line_number":182,"context_line":"            pass"},{"line_number":183,"context_line":""},{"line_number":184,"context_line":"        # finally try to find entity by name"},{"line_number":185,"context_line":"        try:"},{"line_number":186,"context_line":"            return manager.find(name\u003dname_or_id)"},{"line_number":187,"context_line":"        except exceptions.NotFound:"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a80dd14_f242c7a9","line":184,"updated":"2015-03-19 10:26:06.000000000","message":"Good point, I\u0027ll update the comment.","commit_id":"5aed2d13fb12ae59bedc349a02cfc92dfcdaddf1"},{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"c872f0687ef33e4c49f49b57e410da7d310434ab","unresolved":false,"context_lines":[{"line_number":181,"context_line":"        except exceptions.NotFound:"},{"line_number":182,"context_line":"            pass"},{"line_number":183,"context_line":""},{"line_number":184,"context_line":"        # finally try to find entity by name"},{"line_number":185,"context_line":"        try:"},{"line_number":186,"context_line":"            return manager.find(name\u003dname_or_id)"},{"line_number":187,"context_line":"        except exceptions.NotFound:"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a80dd14_e3604037","line":184,"updated":"2015-03-19 09:57:26.000000000","message":"This isn\u0027t our final try, so finally is confusing here.","commit_id":"5aed2d13fb12ae59bedc349a02cfc92dfcdaddf1"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"751b273c973fdbdcca26ed274a434511280a88e8","unresolved":false,"context_lines":[{"line_number":166,"context_line":"            return manager.get(int(name_or_id))"},{"line_number":167,"context_line":"    except exceptions.NotFound:"},{"line_number":168,"context_line":"        pass"},{"line_number":169,"context_line":"    else:"},{"line_number":170,"context_line":"        # now try to get entity as uuid"},{"line_number":171,"context_line":"        try:"},{"line_number":172,"context_line":"            uuid.UUID(name_or_id)"}],"source_content_type":"text/x-python","patch_set":3,"id":"dac4157f_3e403156","line":169,"updated":"2015-04-20 15:29:50.000000000","message":"I\u0027m not sure why this is better than before... and we don\u0027t need the safe_decode before this?","commit_id":"6ebe6e98d7ca6b3db6cc830898e51e00e06f4ef4"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"4bbe9282f0c6e05ebe1f92fe69ff528045c3a940","unresolved":false,"context_lines":[{"line_number":166,"context_line":"            return manager.get(int(name_or_id))"},{"line_number":167,"context_line":"    except exceptions.NotFound:"},{"line_number":168,"context_line":"        pass"},{"line_number":169,"context_line":"    else:"},{"line_number":170,"context_line":"        # now try to get entity as uuid"},{"line_number":171,"context_line":"        try:"},{"line_number":172,"context_line":"            uuid.UUID(name_or_id)"}],"source_content_type":"text/x-python","patch_set":3,"id":"dac4157f_c127fa10","line":169,"in_reply_to":"dac4157f_3e403156","updated":"2015-04-21 07:35:46.000000000","message":"We don\u0027t need to safe decode the string if it\u0027s a UUID (only digits and -) and if it\u0027s not a UUID it will throw ValueError regardless of the encoding.\nSo  if it\u0027s a UUID, why bother with the safe decoding in the first place?","commit_id":"6ebe6e98d7ca6b3db6cc830898e51e00e06f4ef4"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"5908132a910f761fa795b8f2324935b998eee33c","unresolved":false,"context_lines":[{"line_number":166,"context_line":"            return manager.get(int(name_or_id))"},{"line_number":167,"context_line":"    except exceptions.NotFound:"},{"line_number":168,"context_line":"        pass"},{"line_number":169,"context_line":"    else:"},{"line_number":170,"context_line":"        # now try to get entity as uuid"},{"line_number":171,"context_line":"        try:"},{"line_number":172,"context_line":"            uuid.UUID(name_or_id)"}],"source_content_type":"text/x-python","patch_set":3,"id":"dac4157f_051dc80e","line":169,"in_reply_to":"dac4157f_a6363850","updated":"2015-04-22 09:24:16.000000000","message":"I tied it to the try block because if the name_or_id is a number and we don\u0027t find it with the manager.get in the try block (exceptions.NotFound is raised), we already know it\u0027s not a UUID, so why bother checking it?","commit_id":"6ebe6e98d7ca6b3db6cc830898e51e00e06f4ef4"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"1153ebc92851d10dbb4dda8f87dd7842aaa04f40","unresolved":false,"context_lines":[{"line_number":166,"context_line":"            return manager.get(int(name_or_id))"},{"line_number":167,"context_line":"    except exceptions.NotFound:"},{"line_number":168,"context_line":"        pass"},{"line_number":169,"context_line":"    else:"},{"line_number":170,"context_line":"        # now try to get entity as uuid"},{"line_number":171,"context_line":"        try:"},{"line_number":172,"context_line":"            uuid.UUID(name_or_id)"}],"source_content_type":"text/x-python","patch_set":3,"id":"dac4157f_a6363850","line":169,"in_reply_to":"dac4157f_c127fa10","updated":"2015-04-21 21:13:55.000000000","message":"Ok.  I\u0027ll say that I\u0027m really not a fan of the else: usage here, but it works well enough I suppose.  (Seems more confusing than anything, given that this method is a list of get/find calls and I\u0027m not sure why this one is particularly tied to the above try: block.)","commit_id":"6ebe6e98d7ca6b3db6cc830898e51e00e06f4ef4"},{"author":{"_account_id":11600,"name":"Michał Dulko","email":"michal.dulko@gmail.com","username":"dulek"},"change_message_id":"bd06617395fef2e5cb95c5cc0a6e7d89f8446fb4","unresolved":false,"context_lines":[{"line_number":183,"context_line":"        except exceptions.NotFound:"},{"line_number":184,"context_line":"            pass"},{"line_number":185,"context_line":""},{"line_number":186,"context_line":"        # finally try to find entity by name"},{"line_number":187,"context_line":"        try:"},{"line_number":188,"context_line":"            return manager.find(name\u003dname_or_id)"},{"line_number":189,"context_line":"        except exceptions.NotFound:"}],"source_content_type":"text/x-python","patch_set":3,"id":"7aaa499b_84d7b1be","line":186,"updated":"2015-04-14 14:46:12.000000000","message":"A nit I\u0027ve mentioned in my former comment - finally here is confusing as this isn\u0027t our last try.","commit_id":"6ebe6e98d7ca6b3db6cc830898e51e00e06f4ef4"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"3a65d6b59002735bb7ad733d912c0fb8776badc8","unresolved":false,"context_lines":[{"line_number":183,"context_line":"        except exceptions.NotFound:"},{"line_number":184,"context_line":"            pass"},{"line_number":185,"context_line":""},{"line_number":186,"context_line":"        # finally try to find entity by name"},{"line_number":187,"context_line":"        try:"},{"line_number":188,"context_line":"            return manager.find(name\u003dname_or_id)"},{"line_number":189,"context_line":"        except exceptions.NotFound:"}],"source_content_type":"text/x-python","patch_set":3,"id":"7aaa499b_fa77309d","line":186,"in_reply_to":"7aaa499b_84d7b1be","updated":"2015-04-14 15:32:30.000000000","message":"Ok, I did change that in Patch 2, you were not being ignored ;-), but it was lost when I rebased the \"needed by\" branch.  :-(","commit_id":"6ebe6e98d7ca6b3db6cc830898e51e00e06f4ef4"},{"author":{"_account_id":7173,"name":"Scott DAngelo","email":"scott.dangelo@gmail.com","username":"scottda"},"change_message_id":"089014274c1f16350cc4ebf65d25f19765dbff2f","unresolved":false,"context_lines":[{"line_number":193,"context_line":"        try:"},{"line_number":194,"context_line":"            return manager.find(display_name\u003dname_or_id)"},{"line_number":195,"context_line":"        except (UnicodeDecodeError, exceptions.NotFound):"},{"line_number":196,"context_line":"            msg \u003d \"No %s with a name or ID of \u0027%s\u0027 exists.\" % \\"},{"line_number":197,"context_line":"                (manager.resource_class.__name__.lower(), name_or_id)"},{"line_number":198,"context_line":"            raise exceptions.CommandError(msg)"},{"line_number":199,"context_line":"    except exceptions.NoUniqueMatch:"}],"source_content_type":"text/x-python","patch_set":3,"id":"baa041b7_d8960394","line":196,"updated":"2015-04-01 20:47:26.000000000","message":"If you load another patch, you could replace the \u0027\\\u0027 with enclosing parenthesis \u0027(...)\u0027","commit_id":"6ebe6e98d7ca6b3db6cc830898e51e00e06f4ef4"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"3a65d6b59002735bb7ad733d912c0fb8776badc8","unresolved":false,"context_lines":[{"line_number":193,"context_line":"        try:"},{"line_number":194,"context_line":"            return manager.find(display_name\u003dname_or_id)"},{"line_number":195,"context_line":"        except (UnicodeDecodeError, exceptions.NotFound):"},{"line_number":196,"context_line":"            msg \u003d \"No %s with a name or ID of \u0027%s\u0027 exists.\" % \\"},{"line_number":197,"context_line":"                (manager.resource_class.__name__.lower(), name_or_id)"},{"line_number":198,"context_line":"            raise exceptions.CommandError(msg)"},{"line_number":199,"context_line":"    except exceptions.NoUniqueMatch:"}],"source_content_type":"text/x-python","patch_set":3,"id":"7aaa499b_bad408bd","line":196,"in_reply_to":"baa041b7_d8960394","updated":"2015-04-14 15:32:30.000000000","message":"That was already like that, but I have no problem changing it when I fix the comment.","commit_id":"6ebe6e98d7ca6b3db6cc830898e51e00e06f4ef4"}]}