)]}'
{"id":"openstack%2Fpython-cinderclient~162139","triplet_id":"openstack%2Fpython-cinderclient~master~I613dd25676ebe0fabd2e96813cccf56d96c205fd","project":"openstack/python-cinderclient","branch":"master","topic":"bug/1429103","hashtags":[],"change_id":"I613dd25676ebe0fabd2e96813cccf56d96c205fd","subject":"Add cache to Managers\u0027 find/findall methods","status":"ABANDONED","created":"2015-03-06 13:10:06.000000000","updated":"2015-07-09 11:31:13.000000000","total_comment_count":10,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"76e4e77030577f4beb578e4e8a77a09da221f3d3","_number":162139,"virtual_id_number":162139,"owner":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"actions":{},"labels":{"Verified":{"disliked":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":-1,"date":"2015-05-17 20:57:59.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":13636,"name":"aarefiev","display_name":"Anton","email":"arefyevanton@gmail.com","username":"aarefiev"},{"_account_id":7764,"name":"Peter Hamilton","email":"peter.hamilton@jhuapl.edu","username":"Peter"},{"_account_id":7173,"name":"Scott DAngelo","email":"scott.dangelo@gmail.com","username":"scottda"},{"_account_id":10263,"name":"Vilobh Meshram","email":"vilobhmm@yahoo-inc.com","username":"vilobhmm"},{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},{"date":"2015-04-24 17:28:52.000000000","_account_id":170,"name":"Mike Perez","email":"thingee@gmail.com","username":"thingee"},{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},{"date":"2015-04-09 08:27:19.000000000","_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},{"_account_id":14271,"name":"Kallebe Monteiro","email":"kallebe.monteiro@lsbd.ufc.br","username":"kallebe"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":-1,"default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":170,"name":"Mike Perez","email":"thingee@gmail.com","username":"thingee"},"disliked":{"_account_id":13636,"name":"aarefiev","display_name":"Anton","email":"arefyevanton@gmail.com","username":"aarefiev"},"all":[{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":-1,"date":"2015-05-06 13:23:11.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":13636,"name":"aarefiev","display_name":"Anton","email":"arefyevanton@gmail.com","username":"aarefiev"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":7764,"name":"Peter Hamilton","email":"peter.hamilton@jhuapl.edu","username":"Peter"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":7173,"name":"Scott DAngelo","email":"scott.dangelo@gmail.com","username":"scottda"},{"value":1,"date":"2015-05-06 06:28:11.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":10263,"name":"Vilobh Meshram","email":"vilobhmm@yahoo-inc.com","username":"vilobhmm"},{"value":2,"date":"2015-05-05 14:19:02.000000000","permitted_voting_range":{"min":-2,"max":2},"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},{"value":2,"date":"2015-05-04 23:20:46.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":170,"name":"Mike Perez","email":"thingee@gmail.com","username":"thingee"},{"value":0,"permitted_voting_range":{"min":-2,"max":2},"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},{"value":0,"permitted_voting_range":{"min":-2,"max":2},"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":14271,"name":"Kallebe Monteiro","email":"kallebe.monteiro@lsbd.ufc.br","username":"kallebe"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":-1,"default_value":0,"optional":true},"Workflow":{"all":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":13636,"name":"aarefiev","display_name":"Anton","email":"arefyevanton@gmail.com","username":"aarefiev"},{"_account_id":7764,"name":"Peter Hamilton","email":"peter.hamilton@jhuapl.edu","username":"Peter"},{"_account_id":7173,"name":"Scott DAngelo","email":"scott.dangelo@gmail.com","username":"scottda"},{"_account_id":10263,"name":"Vilobh Meshram","email":"vilobhmm@yahoo-inc.com","username":"vilobhmm"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},{"_account_id":170,"name":"Mike Perez","email":"thingee@gmail.com","username":"thingee"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},{"value":0,"permitted_voting_range":{"min":-1,"max":1},"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},{"_account_id":14271,"name":"Kallebe Monteiro","email":"kallebe.monteiro@lsbd.ufc.br","username":"kallebe"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":13636,"name":"aarefiev","display_name":"Anton","email":"arefyevanton@gmail.com","username":"aarefiev"},{"_account_id":7764,"name":"Peter Hamilton","email":"peter.hamilton@jhuapl.edu","username":"Peter"},{"_account_id":7173,"name":"Scott DAngelo","email":"scott.dangelo@gmail.com","username":"scottda"},{"_account_id":10263,"name":"Vilobh Meshram","email":"vilobhmm@yahoo-inc.com","username":"vilobhmm"},{"value":0,"permitted_voting_range":{"min":-1,"max":2},"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},{"_account_id":170,"name":"Mike Perez","email":"thingee@gmail.com","username":"thingee"},{"value":0,"permitted_voting_range":{"min":-1,"max":2},"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},{"value":0,"permitted_voting_range":{"min":-1,"max":2},"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},{"_account_id":14271,"name":"Kallebe Monteiro","email":"kallebe.monteiro@lsbd.ufc.br","username":"kallebe"}],"values":{"-1":"Branch Freeze"," 0":"No Priority","+1":"Important Change","+2":"Gate Blocker Fix / Urgent Change"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":170,"name":"Mike Perez","email":"thingee@gmail.com","username":"thingee"},{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},{"_account_id":7173,"name":"Scott DAngelo","email":"scott.dangelo@gmail.com","username":"scottda"},{"_account_id":7764,"name":"Peter Hamilton","email":"peter.hamilton@jhuapl.edu","username":"Peter"},{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},{"_account_id":10263,"name":"Vilobh Meshram","email":"vilobhmm@yahoo-inc.com","username":"vilobhmm"},{"_account_id":13636,"name":"aarefiev","display_name":"Anton","email":"arefyevanton@gmail.com","username":"aarefiev"},{"_account_id":14271,"name":"Kallebe Monteiro","email":"kallebe.monteiro@lsbd.ufc.br","username":"kallebe"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2015-03-11 11:54:39.000000000","updated_by":{"_account_id":14271,"name":"Kallebe Monteiro","email":"kallebe.monteiro@lsbd.ufc.br","username":"kallebe"},"reviewer":{"_account_id":14271,"name":"Kallebe Monteiro","email":"kallebe.monteiro@lsbd.ufc.br","username":"kallebe"},"state":"REVIEWER"},{"updated":"2015-03-14 18:24:18.000000000","updated_by":{"_account_id":7764,"name":"Peter Hamilton","email":"peter.hamilton@jhuapl.edu","username":"Peter"},"reviewer":{"_account_id":7764,"name":"Peter Hamilton","email":"peter.hamilton@jhuapl.edu","username":"Peter"},"state":"REVIEWER"},{"updated":"2015-04-08 19:55:08.000000000","updated_by":{"_account_id":7173,"name":"Scott DAngelo","email":"scott.dangelo@gmail.com","username":"scottda"},"reviewer":{"_account_id":7173,"name":"Scott DAngelo","email":"scott.dangelo@gmail.com","username":"scottda"},"state":"REVIEWER"},{"updated":"2015-04-08 19:58:39.000000000","updated_by":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"reviewer":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"state":"REVIEWER"},{"updated":"2015-04-24 17:28:52.000000000","updated_by":{"_account_id":170,"name":"Mike Perez","email":"thingee@gmail.com","username":"thingee"},"reviewer":{"_account_id":170,"name":"Mike Perez","email":"thingee@gmail.com","username":"thingee"},"state":"REVIEWER"},{"updated":"2015-05-05 14:19:02.000000000","updated_by":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"reviewer":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"state":"REVIEWER"},{"updated":"2015-05-06 06:28:11.000000000","updated_by":{"_account_id":10263,"name":"Vilobh Meshram","email":"vilobhmm@yahoo-inc.com","username":"vilobhmm"},"reviewer":{"_account_id":10263,"name":"Vilobh Meshram","email":"vilobhmm@yahoo-inc.com","username":"vilobhmm"},"state":"REVIEWER"},{"updated":"2015-05-06 13:23:11.000000000","updated_by":{"_account_id":13636,"name":"aarefiev","display_name":"Anton","email":"arefyevanton@gmail.com","username":"aarefiev"},"reviewer":{"_account_id":13636,"name":"aarefiev","display_name":"Anton","email":"arefyevanton@gmail.com","username":"aarefiev"},"state":"REVIEWER"},{"updated":"2015-05-17 20:57:59.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"580d3ef7fa09a6cdb296217dae8ffb675b6e451a","author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"date":"2015-03-06 13:10:06.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"b56bb477f5fae0816ee81786c5bee64de9e92231","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-03-06 14:08:32.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-cinderclient-python26 http://logs.openstack.org/39/162139/1/check/gate-python-cinderclient-python26/e966e07/ : SUCCESS in 41s\n- gate-python-cinderclient-pep8 http://logs.openstack.org/39/162139/1/check/gate-python-cinderclient-pep8/97ab55f/ : SUCCESS in 50s\n- gate-python-cinderclient-docs http://docs-draft.openstack.org/39/162139/1/check/gate-python-cinderclient-docs/c05f575//doc/build/html/ : SUCCESS in 49s\n- gate-python-cinderclient-python27 http://logs.openstack.org/39/162139/1/check/gate-python-cinderclient-python27/f620b26/ : SUCCESS in 55s\n- gate-python-cinderclient-python34 http://logs.openstack.org/39/162139/1/check/gate-python-cinderclient-python34/441d83b/ : SUCCESS in 2m 17s\n- gate-tempest-dsvm-neutron-src-python-cinderclient http://logs.openstack.org/39/162139/1/check/gate-tempest-dsvm-neutron-src-python-cinderclient/82e1273/ : SUCCESS in 57m 57s\n- gate-tempest-dsvm-neutron-src-python-cinderclient-icehouse http://logs.openstack.org/39/162139/1/check/gate-tempest-dsvm-neutron-src-python-cinderclient-icehouse/03380d5/ : SUCCESS in 26m 28s\n- gate-tempest-dsvm-neutron-src-python-cinderclient-juno http://logs.openstack.org/39/162139/1/check/gate-tempest-dsvm-neutron-src-python-cinderclient-juno/05c9f77/ : SUCCESS in 42m 29s\n- gate-python-cinderclient-pypy http://logs.openstack.org/39/162139/1/check/gate-python-cinderclient-pypy/8f178ff/ : SUCCESS in 1m 42s","accounts_in_message":[],"_revision_number":1},{"id":"e9707f03e5a1330783df37abb832f822962c7900","author":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"date":"2015-03-10 20:23:06.000000000","message":"Patch Set 1: Code-Review-1\n\n(3 comments)","accounts_in_message":[],"_revision_number":1},{"id":"a5750b394ad7ef32ef63e400e38d92bef0958d72","author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"date":"2015-03-11 09:14:14.000000000","message":"Patch Set 1:\n\n(3 comments)","accounts_in_message":[],"_revision_number":1},{"id":"77650e19c676c32568f1b0517c47ee9fd1de1431","author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"date":"2015-03-11 09:57:07.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"878c8bb9f8a23ed91df319823eac20101d53466e","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-03-11 11:00:25.000000000","message":"Patch Set 2: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-cinderclient-python26 http://logs.openstack.org/39/162139/2/check/gate-python-cinderclient-python26/509d99f/ : SUCCESS in 1m 02s\n- gate-python-cinderclient-pep8 http://logs.openstack.org/39/162139/2/check/gate-python-cinderclient-pep8/1bb573f/ : SUCCESS in 56s\n- gate-python-cinderclient-docs http://docs-draft.openstack.org/39/162139/2/check/gate-python-cinderclient-docs/d84a20c//doc/build/html/ : SUCCESS in 49s\n- gate-python-cinderclient-python27 http://logs.openstack.org/39/162139/2/check/gate-python-cinderclient-python27/a1cf2a9/ : SUCCESS in 1m 00s\n- gate-python-cinderclient-python34 http://logs.openstack.org/39/162139/2/check/gate-python-cinderclient-python34/ee2149a/ : SUCCESS in 2m 38s\n- gate-tempest-dsvm-neutron-src-python-cinderclient http://logs.openstack.org/39/162139/2/check/gate-tempest-dsvm-neutron-src-python-cinderclient/7962360/ : SUCCESS in 1h 00m 56s\n- gate-tempest-dsvm-neutron-src-python-cinderclient-icehouse http://logs.openstack.org/39/162139/2/check/gate-tempest-dsvm-neutron-src-python-cinderclient-icehouse/7fa50d7/ : SUCCESS in 27m 07s\n- gate-tempest-dsvm-neutron-src-python-cinderclient-juno http://logs.openstack.org/39/162139/2/check/gate-tempest-dsvm-neutron-src-python-cinderclient-juno/02beec9/ : SUCCESS in 38m 43s\n- gate-python-cinderclient-pypy http://logs.openstack.org/39/162139/2/check/gate-python-cinderclient-pypy/d3f4302/ : SUCCESS in 1m 50s","accounts_in_message":[],"_revision_number":2},{"id":"f299740ab05dacf21ffce35c44993eb63aad7726","author":{"_account_id":14271,"name":"Kallebe Monteiro","email":"kallebe.monteiro@lsbd.ufc.br","username":"kallebe"},"date":"2015-03-11 11:44:02.000000000","message":"Patch Set 2: Code-Review-1\n\nGood change. Thanks. However I have a question about the usage of it.\n\nI was wondering if it would be better to have --use_cache as a CLI parameter for the users to decide if they would like to use it, because even though the default for the method find_all will be use_cache\u003dFalse, all the calls from the Manager set use_cache\u003dTrue and this leads to the question below.\n\nAnother question, but this one I am not sure if I am getting it right. Suppose the user decides to use cache but later on another volume is added. Apparently if he or she continues to use the cached list, cinderclient will not return the updated list. I am not sure if this will happen, correct me if I got it wrong, just something to consider.\n\nThen again, I liked your change and when you answer these questions I am more than happy to change to +1.","accounts_in_message":[],"_revision_number":2},{"id":"5aed3a9925ddd44728cb0034c806083434aaeeae","author":{"_account_id":14271,"name":"Kallebe Monteiro","email":"kallebe.monteiro@lsbd.ufc.br","username":"kallebe"},"date":"2015-03-11 11:53:48.000000000","message":"Patch Set 2:\n\nLooking through utils I see that you clear the cache. I see it now.","accounts_in_message":[],"_revision_number":2},{"id":"513b4dcbc82dcfca45631af1dd6b0a82e1e1f713","author":{"_account_id":14271,"name":"Kallebe Monteiro","email":"kallebe.monteiro@lsbd.ufc.br","username":"kallebe"},"date":"2015-03-11 11:54:39.000000000","message":"Patch Set 2: Code-Review+1\n\nChange to +1 because I see now that you clear the cache. Good change.","accounts_in_message":[],"_revision_number":2},{"id":"25302c48a9c7bbf113d1d8e1ab892beaca16fc70","author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"date":"2015-03-11 12:51:09.000000000","message":"Patch Set 2:\n\nKallebe, you are no fun, you answer your own questions. ;)\nThanks reviewing the patch.","accounts_in_message":[],"_revision_number":2},{"id":"1bb6e40149fb50288cf9c6bb2c8f4de500fa0adb","author":{"_account_id":7764,"name":"Peter Hamilton","email":"peter.hamilton@jhuapl.edu","username":"Peter"},"date":"2015-03-14 18:24:18.000000000","message":"Patch Set 2: Code-Review+1","accounts_in_message":[],"_revision_number":2},{"id":"bf7b5171534c1000b6520f3c991ff5858d685be2","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-03-31 16:51:46.000000000","message":"Patch Set 2: Verified-1\n\nMerge Failed.\n\nThis change was unable to be automatically merged with the current state of the repository. Please rebase your change and upload a new patchset.","accounts_in_message":[],"_revision_number":2},{"id":"cee68ee55a3d6d2474e175c8da4743decc806d5a","author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"date":"2015-04-01 10:41:29.000000000","message":"Uploaded patch set 3.","accounts_in_message":[],"_revision_number":3},{"id":"b05e905dd457453e11cbc3cdbab78dd7ea6c48ce","author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"date":"2015-04-01 10:41:56.000000000","message":"Patch Set 3:\n\nRebased","accounts_in_message":[],"_revision_number":3},{"id":"f0f4352eafaf6478f4fb22af8cb250e99e757829","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-04-01 11:58:04.000000000","message":"Patch Set 3: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-cinderclient-python26 http://logs.openstack.org/39/162139/3/check/gate-python-cinderclient-python26/5da7703/ : SUCCESS in 51s\n- gate-python-cinderclient-pep8 http://logs.openstack.org/39/162139/3/check/gate-python-cinderclient-pep8/8a292de/ : SUCCESS in 54s\n- gate-python-cinderclient-docs http://docs-draft.openstack.org/39/162139/3/check/gate-python-cinderclient-docs/a11e7f8//doc/build/html/ : SUCCESS in 43s\n- gate-python-cinderclient-python27 http://logs.openstack.org/39/162139/3/check/gate-python-cinderclient-python27/e9c6e92/ : SUCCESS in 1m 45s\n- gate-python-cinderclient-python34 http://logs.openstack.org/39/162139/3/check/gate-python-cinderclient-python34/23881a9/ : SUCCESS in 2m 51s\n- gate-tempest-dsvm-neutron-src-python-cinderclient http://logs.openstack.org/39/162139/3/check/gate-tempest-dsvm-neutron-src-python-cinderclient/6d1f11c/ : SUCCESS in 1h 03m 06s\n- gate-tempest-dsvm-neutron-src-python-cinderclient-icehouse http://logs.openstack.org/39/162139/3/check/gate-tempest-dsvm-neutron-src-python-cinderclient-icehouse/5a39e8e/ : SUCCESS in 29m 56s\n- gate-tempest-dsvm-neutron-src-python-cinderclient-juno http://logs.openstack.org/39/162139/3/check/gate-tempest-dsvm-neutron-src-python-cinderclient-juno/e167298/ : SUCCESS in 54m 24s\n- gate-python-cinderclient-pypy http://logs.openstack.org/39/162139/3/check/gate-python-cinderclient-pypy/233525e/ : SUCCESS in 1m 41s","accounts_in_message":[],"_revision_number":3},{"id":"a0871a29699bb2e67cd6e65673a661d68712a143","author":{"_account_id":7173,"name":"Scott DAngelo","email":"scott.dangelo@gmail.com","username":"scottda"},"date":"2015-04-01 15:28:31.000000000","message":"Patch Set 3: Code-Review-1\n\n(1 comment)","accounts_in_message":[],"_revision_number":3},{"id":"fe5a0de7fe78a9b78376181b01fc5c1e2e139b2d","author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"date":"2015-04-01 16:27:51.000000000","message":"Patch Set 3:\n\n(1 comment)","accounts_in_message":[],"_revision_number":3},{"id":"25d2379dbef12d132f817debcf5e720d998fc9d4","author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"date":"2015-04-08 19:07:31.000000000","message":"Uploaded patch set 4.","accounts_in_message":[],"_revision_number":4},{"id":"6011dc3b522f12637d715d005de17112dbc78a37","author":{"_account_id":7173,"name":"Scott DAngelo","email":"scott.dangelo@gmail.com","username":"scottda"},"date":"2015-04-08 19:55:08.000000000","message":"Patch Set 4: Code-Review+1","accounts_in_message":[],"_revision_number":4},{"id":"c9e7f23b1aaa85660eb4c8a5023f43de743b5268","author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"date":"2015-04-08 19:58:39.000000000","message":"Patch Set 4: Code-Review-1\n\n(1 comment)","accounts_in_message":[],"_revision_number":4},{"id":"1805e9b9193cf7f8de2af127130c9842af9acbab","author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"date":"2015-04-08 20:18:53.000000000","message":"Uploaded patch set 5.","accounts_in_message":[],"_revision_number":5},{"id":"ab7435e2080ce7df87451ec4f5671168cc277877","author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"date":"2015-04-08 20:19:35.000000000","message":"Patch Set 4:\n\n(1 comment)","accounts_in_message":[],"_revision_number":4},{"id":"1e9eb9c37650041a83da94ba5fa60b10f2029c94","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-04-08 21:20:51.000000000","message":"Patch Set 5: Verified-1\n\nBuild failed (check pipeline).  For information on how to proceed, see http://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n- gate-python-cinderclient-python26 http://logs.openstack.org/39/162139/5/check/gate-python-cinderclient-python26/d76dc5f/ : SUCCESS in 56s\n- gate-python-cinderclient-pep8 http://logs.openstack.org/39/162139/5/check/gate-python-cinderclient-pep8/e7a4ec3/ : SUCCESS in 55s\n- gate-python-cinderclient-docs http://docs-draft.openstack.org/39/162139/5/check/gate-python-cinderclient-docs/c632c7d//doc/build/html/ : SUCCESS in 52s\n- gate-python-cinderclient-python27 http://logs.openstack.org/39/162139/5/check/gate-python-cinderclient-python27/b6a590a/ : SUCCESS in 1m 17s\n- gate-python-cinderclient-python34 http://logs.openstack.org/39/162139/5/check/gate-python-cinderclient-python34/dc3d60f/ : SUCCESS in 1m 59s\n- gate-tempest-dsvm-neutron-src-python-cinderclient http://logs.openstack.org/39/162139/5/check/gate-tempest-dsvm-neutron-src-python-cinderclient/aa3a344/ : SUCCESS in 1h 01m 46s\n- gate-tempest-dsvm-neutron-src-python-cinderclient-icehouse http://logs.openstack.org/39/162139/5/check/gate-tempest-dsvm-neutron-src-python-cinderclient-icehouse/653e12d/ : SUCCESS in 30m 35s\n- gate-tempest-dsvm-neutron-src-python-cinderclient-juno http://logs.openstack.org/39/162139/5/check/gate-tempest-dsvm-neutron-src-python-cinderclient-juno/a2895e4/ : FAILURE in 56m 32s\n- gate-python-cinderclient-pypy http://logs.openstack.org/39/162139/5/check/gate-python-cinderclient-pypy/c7388b4/ : SUCCESS in 1m 28s","accounts_in_message":[],"_revision_number":5},{"id":"cfa5de669e8db7ffa2a09482b0734e674f1823f3","author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"date":"2015-04-09 08:27:19.000000000","message":"Patch Set 5:\n\nrecheck","accounts_in_message":[],"_revision_number":5},{"id":"e28f38a03c305099fe53386234cf92cc6a613d28","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-04-09 09:27:46.000000000","message":"Patch Set 5:\n\nBuild failed (check pipeline).  For information on how to proceed, see http://docs.openstack.org/infra/manual/developers.html#automated-testing\n\n- gate-python-cinderclient-python26 http://logs.openstack.org/39/162139/5/check/gate-python-cinderclient-python26/af77e23/ : SUCCESS in 54s\n- gate-python-cinderclient-pep8 http://logs.openstack.org/39/162139/5/check/gate-python-cinderclient-pep8/939909d/ : SUCCESS in 52s\n- gate-python-cinderclient-docs http://docs-draft.openstack.org/39/162139/5/check/gate-python-cinderclient-docs/8e470df//doc/build/html/ : SUCCESS in 1m 00s\n- gate-python-cinderclient-python27 http://logs.openstack.org/39/162139/5/check/gate-python-cinderclient-python27/0366292/ : SUCCESS in 1m 00s\n- gate-python-cinderclient-python34 http://logs.openstack.org/39/162139/5/check/gate-python-cinderclient-python34/a3949b0/ : SUCCESS in 2m 11s\n- gate-tempest-dsvm-neutron-src-python-cinderclient http://logs.openstack.org/39/162139/5/check/gate-tempest-dsvm-neutron-src-python-cinderclient/7429e28/ : SUCCESS in 52m 52s\n- gate-tempest-dsvm-neutron-src-python-cinderclient-icehouse http://logs.openstack.org/39/162139/5/check/gate-tempest-dsvm-neutron-src-python-cinderclient-icehouse/ddd7069/ : SUCCESS in 25m 56s\n- gate-tempest-dsvm-neutron-src-python-cinderclient-juno http://logs.openstack.org/39/162139/5/check/gate-tempest-dsvm-neutron-src-python-cinderclient-juno/f5ed2ef/ : FAILURE in 48m 47s\n- gate-python-cinderclient-pypy http://logs.openstack.org/39/162139/5/check/gate-python-cinderclient-pypy/186c256/ : SUCCESS in 1m 34s","accounts_in_message":[],"_revision_number":5},{"id":"c6a315c7562aa005e5268eecd5f2974ce9bf3633","author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"date":"2015-04-09 14:16:53.000000000","message":"Patch Set 5:\n\nFailure looks like it\u0027s hitting a new bug, so I have opened a LP bug for it: https://bugs.launchpad.net/tempest/+bug/1442086","accounts_in_message":[],"_revision_number":5},{"id":"3ce57f1d2d433916ee615e175cb1b2aa2a8a6e69","author":{"_account_id":170,"name":"Mike Perez","email":"thingee@gmail.com","username":"thingee"},"date":"2015-04-24 17:28:52.000000000","message":"Patch Set 5:\n\nrecheck","accounts_in_message":[],"_revision_number":5},{"id":"7a8d5efd40af737f581acf13f2f5cae7f6301f41","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-04-24 18:19:04.000000000","message":"Patch Set 5: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-cinderclient-python26 http://logs.openstack.org/39/162139/5/check/gate-python-cinderclient-python26/84006f1/ : SUCCESS in 59s\n- gate-python-cinderclient-pep8 http://logs.openstack.org/39/162139/5/check/gate-python-cinderclient-pep8/cbdc2f4/ : SUCCESS in 56s\n- gate-python-cinderclient-docs http://docs-draft.openstack.org/39/162139/5/check/gate-python-cinderclient-docs/4e7958b//doc/build/html/ : SUCCESS in 1m 00s\n- gate-python-cinderclient-python27 http://logs.openstack.org/39/162139/5/check/gate-python-cinderclient-python27/67fae37/ : SUCCESS in 47s\n- gate-python-cinderclient-python34 http://logs.openstack.org/39/162139/5/check/gate-python-cinderclient-python34/608e34c/ : SUCCESS in 2m 43s\n- gate-tempest-dsvm-neutron-src-python-cinderclient http://logs.openstack.org/39/162139/5/check/gate-tempest-dsvm-neutron-src-python-cinderclient/290ef8b/ : SUCCESS in 48m 43s\n- gate-python-cinderclient-pypy http://logs.openstack.org/39/162139/5/check/gate-python-cinderclient-pypy/6a05803/ : SUCCESS in 1m 51s","accounts_in_message":[],"_revision_number":5},{"id":"c96e30b2789c62bd8b5e473fa7a8a04550ba4542","author":{"_account_id":170,"name":"Mike Perez","email":"thingee@gmail.com","username":"thingee"},"date":"2015-05-04 23:20:46.000000000","message":"Patch Set 5: Code-Review+2","accounts_in_message":[],"_revision_number":5},{"id":"5261749be17cb58df58e93b1b82bd8c10fbaf606","author":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"date":"2015-05-05 14:19:02.000000000","message":"Patch Set 5: Code-Review+2","accounts_in_message":[],"_revision_number":5},{"id":"84afcd99911d9a646e1881663711939d083435c4","author":{"_account_id":10263,"name":"Vilobh Meshram","email":"vilobhmm@yahoo-inc.com","username":"vilobhmm"},"date":"2015-05-06 06:28:11.000000000","message":"Patch Set 5: Code-Review+1\n\nThanks for the fix. Looks good.","accounts_in_message":[],"_revision_number":5},{"id":"7962b1fe586f1aad82739072b7b230e50a84228e","author":{"_account_id":13636,"name":"aarefiev","display_name":"Anton","email":"arefyevanton@gmail.com","username":"aarefiev"},"date":"2015-05-06 13:23:11.000000000","message":"Patch Set 5: Code-Review-1\n\nI think cache not needed here, in most cases we need only one request to api to get resources, please, see my patches https://review.openstack.org/#/c/180533/ .","accounts_in_message":[],"_revision_number":5},{"id":"6ea49cdff91007e5cd2c996bb0e47f211a64a949","author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"date":"2015-05-06 15:15:47.000000000","message":"Patch Set 5:\n\nAnton, I like your patch and I think these 2 patches could go well together, since for human_id you would still need to retrieve all the results again.\n\nI even think that we should join together this patch, your patch and the one that tries server side filtering (https://review.openstack.org/#/c/180534/1) into 1 common solution (some changes to the mix are needed to make it work efficiently).\n\nWith you patch only desired field would be searched, with the server side filtering patch transmitted data would be decreased in most cases and if there is no server side filtering, caching would still help in those cases.","accounts_in_message":[],"_revision_number":5},{"id":"68dce865b40b18b9229ab8080ce7b5be52cf9814","author":{"_account_id":13636,"name":"aarefiev","display_name":"Anton","email":"arefyevanton@gmail.com","username":"aarefiev"},"date":"2015-05-06 16:57:51.000000000","message":"Patch Set 5:\n\nGorka, first \u0027find\u0027 call should return the result (it should filter data on server side, and it is true for fine_resource function with \u0027name\u0027 and \u0027display_name\u0027 attr ), so filtering on client side no needed; it is just return result. Resource can contain either \u0027name\u0027 or  \u0027display_name\u0027, \u0027find\u0027 call for both is redundant.\nAs  for human_id  it is client\u0027s side entity, slugified form of resource name. Find by human_id is client side work among all objects(in that case we get all objects to client). \nSo when we search resource by name(\u0027name\u0027 or \u0027display_name\u0027), only one request with server side filtering will be used, and no needs to use cache.\nGeneral case:\n1) first \u0027find\u0027 call  - list request by \u0027name\u0027 or \u0027display name\u0027 , return expected result(nothing to cache);\n2) second \u0027find\u0027 call(unusual case) - list request all objects and serch by \u0027human_id\u0027, it is last operation, so nobody uses chached data after it. Also I think it is useless feature on big envs.\nSince we don\u0027t use other search attributes for find, I don\u0027t see cases where cache is usefull, could you give an example?","accounts_in_message":[],"_revision_number":5},{"id":"5ff00aa321a2acda0cab9a797adb9688972be756","author":{"_account_id":13636,"name":"aarefiev","display_name":"Anton","email":"arefyevanton@gmail.com","username":"aarefiev"},"date":"2015-05-06 17:02:11.000000000","message":"Patch Set 5:\n\nsorry, formatting issue\n\nGorka, first \u0027find\u0027 call should return the result (it should filter data\non server side, and it is true for fine_resource function with \u0027name\u0027 and\n\u0027display_name\u0027 attr ), so filtering on client side no needed; it is just\nreturn result. Resource can contain either \u0027name\u0027 or  \u0027display_name\u0027, \u0027find\u0027\ncall for both is redundant.\n\nAs  for human_id  it is client\u0027s side entity, slugified form of resource name.\nFind by human_id is client side work among all objects(in that case we get all\nobjects to client). \n\nSo when we search resource by name(\u0027name\u0027 or \u0027display_name\u0027), only one request\nwith server side filtering will be used, and no needs to use cache.\n\nGeneral case:\n1) first \u0027find\u0027 call  - list request by \u0027name\u0027 or \u0027display name\u0027 , return expected\nresult(nothing to cache);\n2) second \u0027find\u0027 call(unusual case) - list request all objects and serch by \u0027human_id\u0027,\nit is last operation, so nobody uses chached data after it. Also I think it is useless\nfeature on big envs.\n\nSince we don\u0027t use other search attributes for find, I don\u0027t see cases where\ncache is usefull, could you give an example?","accounts_in_message":[],"_revision_number":5},{"id":"dfada836060730808ad14bfbcc354de3af183ac4","author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"date":"2015-05-06 17:16:51.000000000","message":"Patch Set 5:\n\nThanks for reformatting  :-)\n\nI don\u0027t think find method does what you think it does... Because it uses findall method which doesn\u0027t do any kind of server side filtering right now: https://github.com/openstack/python-cinderclient/blob/master/cinderclient/base.py#L239\n\nThat\u0027s why I mentioned the other patch is a good idea.\n\nBut if you see that patch you\u0027ll see that server side filtering is not always available, therefore you must do a local filter afterwards (in case it wasn\u0027t available).\n\nCache is useful when there is no server side filtering available (it can happen) and you search for volume/resource by human-id or you just search for a non-existing volume. This last case is very frequent.\n\nIf we join all 3 patches I think we could clear cache as method exits.","accounts_in_message":[],"_revision_number":5},{"id":"fec21c374126cf2b4c8f3c23204dd42121941b45","author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"date":"2015-05-11 17:34:32.000000000","message":"Patch Set 5:\n\nHey Anton,\n\nAfter pulling my head out of my ass, I realized both patches are yours while reviewing them.\n\nKudos on your patches and the patience needed not to kill me. :-D","accounts_in_message":[],"_revision_number":5},{"id":"6bd3c457d6e5798ed371449aa27a06c1b87813ef","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-05-17 20:57:59.000000000","message":"Patch Set 5: Verified-1\n\nMerge Failed.\n\nThis change was unable to be automatically merged with the current state of the repository. Please rebase your change and upload a new patchset.","accounts_in_message":[],"_revision_number":5},{"id":"5ba37240b6303bb0111ffb020d01b7a3e7af15a8","author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"date":"2015-07-09 11:31:13.000000000","message":"Abandoned","accounts_in_message":[],"_revision_number":5}],"current_revision_number":5,"current_revision":"68ab8210cbc89d88dc67772e40d1059d75b24888","revisions":{"b498e7046236a432527d5f6dd845d5e931688b12":{"kind":"REWORK","_number":1,"created":"2015-03-06 13:10:06.000000000","uploader":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"ref":"refs/changes/39/162139/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-cinderclient","ref":"refs/changes/39/162139/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-cinderclient refs/changes/39/162139/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-cinderclient refs/changes/39/162139/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-cinderclient refs/changes/39/162139/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-cinderclient refs/changes/39/162139/1"}}},"commit":{"parents":[{"commit":"5aed2d13fb12ae59bedc349a02cfc92dfcdaddf1","subject":"Remove duplicate find request in find_resource","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-cinderclient/commit/5aed2d13fb12ae59bedc349a02cfc92dfcdaddf1"}]}],"author":{"name":"Gorka Eguileor","email":"geguileo@redhat.com","date":"2015-03-06 13:04:35.000000000","tz":60},"committer":{"name":"Gorka Eguileor","email":"geguileo@redhat.com","date":"2015-03-06 13:04:35.000000000","tz":60},"subject":"Add cache to Managers\u0027 find/findall methods","message":"Add cache to Managers\u0027 find/findall methods\n\nCurrently we are generating multiple requests to\nvolumes/detail?all_tenants\u003d1 from find_resource when we could limit this\nto 1 request and then search the results multiple times.\n\nThis patch adds cache feature to find and findall methods so that we can\nreuse previous list results if we want to.\n\nThis will speed up any operation that searches for a non existing\nresource using find_resource.\n\nIt will also speed up on searches by name and display_name.\n\nChange-Id: I613dd25676ebe0fabd2e96813cccf56d96c205fd\nCloses-Bug: #1429103\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-cinderclient/commit/b498e7046236a432527d5f6dd845d5e931688b12"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-cinderclient/commit/b498e7046236a432527d5f6dd845d5e931688b12"}]},"branch":"refs/heads/master"},"0bc3f9c205ca6959bdc86a3965c2049014520198":{"kind":"REWORK","_number":2,"created":"2015-03-11 09:57:07.000000000","uploader":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"ref":"refs/changes/39/162139/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-cinderclient","ref":"refs/changes/39/162139/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-cinderclient refs/changes/39/162139/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-cinderclient refs/changes/39/162139/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-cinderclient refs/changes/39/162139/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-cinderclient refs/changes/39/162139/2"}}},"commit":{"parents":[{"commit":"5aed2d13fb12ae59bedc349a02cfc92dfcdaddf1","subject":"Remove duplicate find request in find_resource","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-cinderclient/commit/5aed2d13fb12ae59bedc349a02cfc92dfcdaddf1"}]}],"author":{"name":"Gorka Eguileor","email":"geguileo@redhat.com","date":"2015-03-06 13:04:35.000000000","tz":60},"committer":{"name":"Gorka Eguileor","email":"geguileo@redhat.com","date":"2015-03-11 09:13:46.000000000","tz":60},"subject":"Add cache to Managers\u0027 find/findall methods","message":"Add cache to Managers\u0027 find/findall methods\n\nCurrently we are generating multiple requests to\nvolumes/detail?all_tenants\u003d1 from find_resource when we could limit this\nto 1 request and then search the results multiple times.\n\nThis patch adds cache feature to find and findall methods so that we can\nreuse previous list results if we want to.\n\nThis will speed up any operation that searches for a non existing\nresource using find_resource.\n\nIt will also speed up on searches by name and display_name.\n\nChange-Id: I613dd25676ebe0fabd2e96813cccf56d96c205fd\nCloses-Bug: #1429103\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-cinderclient/commit/0bc3f9c205ca6959bdc86a3965c2049014520198"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-cinderclient/commit/0bc3f9c205ca6959bdc86a3965c2049014520198"}]},"branch":"refs/heads/master"},"08d62f56a7b7b71d47b030948911a273c1cf92c8":{"kind":"REWORK","_number":3,"created":"2015-04-01 10:41:29.000000000","uploader":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"ref":"refs/changes/39/162139/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-cinderclient","ref":"refs/changes/39/162139/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-cinderclient refs/changes/39/162139/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-cinderclient refs/changes/39/162139/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-cinderclient refs/changes/39/162139/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-cinderclient refs/changes/39/162139/3"}}},"commit":{"parents":[{"commit":"6ebe6e98d7ca6b3db6cc830898e51e00e06f4ef4","subject":"Remove duplicate find request in find_resource","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-cinderclient/commit/6ebe6e98d7ca6b3db6cc830898e51e00e06f4ef4"}]}],"author":{"name":"Gorka Eguileor","email":"geguileo@redhat.com","date":"2015-03-06 13:04:35.000000000","tz":60},"committer":{"name":"Gorka Eguileor","email":"geguileo@redhat.com","date":"2015-04-01 10:38:19.000000000","tz":120},"subject":"Add cache to Managers\u0027 find/findall methods","message":"Add cache to Managers\u0027 find/findall methods\n\nCurrently we are generating multiple requests to\nvolumes/detail?all_tenants\u003d1 from find_resource when we could limit this\nto 1 request and then search the results multiple times.\n\nThis patch adds cache feature to find and findall methods so that we can\nreuse previous list results if we want to.\n\nThis will speed up any operation that searches for a non existing\nresource using find_resource.\n\nIt will also speed up on searches by name and display_name.\n\nChange-Id: I613dd25676ebe0fabd2e96813cccf56d96c205fd\nCloses-Bug: #1429103\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-cinderclient/commit/08d62f56a7b7b71d47b030948911a273c1cf92c8"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-cinderclient/commit/08d62f56a7b7b71d47b030948911a273c1cf92c8"}]},"branch":"refs/heads/master"},"8851cd3ad965f0a36ac45cf721c10250f7ff25b4":{"kind":"REWORK","_number":4,"created":"2015-04-08 19:07:31.000000000","uploader":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"ref":"refs/changes/39/162139/4","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-cinderclient","ref":"refs/changes/39/162139/4","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-cinderclient refs/changes/39/162139/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-cinderclient refs/changes/39/162139/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-cinderclient refs/changes/39/162139/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-cinderclient refs/changes/39/162139/4"}}},"commit":{"parents":[{"commit":"6ebe6e98d7ca6b3db6cc830898e51e00e06f4ef4","subject":"Remove duplicate find request in find_resource","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-cinderclient/commit/6ebe6e98d7ca6b3db6cc830898e51e00e06f4ef4"}]}],"author":{"name":"Gorka Eguileor","email":"geguileo@redhat.com","date":"2015-03-06 13:04:35.000000000","tz":60},"committer":{"name":"Gorka Eguileor","email":"geguileo@redhat.com","date":"2015-04-01 17:12:54.000000000","tz":120},"subject":"Add cache to Managers\u0027 find/findall methods","message":"Add cache to Managers\u0027 find/findall methods\n\nCurrently we are generating multiple requests to\nvolumes/detail?all_tenants\u003d1 from find_resource when we could limit this\nto 1 request and then search the results multiple times.\n\nThis patch adds cache feature to find and findall methods so that we can\nreuse previous list results if we want to.\n\nThis will speed up any operation that searches for a non existing\nresource using find_resource.\n\nIt will also speed up on searches by name and display_name.\n\nChange-Id: I613dd25676ebe0fabd2e96813cccf56d96c205fd\nCloses-Bug: #1429103\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-cinderclient/commit/8851cd3ad965f0a36ac45cf721c10250f7ff25b4"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-cinderclient/commit/8851cd3ad965f0a36ac45cf721c10250f7ff25b4"}]},"branch":"refs/heads/master"},"68ab8210cbc89d88dc67772e40d1059d75b24888":{"kind":"REWORK","_number":5,"created":"2015-04-08 20:18:53.000000000","uploader":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"ref":"refs/changes/39/162139/5","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-cinderclient","ref":"refs/changes/39/162139/5","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-cinderclient refs/changes/39/162139/5 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-cinderclient refs/changes/39/162139/5 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-cinderclient refs/changes/39/162139/5 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-cinderclient refs/changes/39/162139/5"}}},"commit":{"parents":[{"commit":"6ebe6e98d7ca6b3db6cc830898e51e00e06f4ef4","subject":"Remove duplicate find request in find_resource","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-cinderclient/commit/6ebe6e98d7ca6b3db6cc830898e51e00e06f4ef4"}]}],"author":{"name":"Gorka Eguileor","email":"geguileo@redhat.com","date":"2015-03-06 13:04:35.000000000","tz":60},"committer":{"name":"Gorka Eguileor","email":"geguileo@redhat.com","date":"2015-04-08 20:17:57.000000000","tz":120},"subject":"Add cache to Managers\u0027 find/findall methods","message":"Add cache to Managers\u0027 find/findall methods\n\nCurrently we are generating multiple requests to\nvolumes/detail?all_tenants\u003d1 from find_resource when we could limit this\nto 1 request and then search the results multiple times.\n\nThis patch adds cache feature to find and findall methods so that we can\nreuse previous list results if we want to.\n\nThis will speed up any operation that searches for a non existing\nresource using find_resource.\n\nIt will also speed up on searches by name and display_name.\n\nChange-Id: I613dd25676ebe0fabd2e96813cccf56d96c205fd\nCloses-Bug: #1429103\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-cinderclient/commit/68ab8210cbc89d88dc67772e40d1059d75b24888"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-cinderclient/commit/68ab8210cbc89d88dc67772e40d1059d75b24888"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}