)]}'
{"id":"openstack%2Fpython-cinderclient~178588","triplet_id":"openstack%2Fpython-cinderclient~master~Iea619d66d217d92047a5b965d1e375acc97fa65b","project":"openstack/python-cinderclient","branch":"master","topic":"bug/1252665","hashtags":[],"change_id":"Iea619d66d217d92047a5b965d1e375acc97fa65b","subject":"Add search_opts into the method list() for qos specs","status":"MERGED","created":"2015-04-29 10:05:49.000000000","updated":"2015-07-06 17:31:46.000000000","submitted":"2015-07-06 17:31:44.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":2,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"0402665b841547a04143799d5724d65b5fa7c3f6","_number":178588,"virtual_id_number":178588,"owner":{"_account_id":13636,"name":"aarefiev","display_name":"Anton","email":"arefyevanton@gmail.com","username":"aarefiev"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":0,"date":"2015-06-26 17:47:17.000000000","_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},{"value":2,"date":"2015-07-06 17:31:44.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"date":"2015-06-05 08:18:46.000000000","_account_id":13636,"name":"aarefiev","display_name":"Anton","email":"arefyevanton@gmail.com","username":"aarefiev"},{"value":0,"_account_id":7764,"name":"Peter Hamilton","email":"peter.hamilton@jhuapl.edu","username":"Peter"},{"value":0,"_account_id":9061,"name":"David Moreau Simard","email":"moi@dmsimard.com","username":"dmsimard"},{"value":0,"date":"2015-06-05 17:55:28.000000000","_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},{"value":0,"_account_id":170,"name":"Mike Perez","email":"thingee@gmail.com","username":"thingee"},{"value":0,"_account_id":2861,"name":"Vincent Hou","email":"shou@us.ibm.com","username":"houshengbo"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"recommended":{"_account_id":9061,"name":"David Moreau Simard","email":"moi@dmsimard.com","username":"dmsimard"},"all":[{"value":0,"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":13636,"name":"aarefiev","display_name":"Anton","email":"arefyevanton@gmail.com","username":"aarefiev"},{"value":1,"date":"2015-06-30 12:44:27.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":7764,"name":"Peter Hamilton","email":"peter.hamilton@jhuapl.edu","username":"Peter"},{"value":1,"date":"2015-06-25 23:28:27.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":9061,"name":"David Moreau Simard","email":"moi@dmsimard.com","username":"dmsimard"},{"value":2,"date":"2015-07-06 16:24:48.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},{"value":2,"date":"2015-07-06 15:55:27.000000000","_account_id":170,"name":"Mike Perez","email":"thingee@gmail.com","username":"thingee"},{"value":-1,"date":"2015-06-05 08:07:08.000000000","permitted_voting_range":{"min":-1,"max":1},"_account_id":2861,"name":"Vincent Hou","email":"shou@us.ibm.com","username":"houshengbo"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":1,"default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"all":[{"value":0,"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":13636,"name":"aarefiev","display_name":"Anton","email":"arefyevanton@gmail.com","username":"aarefiev"},{"value":0,"_account_id":7764,"name":"Peter Hamilton","email":"peter.hamilton@jhuapl.edu","username":"Peter"},{"value":0,"_account_id":9061,"name":"David Moreau Simard","email":"moi@dmsimard.com","username":"dmsimard"},{"value":1,"date":"2015-07-06 16:24:48.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},{"value":0,"_account_id":170,"name":"Mike Perez","email":"thingee@gmail.com","username":"thingee"},{"value":0,"_account_id":2861,"name":"Vincent Hou","email":"shou@us.ibm.com","username":"houshengbo"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":13636,"name":"aarefiev","display_name":"Anton","email":"arefyevanton@gmail.com","username":"aarefiev"},{"value":0,"_account_id":7764,"name":"Peter Hamilton","email":"peter.hamilton@jhuapl.edu","username":"Peter"},{"value":0,"_account_id":9061,"name":"David Moreau Simard","email":"moi@dmsimard.com","username":"dmsimard"},{"value":0,"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},{"value":0,"_account_id":170,"name":"Mike Perez","email":"thingee@gmail.com","username":"thingee"},{"value":0,"_account_id":2861,"name":"Vincent Hou","email":"shou@us.ibm.com","username":"houshengbo"}],"values":{"-1":"Branch Freeze"," 0":"No Priority","+1":"Important Change","+2":"Gate Blocker Fix / Urgent Change"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":170,"name":"Mike Perez","email":"thingee@gmail.com","username":"thingee"},{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},{"_account_id":2861,"name":"Vincent Hou","email":"shou@us.ibm.com","username":"houshengbo"},{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},{"_account_id":7764,"name":"Peter Hamilton","email":"peter.hamilton@jhuapl.edu","username":"Peter"},{"_account_id":9061,"name":"David Moreau Simard","email":"moi@dmsimard.com","username":"dmsimard"},{"_account_id":13636,"name":"aarefiev","display_name":"Anton","email":"arefyevanton@gmail.com","username":"aarefiev"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2015-06-05 08:07:08.000000000","updated_by":{"_account_id":2861,"name":"Vincent Hou","email":"shou@us.ibm.com","username":"houshengbo"},"reviewer":{"_account_id":2861,"name":"Vincent Hou","email":"shou@us.ibm.com","username":"houshengbo"},"state":"REVIEWER"},{"updated":"2015-06-25 23:28:27.000000000","updated_by":{"_account_id":9061,"name":"David Moreau Simard","email":"moi@dmsimard.com","username":"dmsimard"},"reviewer":{"_account_id":9061,"name":"David Moreau Simard","email":"moi@dmsimard.com","username":"dmsimard"},"state":"REVIEWER"},{"updated":"2015-06-26 17:47:17.000000000","updated_by":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"reviewer":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"state":"REVIEWER"},{"updated":"2015-06-30 12:44:27.000000000","updated_by":{"_account_id":7764,"name":"Peter Hamilton","email":"peter.hamilton@jhuapl.edu","username":"Peter"},"reviewer":{"_account_id":7764,"name":"Peter Hamilton","email":"peter.hamilton@jhuapl.edu","username":"Peter"},"state":"REVIEWER"},{"updated":"2015-07-06 15:55:27.000000000","updated_by":{"_account_id":170,"name":"Mike Perez","email":"thingee@gmail.com","username":"thingee"},"reviewer":{"_account_id":170,"name":"Mike Perez","email":"thingee@gmail.com","username":"thingee"},"state":"REVIEWER"},{"updated":"2015-07-06 16:24:48.000000000","updated_by":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"reviewer":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"state":"REVIEWER"},{"updated":"2015-07-06 17:31:44.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"b97635ae49a02428d11d374331bb986810c69c86","author":{"_account_id":13636,"name":"aarefiev","display_name":"Anton","email":"arefyevanton@gmail.com","username":"aarefiev"},"date":"2015-04-29 10:05:49.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"b868f10b1fea7417a7a4be90e8382e62d7feacc3","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-04-29 11:01:51.000000000","message":"Patch Set 1: Verified+1\n\nBuild succeeded (check pipeline).\n\n- gate-python-cinderclient-python26 http://logs.openstack.org/88/178588/1/check/gate-python-cinderclient-python26/97e15b2/ : SUCCESS in 1m 09s\n- gate-python-cinderclient-pep8 http://logs.openstack.org/88/178588/1/check/gate-python-cinderclient-pep8/a3de4d9/ : SUCCESS in 56s\n- gate-python-cinderclient-docs http://docs-draft.openstack.org/88/178588/1/check/gate-python-cinderclient-docs/523a4a5//doc/build/html/ : SUCCESS in 55s\n- gate-python-cinderclient-python27 http://logs.openstack.org/88/178588/1/check/gate-python-cinderclient-python27/2036902/ : SUCCESS in 53s\n- gate-python-cinderclient-python34 http://logs.openstack.org/88/178588/1/check/gate-python-cinderclient-python34/a74f401/ : SUCCESS in 1m 56s\n- gate-tempest-dsvm-neutron-src-python-cinderclient http://logs.openstack.org/88/178588/1/check/gate-tempest-dsvm-neutron-src-python-cinderclient/f9d0e65/ : SUCCESS in 55m 35s\n- gate-python-cinderclient-pypy http://logs.openstack.org/88/178588/1/check/gate-python-cinderclient-pypy/90e69db/ : SUCCESS in 1m 42s","accounts_in_message":[],"_revision_number":1},{"id":"63985efccc5fbce29052c3f84e82ad3fe1f60fb9","author":{"_account_id":2861,"name":"Vincent Hou","email":"shou@us.ibm.com","username":"houshengbo"},"date":"2015-06-05 08:07:08.000000000","message":"Patch Set 1: Code-Review-1\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"a7547e1ef3cd7076ac04cfbe16324d4b60dab307","author":{"_account_id":13636,"name":"aarefiev","display_name":"Anton","email":"arefyevanton@gmail.com","username":"aarefiev"},"date":"2015-06-05 08:18:46.000000000","message":"Patch Set 1:\n\nVincent, I think it\u0027s simple change should be backported","accounts_in_message":[],"_revision_number":1},{"id":"b36db8fd5dd59000e39aa64dc2709f0b2143f71d","author":{"_account_id":13636,"name":"aarefiev","display_name":"Anton","email":"arefyevanton@gmail.com","username":"aarefiev"},"date":"2015-06-05 08:22:50.000000000","message":"Patch Set 1:\n\nI mean the simplest way to do it in one cherry pick for v1 and v2.","accounts_in_message":[],"_revision_number":1},{"id":"cc64ce5a1f5090850cb894c3dcb6aadc86ffc7a0","author":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"date":"2015-06-05 17:55:28.000000000","message":"Patch Set 1:\n\n(1 comment)","accounts_in_message":[],"_revision_number":1},{"id":"6d4a483067bd3656c782f5ccf8c46f79558e7060","author":{"_account_id":9061,"name":"David Moreau Simard","email":"moi@dmsimard.com","username":"dmsimard"},"date":"2015-06-25 23:28:27.000000000","message":"Patch Set 1: Code-Review+1\n\nWorks for me - also an important fix to do in both v1 and v2.\nFWIW this is a fix that was done to several other methods (see for example https://bugs.launchpad.net/python-cinderclient/+bug/1248519)\n\nThis is also a fix that allows the openstackclient qos implementation to search a qos by name or id (see review: https://review.openstack.org/#/c/194922/)","accounts_in_message":[],"_revision_number":1},{"id":"f134906bb9e30812b3b3afe4e120cd75c10b1381","author":{"_account_id":6482,"name":"Steve Martinelli","email":"s.martinelli@gmail.com","username":"stevemar"},"date":"2015-06-26 17:47:17.000000000","message":"Patch Set 1:\n\ncould separate out the changes between v1 and v2 if it\u0027s causing issues, but overall the fix looks good","accounts_in_message":[],"_revision_number":1},{"id":"bef87990c509310b480468fbd1254569e62034cc","author":{"_account_id":13636,"name":"aarefiev","display_name":"Anton","email":"arefyevanton@gmail.com","username":"aarefiev"},"date":"2015-06-30 10:08:25.000000000","message":"Patch Set 1:\n\nSteve, not sure, why we should separate v1 and v2 changes!?","accounts_in_message":[],"_revision_number":1},{"id":"1a8a7568f829307dc2267ee62f86292affbc69e0","author":{"_account_id":7764,"name":"Peter Hamilton","email":"peter.hamilton@jhuapl.edu","username":"Peter"},"date":"2015-06-30 12:44:27.000000000","message":"Patch Set 1: Code-Review+1\n\nIf there\u0027s a good argument for backporting to v1, it\u0027s fine by me.","accounts_in_message":[],"_revision_number":1},{"id":"30d5e8666f6c5eeafbe4a675455e399f2a77c58b","author":{"_account_id":170,"name":"Mike Perez","email":"thingee@gmail.com","username":"thingee"},"date":"2015-07-06 15:55:27.000000000","message":"Patch Set 1: Code-Review+2","accounts_in_message":[],"_revision_number":1},{"id":"4e931d66ec2772e5b60fdc6b2f20cfa6f7b92adf","author":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"date":"2015-07-06 16:24:48.000000000","message":"Patch Set 1: Code-Review+2 Workflow+1","accounts_in_message":[],"_revision_number":1},{"id":"ec3c8696d008f11ba27c2eb566f30ab0cf50734b","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-07-06 16:24:53.000000000","message":"Patch Set 1: -Verified\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":1},{"id":"2dda17b8537103b260f828a7107cc8d4f9f7693a","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-07-06 17:31:44.000000000","message":"Patch Set 1: Verified+2\n\nBuild succeeded (gate pipeline).\n\n- gate-python-cinderclient-python26 http://logs.openstack.org/88/178588/1/gate/gate-python-cinderclient-python26/8bbd5b4/ : SUCCESS in 2m 05s\n- gate-python-cinderclient-docs http://docs-draft.openstack.org/88/178588/1/gate/gate-python-cinderclient-docs/979cda1//doc/build/html/ : SUCCESS in 1m 16s\n- gate-python-cinderclient-pep8 http://logs.openstack.org/88/178588/1/gate/gate-python-cinderclient-pep8/58364ed/ : SUCCESS in 1m 09s\n- gate-python-cinderclient-python27 http://logs.openstack.org/88/178588/1/gate/gate-python-cinderclient-python27/dd20ee3/ : SUCCESS in 1m 13s\n- gate-python-cinderclient-python34 http://logs.openstack.org/88/178588/1/gate/gate-python-cinderclient-python34/da9ff91/ : SUCCESS in 1m 49s\n- gate-tempest-dsvm-neutron-src-python-cinderclient http://logs.openstack.org/88/178588/1/gate/gate-tempest-dsvm-neutron-src-python-cinderclient/ea13c3d/ : SUCCESS in 1h 05m 12s\n- gate-python-cinderclient-pypy http://logs.openstack.org/88/178588/1/gate/gate-python-cinderclient-pypy/98a1f64/ : SUCCESS in 1m 59s (non-voting)","accounts_in_message":[],"_revision_number":1},{"id":"bc326e6d69725d75db54bfac2253502ddc6ebf10","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2015-07-06 17:31:46.000000000","message":"Change has been successfully merged into the git repository.","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"a96725e2ad543ffcd5a3de3040581c5e05cc780d","revisions":{"a96725e2ad543ffcd5a3de3040581c5e05cc780d":{"kind":"REWORK","_number":1,"created":"2015-04-29 10:05:49.000000000","uploader":{"_account_id":13636,"name":"aarefiev","display_name":"Anton","email":"arefyevanton@gmail.com","username":"aarefiev"},"ref":"refs/changes/88/178588/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/python-cinderclient","ref":"refs/changes/88/178588/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/python-cinderclient refs/changes/88/178588/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/python-cinderclient refs/changes/88/178588/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/python-cinderclient refs/changes/88/178588/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/python-cinderclient refs/changes/88/178588/1"}}},"commit":{"parents":[{"commit":"c82723660d8b3f1c1ad26abe7236b6c88ad6b297","subject":"Merge \"Support pagination param limit in volume list in V1\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-cinderclient/commit/c82723660d8b3f1c1ad26abe7236b6c88ad6b297"}]}],"author":{"name":"Anton Arefiev","email":"aarefiev@mirantis.com","date":"2015-04-29 09:45:28.000000000","tz":180},"committer":{"name":"Anton Arefiev","email":"aarefiev@mirantis.com","date":"2015-04-29 09:45:28.000000000","tz":180},"subject":"Add search_opts into the method list() for qos specs","message":"Add search_opts into the method list() for qos specs\n\nManagerWithFind.findall require  search_opts for all tenants support,\nthe parameter search_opts should also be in all manager classes, which\nuse find method, qos spec does\u0027t have this parameter for list().\nThis change add it.\n\nChange-Id: Iea619d66d217d92047a5b965d1e375acc97fa65b\nRelated-Bug: #1252665\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-cinderclient/commit/a96725e2ad543ffcd5a3de3040581c5e05cc780d"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/python-cinderclient/commit/a96725e2ad543ffcd5a3de3040581c5e05cc780d"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}